Project

General

Profile

Actions

Bug #87390

closed

View Upgrade Documentation: ordering mixed (wrong sorting)

Added by Josef Glatz over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2019-01-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Problem/Description

In TYPO3 9.5 LTS, the ordering is mixed. Seems to be an regression, because it was ordered by severity in TYPO3 8.5 LTS.

ToDo(s)

  • Order list of RsT's by severity to make consuming easier for system maintainers

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #88883: Wrong sorting in documentation changelogClosed2019-08-01

Actions
Actions #1

Updated by Georg Ringer about 4 years ago

  • Status changed from Accepted to Needs Feedback

can you pls recheck if still valid in 10, imo fixed

Actions #2

Updated by Georg Ringer about 4 years ago

  • Related to Bug #88883: Wrong sorting in documentation changelog added
Actions #3

Updated by Josef Glatz about 4 years ago

  • Subject changed from View Upgrade Documentation: ordering mixed to View Upgrade Documentation: ordering mixed (wrong sorting)

Nope, not fixed in 9.5 or master as of today

Affected TYPO3 versions: 9.5 and master (10)

until TYPO3 8.7 the rST's itself where sorted by "severity". Beginning with Breaking, ... and so on

By looking into the code I think the right position is in \TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::getDocumentationFilesForVersion

    /**
     * Handle a single directory
     *
     * @param string $docDirectory
     * @return array
     */
    protected function getDocumentationFilesForVersion(string $docDirectory): array
    {
        $documentationFiles = [[]];
        $absolutePath = str_replace('\\', '/', $docDirectory);
        $finder = $this->getDocumentFinder()->in($absolutePath);

        foreach ($finder->files() as $file) {
            /** @var SplFileInfo $file */
            $documentationFiles[] = $this->getListEntry($file->getPathname());
        }

        return array_merge(...$documentationFiles);
    }

Maybe it's the right area to sort by class subarray value. The "class" subarray value holds values like feature.

Actions #4

Updated by Gerrit Code Review about 4 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913

Actions #5

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913

Actions #6

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913

Actions #7

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63894

Actions #8

Updated by Anonymous about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF