Project

General

Profile

Actions

Bug #88208

closed

Indexed Search Title - Problem with htmlspecialchars &

Added by Samuel Heinz almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Indexed Search
Start date:
2019-04-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

https://forge.typo3.org/issues/56262
This issue seems to be present in the current 9.5.5 with "&" in page title.
Page titles like "Lorem & ipsum" leads to "Lorem & ispum" in source code.

Maybe the "htmlspecialchars($title)" in indexed_search/Classes/Controller/SearchController.php causes the problem?

Best regards
Sam


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #90935: Indexed Search double htmlspecialchars full path in result info sectionClosed2020-04-02

Actions
Actions #1

Updated by Benni Mack almost 5 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
Actions #2

Updated by Manfred Egger over 4 years ago

I can confirm this issue. The problem is caused by the calls to linkPageATagWrap on lines 489 and 506 in \TYPO3\CMS\IndexedSearch\Controller\SearchController (TYPO3 9.5.8). The title gets html escaped but inside the method linkPageATagWrap the title is escaped again.

The solution is to remove the htmlspecialchars call in lines 490 and 507.

Actions #3

Updated by Frank Nägler over 4 years ago

  • Status changed from New to In Progress
  • Assignee set to Frank Nägler
Actions #4

Updated by Gerrit Code Review over 4 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61959

Actions #5

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61959

Actions #6

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61972

Actions #7

Updated by Frank Nägler over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions #9

Updated by Henri Nathanson about 4 years ago

  • Related to Bug #90935: Indexed Search double htmlspecialchars full path in result info section added
Actions

Also available in: Atom PDF