Project

General

Profile

Actions

Task #88612

closed

Streamline ClassSchema property api

Added by Alexander Schnitzler almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2019-06-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

This patch tackles three different issues with the current
ClassSchema property api.

Due to the history and the refactoring of the ReflectionService,
the ClassSchema class cached data redundantly. Information like
the type of a property has been stored multiple times in different
cache keys. With this patch, the redundancy has been removed.

The information about properties had been roughly grouped by the
ones gathered by php reflection and the ones gathered from doc
blocks and/or annotations. This kind of grouping had also been
exposed to the public by different methods in the Property class.

Said grouping has been removed and the api does no longer allow
for requesting annotation data. The purpose of the api is to tell
the status quo of the information about a property, regardless of
how said information had been gathered in the first place.

Instead of exposing the annotation data itself via method
`getAnnotationValue('lazy')`, there is a specific method for each
relevant piece of information like `isLazy()`.

A lot of information about properties are boolean values which
had been stored as separate keys in the cache. All boolean keys
are now represented by a BitSet, which saves quite a lot of
bytes during serialization of ClassSchema instances.

Actions #1

Updated by Alexander Schnitzler almost 5 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61101

Actions #3

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61101

Actions #4

Updated by Gerrit Code Review almost 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61101

Actions #5

Updated by Gerrit Code Review almost 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61101

Actions #6

Updated by Anonymous almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF