Extbase MVC Framework

From my point of view definitely a bug. The problem with rewind is that you loose your cursor.

How would something like the following work:

    /**
     * Returns this object storage as an array
     *
     * @return array The object storage
     */
    public function toArray() {
        return array_values($this->storage);
    }

    /**
     * Returns this object storage as an array
     *
     * @return array The object storage
     */
    public function toArray() {
        $array = array();
        foreach ($this->storage as $item) {
            $array[] = $item['obj'];
        }
        return $array;
    }

we could use the power and speed of C ;)

Hey Thomas,

if you would have a closer look at the code you'd see that $this->storage is not just an array holding objects but an array holding another array per object with optional tag/description in a second array key. So using array_values wouldn't work here, or at least not return just the objects.

Because toArray() uses an foreach internally there must not be an rewind called normally, but we should verify this with unit tests.

Fix submitted for review as change 533b9da in git repository for Extbase. A combination of both: array_values then iteration, array pointer is preserved.

Patch set 1 of change I52c676b2660288d29d228044b92ada8ce6e3581b has been pushed to the review server.
It is available at http://review.typo3.org/2148

I think I reset my git repository by mistake, still getting used to git instead of SVN - re-uploaded now as 8f66be7.

Use case: It should be possible to call toArray() without changing the current array-position (the cursor).

Try the following with and without the array_values()-row.

class C {
                var $storage;

public function toArray() {
                        $array = array();
                        $storage = array_values($this->storage);
                        foreach ($storage as $item) {
                                $array[] = $item['obj'];
                        }
                        return $array;
                }
        }

$c = new C();
        $c->storage = array(1,2,3,4);
        reset($c->storage);
        next($c->storage);
        next($c->storage);
        echo 'First: '.current($c->storage)."\n";
        $x = $c->toArray();
        echo 'Second: '.current($c->storage)."\n";