Task #92205: Provide web server url configuration for acceptance tests - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #92205

closed

Provide web server url configuration for acceptance tests

Added by Alexander Nitsche over 3 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Tests

Target version:

Candidate for patchlevel

Start date:

2020-09-05

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Testing

Complexity:

easy

Sprint Focus:

Description

In order to run TYPO3 Core acceptance tests not only in the TYPO3 Core own docker environment but in an arbitrary environment the web server url of the testing environment should be configurable.

For example, having a LEMP docker stack with an Nginx web server available internally at http://nginx:8080 you should be able to set the docker service of the acceptance tests runner accordingly:

acceptance_backend_mariadb10:
    image: {YOUR_DOCKER_PHP_IMAGE_INCLUDING_TYPO3}
    environment:
      typo3TestingAcceptanceBaseUrl: http://nginx:8080

Currently the web server url is set fix to http://web:8000.

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585

Actions

Copy link

Updated by Alexander Nitsche over 3 years ago

I tested this patch by

1) replacing "web" by "nginx" in Build/testing-docker/local/docker-compose.yml
2) running all available acceptance tests:


./Build/Scripts/runTests.sh -s composerInstall
./Build/Scripts/runTests.sh -s acceptance -p 7.3
./Build/Scripts/runTests.sh -s acceptancePagetree -p 7.3
./Build/Scripts/runTests.sh -s acceptanceInstallTool -p 7.3
./Build/Scripts/runTests.sh -s install -d mariadb
./Build/Scripts/runTests.sh -s install -d postgres
./Build/Scripts/runTests.sh -s install -d sqlite

The acceptance test output showed the correct web server urls and the tests had the same results as before with the fixed web:8000 web server address.

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585

Actions

Copy link

Updated by Alexander Nitsche over 3 years ago

Added a default acceptance tests web server url http://web:8000 such that all currently running configurations on bamboo continue to work seamlessly.

Actions

Copy link

Updated by Alexander Nitsche over 3 years ago

The way to test this patch changed slightly by

1) replacing "web" by "nginx" in Build/testing-docker/local/docker-compose.yml
2) adding environment variable typo3TestingAcceptanceBaseUrl: http://nginx:8000 to the following services of Build/testing-docker/local/docker-compose.yml

acceptance_backend_mariadb10:
acceptance_pagetree_mariadb10:
acceptance_installtool_mariadb10:
acceptance_install_mariadb10:
acceptance_install_postgres10:
acceptance_install_sqlite:

3) running all available acceptance tests:

./Build/Scripts/runTests.sh -s composerInstall
./Build/Scripts/runTests.sh -s acceptance -p 7.3
./Build/Scripts/runTests.sh -s acceptancePagetree -p 7.3
./Build/Scripts/runTests.sh -s acceptanceInstallTool -p 7.3
./Build/Scripts/runTests.sh -s install -d mariadb
./Build/Scripts/runTests.sh -s install -d postgres
./Build/Scripts/runTests.sh -s install -d sqlite

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585

Actions

Copy link

Updated by Alexander Nitsche over 3 years ago

Tracker changed from Feature to Task
TYPO3 Version set to 11

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585

Actions

Copy link

Updated by Alexander Nitsche over 3 years ago

Missed to pass Codeception configuration parameters to tests. This is done now by a new Codeception Helper Config which can read and expose the configuration of itself (can be used to pass arbitrary parameters to any test class) and to expose the configuration of other modules. The latter is used to retrieve the parameter url of the Codeception module WebDriver in the test classes.

Note: It might be appropriate to move that new helper Config to the https://github.com/TYPO3/testing-framework extension in order to provide it to all TYPO3 3rd-party extensions as well.

Actions

Copy link

#10

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585

Actions

Copy link

#11

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585

Actions

Copy link

#12

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65585

Actions

Copy link

#13

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65602

Actions

Copy link

#14