Project

General

Profile

Actions

Bug #92762

closed

Accessing a restricted subpage of a sysfolder triggers a 404 instead of 403

Added by Rémy DANIEL over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2020-11-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

On TYPO3 9, accessing a restricted subpage of a sysfolder triggered a 403.
On TYPO3 10, a 404 is triggered.

This is a regression introduced in https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829

How to reproduce

With the following page tree:

Rootpage
- page 1 (public, enabled)
- sysfolder 3 (enabled)
-- subpage 2 (restricted to authenticated users, enabled)

Without a frontend session, access the subpage 2 triggers a 404.

What should I see?

Without a frontend session, access the subpage B should trigger a 403.


Related issues 5 (0 open5 closed)

Related to TYPO3 Core - Task #92225: Add test previewing created hidden page & content in workspaceClosedBenni Mack2020-09-07

Actions
Related to TYPO3 Core - Bug #86346: Hidden pages sent 403 HeaderClosed2018-09-21

Actions
Related to TYPO3 Core - Bug #18079: slide of cObj CONTENT stops if sysfolder in rootlineClosed2008-01-30

Actions
Related to TYPO3 Core - Feature #20933: Enable working with SysFolders in CONTENTClosed2009-08-26

Actions
Related to TYPO3 Core - Bug #93229: Page with access restriction throws 404 if parent is a folderClosed2021-01-06

Actions
Actions #1

Updated by Rémy DANIEL over 3 years ago

  • Related to Task #92225: Add test previewing created hidden page & content in workspace added
Actions #2

Updated by Rémy DANIEL over 3 years ago

  • Related to Bug #86346: Hidden pages sent 403 Header added
Actions #3

Updated by Benoit Chenu over 3 years ago

I think the issue was introduced here :

https://review.typo3.org/c/Packages/TYPO3.CMS/+/64038/5/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php

Related to this issue :

https://forge.typo3.org/issues/18079

If we remove the condition on DOKTYPE_SYSFOLDER, TYPO3 send a 403 as expected :

< if ($this->page['doktype']  PageRepository::DOKTYPE_SPACER || $this->page['doktype']  PageRepository::DOKTYPE_SYSFOLDER) {
> if ($this->page['doktype'] == PageRepository::DOKTYPE_SPACER) {
Actions #4

Updated by Benoit Chenu over 3 years ago

  • Related to Bug #18079: slide of cObj CONTENT stops if sysfolder in rootline added
Actions #5

Updated by Markus Klein over 3 years ago

  • Related to Feature #20933: Enable working with SysFolders in CONTENT added
Actions #6

Updated by Marc Hirdes almost 3 years ago

A fix would be great

Actions #7

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69306

Actions #8

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69306

Actions #9

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69306

Actions #10

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69306

Actions #11

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71362

Actions #12

Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71362

Actions #14

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71362

Actions #15

Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved
Actions #16

Updated by Benni Mack about 2 years ago

  • Related to Bug #93229: Page with access restriction throws 404 if parent is a folder added
Actions #17

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF