Formhandler

This works so far, but there a still problems with the csv parser.

Office cant import the generated csv files correctly, but OpenOffice is useable. I think this is a problem of newlines and some other UTF.8 codes.

Perhaps we should use another PHP class for doing that. As this is hard to test without real life data, I will do some tests with the following classes:

This TYPO3 Extension would enable formhandler to write even xls directly:
http://typo3.org/documentation/document-library/extension-manuals/phpexcel_library/1.7.0/view/toc/0/

http://code.google.com/p/parsecsv-for-php/

A PEAR CLASS (has dependencies, not my first choice)
http://pear.php.net/package/File_CSV

Any more ideas?

Is it possible that there is already a similar patch (like the one you provided above) in the function generateFrontendCSV in the Tx_Formhandler_Generator_CSV.php file?

public function generateFrontendCSV($params, $exportParams = array()) {
        //require class for $this->csv
        require_once('typo3conf/ext/formhandler/Resources/PHP/csv.lib.php');

        //build data
        foreach($params as $key => &$value) {
            if(is_array($value)) {
                $value = implode(',', $value);
            }
            if(count($exportParams) > 0 && !in_array($key, $exportParams)) {
                unset($params[$key]);
            }
            $value = str_replace('"', '""', $value);
        }

        //init csv object
        $this->csv = new export2CSV(',', "\n");
        $data[0] = $params;

        //generate file
        $this->csv = $this->csv->create_csv_file($data);
        header('Content-type: application/eml');
        header('Content-Disposition: attachment; filename=formhandler.csv');
        echo $this->csv;
        die();
    }    

but the

            if(is_array($value)) {
                $value = implode(',', $value);
            }

and

            $value = str_replace('"', '""', $value);

part are not in use, as the $value var is never ever used?

Yeah, it seems as if I patched it some time, but only for the frontend CSV. Nice work by me! :-)
Anyway, it would be great if you could test it with real life data. If you ask me, generating xls would be too much, as CSV can be opened easily in in excel and others (if the format is correct :-)).

I think, the best will be to fix the CSV bug first to make the file readable in Excel and OpenOffice. And afterwards we can discuss about generateing xls or not.

Our problem is based on something i would call a "word-copy-and-paste-char-problem". Some users paste word text in or textareas and some of these chars are written to the DB and later cause problems when opening in excel (not in openoffice).

Some example what data we get (pass is formhandler):
http://miranda.pastebin.ca/EXCIV7BJ

Did I forget to use an option in my form TS which activates "RTE-Cleaning" before saving?

Aside from the above mentioned problem I would recommend to use the parsecsv class as its stable, under active development, is well configurable and parses the values for quotes, newline, etc:
http://code.google.com/p/parsecsv-for-php/

Its very easy to use (im using the stable version):

    public function generateModuleCSV($records, $exportParams = array()) {

        //require class for $this->csv
        require_once('../../../Resources/PHP/parsecsv.lib.php');
        $data = array();        
        $dataSorted = array();

        //build data array
        foreach($records as $record) {
            if(!is_array($record['params'])) {
                $record['params'] = array();
            }
            foreach($record['params'] as &$param) {
                if(is_array($param)) {
                    $param = implode(';', $param);
                }
            }
            $data[] = $record['params'];
        }
        if(count($exportParams) > 0) {
            foreach($data as &$params) {
                foreach($params as $key => $value) {
                    if(!in_array($key, $exportParams)) {
                        unset($params[$key]);
                    }
                }
            }
        }

        // sort data
        foreach($data as $array) {
            debug($array);
            $dataSorted[] = $this->sortArrayByArray($array, $exportParams);
        }            

        $csv = new parseCSV();
        $csv->output (true, 'formhandler.csv', $dataSorted);
        die();
    }

Im on vacation the next few days, so Im not able to test -- please consider this when waiting for an answer.

Regarding the "RTE-Cleaning" problem: AFAIK, there is no built-in solution for that. But if you ask me, this could easily be done with a saveInterceptor.

parsecsv looks promising. Let's talk about that after your vacation.

I'm back and allocated some time to test the current svn version. I hopefully will answer some of the open issues the next few hours.

I just started testing. Looks promising.

Nice! Works great so far!
Please note Im only testing BE not FE.