Project

General

Profile

Actions

Bug #95290

closed

BE - Form content - Finisher overriding issues

Added by Davide Alghi over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2021-09-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
form, form engine, formframework, content, tt_content, finisher
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

TYPO3 v10 (6 issues)

CONTEXT : Backend - "Form" content type (form_formframework): a form with finisher is selected and "Override finisher settings" is enabled

ISSUE 1 : Deleting an invalid IRRE record prevents saving (validation failure)
When a IRRE record (with initially invalid field) is added and just deleted, the saving is inhibited.
Steps to reproduce :
1) create a form with finisher containing IRRE fields, such as "Email to sender"
2) add a Form Content Element to any page
3) choose that form ("Form definition")
4) enable "Override finisher settings"
5) switch to "Email to sender" tab and add a "Recipient" (or Reply-To Recipient, CC Recipient, BCC Recipient)
6) the "Email Address" field is invalid
7) delete the newly added recipient, without making any changes
8) try to save: saving stop you ("The fields marked with an exclamation mark are not yet correctly filled in. Please complete them properly.")

ISSUE 2 : If an IRRE record is added and editing is ended, by "Close" button or changing BE module, the GUI exits without alert.
Steps to reproduce :
1-5) same as ISSUE 1
6) click on Close button or change module (by main menu)
7) it exits without alert

ISSUE 3 : If you delete an existing section, no alert are triggered when exiting the edit (by "Close" button or changing BE module)
Steps to reproduce :
1-5) same as ISSUE 1
6) add a new "Recipient"
7) save form
8) delete the last added recipient
9) click on Close button or change module (by main menu)
7) it exits without alert

ISSUE 4 : Toggle action is confusing; it should open / close all sections the same way. Currently open ones are closed and vice versa.
The behavior should be like that implemented in v11.
Steps to reproduce :
1-5) same as ISSUE 1
6) click on "Toggle all" button

ISSUE 5 : If you click close (horizontally, right side), outside, to the "Toggle all" button, all sections are toggled.
The js handler is binded to "div" click event, instead of inner "a" click event.
Steps to reproduce :
1-5) same as ISSUE 1
6) click outside the "Toggle all" button, on the right side, on the same horizontal line
7) all sections are toggled

ISSUE 6 : On section deleting, the alert message is not defined/translated ("Are you sure you want to delete this section?")
Steps to reproduce :
1-5) same as ISSUE 1
6) set the BE lang other than English
7) delete the newly added recipient, without making any changes
8) the alert message is in English language

_________________________ * _________________________

TYPO3 v11 (4 issues)

CONTEXT : Backend - "Form" content type (form_formframework): a form with finisher is selected and "Override finisher settings" is enabled

ISSUE 1 : as for ISSUE 1 in v10
ISSUE 2 : as for ISSUE 2 in v10
ISSUE 3 : as for ISSUE 3 in v10
ISSUE 4 : as for ISSUE 6 in v10


Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Task #95291: Fixes FormContent-FinisherOverriding masterRejected2021-09-21

Actions
Related to TYPO3 Core - Task #95292: Fixes FormContentFinisherOverriding issuesRejected2021-09-21

Actions
Related to TYPO3 Core - Task #95591: Fixes FormContentFinisherOverriding issuesClosed2021-10-12

Actions
Related to TYPO3 Core - Task #95589: Fixes FormContent-FinisherOverriding masterClosed2021-10-12

Actions
Actions #1

Updated by Davide Alghi over 2 years ago

Here my proposals to fix issues

TYPO3 v10: https://github.com/TYPO3/typo3/pull/321

TYPO3 master: https://github.com/TYPO3/typo3/pull/320

Actions #2

Updated by Davide Alghi over 2 years ago

  • Related to Task #95291: Fixes FormContent-FinisherOverriding master added
Actions #3

Updated by Davide Alghi over 2 years ago

  • Related to Task #95292: Fixes FormContentFinisherOverriding issues added
Actions #4

Updated by Benni Mack over 2 years ago

  • Related to Task #95591: Fixes FormContentFinisherOverriding issues added
Actions #5

Updated by Christian Kuhn over 2 years ago

  • Related to Task #95589: Fixes FormContent-FinisherOverriding master added
Actions #6

Updated by Björn Jacob about 2 years ago

  • Sprint Focus set to Remote Sprint

We have to test this and discuss possible solutions.

Actions #7

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73699

Actions #8

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73706

Actions #9

Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF