Project

General

Profile

Actions

Bug #96858

closed

Encoded tokens (e.g. in redirectUrl) are not sanitized in the log

Added by Imko Schumacher about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2022-02-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Encoded tokens (e.g. in redirectUrl) are not sanitized in the log.

Example exception

(I have no clue how I produced it)
Note: In the log, the % is additionally escaped.

Reduced to important parts

?token=--AnonymizedToken--&returnUrl=%%3Ftoken%%3D14d0db7abc481cd5975d1d759924fb7216194d7f

Full log entry

Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1441706370: Button "TYPO3\CMS\Backend\Template\Components\Buttons\LinkButton" is not valid | InvalidArgumentException thrown in file /var/www/html/typo3/sysext/backend/Classes/Template/Components/ButtonBar.php in line 68. Requested URL: http://t3master.ddev.site/typo3/record/edit?token=--AnonymizedToken--&edit%%5Bpages%%5D%%5B2%%5D=new&returnUrl=%%2Ftypo3%%2Fmodule%%2Fweb%%2Flist%%3Ftoken%%3D14d0db7abc481cd5975d1d759924fb7216194d7f%%26id%%3D2%%26table%%3D%%26pointer%%3D1

Actions #1

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73456

Actions #2

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73456

Actions #3

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73399

Actions #4

Updated by Imko Schumacher about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF