Project

General

Profile

Actions

Epic #97602

open

Always call GU::trimExplode with a string parameter

Added by Oliver Klee almost 2 years ago. Updated 5 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2022-05-10
Due date:
% Done:

0%

Estimated time:
Sprint Focus:

Description

This avoids type errors when GeneralUtility is switched to strict mode.


Related issues 1 (0 open1 closed)

Blocked by TYPO3 Core - Bug #97960: Always call GU::trimExplode with a string parameter in EXT:extbase and EXT:fluidClosed2022-07-16

Actions
Actions #1

Updated by Oliver Klee almost 2 years ago

  • Blocks Task #97578: Mark GeneralUtility as strict added
Actions #2

Updated by Georg Ringer almost 2 years ago

  • Status changed from New to Accepted
Actions #3

Updated by Georg Ringer almost 2 years ago

  • Subject changed from Always call GU::trimeExplode with a string parameter to Always call GU::trimExplode with a string parameter
Actions #4

Updated by Oliver Klee almost 2 years ago

  • Blocks deleted (Task #97578: Mark GeneralUtility as strict)
Actions #5

Updated by Oliver Klee almost 2 years ago

This is not necessary (at least not for marking GU as strict): GU::trimExplode already casts the parameter to string. So this ticket can be closed.

Actions #6

Updated by Oliver Klee almost 2 years ago

Ah, let's keep this open as this will become necessary once GU::trimExplode has native type declarations (and GU is marked as strict).

Actions #7

Updated by Oliver Klee almost 2 years ago

There are really a lot a places to change. We should split this up:

- backend
- core
- extbase & fluid
- felogin
- frontend
- install
- recordlist
- workspaces
- everything else

Actions #8

Updated by Oliver Klee almost 2 years ago

  • Tracker changed from Bug to Epic
  • TYPO3 Version deleted (12)
Actions #9

Updated by Oliver Klee almost 2 years ago

  • Blocked by Bug #97960: Always call GU::trimExplode with a string parameter in EXT:extbase and EXT:fluid added
Actions #10

Updated by Benni Mack 11 months ago

  • Target version deleted (12 LTS)
Actions #11

Updated by Gerrit Code Review 5 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81964

Actions #12

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81964

Actions

Also available in: Atom PDF