Project

General

Profile

Actions

Bug #97768

closed

TYPO3 10.4.29 regression in Admin Tools

Added by Thomas Hohn almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2022-06-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The new function

public function hasActiveBackendUserRoleAndSession(): bool TYPO3\CMS\Install\Service\SessionService

introduces a regression if you have no system maintainer configured. According to the documentation

"If no system maintainer is set up, then all administrators are assigned the system maintainer role."

The following statement fails:

$systemMaintainers = array_map('intval', $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemMaintainers'] ?? []);
// stop here, in case the current admin tool session does not belong to a backend user having admin & maintainer privileges
if (!$isAdmin || !in_array((int)$backendUserRecord['uid'], $systemMaintainers, true)) {
       return false;
}

Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #97769: Cannot open Admin modules anymoreClosed2022-06-14

Actions
Actions #1

Updated by Thomas Hohn almost 2 years ago

  • Assignee set to Oliver Hader
Actions #2

Updated by Oliver Hader almost 2 years ago

  • Subject changed from TYPO3 10.4.30 introduces an regression to TYPO3 10.4.29 introduces an regression
Actions #3

Updated by Oliver Hader almost 2 years ago

Work-around for the time being: configure a system maintainer

Actions #4

Updated by Oliver Hader almost 2 years ago

  • Assignee deleted (Oliver Hader)
Actions #5

Updated by Oliver Hader almost 2 years ago

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/9.0/Feature-82266-BackendUsersSystemMaintainers.html

If no system maintainer is set up, then all administrators are assigned the system maintainer role.
In Development context, all administrators are system maintainers as well.

Actions #6

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74910

Actions #7

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74911

Actions #8

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74912

Actions #9

Updated by Thomas Hohn almost 2 years ago

Gerrit Code Review wrote in #note-7:

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74911

It seems to fix the issue - at least under 10.4.30

Actions #10

Updated by Oliver Hader almost 2 years ago

  • Has duplicate Bug #97769: Cannot open Admin modules anymore added
Actions #11

Updated by Oliver Hader almost 2 years ago

  • Subject changed from TYPO3 10.4.29 introduces an regression to TYPO3 10.4.29 regression in Admin Tools
Actions #12

Updated by Oliver Hader almost 2 years ago

  • Is Regression set to Yes
Actions #13

Updated by Oliver Hader almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF