Project

General

Profile

Actions

Bug #98049

open

[FE][permalogin] = 1 and not enabled permalogin does not work

Added by Georg Ringer almost 2 years ago. Updated 12 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
Category:
felogin
Start date:
2022-07-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Setting permalogin to 1 states: "Permanent login is by default enabled but can be disabled by a form control in the login form."

but actually this doesn't work. the reason is simple:

strlen((string)$isPermanent) != 1

this will not respect the setting "0"

Actions #1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75328

Actions #2

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75328

Actions #3

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75328

Actions #4

Updated by Markus Klein over 1 year ago

  • Description updated (diff)

The problem is actually not the setting "0", but that a non-checked checkbox does not send any POST data.
Hence, $isPermanent is always an empty string.

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75328

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75328

Actions #7

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75328

Actions #8

Updated by Gerrit Code Review 12 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75328

Actions

Also available in: Atom PDF