Project

General

Profile

Actions

Bug #99199

closed

Image cropper: Part of the image not visible if the modal is < 1000px high

Added by Leonie Philine over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Image Cropping
Target version:
-
Start date:
2022-11-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

To reproduce:

- Set your browser (e.g. in responsive design mode) to a viewport height < 1000px (e.g. HiDPI Laptop 1440x900 px)
- Upload a big image using upright / portrait orientation.
- Add the image to a content element
- Open the image cropper

Expected:

- The entire image is visible; scaled down to fit into the image cropper modal
- At least, though, it should be possible to scroll up and down to see and crop from the entire image

Actual result:

- The #t3js-crop-image-container.cropper-image-container has a height of 1000px
- The image is centered vertially
- It is possible to scroll down to see the bottom edge of the image
- However, it is NOT possible to scroll up to see the top edge of the image!

See attached annotated screenshot:

- In the screenshot, the cropper is shown in its initial scroll state, which is scrolled all the way to the top.
- However, the image (in fact, the #t3js-crop-image-container.cropper-image-container) is vertically centered;
- thus the top part of the image is invisible and cannot be scrolled to.

IIRC, this is a regression from TYPO3 10 to TYPO3 11. (Might have been introduced by replacing cropper with cropperjs.)


Files

Screenshot_20221125_181250.png (860 KB) Screenshot_20221125_181250.png Leonie Philine, 2022-11-25 17:15
Actions #1

Updated by Chris Müller about 1 year ago

I can confirm the behaviour. A workaround is to zoom out ("Ctrl" + "-"), then the whole image is visible (at least on Brave/Chromium).

Actions #2

Updated by Leonie Philine about 1 year ago

  • Is Regression set to Yes

Issue priority is shown as "Should have", but it's really "Must have".

Apparently I cannot change that myself, though.

Maintainers, please set to "Must have".

Actions #3

Updated by Jasmina Ließmann about 1 year ago

  • Priority changed from Should have to Must have

Can confirm for v11 and v12, can't reproduce this in v10. In some constellations, part of the image is not visible both above and below.

Actions #4

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77920

Actions #5

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77920

Actions #6

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77994

Actions #7

Updated by Jasmina Ließmann about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF