Bug #99648: The method getPageAndRootline in TypoScriptFrontendController can throw the PHP warning : Undefined array key "hidden" in ... - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #99648

closed

The method getPageAndRootline in TypoScriptFrontendController can throw the PHP warning : Undefined array key "hidden" in ...

Added by Thomas Hohn over 1 year ago. Updated about 1 year ago.

Status:

Closed

Priority:

Should have

Assignee:

Thomas Hohn

Category:

Frontend

Target version:

Candidate for patchlevel

Start date:

2023-01-19

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

8.1

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

In the TypoScriptFrontendController there is the following code:

 if (!empty($hiddenField) && !$includeHiddenPages) {
                    // Page is "hidden" => 404 (deliberately done in default language, as this cascades to language overlays)
                    $rawPageRecord = $this->sys_page->getPage_noCheck($this->id);
                    $requestedPageIsHidden = (bool)$rawPageRecord[$hiddenField];
                }

If a non-existing id is provided the $rawPageRecord will be the empty array and hence the line

$requestedPageIsHidden

will throw an error the line should instead be

$requestedPageIsHidden = (bool)(isset($rawPageRecord[$hiddenField] ?: false);

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77504

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505

Actions

Copy link

Updated by Thomas Hohn about 1 year ago

Assignee set to Thomas Hohn

Actions

Copy link

Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77505

Actions

Copy link

#10

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77968

Actions

Copy link

#11