TYPO3 Core

The pagesToFlatArray method of the TYPO3\CMS\Backend\Controller\Page\TreeController has some performance optimization potential.

Currenytly it calls the getPageTreeRepository method multible times. This is even more worse, since this method calls itself recursivly!

Since the getPageTreeRepository method always returns the same result in one request, it could be handover as an additional parameter to the pagesToFlatArray method.

Doing this, the getPageTreeRepository method is called only once, which reduces the rendertime significant.

I did some measurements with a simple page tree with around 20 pages, max 2 levels deep and was able to reduce the response time of a /record/tree/fetchData call from 370 ms to 270 ms!

Imaging what an impact this could have on huge page trees with around 1000 pages in multible levels!

Another possible optimization is to change the way of the array_merge done inside the fetchDataAction, filterDataAction and again pagesToFlatArray.

PHPStorm mark all the places with a red underline and this hint:

array_merge(...) is used in a loop and is a ressources greedy construction.

The help of PhpStorm contains a link to this page:
https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop

Maybe this helps to improve the performance even more.

I will try to create a patchset within the next days.