Feature #101446
Updated by Daniel Siepmann 10 months ago
Foremost I'm not sure if TYPO3 should change that. Still I try to explain our scenario and a possible solution. I'm fine if TYPO3 decides to reject the issue.
Environment:
TYPO3 11.5.23
PHP 8.1
Our scenario:
We had a small code that called <code>applyProcessingInstructions()</code> of <code>TYPO3\CMS\Extbase\Service\ImageService</code>
The code looked like this:
<pre><code class="php">
$cropParam = ($crop)?'c':'';
$processingInstructions = [
'width' => $imageWidth . $cropParam,
'crop' => $this->getCropArea($imageObj, $cropVariant),
];
if ($forceRatio > 0) {
$processingInstructions['height'] = ($crop) ? $imageWidth / $forceRatio . $cropParam : null;
}
$processedImage = $this->imageService->applyProcessingInstructions($imageObj, $processingInstructions);
</code></pre>
We than needed to make changes to the code base and ended up with the following code:
<pre><code class="php">
$cropParam = ($crop) ? 'c' : '';
$processingInstructions = [
'width' => $imageWidth . $cropParam,
'height' => null,
'crop' => $this->getCropArea($image, $cropVariant),
];
if ($forceRatio > 0 && $crop) {
$processingInstructions['height'] = ($imageWidth / $forceRatio) . $cropParam;
}
return $this->imageService->applyProcessingInstructions(
$image,
$processingInstructions
);
</code></pre>
We didn't expect anything bad from that change. Once deployed our system went down due to heavy system load, caused by many gm (=graphics magick) processed.
We reverted the change and thanks to Hannes with his experience we found the root cause. We modified the <code>$processingInstructions</code> <pre>$processingInstructions</pre> that is used to create a hash in order to find entries from database table <code>sys_file_processedfile</code>. Our modifications lead to a different array (height before, crop and height now always was set). That lead to a different hash leading to not finding processed images, leading to re-processing all images.
My proposal:
Add some streamlining to the incoming processing instructions. E.g. alphabetical sorting, array filter to filter out empty values like `null`. Something in that regard should prevent such issues for systems.
It forces an update wizard in order to update all existing entries with the sanitized and updated hash version in order to prevent re processing all images after system update.