Activity
From 2009-02-15 to 2009-03-16
2009-03-10
- 21:01 Bug #2820 (Resolved): Finisher_DB should store uploaded files
- Applied in changeset r17687.
- 20:42 Bug #2820: Finisher_DB should store uploaded files
- I had to sort the finisher array to get Finisher_DB called after Finisher_StoreUploadedFiles.
Please test this.
E... - 19:18 Bug #2820 (Resolved): Finisher_DB should store uploaded files
- Finisher_DB currently ignores fields with uploaded files. Should save path to uploaded files.
requires that finisher... - 19:06 Task #2772 (Closed): Apply auto formating to code
- Formatted all files today. If something got messed bad, please report.
- 18:06 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- I talked with Reinhard about this idea:
The Finisher_DB adds $this->gp['inserted_uid'] and saves the filepaths to the... - 14:36 Feature #2810 (Closed): Add t3lib_div::devLog() call to MailformPlusPlus
- Fabien told me about this great extension and I tried it out in an extension I'm currently developing... works like a...
- 13:42 Feature #2807: Show TypoScript examples in Backend
- Nice idea.
But I think a module isn't the right place for that, because this is only needed while the form is in dev... - 13:29 Feature #2807 (Closed): Show TypoScript examples in Backend
- Just thought about something:
There are many classes in MailformPlusPlus having their own TypoScript configuration... - 12:06 Bug #2800: Update the documentation
- Much documentation work on my side too.
* TypoScript options have to be updated
* Sample configuration for Finish... - 11:58 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- Added the feature to add custom markers to naming scheme.
Sample config:... - 01:10 Bug #2800: Update the documentation
- I think
@TSFE:fe_user|user|first_name@
would only work if a fe_user is loged in.
@TSFE:fe_user|sesData|first_na...
2009-03-09
- 22:18 Bug #2800 (Closed): Update the documentation
- Before we can go beta, we must refresh / update the documentation.
On my side, I must document the new option: sav... - 21:33 Feature #2472: Getting information from the DB before sending an email
- Needs to be tested on my side. I will do it at the end of the week.
- 20:38 Bug #2781 (Closed): Finisher DB seems broken
- Finisher_DB has started again. Thanks! It works nicely for me.
Bug closed. - 20:21 Bug #2781: Finisher DB seems broken
- so I was rigth and it might work for me some revisions ago :)
- 20:06 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- 1. made a quick workaround for me:
after @$this->save($queryFields);@... - 19:22 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- I don't like it very much to store the uid in $_SESSION, but I can't think of any other possible way, so it's OK.
Wh... - 19:20 Bug #2781: Finisher DB seems broken
- I thought I removed this bug some time ago. Why is it still in there? Removed escapeFields() call and committed
- 18:52 Bug #2781: Finisher DB seems broken
- I think escapeFields() is not needed at all since this is already within INSERTquery.
ATM latBuiltQuery looks like: ... - 14:28 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- great.
For the use of [uid] the Finisher_DB must store the insert_id to the session. This should be also be usable... - 00:15 Feature #2745 (Closed): Makes that values can be POST on a redirected page
- Looks nice
- 00:14 Bug #2780 (Closed): Finisher Confirmation needs to be check
- Changed some missed occurrences of $gp to $this->gp and fixed wrong code in Controllers. Works fine now.
2009-03-08
- 23:17 Feature #2745: Makes that values can be POST on a redirected page
- I was out of topic!
When I called the method storeGPinSession(), I didn't notice it was already used in Controller... - 22:56 Task #2774: Check code with error_reporting() or so
- > I think, this should be used at least in Finisher_IPBlocking to inform about possible spammers.
I think that's mak... - 22:46 Feature #2745: Makes that values can be POST on a redirected page
- I meant this method in Controller_Default:...
- 22:41 Feature #2745: Makes that values can be POST on a redirected page
- Yes. I added in method process() of Controller_Multistep....
- 22:06 Task #2779 (Resolved): Exceptions and debug message in translation file
- If the provided key is not found, the value will be treated as message and print out or thrown as exception:...
- 21:59 Task #2774 (Closed): Check code with error_reporting() or so
- Checking with error_reporting() is a waste of time!
- 21:36 Task #2774: Check code with error_reporting() or so
- error_reporting(E_ALL) also checks all code used from TYPO3 core, so there are a lot of messages. Furthermore it's mo...
- 21:35 Feature #2745: Makes that values can be POST on a redirected page
- is this option also checked in Controller_Multistep? If not, please add it there too and the issue can be closed.
- 20:56 Task #2772: Apply auto formating to code
- :)
Seems NetBeans 6.5 needs some improvement still. - 20:54 Task #2772: Apply auto formating to code
- I don't know what NetBeans does with the code, but Eclipse seems to do OK....
2009-03-07
- 01:51 Bug #2781: Finisher DB seems broken
- It wokrs for me.
Did you configure the mapping? All fields need at least an empty finishers.1.config.fields.fieldnam... - 01:44 Bug #2781 (Closed): Finisher DB seems broken
- Records are stored in the database but... with no value. Every thing is 0 or NULL.
Needs to be checked. The bug sh... - 01:07 Bug #2780 (Closed): Finisher Confirmation needs to be check
- It seems Finisher Confirmation needs a little check up.
It does not work as expected:
- I have to reload twice ... - 00:06 Task #2774: Check code with error_reporting() or so
- > Do you know something better than doing this only with error_reporting()?
Mmm.. not really. Do you thing error_rep...
2009-03-06
- 23:50 Task #2772: Apply auto formating to code
- I tried already with NetBeans but some portion sucked.
Do you succeed with Eclipse on F3_MailformPlusPlus_Finishe... - 23:21 Task #2779: Exceptions and debug message in translation file
- Nice feature.
A little code clean up was needed on my side. I was on the way for doing that and... I notice the jo... - 23:02 Feature #2745: Makes that values can be POST on a redirected page
- Commited r17559 : new configuration option "storeGP" in TS. This option is also available in the flexform. I have upd...
- 18:33 Feature #2745: Makes that values can be POST on a redirected page
- Oups! I am almost finished with the implementation. I suggest, I submit my code and you adapt it if you think it is w...
- 18:28 Feature #2745: Makes that values can be POST on a redirected page
- Thanks for your work! Will think about it and give you feedback after the weekend.
- 18:21 Task #2779: Exceptions and debug message in translation file
- Debug messages in ...
- 17:38 Feature #2745 (Accepted): Makes that values can be POST on a redirected page
- I checked the link but honestly I found all techniques a bit tricky. I prefer for the moment to store the info in the...
- 16:59 Task #2779 (Resolved): Exceptions and debug message in translation file
- It sucks to have all of these messages directly in the code. The messages should be translatable and a single class s...
- 16:47 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- Just thought of something:
It would be possible to add the values for stuff like [table],[pid],... via TypoScript:... - 16:42 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- Committed a try of intelligent renaming:...
- 14:53 Feature #2777 (Closed): Truncate log tables in BE
- Include a feature into backend module to truncate the log tables or all tables names like tx_mailformplusplus_*.
T... - 14:34 Task #2774 (Closed): Check code with error_reporting() or so
- I want to check the code using error_reporting() with E_ALL or E_STRICT to hunt down uninitialized variables. Sure th...
- 14:05 Task #2772 (Closed): Apply auto formating to code
- I think it would be nice to apply auto formating with eclipse to the whole code.
I will do this on sunday, if nobody... - 11:39 Feature #2745: Makes that values can be POST on a redirected page
- I am quite sure you found this possibility too while doing research: Add a form which submits itself.
http://www.w... - 10:27 Feature #2745: Makes that values can be POST on a redirected page
- True. I thought cURL was a default requirement for T3. But in fact it is a recommendation when using with proxy.
h... - 10:11 Bug #2768 (Closed): Uncaught exception in ext_tables.php
- Works fine for me!
- 10:09 Bug #2750 (Resolved): Setting default values for fields
- 10:08 Bug #2750: Setting default values for fields
- Tested and seems to work nicely.
- 10:07 Feature #2712 (Resolved): sending limiter
- Works as requested
- 03:18 Bug #2635 (Closed): TypoScription configuration should not be mandatory for sending email
- Done!
This patch impact following files:
M Classes/Controller/F3_MailformPlusPlus_Controller_Default.php
...
2009-03-05
- 23:55 Bug #2768 (Closed): Uncaught exception in ext_tables.php
- When the static template is not loaded, an error is thrown. This is done in file ext_tables.php. Unfortunately, this ...
- 01:13 Bug #2635: TypoScription configuration should not be mandatory for sending email
- Work in progress!
2009-03-04
- 20:03 Bug #2750: Setting default values for fields
- Tested a little.
Fixed small bug in code.
Will test further with multistep forms.
One small problem:
If a user... - 19:54 Feature #2712: sending limiter
- Added new TypoScript settings:
* redirectPage: If the submission of the form gets blocked, the user gets redirecte... - 19:47 Bug #2750: Setting default values for fields
- changed to ...
- 19:37 Feature #2745: Makes that values can be POST on a redirected page
- I like the feature, but I don't like using cURL to implement it. I'd like to try not using PHP extensions which could...
- 19:24 Bug #2750: Setting default values for fields
- Looked at the code again: As far as I remember, settings for multistep forms can be set globally too, not only for a ...
- 19:18 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- Wouldn't be necessary to scan the whole folder, except all files have the same name.
I thought about something lik... - 18:58 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- Sounds good.
But I think the incremental scheme should also include something like a shortMD5 part, otherwise some... - 18:17 Bug #2750: Setting default values for fields
- No, I think no other patches are required. These patches you talked about are related to an other issue I will post l...
- 17:55 Bug #2750: Setting default values for fields
- I had a quick look at the code and it looks OK. Does this PreProcessor require any patches to the controllers?
I rem... - 17:45 Bug #2760: finisher StoreUploadedFiles should rename the uploaded files
- You are right, we need to rename the files.
Maybe we could add a TypoScript setting to define the scheme. Somethin... - 17:01 Bug #2760 (Closed): finisher StoreUploadedFiles should rename the uploaded files
- currently the files ar copied directly to the finishedUploadFolder. Thus files can be overwritten by another user if ...
- 09:40 Task #2744: Going beta
- For me it is OK. I am available rather at the end of the afternoon. It could be Monday or Tuesday.
2009-03-03
- 19:01 Bug #2750: Setting default values for fields
- I already made this PreProcessor work for me. See attached file.
I'm not sure if it's the best solution. What did yo... - 15:37 Task #2744: Going beta
- I will resolve #2712 and #2750 as soon as possible and take care about phpdoc and the manual.
The roadmap feature ... - 15:21 Task #2744: Going beta
- I will take care about:
- update documentation doxygen
- resolved #2635
I don't know whether I will found the ... - 15:11 Feature #2712: sending limiter
- The code works fine, but each time the form gets submitted too often, the alert e-mail will be sent, which will resul...
- 15:09 Bug #2750 (Resolved): Setting default values for fields
- Currently there is no PreProcessor setting default values for fields, but I already got the code in my head.
The p... - 15:05 Task #2744: Going beta
- Would be great to go beta!
I suggest to resolve some open issues before that. Furthermore we should update phpdoc ... - 14:58 Bug #2484 (Resolved): markers don't get replaced correctly
- Tested and committed. Issue resolved.
- 02:20 Feature #2745 (Closed): Makes that values can be POST on a redirected page
- This is a nice to have feature:
It would be nice to be able to POST values whenever a page is redirected to an oth... - 02:03 Task #2744 (Closed): Going beta
- I was going to suggest to release a new version of MF as I noticed this was already done recently. Now, I am wonderin...
- 01:52 Bug #2635 (Accepted): TypoScription configuration should not be mandatory for sending email
- 01:51 Bug #2687 (Closed): Mailformplusplus should work without TypoScript
- Works fine for me
2009-03-02
- 15:33 Bug #2687: Mailformplusplus should work without TypoScript
- Finally I found that templateFile + langFile were missing in Finisher_Mail. (Fixed in Revision r17389)
BTW, I have...
2009-02-26
- 23:50 Feature #2712: sending limiter
- Committed feature to send a report mail.
New example configuration:... - 20:32 Feature #2712: sending limiter
- Committed F3_MailformPlusPlus_Interceptor_IPBlocking.
Example TypoScript:... - 14:07 Bug #2635: TypoScription configuration should not be mandatory for sending email
- Good idea!
I'm thinking of two possible ways to do this:
1. The check if configuration is sufficient is done in... - 13:58 Feature #2712 (Accepted): sending limiter
- We will talk about details next week.
- 13:49 Feature #2712: sending limiter
- Useful for forms which e.g. aren't using captcha..
- 12:23 Feature #2712 (Resolved): sending limiter
- It would be nice if there is a rate limiting function for forms (perhaps per IP), so bots sending forms could be auto...
- 09:28 Bug #2635: TypoScription configuration should not be mandatory for sending email
- When an other predefined forms is set, other than the default one, I suggest here to have a little check if the confi...
- 00:35 Bug #2484: markers don't get replaced correctly
- I have to admit, that I do not remember why this distinction is made. I think we changed to callUserFunction() in th_...
- 00:20 Bug #2484: markers don't get replaced correctly
- ah, ok. Sorry, did't look at the return of strcmp. Allways was looking to get the USER object called via cObjGetSingl...
2009-02-25
- 22:48 Bug #2484: markers don't get replaced correctly
- The code looks like this:...
- 22:47 Bug #2687: Mailformplusplus should work without TypoScript
- Nice job :)
Good think to have a 1:1 flexform - TS configuration
I will check the changes deeper tomorrow but ... - 22:40 Bug #2611 (Resolved): Writing german umlauts into an input field crashes validation
- No error found!
- 22:39 Bug #2635: TypoScription configuration should not be mandatory for sending email
- Should be resolved as soon as bug #2687 is resolved.
- 22:34 Bug #2687: Mailformplusplus should work without TypoScript
- I just committed the suggested changes:
- Finishers and Validator have a new method loadConfig($gp,$tsConfig) in w... - 11:56 Feature #2699: Save sent mails into db
- hi *,
> Having some kind of wizard to generate the template code would be awesome, but also a lot of work unfortun... - 01:39 Bug #2687: Mailformplusplus should work without TypoScript
- Forget what I said about the problems with storing the cObj in StaticFuncs. I think this should work just fine.
- 01:29 Bug #2687: Mailformplusplus should work without TypoScript
- I just saw, that some flexform values (redirect_page, ...) get parsed in tx_MailformPlusPlus_Dispatcher and are set a...
- 01:14 Bug #2687: Mailformplusplus should work without TypoScript
- Very good idea... and it makes sense to declare the method() in the interface.
In fact, I was thinking about somet... - 00:58 Feature #2699: Save sent mails into db
- Thanks!
This kind of development could be realized in the frame of a customer's project. Let's see what it could b... - 00:45 Bug #2687: Mailformplusplus should work without TypoScript
- It seems as if I totally forgot to consider flexform values in all the classes. Shame on me!
Just had an idea:
W... - 00:37 Feature #2699: Save sent mails into db
- This feature was just a suggestion anyway. I don't know how this would affect database performance and needed disk sp...
- 00:25 Bug #2687: Mailformplusplus should work without TypoScript
- "Redirect" and "mandatory fields" are typical features that need to be still checked.
At the moment "Redirect" do... - 00:19 Feature #2699: Save sent mails into db
> I did not mean to replace the existing module, but to enhance it with this feature.
Of course...
> I do no k...- 00:08 Bug #2687: Mailformplusplus should work without TypoScript
- Thanks!
I had a look at the setup.txt and compared the settings to the options a user can set in flexform.
The se...
2009-02-24
- 23:55 Feature #2699: Save sent mails into db
- I did not mean to replace the existing module, but to enhance it with this feature.
I had in mind, that the user ca... - 23:46 Bug #2687: Mailformplusplus should work without TypoScript
- Done.
Files impacted:
Configuration/Settings/setup.txt
Resources/PHP/class.tx_dynaflex.php
Before we can clos... - 23:39 Feature #2699: Save sent mails into db
- What would brings in term of features a new module comparing to the existing one? Right now, data are already seriali...
- 23:26 Bug #2687: Mailformplusplus should work without TypoScript
- I like the idea of having a predefined form. Please commit the files!
- 23:15 Bug #2687: Mailformplusplus should work without TypoScript
- That's a good idea indeed... In this case, I would suggest to have a default predefined form in the dropmenu (cf: scr...
- 16:18 Feature #2699 (Closed): Save sent mails into db
- Mails sent by F3_MailformPlusPlus_Finisher_Mail could be stored in a database table and managed via backend module.
... - 02:30 Feature #2405 (Resolved): Add condition before inserting record in the database
- 02:29 Feature #2405: Add condition before inserting record in the database
- The patch got included to source. I don' think that the PHP syntax of the condition is a problem. In my opinion, peop...
- 02:18 Feature #2472: Getting information from the DB before sending an email
- I committed a first approach to this. The finisher gets configuration as posted above, selects the data and stores it...
- 01:18 Bug #2687: Mailformplusplus should work without TypoScript
- Yes, I agree 100%. Novice users will not be able to quickly set up a form, when they have to write the TypoScript set...
- 01:07 Bug #2687 (Closed): Mailformplusplus should work without TypoScript
- For novice users, I think it could be a good idea to have a working mailform++ only by defining values in the flexfor...
2009-02-23
- 23:06 Task #2686: Add templates for backend module
- Added templates for list view and detail view plus a CSS file for styles.
Still TODO:
- Templates for format an... - 23:03 Task #2686 (Closed): Add templates for backend module
- HTML code is written directly in the PHP class of the module.
Add HTML templates and CSS file. - 22:33 Bug #2611 (Accepted): Writing german umlauts into an input field crashes validation
- Reopened due to issues with strings already being UTF-8.
Added a quick fix to detect the charset of a string before ...
2009-02-20
- 22:48 Task #2468 (Closed): Convert encoding to UTF-8
- Everything is UTF-8 now :=) I don't know what happened.
To convert charset in bash mode, you can use the command:
... - 14:42 Task #2468 (Needs Feedback): Convert encoding to UTF-8
- Do you know a suitable way to convert the files to UTF-8 and update SVN. I set my Eclipse to work with UTF-8, but all...
- 14:40 Bug #2670 (Closed): Making MathGuard more customizable with CSS
- Committed!
- 14:28 Bug #2670: Making MathGuard more customizable with CSS
- Absolutely ok. I added the extra ...
- 14:21 Bug #2670 (Needs Feedback): Making MathGuard more customizable with CSS
- 14:20 Bug #2670 (Closed): Making MathGuard more customizable with CSS
- I am for removing the double < pre >< / pre > tags around the Mathgard in order to make it more customizable with CSS...
- 11:28 Feature #2634 (Closed): Add translation for the backend
- French translation added!
- 11:24 Feature #2600 (Closed): Add French translation in examples
2009-02-16
- 23:02 Feature #2634 (Accepted): Add translation for the backend
- I added language labels and translation to english and german. Feel free to add french translation!
- 22:21 Bug #2635: TypoScription configuration should not be mandatory for sending email
- Interesting behavior indeed. I would appreciate it, if you could have a look at the problem.
- 22:17 Feature #2634: Add translation for the backend
- You are totally right. The code for the backend module is a mess right now. I planned on adding templates too to get ...
2009-02-15
- 23:49 Bug #2635 (Closed): TypoScription configuration should not be mandatory for sending email
- I am realizing that TS configuration is mandatory for sending email. If I define values for sending email in the flex...
- 22:44 Feature #2634 (Closed): Add translation for the backend
- At the moment label are hardcoded... This should be convenient to have translation files.
- 22:29 Feature #2600 (Accepted): Add French translation in examples
- First translation landed in the trunk. Needs maybe some adjustment after using the extension. This can be done later.
Also available in: Atom