Index: typo3/mod/tools/em/class.em_index.php =================================================================== --- typo3/mod/tools/em/class.em_index.php (revision 7609) +++ typo3/mod/tools/em/class.em_index.php (working copy) @@ -382,7 +382,8 @@ ); $this->privacyNotice = $GLOBALS['LANG']->getLL('privacy_notice'); - $securityMessage = sprintf($GLOBALS['LANG']->getLL('security_descr'), + $securityMessage = $GLOBALS['LANG']->getLL('security_warning_extensions') . + '

' . sprintf($GLOBALS['LANG']->getLL('security_descr'), '', '' ); $flashMessage = t3lib_div::makeInstance( @@ -419,7 +420,6 @@ $this->terConnection->wsdlURL = $TYPO3_CONF_VARS['EXT']['em_wsdlURL']; $this->xmlhandler = t3lib_div::makeInstance('SC_mod_tools_em_xmlhandler'); $this->xmlhandler->emObj = $this; - $this->xmlhandler->useUnchecked = $this->MOD_SETTINGS['display_unchecked']; $this->xmlhandler->useObsolete = $this->MOD_SETTINGS['display_obsolete']; // Initialize Document Template object: @@ -515,7 +515,6 @@ ), 'display_shy' => '', 'display_own' => '', - 'display_unchecked' => '', 'display_obsolete' => '', 'display_installed' => '', 'display_files' => '', @@ -885,9 +884,9 @@ $offset = $this->listingLimit*$this->pointer; if($this->MOD_SETTINGS['display_own'] && strlen($this->fe_user['username'])) { - $this->xmlhandler->searchExtensionsXML($this->listRemote_search, $this->fe_user['username'], $this->MOD_SETTINGS['listOrder']); + $this->xmlhandler->searchExtensionsXML($this->listRemote_search, $this->fe_user['username'], $this->MOD_SETTINGS['listOrder'], TRUE); } else { - $this->xmlhandler->searchExtensionsXML($this->listRemote_search, '', $this->MOD_SETTINGS['listOrder'], false, false, $offset, $this->listingLimit); + $this->xmlhandler->searchExtensionsXML($this->listRemote_search, '', $this->MOD_SETTINGS['listOrder'], TRUE, FALSE, $offset, $this->listingLimit); } if (count($this->xmlhandler->extensionsXML)) { list($list,$cat) = $this->prepareImportExtList(true); @@ -948,13 +947,8 @@ $onsubmit = "window.location.href='index.php?ter_connect=1&ter_search='+escape(this.elements['lookUp'].value);return false;"; $content .= '

+ sprintf($GLOBALS['LANG']->getLL('list_or_look_up'), '') + . '


'; @@ -1004,13 +998,8 @@ $onsubmit = "window.location.href='index.php?ter_connect=1&ter_search='+escape(this.elements['lookUp'].value);return false;"; $content .= '

+ sprintf($GLOBALS['LANG']->getLL('list_or_look_up'), '') + . '


'; @@ -1028,13 +1017,8 @@ $onsubmit = "window.location.href='index.php?ter_connect=1&ter_search='+escape(this.elements['lookUp'].value);return false;"; $content .= '

+ sprintf($GLOBALS['LANG']->getLL('list_or_look_up'), '') + . '


'; @@ -1130,20 +1114,6 @@ $content.= ' ' . t3lib_BEfunc::cshItem('_MOD_tools_em', 'settings', $GLOBALS['BACK_PATH'], '|
') . ' -
' . $GLOBALS['LANG']->getLL('security_settings') . ' - - - - - -
'.t3lib_BEfunc::getFuncCheck(0,'SET[display_unchecked]',$this->MOD_SETTINGS['display_unchecked'],'','','id="display_unchecked"').'
- ' . $GLOBALS['LANG']->getLL('notice') . ' ' . - sprintf($GLOBALS['LANG']->getLL('security_notice'), - '', '' - ) . - '
-
-
' . $GLOBALS['LANG']->getLL('user_settings') . ' @@ -1868,7 +1838,7 @@ if (!$this->xmlhandler->countExtensions()) { $this->fetchMetaData('extensions'); } - $this->xmlhandler->searchExtensionsXMLExact($extKey, '', '', true); + $this->xmlhandler->searchExtensionsXMLExact($extKey, '', '', TRUE, TRUE); // check if extension can be fetched if(isset($this->xmlhandler->extensionsXML[$extKey])) { @@ -6150,7 +6120,7 @@ ''; foreach ($extList[0] as $name => $data) { - $this->xmlhandler->searchExtensionsXMLExact($name, '', '', false, true); + $this->xmlhandler->searchExtensionsXMLExact($name, '', '', TRUE, TRUE); if (!is_array($this->xmlhandler->extensionsXML[$name])) { continue; } Index: typo3/mod/tools/em/class.em_xmlhandler.php =================================================================== --- typo3/mod/tools/em/class.em_xmlhandler.php (revision 7609) +++ typo3/mod/tools/em/class.em_xmlhandler.php (working copy) @@ -53,7 +53,6 @@ var $extXMLResult = array(); var $extensionsXML = array(); var $reviewStates = null; - var $useUnchecked = false; var $useObsolete = false; /** @@ -84,16 +83,14 @@ if ($owner) { $where.= ' AND ownerusername='.$GLOBALS['TYPO3_DB']->fullQuoteStr($owner, 'cache_extensions'); } - if (strlen($owner) || $this->useUnchecked || $allExt) { - // show extensions without review or that have passed review - $where.= ' AND reviewstate >= 0'; - } else { - // only display extensions that have passed review - $where.= ' AND reviewstate > 0'; + + // Show extensions without a review or that have passed a review, but not insecure extensions + $where .= ' AND reviewstate >= 0'; + + if (!$this->useObsolete) { + // 5 == obsolete + $where.= ' AND state != 5'; } - if (!$this->useObsolete && !$allExt) { - $where.= ' AND state!=5'; // 5 == obsolete - } switch ($order) { case 'author_company': $forder = 'authorname, authorcompany'; @@ -108,11 +105,7 @@ } $order = $forder.', title'; if (!$allVer) { - if ($this->useUnchecked) { - $where .= ' AND lastversion>0'; - } else { - $where .= ' AND lastreviewedversion>0'; - } + $where .= ' AND lastversion > 0'; } $this->catArr = array(); $idx = 0; @@ -226,38 +219,6 @@ } /** - * Removes all extension versions from $extensions that have a reviewstate<1, unless explicitly allowed - * - * @param array &$extensions The "versions" subpart of the extension list - * @return void - */ - function checkReviewState(&$extensions) { - if ($this->useUnchecked) return; - - foreach ($extensions as $version => $data) { - if($data['reviewstate']<1) - unset($extensions[$version]); - } - } - - /** - * Removes all extension versions from the list of available extensions that have a reviewstate<1, unless explicitly allowed - * - * @return void - */ - function checkReviewStateGlobal() { - if($this->useUnchecked) return; - - foreach ($this->extensionsXML as $extkey => $data) { - foreach ($data['versions'] as $version => $vdata) { - if($vdata['reviewstate']<1) unset($this->extensionsXML[$extkey]['versions'][$version]); - } - if(!count($this->extensionsXML[$extkey]['versions'])) unset($this->extensionsXML[$extkey]); - } - } - - - /** * ***************PARSING METHODS*********************** */ /** Index: typo3/sysext/lang/locallang_mod_tools_em.xml =================================================================== --- typo3/sysext/lang/locallang_mod_tools_em.xml (revision 7609) +++ typo3/sysext/lang/locallang_mod_tools_em.xml (working copy) @@ -33,6 +33,7 @@ + @@ -73,7 +74,7 @@ - +