TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692013-03-23T19:24:34ZTYPO3 Forge
Redmine TYPO3 Core - Bug #46610 (Closed): ElementBrowser must not use dirname() on identifierhttp://forge.typo3.org/issues/466102013-03-23T19:24:34ZGeorg Ringer
<p>There is such a code twice in Elementbrowser</p>
<pre><code class="php syntaxhl" data-language="php"><span class="c1">// It's a file</span>
<span class="c1">// @todo: find the parent folder, right now done a bit ugly, because the file does not</span>
<span class="c1">// support finding the parent folder of a file on purpose</span>
<span class="nv">$folderIdentifier</span> <span class="o">=</span> <span class="nb">dirname</span><span class="p">(</span><span class="nv">$fileOrFolderObject</span><span class="o">-></span><span class="nf">getIdentifier</span><span class="p">());</span>
</code></pre>
<p>this breaks every driver which is not based on directories</p> TYPO3 Core - Task #46580 (Closed): FileList misses function getFolderObjecthttp://forge.typo3.org/issues/465802013-03-23T09:26:42ZGeorg Ringer
<p>The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['fileList']['editIconsHook'] is useless if there is no information about the folderobject itself.</p>
<p>Usecase: I want to change the edit icons for a specific driver.</p>
<p>Solution: add <br /><pre>
/**
* Get folder object
*
* @return \TYPO3\CMS\Core\Resource\Folder
*/
public function getFolderObject() {
return $this->folderObject;
}
</pre></p> TYPO3 Core - Task #46547 (Closed): Remove unneded text in Install-Toolhttp://forge.typo3.org/issues/465472013-03-22T13:53:24ZGeorg Ringer
<p>Some text in the install tool should be removed</p>
<p>- "Installing TYPO3 as always been a hot topic on the mailinglist"... Nowadays it is quite easy to install TYPO3<br />- The text why the InstallTool should be standalone and no BE module is not quite true as it is also a BE module and rest of the text is such technical and got no information benefit for anybody</p> TYPO3 Core - Task #45287 (Closed): Setting pageNotFoundOnCHashError should be TRUE by defaulthttp://forge.typo3.org/issues/452872013-02-08T16:36:17ZGeorg Ringer
<p>The setting pageNotFoundOnCHashError should be true by default because of perfomance reasons.</p> TYPO3 Core - Bug #44370 (Closed): LocalDriver doesn't respect flag "is_writeable"http://forge.typo3.org/issues/443702013-01-08T11:14:55ZGeorg Ringer
<p>The LocalDriver needs also to respect the flag "is_writeable".</p>
<p>This means: if the flag is not set, no folder/file can be edited/moved....</p>
<p>I don't know if my solution is the correct one - but at least it works</p> TYPO3 Core - Bug #41293 (Rejected): FAL: filepicker allows picking the same file multiple timeshttp://forge.typo3.org/issues/412932012-09-23T15:15:52ZGeorg Ringer
<p>PoC: page properties > media > popup for selectiong the file: when clicking the '+' multiple times, the image will be added multiple times too.</p> TYPO3 Core - Bug #41249 (Closed): tsconfig_help currently broken because of emhttp://forge.typo3.org/issues/412492012-09-22T13:30:57ZGeorg Ringer
<p>current code of tsconfig_help is</p>
<pre>
if (!\TYPO3\CMS\Core\Extension\ExtensionManager::isLoaded('em')) {
// Em is not loaded, so include the unzip class
\TYPO3\CMS\Core\Utility\GeneralUtility::requireOnce(PATH_typo3 . 'sysext/em/classes/tools/class.tx_em_tools_unzip.php');
}
$unzip = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('tx_em_Tools_Unzip', $file);
$ret = $unzip->extract(array('add_path' => $path));
return is_array($ret);
</pre>
<p>ext is no "extensionmamanager" and unzip is not there anymore</p> TYPO3 Core - Task #39646 (Closed): Improve display of content elementshttp://forge.typo3.org/issues/396462012-08-09T15:04:25ZGeorg Ringer
<p>After changing the presenting of content elements in page module some things needs to be still improved.</p>
<p>to test, add the content elements with no title set and take a look at the page module</p>
examples
<ul>
<li>felogin > the element is empty</li>
<li>simple search > the element is empty</li>
<li>sitemap > it displays the root of a sitemap and the page id(s)</li>
</ul> TYPO3 Core - Task #39606 (Closed): Fix typos in corehttp://forge.typo3.org/issues/396062012-08-08T08:21:39ZGeorg Ringer
<p>some more typos to be fixed</p> TYPO3 Core - Feature #36514 (Rejected): Translation of backendlayoutshttp://forge.typo3.org/issues/365142012-04-24T15:10:07ZGeorg Ringer
<p>currently the title of a backend layout is not translatable but this is needed for multilingual pages (and editors).</p>
<p>A simple solution would be to use a hook<br />ext_tables.php<br /><pre><code class="php syntaxhl" data-language="php"> <span class="o">*</span> <span class="nc">Make</span> <span class="n">backend</span><span class="o">-</span><span class="n">layout</span> <span class="n">selector</span> <span class="n">multilanguage</span> <span class="n">aware</span>
<span class="o">*/</span>
<span class="n">t3lib_div</span><span class="o">::</span><span class="nf">requireOnce</span><span class="p">(</span><span class="n">t3lib_extMgm</span><span class="o">::</span><span class="nf">extPath</span><span class="p">(</span><span class="nv">$_EXTKEY</span><span class="p">)</span> <span class="mf">.</span> <span class="s1">'Classes/Hooks/ItemsProcFunc.php'</span><span class="p">);</span>
<span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TCA'</span><span class="p">][</span><span class="s1">'backend_layout'</span><span class="p">][</span><span class="s1">'ctrl'</span><span class="p">][</span><span class="s1">'label_alt_force'</span><span class="p">]</span> <span class="o">=</span> <span class="mi">1</span><span class="p">;</span>
<span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TCA'</span><span class="p">][</span><span class="s1">'backend_layout'</span><span class="p">][</span><span class="s1">'ctrl'</span><span class="p">][</span><span class="s1">'label_userFunc'</span><span class="p">]</span> <span class="o">=</span> <span class="s1">'Tx_Modernpackage_Hooks_ItemsProcFunc->getLabel'</span><span class="p">;</span>
</code></pre></p>
<p>Classes/Hooks/ItemsProcFunc.php<br /><pre><code class="php syntaxhl" data-language="php"><span class="cp"><?php</span>
<span class="cd">/***************************************************************
* Copyright notice
*
* (c) 2012 Georg Ringer <typo3@ringerge.org>
* All rights reserved
*
* This script is part of the TYPO3 project. The TYPO3 project is
* free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* The GNU General Public License can be found at
* http://www.gnu.org/copyleft/gpl.html.
*
* This script is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* This copyright notice MUST APPEAR in all copies of the script!
***************************************************************/</span>
<span class="cd">/**
* ItemsProcFunc to make backend_layout fields
* multilanguage aware if the name starts with 'LLL:'
*
* @package TYPO3
* @subpackage tx_modernpackage
*/</span>
<span class="kd">class</span> <span class="nc">Tx_Modernpackage_Hooks_ItemsProcFunc</span> <span class="p">{</span>
<span class="cd">/**
* Labels of a be_layout record
*
* @param array $params
* @return void
*/</span>
<span class="k">public</span> <span class="k">function</span> <span class="n">getLabel</span><span class="p">(</span><span class="kt">array</span> <span class="o">&</span><span class="nv">$params</span><span class="p">)</span> <span class="p">{</span>
<span class="k">if</span> <span class="p">(</span><span class="n">t3lib_div</span><span class="o">::</span><span class="nf">isFirstPartOfStr</span><span class="p">(</span><span class="nv">$params</span><span class="p">[</span><span class="s1">'row'</span><span class="p">][</span><span class="s1">'title'</span><span class="p">],</span> <span class="s1">'LLL:'</span><span class="p">))</span> <span class="p">{</span>
<span class="nv">$params</span><span class="p">[</span><span class="s1">'title'</span><span class="p">]</span> <span class="o">=</span> <span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'LANG'</span><span class="p">]</span><span class="o">-></span><span class="nf">sL</span><span class="p">(</span><span class="nv">$params</span><span class="p">[</span><span class="s1">'row'</span><span class="p">][</span><span class="s1">'title'</span><span class="p">],</span> <span class="kc">TRUE</span><span class="p">);</span>
<span class="p">}</span> <span class="k">else</span> <span class="p">{</span>
<span class="nv">$params</span><span class="p">[</span><span class="s1">'title'</span><span class="p">]</span> <span class="o">=</span> <span class="nv">$params</span><span class="p">[</span><span class="s1">'row'</span><span class="p">][</span><span class="s1">'title'</span><span class="p">];</span>
<span class="p">}</span>
<span class="p">}</span>
<span class="p">}</span>
<span class="cp">?></span>
</code></pre></p> TYPO3 Core - Bug #34460 (Closed): Allowed excludefields shows fields of tables which are admin onlyhttp://forge.typo3.org/issues/344602012-03-02T13:16:36ZGeorg Ringer
The selection Allowed excludefields shows fields of tables which can only be edited by admins like:
<ul>
<li>Website language</li>
<li>Template</li>
<li>Workspace</li>
</ul> TYPO3 Core - Bug #31978 (Closed): tcaTree: PHP Warning: Missing argument 2 for extDirect_DataProv...http://forge.typo3.org/issues/319782011-11-22T06:51:38ZGeorg Ringer
<p>the tcatree throws an error every time it is called. I am not into ExtJS and neither into the tcaTree itself but IMO those information should be enough to fix it.</p>
<p>How to test<br />-------------<br />Install EXT:news, create at least one category and call either the category record or the plugin - both got a tca tree implemented</p>
<p>Information from debugging<br />---------------------------<br />The error comes from class t3lib_TCEforms_Tree which got an inline JS <br /><pre>
expandnode: function(node) {
top.TYPO3.BackendUserSettings.ExtDirect.addToList("tcaTrees." + this.ucId, node.attributes.uid);
}
</pre></p>
<p>Problem is that node.attributes.uid is undefined. This happens with the root node</p>
<p>Using this code to debug<br /><pre>
if (node.attributes.uid) {
top.TYPO3.BackendUserSettings.ExtDirect.addToList("tcaTrees." + this.ucId, node.attributes.uid);
} else {
alert(node);
}
</pre><br />shows 2 alert boxes with:<br /><pre>[Node xnode-27]
[Node root]
</pre></p>
<p>Possible solutions
======================<br />As already stated, I no nothing about ExtJS but there are IMO 2 possible solutions:<br />1) Use an if clause "if (node.attributes.uid) {"</p>
<p>2) Maybe it is even more simple as IMO it should be node.attributes.id as t3lib_tree_pagetree_DataProvider also uses e.g. "$node->setId('root');" The maybe wrong value is also used in TYPO3.Components.Tree.TcaCheckChangeHandler inside tree.js</p> TYPO3 Core - Bug #27971 (Rejected): xliff removed hook to override locallangshttp://forge.typo3.org/issues/279712011-07-08T09:05:51ZGeorg Ringer
<p>There was a hook in t3lib_div::readLLFile() to override <strong>any</strong> locallang file by another one. The additional locallang is merged with the existing one which is very nice feature to override just one label.</p>
<p>as the l10n changed a lot with xliff, it is not just a copy paste to get hook working again.<br />previous hook was this</p>
<pre>
$overrides = array();
$fileRefWithoutExtension = preg_replace('/\.(php|xml)$/', '', $fileRef);
if (is_array($GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride'][$fileRefWithoutExtension . '.php'])) {
$overrides = array_merge($overrides, $GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride'][$fileRefWithoutExtension . '.php']);
}
if (is_array($GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride'][$fileRefWithoutExtension . '.xml'])) {
$overrides = array_merge($overrides, $GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride'][$fileRefWithoutExtension . '.xml']);
}
if (count($overrides) > 0) {
foreach ($overrides as $overrideFile) {
$languageOverrideFileName = self::getFileAbsFileName($overrideFile);
if (@is_file($languageOverrideFileName)) {
$languageOverrideArray = self::readLLXMLfile($languageOverrideFileName, $langKey, $charset);
$LOCAL_LANG = self::array_merge_recursive_overrule($LOCAL_LANG, $languageOverrideArray);
}
}
}
</pre> TYPO3 Core - Bug #24975 (Closed): hsc called twice for title tag at login pagehttp://forge.typo3.org/issues/249752011-02-07T07:54:46ZGeorg Ringer
<p>htmlspecialchars is used twice on the title tag of the login page. If there is a '&' in $TYPO3_CONF_VARS['SYS']['sitename'], this looks very ugly (&).</p>
<p>How it works:<br />1) index.php calls $TBE_TEMPLATE->startPage('TYPO3 Login: ' . htmlspecialchars($TYPO3_CONF_VARS['SYS']['sitename']), FALSE);</p>
<p>2) in template.php startPage() the pagerenderer is called with $this->pageRenderer->setHtmlTag($htmlTag);</p>
<p>3) in class.t3lib_pagerenderer.php the final htmlspecialchars() is used in line 1494: 'TITLE' => $this->title ? str_replace('|', htmlspecialchars($this->title), $this->titleTag) : '',</p>
<p>So it is safe to remove the hsc() in index.php</p>
<p>(issue imported from #M17503)</p> TYPO3 Core - Feature #18618 (Closed): stdWrap for HMENU maxItems & minItems & beginhttp://forge.typo3.org/issues/186182008-04-14T12:23:46ZGeorg Ringer
<p>currently it is not possible to use stdWrap for maxItems, minItems & begin in HMENU</p>
<p>this can be very nice to build a page browser, example:<br />lib.mainmenu_level4 = HMENU<br />lib.mainmenu_level4 { <br /> maxItems = 6<br /> begin.data = GPvar:browse<br />}</p>
<p>(issue imported from #M8115)</p>