TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692014-02-21T20:21:13ZTYPO3 Forge
Redmine TYPO3 Core - Task #56200 (Closed): Clean up duplicated code in calcAgehttp://forge.typo3.org/issues/562002014-02-21T20:21:13ZTymoteusz Motylewskit.motylewski@gmail.com
<p>both classes<br />typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php<br />typo3/sysext/backend/Classes/Utility/BackendUtility.php</p>
<p>implement calcAge() method, which is almost exact copy.<br />We should refactor it by moving the method to some utility class.</p> TYPO3 Core - Bug #55979 (Closed): Uncaught Error: Script error for: TYPO3/CMS/Backend/FileListLoc...http://forge.typo3.org/issues/559792014-02-14T11:11:38ZTymoteusz Motylewskit.motylewski@gmail.com
<p>when you open link browser from RTE there is an error in the browser console:<br />"Uncaught Error: Script error for: TYPO3/CMS/Backend/FileListLocalisation" <br />its thrown because file <br />typo3/sysext/backend/Resources/Public/JavaScript/FileListLocalisation.js<br />does not exist.<br />(it's referenced from loadDragUploadJs method of <br />typo3/sysext/backend/Classes/Form/Element/InlineElement.php )</p>
<p>The only file with this name exists in <br />typo3/sysext/filelist/Resources/Public/JavaScript/FileListLocalisation.js</p>
<p>I'm not sure if the file is missing, or the reference (path) is wrong in InlineElement.</p> TYPO3 Core - Bug #55876 (Closed): Rename classes with the same namehttp://forge.typo3.org/issues/558762014-02-11T15:30:15ZTymoteusz Motylewskit.motylewski@gmail.com
<p>We have 3 implementations of the \localPageTree class in the global namespace in:<br />- db_new.php<br />- move_el.php<br />- class.browse_links.php</p>
<p>We should clean this up, as it's quite confusing for the developer which class is used when and makes autoloading impossible.</p>
<p>I attach Sequence diagram for db_new.php (and a source code of it). Diagram was generated with <a class="external" href="http://interactive.blockdiag.com/seqdiag/">http://interactive.blockdiag.com/seqdiag/</a><br />For the class inheritance diagram see <a class="external" href="http://forge.typo3.org/issues/55830">http://forge.typo3.org/issues/55830</a></p> TYPO3 Core - Bug #55721 (Closed): wrong filenames when UTF8filesystem is set and 'systemLocale' i...http://forge.typo3.org/issues/557212014-02-06T12:11:20ZTymoteusz Motylewskit.motylewski@gmail.com
<p>While checking out issue <a class="external" href="http://forge.typo3.org/issues/32683">http://forge.typo3.org/issues/32683</a> on 6.2 I stumbled upon the same issue.<br />I found out that if you have UTF8Filesystem set to 1, but $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'] is empty, then TYPO3 generate wrong file names, resulting e.g. in thumbnails not being generated in the backend. The problem disappear if I set '['SYS']['systemLocale']' to e.g. 'C.UTF-8' or 'en_US.UTF-8' or similar.</p>
<p>But the issue is not limited to thumbnails ony. It also occurs in many other places. There are plenty of related issues in Forge.</p>
<p>The common pattern all over TYPO3 is sth like this:<br /><pre>
if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem']) {
$currentLocale = setlocale(LC_CTYPE, 0);
setlocale(LC_CTYPE, $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale']);
}
//do sth here e.g. basename, escapeshellarg, dirname, pathinfo
$escapedInputName = escapeshellarg($inputName);
if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem']) {
setlocale(LC_CTYPE, $currentLocale);
}
</pre><br />Btw, there is already a ticket to refactor this and put the logic in the central place. <a class="external" href="http://forge.typo3.org/issues/39928">http://forge.typo3.org/issues/39928</a></p>
<p>I see several solutions here:<br />1. Use fallback when setting locale. <br />Instead of <br /> setlocale(LC_CTYPE, $currentLocale);<br /> setlocale(LC_CTYPE, $currentLocale, 'C.UTF-8', 'en_US.utf8');</p>
<p>2. Set default value 'C.UTF-8' to $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'], so it should be never empty.<br />3. Add install tool warning when systemLocale is not set<br />4. BTW, why can not we set setlocale() globally in bootstrap instead of setting it for each function separately?</p> TYPO3 Core - Task #51091 (Closed): Provide functional test base classhttp://forge.typo3.org/issues/510912013-08-15T17:09:45ZTymoteusz Motylewskit.motylewski@gmail.com
<p>We need a base test case class for the functional tests.</p> TYPO3 Core - Bug #40154 (Closed): Error when klicking "open in new window" icon in task modulehttp://forge.typo3.org/issues/401542012-08-25T00:24:13ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Steps to reproduce:<br />Go to tasks center module<br />click on the gray icon "open in new window" (right top corner)</p>
<p>The popup will contain error:</p>
<p>#1294585070: No module "" could be found. (More information)</p>
<p>UnexpectedValueException thrown in file<br />\typo3\mod.php in line 55.</p> TYPO3 Core - Bug #40153 (Closed): Class TYPO3\CMS\Version\Dependency\DependencyResolver_Callback ...http://forge.typo3.org/issues/401532012-08-25T00:19:01ZTymoteusz Motylewskit.motylewski@gmail.com
<p>When trying to save template I've got:<br />Class TYPO3\CMS\Version\Dependency\DependencyResolver_Callback does not exist</p>
<p>this wrong class name is used in<br />\typo3\sysext\version\Classes\DataHandler\CommandMap.php<br />line 894</p> TYPO3 Core - Bug #40152 (Closed): Error when accessing wizard module and wizard_create_pages is d...http://forge.typo3.org/issues/401522012-08-25T00:15:23ZTymoteusz Motylewskit.motylewski@gmail.com
<p>When extension wizard module I've got error:</p>
<p>#1270853878: TYPO3 Fatal Error: Extension key "wizard_create_pages" is NOT loaded! (More information)</p>
<p>BadFunctionCallException thrown in file<br />typo3\sysext\core\Classes\Extension\ExtensionManager.php in line 89.</p>
<p>the cause of this error is mapping in <br />typo3\sysext\wizard_crpages\class.tx_wizardcrpages_webfunc_2.php</p>
<p>require_once \TYPO3\CMS\Core\Extension\ExtensionManager::extPath('wizard_create_pages') . 'Classes/Controller/CreatePagesWizardModuleFunctionController.php';</p>
<p>but wizard_create_pages is not real extension but just folder with one file</p> TYPO3 Core - Bug #40151 (Closed): Error when trying to change user in Access modulehttp://forge.typo3.org/issues/401512012-08-25T00:01:43ZTymoteusz Motylewskit.motylewski@gmail.com
<p>when clicking on username in "access" module, "permissions" tab, you're getting:<br />No backend function registered for ajaxID "SC_mod_web_perm_ajax::dispatch".</p> TYPO3 Core - Bug #40149 (Closed): Class '\TYPO3\CMS\IndexedSearch\Controller\SearchFormController...http://forge.typo3.org/issues/401492012-08-24T23:33:09ZTymoteusz Motylewskit.motylewski@gmail.com
<p>in some places GeneralUtility::makeInstance('TYPO3\\CMS\\IndexedSearch\\Controller\\SearchFormController_indexer');<br />is called. <br />The class name is wrong</p> TYPO3 Core - Bug #40148 (Closed): Could not analyse class:TYPO3\CMS\ViewPage\Controller\ViewModul...http://forge.typo3.org/issues/401482012-08-24T23:21:46ZTymoteusz Motylewskit.motylewski@gmail.com
<p>While accessing View module in TYPO3 backend exception is thrown</p>
<p>Could not analyse class:TYPO3\CMS\ViewPage\Controller\ViewModuleController maybe not loaded or no autoloader?</p> TYPO3 Core - Bug #40146 (Closed): [rsaauth] Call to undefined method CommandUtility::getCommand()http://forge.typo3.org/issues/401462012-08-24T22:24:16ZTymoteusz Motylewskit.motylewski@gmail.com
<p>While trying to log in into backend I'm getting:</p>
<p>Fatal error: Call to undefined method TYPO3\CMS\Core\Utility\CommandUtility::getCommand() in C:\xampp\htdocs\community46\typo3\sysext\rsaauth\Classes\Backend\CommandLineBackend.php on line 60</p>
<p>this line right now is:<br />$this->opensslPath = \TYPO3\CMS\Core\Utility\CommandUtility::getCommand('openssl');</p>
<p>before was:<br />$this->opensslPath = t3lib_exec::getCommand('openssl');</p>
<p>Class t3lib_exec is now mapped to \TYPO3\CMS\Core\Extension\ExtensionManager::extPath('core') . 'Classes/Utility/CommandUtility.php';</p>
<p>but the content of CommandUtility is completely different then the original t3lib_exec class</p> TYPO3 Core - Bug #39563 (Closed): Regression in t3lib_iconWorks::imagecopyresizedhttp://forge.typo3.org/issues/395632012-08-06T23:53:21ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Revision 98f73d8b (issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: imagecopyresized has invalid function parameter (Closed)" href="http://forge.typo3.org/issues/26660">#26660</a>, review [1]) introduced 2 regressions. One in <br />t3lib_stdGraphic::imagecopyresized and the second one in t3lib_iconWorks::imagecopyresized.</p>
<p>First regression was already fixed in master [5] and v.4.7 [6] but the second one is still there. The problem itself is really no brainer - underlying function is called with wrong parameters.</p>
<p>This has to be fixed in 4.7 branch and master (6.0).<br />The original patch wasn't merged yet to 4.5 and 4.6, so bug can be fixed there.</p>
<p>Changes overview:<br />[1] <a class="external" href="https://review.typo3.org/#/c/2564/">https://review.typo3.org/#/c/2564/</a> - master, merged (original change)<br />[2] <a class="external" href="https://review.typo3.org/#/c/9608/">https://review.typo3.org/#/c/9608/</a> - v.4.7, merged<br />[3] <a class="external" href="https://review.typo3.org/#/c/6829/">https://review.typo3.org/#/c/6829/</a> - v.4.6, not merged<br />[4] <a class="external" href="https://review.typo3.org/#/c/6831/">https://review.typo3.org/#/c/6831/</a> - v.4.5, not merged</p>
<p>Regresion fixes:<br />[5] <a class="external" href="https://review.typo3.org/#/c/11984/">https://review.typo3.org/#/c/11984/</a> - master, merged (fix one regression)<br />[6] <a class="external" href="https://review.typo3.org/#/c/12074/">https://review.typo3.org/#/c/12074/</a> - 4.7, merged (fix one regression)</p> TYPO3 Core - Bug #36894 (Closed): [felogin] Wrong action url when nested array is passedhttp://forge.typo3.org/issues/368942012-05-06T20:36:05ZTymoteusz Motylewskit.motylewski@gmail.com
<p>If you have login form on page with url like this:<br />index.php?id=10&L=3&tx_someext[@widget_0][currentPage]=3</p>
<p>Action url of login form will point to:<br />index.php?id=10&L=3&tx_someext[@widget_0]=Array</p>
<p>The problem is in method tx_felogin_pi1->getPreserveGetVars() (called from getPageLink() ).<br />This method assumes that no nested arrays are passed as parameter.<br /><pre>
$params .= '&' . $key . '[' . $key1 . ']=' . $val1;
</pre></p> TYPO3 Core - Bug #21339 (Closed): "Generate random key" button doesn't workhttp://forge.typo3.org/issues/213392009-10-22T13:52:15ZTymoteusz Motylewskit.motylewski@gmail.com
<p>In Typo3 4.2.9 installation tool -> "Basic Configuration" there is a button "Generate random key" used to generate encryption key. There is no action after clicking this button. I tested it in both Firefox 3.5 and Google Chrome 3.0</p>
<p>(issue imported from #M12313)</p>