TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692020-06-22T17:30:32ZTYPO3 Forge
Redmine TYPO3 Core - Feature #91691 (Rejected): Add code coverage report to bamboo buildhttp://forge.typo3.org/issues/916912020-06-22T17:30:32ZTymoteusz Motylewskit.motylewski@gmail.com
<p>It would be nice to get feedback about test code coverage when pushing a commit to gerrit.<br />I've played around with PCOV (<a class="external" href="https://github.com/krakjoe/pcov">https://github.com/krakjoe/pcov</a>), and running unit tests with coverage enabled on my local machine took 46.63 seconds (23.74 seconds without coverage enabled),<br />Generating code coverage report in Clover XML format ... done [15.69 seconds]<br />Generating code coverage report in HTML format ... done [7.77 seconds]</p>
<p>Here is the config I've used:<br /><pre>
#Build/pcov.ini
pcov.enabled = 1
pcov.directory = typo3
pcov.exclude="~(vendor|Tests|Resources|Configuration|node_modules)~"
pcov.initial.files = 10000
memory_limit = 2G
</pre><br /><pre>
php -c Build/pcov.ini vendor/phpunit/phpunit/phpunit -c vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml --coverage-html 'reports/clover_html' --coverage-clover 'reports/clover.xml'
</pre></p>
<p>We can either generate html coverage report ourselves or push the report to some external tool like <a class="external" href="https://coveralls.io/">https://coveralls.io/</a>.</p>
<p>As a first step the report could be generated in the nightly build , later it could be added to bamboo patchset tests.</p>
<p>To have the most meaningful report we should combine coverage reports from our parallel unit builds and functional tests. This could be achieved using phpunit/phpcov (<a class="external" href="https://github.com/sebastianbergmann/phpcov">https://github.com/sebastianbergmann/phpcov</a>):</p>
<pre>
phpunit --coverage-php build/cov/coverage-${component_name}.cov
php vendor/bin/phpcov.php merge --clover build/logs/clover.xml build/cov
</pre> TYPO3 Core - Bug #83523 (Rejected): remove or deprecate NewContentElementControllerhttp://forge.typo3.org/issues/835232018-01-09T21:26:01ZTymoteusz Motylewskit.motylewski@gmail.com
<p>the NewContentElementController was replaced in most usages with NewContentElementWizardController<br />however there are still few places where the old route new_content_element is used</p> TYPO3 Core - Bug #81972 (Rejected): Extbase repositories are always using storage pid of the curr...http://forge.typo3.org/issues/819722017-07-26T12:52:44ZTymoteusz Motylewskit.motylewski@gmail.com
<p>When you use extbase repository from different extension, the configured storage pid should be taken from the extension this repository comes from, not from the extension using the repo.<br />Example:<br />I have an extension "my_users" with FeUserRepository and persistance.storagePid set in typoscript</p>
<p>Then I want to use this repository in a controller from other extension called "my_registrations".<br />my_registrations also have persistance.storagePid set, but to different folder then "my_users" as we want to store registrations in different place than users.</p>
<p>Now, in my controller when you call:</p>
<pre>
$this->userRepository->findAll();
</pre>
<p>the query will use storagePids configured in my_registrations instead of ones configured in my_users. And resulting in 0 records found.</p> TYPO3 Core - Task #77814 (Closed): remove sword_prev_include functionality from indexed searchhttp://forge.typo3.org/issues/778142016-09-02T23:13:24ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Indexed search have a setting<br />clearSearchBox.enableSubSearchCheckBox = 1<br />and <br />sword_prev_include</p>
<p>If this setting is set it makes search combine current keyword with previously typed one.<br />This feature doesn't make sense any more.</p> TYPO3 Core - Bug #77621 (Closed): Handle new records in selectTreehttp://forge.typo3.org/issues/776212016-08-24T17:38:53ZTymoteusz Motylewskit.motylewski@gmail.com
<p>the new svg tree has to correctly pass command (edit/new) to the ajax controller.</p> TYPO3 Core - Bug #77074 (Rejected): formengine tree appearance allowRecursiveMode has no effecthttp://forge.typo3.org/issues/770742016-07-13T09:35:18ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The allowRecursiveMode setting was implemented here <a class="external" href="https://forge.typo3.org/issues/25061">https://forge.typo3.org/issues/25061</a>,<br /> and documented <a class="external" href="https://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Select/Index.html#treeconfig">https://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Select/Index.html#treeconfig</a></p>
<p>however it does not work at the moment.<br />- setting allowRecursiveMode has no influence right now <br />- user is able to switch from normal mode to recursive mode by green arrow icon on top of the tree (the one which looks like "refresh" icon...). This button works independently from allowRecursiveMode<br />- there is another setting in JS 'tcaSelectRecursive' which controls whether recursive mode is enabled by default or not, however it's hardcoded to false.</p> TYPO3 Core - Task #75963 (Closed): Document how to create custom postprocessors in FORM http://forge.typo3.org/issues/759632016-04-28T12:31:31ZTymoteusz Motylewskit.motylewski@gmail.com
<p>FORMS have 2 built in postprocessors but can also handle custom post processors.<br />We need to document that.</p> TYPO3 Core - Bug #68087 (Rejected): SaltedPasswordService.php calls $this->writeLogMessage with t...http://forge.typo3.org/issues/680872015-07-13T20:56:31ZTymoteusz Motylewskit.motylewski@gmail.com
<p>writeLogMessage in SaltedPasswordService.php has just one param. However it is called with few additional in multiple places.</p> TYPO3 Core - Bug #67843 (Closed): Wrong queries in indexSearchRepositoryhttp://forge.typo3.org/issues/678432015-06-30T11:14:08ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Duplicate 'AND' in IndexSearchRepository.php</p>
<p>Line 562 and 627 both add a 'AND' string so the final query contains 'AND AND' and gets invalid.</p>
<p>The pi-based version of indexed search does not contain 'AND' in function execFinalQuery (SearchFormController.php line 1108)</p>
<p>There is something wrong with the implode function in statement<br />$wordSel = '(' . implode(' OR ', $this->wSelClauses) . ') AND ';<br />in line 614 in IndexSearchRepository.php<br />Implode returns double ORs ('OR OR'). Therefore the query gets invalid.</p>
<p>There are only search results for the first item in defaultFreeIndexUidList. <br />Other items return "no result" even if there are some.</p> TYPO3 Core - Story #64327 (Closed): Unit test compatibility with HHVM http://forge.typo3.org/issues/643272015-01-17T00:24:32ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Make TYPO3 Unit tests work 100% on HHVM</p> TYPO3 Core - Task #64324 (Closed): Move ConditionMatcherTest into one placehttp://forge.typo3.org/issues/643242015-01-17T00:02:55ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Move ConditionMatcherTest into one place.<br />Tests for <br />\TYPO3\CMS\Backend\Configuration\TypoScript\ConditionMatching\ConditionMatcher <br />are placed in two test classes:</p>
<p>TYPO3\CMS\Backend\Tests\Unit\Configuration\TypoScript\ConditionMatching\ConditionMatcherTest</p>
<p>and</p>
<p>TYPO3\CMS\Core\Tests\Unit\Configuration\ConditionMatcherTest</p>
<p>It would be nice to have them merged.</p> TYPO3 Core - Bug #55830 (Closed): Cleanup mess with treeView implementationshttp://forge.typo3.org/issues/558302014-02-10T10:59:42ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Currently we have ~17 classes inheriting from Backend\Tree\View\AbstractTreeView class <br />(not counting legacy classes from before namespace change).<br />We have several classes with the same names (from different namespaces) like:<br />Backend\Tree\View\PageTreeView<br />Backend\View\PageTreeView<br />or</p>
<p>Impexp\LocalPageTree<br />localPageTree from class.browse_links_php<br />localPageTree from db_new_php <br />localPageTree from move_el_php</p>
<p>It might be ok to have the same names across namespaces, but if it's combined with other issues, it makes really hard to understand this area of the core.</p>
<p>There are also 3 empty classes:<br />Rtehtmlarea\ImageFolderTree<br />rteFolderTree from class.browse_links_php<br />rtePageTree from class.browse_links_php</p>
<p>See attached diagrams of classes. One is with legacy classes, second one is without.</p>
<p>Because of this mess behaviour and look of trees differs in different parts of the backend (Link wizard, RTE link wizard, folder selector, file selector, image selector, RTE image selector,....).<br />It's also really hard to reuse it in own extension (which base class to inherit?).</p> TYPO3 Core - Bug #55763 (Closed): using object as string in ResourceStorage->getUniqueName http://forge.typo3.org/issues/557632014-02-07T14:35:09ZTymoteusz Motylewskit.motylewski@gmail.com
<p>I got this error while attaching file in RTE<br />"Object of class TYPO3\CMS\Core\Resource\Folder could not be converted to string"</p>
<p>it is caused by the call <br />if (!$this->driver->fileExistsInFolder($theDestFile, $folder)) {<br />which should look like:<br />if (!$this->driver->fileExistsInFolder($theDestFile, $folder->getIdentifier())) {</p>
<p>because $folder is an object.</p> TYPO3 Core - Task #54914 (Closed): Fix functional tests for Category Collectionhttp://forge.typo3.org/issues/549142014-01-11T19:26:21ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Right now functional tests for category collection are skipped.<br />We need to rewrite them to use functional testing framework and enable them again.</p> TYPO3 Core - Task #53467 (Rejected): Improve flush by tag performance for the file cache backendhttp://forge.typo3.org/issues/534672013-11-08T21:06:38ZTymoteusz Motylewskit.motylewski@gmail.com
<p>currently the "flush by tag" command is painfully slow when using file cache backend.<br />This can be improved e.g. by using tag index (one file for each tag, containing id's of the cache entries)</p>