TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-06-27T15:33:39ZTYPO3 Forge
Redmine TYPO3 Core - Task #101180 (Closed): Add more common tracking params to excludedParametershttp://forge.typo3.org/issues/1011802023-06-27T15:33:39ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Here are some tracking params we're not excluding in excludedParameters.</p>
<p>HubSpot Email Tracking Parameters<br />_hsenc<br />_hsmi</p>
<p>HubSpot CTA Tracking Parameters<br /><pre>
__hssc
__hstc
__hsfp
hsCtaTracking
</pre></p>
<p>HubSpot Form Tracking Parameters<br />submissionGuid</p>
<p>HubSpot Ad Tracking Parameters (Google / Facebook / LinkedIn)<br />hsa_acc<br />hsa_ad<br />hsa_cam<br />hsa_grp<br />hsa_kw<br />hsa_mt<br />hsa_net<br />hsa_src<br />hsa_tgt<br />hsa_ver<br />hsa_ol<br />hsa_la</p>
<p>Additional GA4 UTM Parameters<br />utm_id<br />utm_source_platform<br />utm_creative_format<br />utm_marketing_tactic</p>
<p>GTM<br />gtm_debug</p>
<p>Google Ads<br />dclid</p>
<p>Adobe Advertising IDs Used by Analytics<br />s_kwcid<br />ef_id</p>
<p>At last, we should include the google related ones.<br />It is cumbersome right now, that if marketing wants to use new tool (crm/newsletter...) they have to check with developers whether params are causing 404 or not. And deploy code changes to make it run.</p>
<p>some sources:<br /><a class="external" href="https://matomo.org/faq/tracking-campaigns-url-builder/">https://matomo.org/faq/tracking-campaigns-url-builder/</a><br /><a class="external" href="https://matomo.org/faq/how-to/faq_120/">https://matomo.org/faq/how-to/faq_120/</a><br /><a class="external" href="https://matomo.org/faq/reports/advanced-how-to-manually-build-campaign-tracking-urls/">https://matomo.org/faq/reports/advanced-how-to-manually-build-campaign-tracking-urls/</a></p>
<p><a class="external" href="https://support.google.com/analytics/answer/10917952">https://support.google.com/analytics/answer/10917952</a><br /><a class="external" href="https://support.google.com/analytics/answer/11242870">https://support.google.com/analytics/answer/11242870</a></p> TYPO3 Core - Task #100532 (Closed): Improve PathUtility::getCanonicalPath testshttp://forge.typo3.org/issues/1005322023-04-07T22:08:52ZTymoteusz Motylewskit.motylewski@gmail.com
<p>running mutation tests over PathUtility::getCanonicalPath shows that there are few paths not covered, lets cover them with tests</p> TYPO3 Core - Task #100266 (Closed): Improve error message in testMethodPrefixCheckerhttp://forge.typo3.org/issues/1002662023-03-23T08:51:14ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The current message "At least on method starts with "test" in" is confusing.<br />Lets make it more clear.</p> TYPO3 Core - Task #100263 (Closed): Cover filelist sorting functionality with testshttp://forge.typo3.org/issues/1002632023-03-22T21:41:33ZTymoteusz Motylewskit.motylewski@gmail.com
<p><a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187">https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187</a> brings locale aware sorting for files and folders.<br />Lets add a test to show it.</p> TYPO3 Core - Bug #97508 (Closed): Update to PHPStan 1.6.3http://forge.typo3.org/issues/975082022-04-28T14:46:44ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Task #94888 (Closed): Improve wording in indexed search deleteFromIndexAfterEditinghttp://forge.typo3.org/issues/948882021-08-14T10:44:08ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The rst file attached to the <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/69914">https://review.typo3.org/c/Packages/TYPO3.CMS/+/69914</a><br />mentioned "feature flag" when talking about extension configuration setting.</p>
<p>Lets improve the wording to avoid confusion.</p> TYPO3 Core - Task #94831 (Closed): DUMY test ticket for the codesrpirnthttp://forge.typo3.org/issues/948312021-08-12T09:27:58ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Task #92724 (Closed): Add page ID prefix to page cache and lock identifiershttp://forge.typo3.org/issues/927242020-10-27T22:59:30ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Currently page cache and page locks identifiers are md5 values.<br />It would be nice to be able to quickly spot which page are these entries related to,<br />by prefixing md5 with page id.<br />Identifier before:<br />18aa076fd39fc4b1d03d23dc4dc7c2f5</p>
<p>Identifier after:<br />108_18aa076fd39fc4b1d03d23dc4dc7c2f5</p>
<p>where 108 is a page id.</p>
<p>Thanks to that its easier to debug monitor cache related issues.</p> TYPO3 Core - Task #92574 (Closed): Remove unneeded BE user context set up from TreeController testhttp://forge.typo3.org/issues/925742020-10-16T10:47:12ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Since this commit in testing framework <br /><a class="external" href="https://github.com/TYPO3/testing-framework/commit/a797b7d069b287a6ac4af890e2480cc499383b13">https://github.com/TYPO3/testing-framework/commit/a797b7d069b287a6ac4af890e2480cc499383b13</a></p>
<p>You don't need to set BE user to context manually, when methods like setUpBackendUser or setUpBackendUserFromFixture are used.</p> TYPO3 Core - Feature #91691 (Rejected): Add code coverage report to bamboo buildhttp://forge.typo3.org/issues/916912020-06-22T17:30:32ZTymoteusz Motylewskit.motylewski@gmail.com
<p>It would be nice to get feedback about test code coverage when pushing a commit to gerrit.<br />I've played around with PCOV (<a class="external" href="https://github.com/krakjoe/pcov">https://github.com/krakjoe/pcov</a>), and running unit tests with coverage enabled on my local machine took 46.63 seconds (23.74 seconds without coverage enabled),<br />Generating code coverage report in Clover XML format ... done [15.69 seconds]<br />Generating code coverage report in HTML format ... done [7.77 seconds]</p>
<p>Here is the config I've used:<br /><pre>
#Build/pcov.ini
pcov.enabled = 1
pcov.directory = typo3
pcov.exclude="~(vendor|Tests|Resources|Configuration|node_modules)~"
pcov.initial.files = 10000
memory_limit = 2G
</pre><br /><pre>
php -c Build/pcov.ini vendor/phpunit/phpunit/phpunit -c vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml --coverage-html 'reports/clover_html' --coverage-clover 'reports/clover.xml'
</pre></p>
<p>We can either generate html coverage report ourselves or push the report to some external tool like <a class="external" href="https://coveralls.io/">https://coveralls.io/</a>.</p>
<p>As a first step the report could be generated in the nightly build , later it could be added to bamboo patchset tests.</p>
<p>To have the most meaningful report we should combine coverage reports from our parallel unit builds and functional tests. This could be achieved using phpunit/phpcov (<a class="external" href="https://github.com/sebastianbergmann/phpcov">https://github.com/sebastianbergmann/phpcov</a>):</p>
<pre>
phpunit --coverage-php build/cov/coverage-${component_name}.cov
php vendor/bin/phpcov.php merge --clover build/logs/clover.xml build/cov
</pre> TYPO3 Core - Task #91455 (Closed): [TASK] Improve descriptions of the rootline related methodshttp://forge.typo3.org/issues/914552020-05-20T23:09:16ZTymoteusz Motylewskit.motylewski@gmail.com
<p>document the difference between BackendUtility::BEgetRootLine and RootlineUtility->get()</p> TYPO3 Core - Bug #83523 (Rejected): remove or deprecate NewContentElementControllerhttp://forge.typo3.org/issues/835232018-01-09T21:26:01ZTymoteusz Motylewskit.motylewski@gmail.com
<p>the NewContentElementController was replaced in most usages with NewContentElementWizardController<br />however there are still few places where the old route new_content_element is used</p> TYPO3 Core - Bug #81972 (Rejected): Extbase repositories are always using storage pid of the curr...http://forge.typo3.org/issues/819722017-07-26T12:52:44ZTymoteusz Motylewskit.motylewski@gmail.com
<p>When you use extbase repository from different extension, the configured storage pid should be taken from the extension this repository comes from, not from the extension using the repo.<br />Example:<br />I have an extension "my_users" with FeUserRepository and persistance.storagePid set in typoscript</p>
<p>Then I want to use this repository in a controller from other extension called "my_registrations".<br />my_registrations also have persistance.storagePid set, but to different folder then "my_users" as we want to store registrations in different place than users.</p>
<p>Now, in my controller when you call:</p>
<pre>
$this->userRepository->findAll();
</pre>
<p>the query will use storagePids configured in my_registrations instead of ones configured in my_users. And resulting in 0 records found.</p> TYPO3 Core - Bug #77074 (Rejected): formengine tree appearance allowRecursiveMode has no effecthttp://forge.typo3.org/issues/770742016-07-13T09:35:18ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The allowRecursiveMode setting was implemented here <a class="external" href="https://forge.typo3.org/issues/25061">https://forge.typo3.org/issues/25061</a>,<br /> and documented <a class="external" href="https://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Select/Index.html#treeconfig">https://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Select/Index.html#treeconfig</a></p>
<p>however it does not work at the moment.<br />- setting allowRecursiveMode has no influence right now <br />- user is able to switch from normal mode to recursive mode by green arrow icon on top of the tree (the one which looks like "refresh" icon...). This button works independently from allowRecursiveMode<br />- there is another setting in JS 'tcaSelectRecursive' which controls whether recursive mode is enabled by default or not, however it's hardcoded to false.</p> TYPO3 Core - Bug #68087 (Rejected): SaltedPasswordService.php calls $this->writeLogMessage with t...http://forge.typo3.org/issues/680872015-07-13T20:56:31ZTymoteusz Motylewskit.motylewski@gmail.com
<p>writeLogMessage in SaltedPasswordService.php has just one param. However it is called with few additional in multiple places.</p>