TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-07-31T11:23:09ZTYPO3 Forge
Redmine TYPO3 Core - Task #101503 (New): Cover Ckeditor with acceptance testshttp://forge.typo3.org/issues/1015032023-07-31T11:23:09ZTymoteusz Motylewskit.motylewski@gmail.com
<p>lets cover recent changes/fixes to ckeditor in v12 with acceptance tests, to make sure its working as expected.</p>
<p>Example flow:<br />- input content to RTE<br />- switch to HTML mode<br />- switch back<br />- save<br />- check if content is still ok (nothing is lost on save)</p>
<p>Content could include:<br />- styles (classes from selector, including multiple classes case),<br />- links marked as wrong by linkvalidator<br />- classes set by element/link browser<br />...</p>
<p>It would be good to go through recently merged issues related to RTE and extract test cases for them.<br />link v</p> TYPO3 Core - Bug #92856 (New): "Admin Panel" naming confusinghttp://forge.typo3.org/issues/928562020-11-16T16:05:40ZTymoteusz Motylewskit.motylewski@gmail.com
<p>New TYPO3 users are confusing "Admin Panel" with TYPO3 Backend, as in many other systems (WP, Drupal, Magento,...) the "Admin Panel" (or Administration Panel) means the place we call "Backend".<br />More appropriate name would be "developer toolbar" or "debug bar" or sth similar.</p>
<p>Btw, the term "Backend" is also confusing, especialy with IT/devops, where it's used in the meaning of "upstream server".</p> TYPO3 Core - Bug #91143 (New): Datahandler should check return value of checkStoredRecordhttp://forge.typo3.org/issues/911432020-04-20T13:39:21ZTymoteusz Motylewskit.motylewski@gmail.com
<p>In datahandler isertDB the return value of checkStoredRecord is not being checked (if it's null or array) which then results in calling</p>
<pre><code>$this->getRecordHistoryStore()->addRecord($table, $id, $newRow);</code></pre>
<p>with a wrong type (null) for $newRow.</p>
<p>This causes error like:</p>
<p>Argument 3 passed to TYPO3\CMS\Core\DataHandling\History\RecordHistoryStore::addRecord() must be of the type array, null given,</p> TYPO3 Core - Bug #90742 (New): Interface is not blocked in Extension Manager when doing long oper...http://forge.typo3.org/issues/907422020-03-12T11:06:26ZTymoteusz Motylewskit.motylewski@gmail.com
<p>I've noticed that many new users (especially when trying TYPO3 out for the first time) they have issues and sometimes mess up the system when installing introduction package.</p>
<p>The problem is that the orange progress bar doesn't block the ui, so user<br />1) doesn't recognize that there is something going on<br />2) can click multiple times to install the same extension or to install another one when the first is still in progress.</p>
<p>The same issue applies to the extension search box, also it's hard to notice that something is loading.</p> TYPO3 Core - Bug #90635 (New): Error is thrown when using EXT:extension_name for which is install...http://forge.typo3.org/issues/906352020-03-04T11:14:06ZTymoteusz Motylewskit.motylewski@gmail.com
<a name="Problem"></a>
<h2 >Problem<a href="#Problem" class="wiki-anchor">¶</a></h2>
<a name="Given"></a>
<h3 >Given<a href="#Given" class="wiki-anchor">¶</a></h3>
<p>- an extension e.g. yoast_seo copied to typo3conf/ext/yoast_typo3 (folder different than extension key)<br />- this extension has TYPOScript which references some file using EXT:yoast_seo syntax</p>
<a name="Result"></a>
<h3 >Result:<a href="#Result" class="wiki-anchor">¶</a></h3>
<p>- Backend is broken with "Call to a member function getPackagePath() on null" in ExtensionManagerUtility</p>
<a name="Expected"></a>
<h3 >Expected:<a href="#Expected" class="wiki-anchor">¶</a></h3>
<p>- either the file inclusion is ignored, or the path is correctly resolved (as TYPO3 can correctly translate yoast_seo to yoast_typo3 with <pre>$this->getPackageKeyFromComposerName($packageKey);</pre><br />- breaking whole system is not expected</p>
<a name="Technical-details"></a>
<h2 >Technical details:<a href="#Technical-details" class="wiki-anchor">¶</a></h2>
<p>in this setup<br />- PackageManager->isPackageActive('yoast_seo') return TRUE<br />- PackageManager->getPackageKeyFromComposerName('yoast_seo') returns 'yoast_typo3'<br />- PackageManager->isPackageRegistered('yoast_seo') returns TRUE<br />- PackageManager->isPackageAvailable('yoast_seo')returns TRUE<br />- ExtensionManagementUtility::isLoaded('yoast_seo') returns TRUE<br />- ExtensionManagementUtility::extPath('yoast_seo') throws "Call to a member function getPackagePath() on null" <br />- because PackageManager->getPackage('yoast_seo') returns null</p>
<p>Seems like the API is inconsistent here.</p>
<a name="Possible-solution"></a>
<h2 >Possible solution:<a href="#Possible-solution" class="wiki-anchor">¶</a></h2>
<p>change <br /><pre>
public function getPackage($packageKey)
{
if (!$this->isPackageRegistered($packageKey) && !$this->isPackageAvailable($packageKey)) {
throw new Exception\UnknownPackageException('Package "' . $packageKey . '" is not available. Please check if the package exists and that the package key is correct (package keys are case sensitive).', 1166546734);
}
return $this->packages[$packageKey];
}
</pre><br />to:<br /><pre>
public function getPackage($packageKey)
{
if (!$this->isPackageRegistered($packageKey) && !$this->isPackageAvailable($packageKey)) {
throw new Exception\UnknownPackageException('Package "' . $packageKey . '" is not available. Please check if the package exists and that the package key is correct (package keys are case sensitive).', 1166546734);
}
return $this->packages[$this->getPackageKeyFromComposerName($packageKey)];
}
</pre></p> TYPO3 Core - Bug #90051 (New): User get stuck when translation wizard failshttp://forge.typo3.org/issues/900512020-01-03T13:33:19ZTymoteusz Motylewskit.motylewski@gmail.com
<p>If an translation wizard ajax fails (e.g. 500 timeout error), user get stuck with a spinner, and need to refresh the page to be able to work again.</p>
<p>In such cases an error message should be shown in the modal, with a button to close the modal.</p> TYPO3 Core - Epic #90050 (New): Translation wizard improvements and issueshttp://forge.typo3.org/issues/900502020-01-03T13:25:44ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Epic grouping translation wizard issues</p> TYPO3 Core - Bug #89874 (New): Can't updata database structure on MariaDB 10.0 and TYPO3 9.5 (can...http://forge.typo3.org/issues/898742019-12-06T10:51:20ZTymoteusz Motylewskit.motylewski@gmail.com
<p>I just have an issue when upgrading TYPO3 from 8.7 to 9.5.11 on Mariadb v10.0. It fails on trying to rename db index on sys_file_metadata table:<br /><pre>
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'INDEX pid TO `parent`' at line 1
</pre></p>
<p>The sql query is<br /><pre>
ALTER TABLE sys_file_metadata RENAME INDEX pid TO `parent`
</pre></p>
<p>It seems that mariadb 10 doesn't support index rename<br /><a class="external" href="https://stackoverflow.com/questions/19797105/does-mariadb-support-renaming-an-index">https://stackoverflow.com/questions/19797105/does-mariadb-support-renaming-an-index</a> (edited) <br />So basically we either have to fix the logic of index rename or bump db server requirements.<br />Or maybe its' possible to figure out some detection of the mysql/mariadb type?</p>
<p><a class="external" href="https://github.com/doctrine/migrations/issues/196">https://github.com/doctrine/migrations/issues/196</a></p>
<p>This issue might be related to <br /><a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/62063">https://review.typo3.org/c/Packages/TYPO3.CMS/+/62063</a></p> TYPO3 Core - Bug #89520 (New): Missing tooltips in info modulehttp://forge.typo3.org/issues/895202019-10-26T12:31:12ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The "pagetree overview" as well as "localization overview" is missing some tooltips.</p>
<p>"pagetree overview" (in all 3 modes, basic settings, record overview, cache)<br />- tooltips are missing for edit icons in table header<br />- tooltips are missing for view and edit icons in rows</p>
<p>"localization overview" <br />- the page icon doesn't show a tooltip with page id<br />- in translated page column edit icon says "edit language overlay record" (and it points to editing translated page properties)<br />- clicking on the page title opens a page module, but the labels says "edit page" or "edit page translation", a better would be "Edit page content" <br />- icons by translated pages should display tooltip with page id and allow right click</p> TYPO3 Core - Epic #86307 (New): Extbase allows to fetch deleted/hidden records (respects ignoreEn...http://forge.typo3.org/issues/863072018-09-19T00:33:31ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Bug #82121 (New): Deleting inline 1:1 relation throws error http://forge.typo3.org/issues/821212017-08-17T13:12:27ZTymoteusz Motylewskit.motylewski@gmail.com
<p>1) Given a 1:1 inline relation like <a class="external" href="https://github.com/TYPO3/styleguide/pull/102">https://github.com/TYPO3/styleguide/pull/102</a><br /><pre>
'inline_1' => [
'exclude' => 1,
'label' => 'inline_1',
'config' => [
'type' => 'inline',
'foreign_table' => 'tx_styleguide_inline_1_1_child',
'behaviour' => [
'localizeChildrenAtParentLocalization' => true,
],
'appearance' => [
'showSynchronizationLink' => true,
'showAllLocalizationLink' => true,
'showPossibleLocalizationRecords' => true,
],
'maxitems' => 1,
],
],
</pre></p>
<p>2) add a child relation<br />3) save the record<br />4) delete the relation<br />5) save the parent record<br />6) an error is thrown:</p>
<pre>
Uncaught TYPO3 Exception
#1437656081: Record with uid 2 from table tx_styleguide_inline_1_1_child not found (More information)
TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException thrown in file
typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractDatabaseRecordProvider.php in line 51.
21 TYPO3\CMS\Backend\Form\FormDataProvider\AbstractDatabaseRecordProvider::getRecordFromDatabase("tx_styleguide_inline_1_1_child", 2)
typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseEditRow.php:
00036: }
00037:
00038: $databaseRow = $this->getRecordFromDatabase($result['tableName'], $result['vanillaUid']);
00039: if (!array_key_exists('pid', $databaseRow)) {
00040: throw new \UnexpectedValueException(
</pre> TYPO3 Core - Bug #81996 (New): Read ony select field 'renderType' => 'selectSingle' renders all a...http://forge.typo3.org/issues/819962017-07-28T13:33:03ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Read only select field with 'renderType' => 'selectSingle'<br />renders all available items in the select box.</p>
<p>Instead, only currently selected item should be rendered.<br />This influences performance when there are many available elements.</p> TYPO3 Core - Bug #78643 (New): workspace operations are setting t3_origuid but shouldn'thttp://forge.typo3.org/issues/786432016-11-10T15:10:41ZTymoteusz Motylewskit.motylewski@gmail.com
<p>"non-copy" operations in workspaces are setting t3_origuid field but should not.<br />E.g. if you delete a record in workspaces and publish the change. The t3_origuid field will be set to the record id, but should not be changed.</p> TYPO3 Core - Story #78642 (New): Improve t3_origuid handlinghttp://forge.typo3.org/issues/786422016-11-10T15:03:10ZTymoteusz Motylewskit.motylewski@gmail.com
<p>1. The purpose and usage of the t3_origuid should be claryfied.<br />2. The field needs to be covered with tests in live and workspaces.</p> TYPO3 Core - Task #64324 (Closed): Move ConditionMatcherTest into one placehttp://forge.typo3.org/issues/643242015-01-17T00:02:55ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Move ConditionMatcherTest into one place.<br />Tests for <br />\TYPO3\CMS\Backend\Configuration\TypoScript\ConditionMatching\ConditionMatcher <br />are placed in two test classes:</p>
<p>TYPO3\CMS\Backend\Tests\Unit\Configuration\TypoScript\ConditionMatching\ConditionMatcherTest</p>
<p>and</p>
<p>TYPO3\CMS\Core\Tests\Unit\Configuration\ConditionMatcherTest</p>
<p>It would be nice to have them merged.</p>