TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-07-31T11:23:09ZTYPO3 Forge
Redmine TYPO3 Core - Task #101503 (New): Cover Ckeditor with acceptance testshttp://forge.typo3.org/issues/1015032023-07-31T11:23:09ZTymoteusz Motylewskit.motylewski@gmail.com
<p>lets cover recent changes/fixes to ckeditor in v12 with acceptance tests, to make sure its working as expected.</p>
<p>Example flow:<br />- input content to RTE<br />- switch to HTML mode<br />- switch back<br />- save<br />- check if content is still ok (nothing is lost on save)</p>
<p>Content could include:<br />- styles (classes from selector, including multiple classes case),<br />- links marked as wrong by linkvalidator<br />- classes set by element/link browser<br />...</p>
<p>It would be good to go through recently merged issues related to RTE and extract test cases for them.<br />link v</p> TYPO3 Core - Task #101180 (Closed): Add more common tracking params to excludedParametershttp://forge.typo3.org/issues/1011802023-06-27T15:33:39ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Here are some tracking params we're not excluding in excludedParameters.</p>
<p>HubSpot Email Tracking Parameters<br />_hsenc<br />_hsmi</p>
<p>HubSpot CTA Tracking Parameters<br /><pre>
__hssc
__hstc
__hsfp
hsCtaTracking
</pre></p>
<p>HubSpot Form Tracking Parameters<br />submissionGuid</p>
<p>HubSpot Ad Tracking Parameters (Google / Facebook / LinkedIn)<br />hsa_acc<br />hsa_ad<br />hsa_cam<br />hsa_grp<br />hsa_kw<br />hsa_mt<br />hsa_net<br />hsa_src<br />hsa_tgt<br />hsa_ver<br />hsa_ol<br />hsa_la</p>
<p>Additional GA4 UTM Parameters<br />utm_id<br />utm_source_platform<br />utm_creative_format<br />utm_marketing_tactic</p>
<p>GTM<br />gtm_debug</p>
<p>Google Ads<br />dclid</p>
<p>Adobe Advertising IDs Used by Analytics<br />s_kwcid<br />ef_id</p>
<p>At last, we should include the google related ones.<br />It is cumbersome right now, that if marketing wants to use new tool (crm/newsletter...) they have to check with developers whether params are causing 404 or not. And deploy code changes to make it run.</p>
<p>some sources:<br /><a class="external" href="https://matomo.org/faq/tracking-campaigns-url-builder/">https://matomo.org/faq/tracking-campaigns-url-builder/</a><br /><a class="external" href="https://matomo.org/faq/how-to/faq_120/">https://matomo.org/faq/how-to/faq_120/</a><br /><a class="external" href="https://matomo.org/faq/reports/advanced-how-to-manually-build-campaign-tracking-urls/">https://matomo.org/faq/reports/advanced-how-to-manually-build-campaign-tracking-urls/</a></p>
<p><a class="external" href="https://support.google.com/analytics/answer/10917952">https://support.google.com/analytics/answer/10917952</a><br /><a class="external" href="https://support.google.com/analytics/answer/11242870">https://support.google.com/analytics/answer/11242870</a></p> TYPO3 Core - Task #100532 (Closed): Improve PathUtility::getCanonicalPath testshttp://forge.typo3.org/issues/1005322023-04-07T22:08:52ZTymoteusz Motylewskit.motylewski@gmail.com
<p>running mutation tests over PathUtility::getCanonicalPath shows that there are few paths not covered, lets cover them with tests</p> TYPO3 Core - Task #100266 (Closed): Improve error message in testMethodPrefixCheckerhttp://forge.typo3.org/issues/1002662023-03-23T08:51:14ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The current message "At least on method starts with "test" in" is confusing.<br />Lets make it more clear.</p> TYPO3 Core - Task #100263 (Closed): Cover filelist sorting functionality with testshttp://forge.typo3.org/issues/1002632023-03-22T21:41:33ZTymoteusz Motylewskit.motylewski@gmail.com
<p><a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187">https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187</a> brings locale aware sorting for files and folders.<br />Lets add a test to show it.</p> TYPO3 Core - Bug #100121 (Resolved): Warning in TreeFormLineStreamBuilder when including TS from ...http://forge.typo3.org/issues/1001212023-03-08T12:03:39ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Go to pageproperties, insert TSconfig with wrong path (correct extension, but typo in the folder name).</p>
<pre>
@import 'EXT:sitepackage/Configuration/TSConfig/Mod/NonExistingFolder/*.tsconfig'
</pre>
<p>go to "PageTSConfig" module -> "Included PageTsConfig" <br />An error will be thrown:<br /><pre>
Core: Error handler (BE): PHP Warning: scandir(/var/www/html/typo3conf/ext/sitepackage/Configuration/TSConfig/Mod/NonExistingFolder/): Failed to open directory: No such file or directory in /var/www/html/typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php line 315
</pre></p>
<p>Expected behaviour:<br />Warning is not thrown.<br />Nice to have -> some notice is shown in PageTSConfig module, or logged into TYPO3 log.</p>
<p>Most probably the same problem affects TypoScript.</p> TYPO3 Core - Bug #100115 (Resolved): Copy operator < replaces previous reference operator result ...http://forge.typo3.org/issues/1001152023-03-07T17:22:35ZTymoteusz Motylewskit.motylewski@gmail.com
<p>This is a change of behavior in TypoScript v12.</p>
<p>Given TS:</p>
<pre>
lib.prototype {
fields {
content {
fields {
header = TEXT
header {
field = header
}
}
}
}
}
lib.additionalField {
fields {
content {
fields {
enlargeImageOnClick = true
}
}
}
}
testElement =< lib.prototype
testElement < lib.additionalField
testElement {
fields {
content {
fields {
subheader = TEXT
subheader {
field = subheader
}
}
}
}
}
tt_content.testElement =< lib.prototype
tt_content.testElement < lib.additionalField
tt_content.testElement {
fields {
content {
fields {
subheader = TEXT
subheader {
field = subheader
}
}
}
}
}
</pre>
<p>In v11 it looked like:<br /><img src="http://forge.typo3.org/attachments/download/37452/clipboard-202303071819-mhee9.png" alt="" loading="lazy" /></p>
<p>In v12 it is:<br /><img src="http://forge.typo3.org/attachments/download/37453/clipboard-202303071820-nkssh.png" alt="" loading="lazy" /></p>
<p>see missing "=< lib.prototype" in v12.<br />What is also interesting. Is that neither in v11 nor in v12 there is no "=< lib.prototype" if the testElement is on the root level of TS.</p> TYPO3 Core - Bug #83523 (Rejected): remove or deprecate NewContentElementControllerhttp://forge.typo3.org/issues/835232018-01-09T21:26:01ZTymoteusz Motylewskit.motylewski@gmail.com
<p>the NewContentElementController was replaced in most usages with NewContentElementWizardController<br />however there are still few places where the old route new_content_element is used</p> TYPO3 Core - Bug #79710 (Closed): Reintroduce context menu on page title in the page treehttp://forge.typo3.org/issues/797102017-02-09T15:13:48ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Since context menu refactoring <a class="external" href="https://review.typo3.org/#/c/50124/">https://review.typo3.org/#/c/50124/</a><br />the context was not showing when right clicking on the page title in<br />the page tree.</p> TYPO3 Core - Task #77814 (Closed): remove sword_prev_include functionality from indexed searchhttp://forge.typo3.org/issues/778142016-09-02T23:13:24ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Indexed search have a setting<br />clearSearchBox.enableSubSearchCheckBox = 1<br />and <br />sword_prev_include</p>
<p>If this setting is set it makes search combine current keyword with previously typed one.<br />This feature doesn't make sense any more.</p> TYPO3 Core - Bug #77809 (Closed): Wrong path in compatibility7 indexed searchhttp://forge.typo3.org/issues/778092016-09-02T22:33:08ZTymoteusz Motylewskit.motylewski@gmail.com
<p>typo3/sysext/compatibility7/ext_tables.php<br />contains<br /><pre>
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('compatibility7') . 'Resources/PHP/class.tx_indexed_search_pi_wizicon.php';
</pre><br />but should</p>
<p>\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('compatibility7') . 'PHP/class.tx_indexed_search_pi_wizicon.php';</p> TYPO3 Core - Bug #77796 (Closed): Info module -> Page TS config fro page 0 throws error on clicki...http://forge.typo3.org/issues/777962016-09-02T19:49:55ZTymoteusz Motylewskit.motylewski@gmail.com
<p>If you go to Info module<br />then select Page TSconfig<br />select page 0 (root page) from the page tree<br />click on any page name in the table<br />you'll get an error about misssing CRSF token</p> TYPO3 Core - Bug #67843 (Closed): Wrong queries in indexSearchRepositoryhttp://forge.typo3.org/issues/678432015-06-30T11:14:08ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Duplicate 'AND' in IndexSearchRepository.php</p>
<p>Line 562 and 627 both add a 'AND' string so the final query contains 'AND AND' and gets invalid.</p>
<p>The pi-based version of indexed search does not contain 'AND' in function execFinalQuery (SearchFormController.php line 1108)</p>
<p>There is something wrong with the implode function in statement<br />$wordSel = '(' . implode(' OR ', $this->wSelClauses) . ') AND ';<br />in line 614 in IndexSearchRepository.php<br />Implode returns double ORs ('OR OR'). Therefore the query gets invalid.</p>
<p>There are only search results for the first item in defaultFreeIndexUidList. <br />Other items return "no result" even if there are some.</p> TYPO3 Core - Task #64324 (Closed): Move ConditionMatcherTest into one placehttp://forge.typo3.org/issues/643242015-01-17T00:02:55ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Move ConditionMatcherTest into one place.<br />Tests for <br />\TYPO3\CMS\Backend\Configuration\TypoScript\ConditionMatching\ConditionMatcher <br />are placed in two test classes:</p>
<p>TYPO3\CMS\Backend\Tests\Unit\Configuration\TypoScript\ConditionMatching\ConditionMatcherTest</p>
<p>and</p>
<p>TYPO3\CMS\Core\Tests\Unit\Configuration\ConditionMatcherTest</p>
<p>It would be nice to have them merged.</p> TYPO3 Core - Bug #55830 (Closed): Cleanup mess with treeView implementationshttp://forge.typo3.org/issues/558302014-02-10T10:59:42ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Currently we have ~17 classes inheriting from Backend\Tree\View\AbstractTreeView class <br />(not counting legacy classes from before namespace change).<br />We have several classes with the same names (from different namespaces) like:<br />Backend\Tree\View\PageTreeView<br />Backend\View\PageTreeView<br />or</p>
<p>Impexp\LocalPageTree<br />localPageTree from class.browse_links_php<br />localPageTree from db_new_php <br />localPageTree from move_el_php</p>
<p>It might be ok to have the same names across namespaces, but if it's combined with other issues, it makes really hard to understand this area of the core.</p>
<p>There are also 3 empty classes:<br />Rtehtmlarea\ImageFolderTree<br />rteFolderTree from class.browse_links_php<br />rtePageTree from class.browse_links_php</p>
<p>See attached diagrams of classes. One is with legacy classes, second one is without.</p>
<p>Because of this mess behaviour and look of trees differs in different parts of the backend (Link wizard, RTE link wizard, folder selector, file selector, image selector, RTE image selector,....).<br />It's also really hard to reuse it in own extension (which base class to inherit?).</p>