TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692021-07-02T08:01:30ZTYPO3 Forge
Redmine TYPO3 Core - Task #94467 (Closed): Acceptance tests for indexed search backend modulehttp://forge.typo3.org/issues/944672021-07-02T08:01:30ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Indexed search should get some acceptance test coverage.<br />Lets start from backend module.</p>
<p>First scenario:</p>
<p>open Indexing Module module<br />go through the pages (dropdown)<br />see if expected text exists</p> TYPO3 Core - Bug #92856 (New): "Admin Panel" naming confusinghttp://forge.typo3.org/issues/928562020-11-16T16:05:40ZTymoteusz Motylewskit.motylewski@gmail.com
<p>New TYPO3 users are confusing "Admin Panel" with TYPO3 Backend, as in many other systems (WP, Drupal, Magento,...) the "Admin Panel" (or Administration Panel) means the place we call "Backend".<br />More appropriate name would be "developer toolbar" or "debug bar" or sth similar.</p>
<p>Btw, the term "Backend" is also confusing, especialy with IT/devops, where it's used in the meaning of "upstream server".</p> TYPO3 Core - Task #92724 (Closed): Add page ID prefix to page cache and lock identifiershttp://forge.typo3.org/issues/927242020-10-27T22:59:30ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Currently page cache and page locks identifiers are md5 values.<br />It would be nice to be able to quickly spot which page are these entries related to,<br />by prefixing md5 with page id.<br />Identifier before:<br />18aa076fd39fc4b1d03d23dc4dc7c2f5</p>
<p>Identifier after:<br />108_18aa076fd39fc4b1d03d23dc4dc7c2f5</p>
<p>where 108 is a page id.</p>
<p>Thanks to that its easier to debug monitor cache related issues.</p> TYPO3 Core - Feature #91691 (Rejected): Add code coverage report to bamboo buildhttp://forge.typo3.org/issues/916912020-06-22T17:30:32ZTymoteusz Motylewskit.motylewski@gmail.com
<p>It would be nice to get feedback about test code coverage when pushing a commit to gerrit.<br />I've played around with PCOV (<a class="external" href="https://github.com/krakjoe/pcov">https://github.com/krakjoe/pcov</a>), and running unit tests with coverage enabled on my local machine took 46.63 seconds (23.74 seconds without coverage enabled),<br />Generating code coverage report in Clover XML format ... done [15.69 seconds]<br />Generating code coverage report in HTML format ... done [7.77 seconds]</p>
<p>Here is the config I've used:<br /><pre>
#Build/pcov.ini
pcov.enabled = 1
pcov.directory = typo3
pcov.exclude="~(vendor|Tests|Resources|Configuration|node_modules)~"
pcov.initial.files = 10000
memory_limit = 2G
</pre><br /><pre>
php -c Build/pcov.ini vendor/phpunit/phpunit/phpunit -c vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml --coverage-html 'reports/clover_html' --coverage-clover 'reports/clover.xml'
</pre></p>
<p>We can either generate html coverage report ourselves or push the report to some external tool like <a class="external" href="https://coveralls.io/">https://coveralls.io/</a>.</p>
<p>As a first step the report could be generated in the nightly build , later it could be added to bamboo patchset tests.</p>
<p>To have the most meaningful report we should combine coverage reports from our parallel unit builds and functional tests. This could be achieved using phpunit/phpcov (<a class="external" href="https://github.com/sebastianbergmann/phpcov">https://github.com/sebastianbergmann/phpcov</a>):</p>
<pre>
phpunit --coverage-php build/cov/coverage-${component_name}.cov
php vendor/bin/phpcov.php merge --clover build/logs/clover.xml build/cov
</pre> TYPO3 Core - Bug #91017 (Closed): 9.5 changelog show deprecated TS conditions configuration as an...http://forge.typo3.org/issues/910172020-04-14T07:41:21ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Bug #86625 (Closed): "No pseudo-site found in root line of page" when executing upgr...http://forge.typo3.org/issues/866252018-10-11T09:37:43ZTymoteusz Motylewskit.motylewski@gmail.com
<p>When executing upgrade wizard in the install tool, I'm getting<br />"No pseudo-site found in root line of page 161737" error.</p>
<p>Where page "161737" is a translation of some page (sys_language_uid =1)</p>
<p>Is that correct that the wizzard is trying to find site per translated page id ?<br />I've dig into the code and what is happening is that<br />PopulatePageSlugs.php->populateSlugs calls<br />$slugHelper->isUniqueInSite method</p>
<p>then in line ~269 of the SlugHelper there is a foreach loop with <pre> matchByPageId((int)$record['uid']); </pre><br />and this is a translated uid<br />Then matchByPageId calls pseudoSiteFinder->getSiteByPageId($pageId, $rootLine); (edited)<br />and get SiteByPageID throws an exception, as there is no site configuration for translated page.</p>
<p>Seems we're missing some check for translated page?</p>
<p>What is also worth noticing is that \TYPO3\CMS\Core\DataHandling\SlugHelper::resolveParentPageRecord is NOT called.</p> TYPO3 Core - Bug #86617 (Closed): Trying to get property 'workspace' of non-object when running ...http://forge.typo3.org/issues/866172018-10-10T12:47:27ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Plenty of notices are thrown when running slug upgrade wizard.</p>
<p>PHP Notice: Trying to get property 'workspace' of non-object in /var/www/html/typo3/sysext/backend/Classes/Utility/BackendUtility.php on line 4037<br />PHP Notice: Trying to get property 'workspace' of non-object in /var/www/html/typo3/sysext/backend/Classes/Utility/BackendUtility.php on line 4290<br />PHP Notice: Trying to get property 'workspace' of non-object in /var/www/html/typo3/sysext/backend/Classes/Utility/BackendUtility.php on line 4037</p>
<p>Example stack trace:<br /><pre>
BackendUtility.php:4290, TYPO3\CMS\Backend\Utility\BackendUtility::getMovePlaceholder()
BackendUtility.php:494, TYPO3\CMS\Backend\Utility\BackendUtility::getPageForRootline()
BackendUtility.php:387, TYPO3\CMS\Backend\Utility\BackendUtility::BEgetRootLine()
SlugHelper.php:545, TYPO3\CMS\Core\DataHandling\SlugHelper->resolveParentPageRecord()
SlugHelper.php:169, TYPO3\CMS\Core\DataHandling\SlugHelper->generate()
PopulatePageSlugs.php:167, TYPO3\CMS\Install\Updates\PopulatePageSlugs->populateSlugs()
PopulatePageSlugs.php:99, TYPO3\CMS\Install\Updates\PopulatePageSlugs->executeUpdate()
UpgradeWizardsService.php:397, TYPO3\CMS\Install\Service\UpgradeWizardsService->executeWizard()
UpgradeController.php:967, TYPO3\CMS\Install\Controller\UpgradeController->upgradeWizardsExecuteAction()
RequestHandler.php:205, TYPO3\CMS\Install\Http\RequestHandler->handle()
Application.php:65, TYPO3\CMS\Install\Http\Application->handle()
AbstractApplication.php:110, TYPO3\CMS\Install\Http\Application->run()
install.php:104, {closure:/var/www/html/typo3/install.php:101-105}()
install.php:105, {main}()
</pre></p> TYPO3 Core - Task #82012 (Closed): Add Functional tests for rendering of translated hidden recordshttp://forge.typo3.org/issues/820122017-07-31T16:37:07ZTymoteusz Motylewskit.motylewski@gmail.com
<p>We need to cover 2 more cases in LocalizedContentRenderingTest:<br />1) when record is hidden in default language but his translation is not hidden<br />2) when visible default language record has hidden translation</p> TYPO3 Core - Task #80097 (Closed): [TASK] Improve migration steps of BE viewhelper attributes dep...http://forge.typo3.org/issues/800972017-03-02T14:16:31ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Task #79789 (Closed): Add acceptance tests for Translation Wizardhttp://forge.typo3.org/issues/797892017-02-13T20:28:38ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The page module's translation wizard should be covered with acceptance tests.</p> TYPO3 Core - Task #77234 (Closed): add collapse all and expand all icons to the icon registryhttp://forge.typo3.org/issues/772342016-07-24T17:16:02ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Icons introduced in <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Replace category tree toolbar icons with SVG (Closed)" href="http://forge.typo3.org/issues/77220">#77220</a> should be also added to the icon registry</p> TYPO3 Core - Bug #62001 (Closed): [Regression] Can not add image to FAL field in Flexformhttp://forge.typo3.org/issues/620012014-10-02T10:08:29ZTymoteusz Motylewskit.motylewski@gmail.com
<p>commit cb6b7f519b54cec0d09f46966e5a8461f13e45e5 <br />[TASK] Replace Prototype in inline record JS<br />Introduced a regression that FAL fields are not working in flexform any more.</p>
<p>How to reproduce:<br />1. download and install extension:<br /><a class="external" href="https://forge.typo3.org/attachments/download/26263/mediacenter.zip">https://forge.typo3.org/attachments/download/26263/mediacenter.zip</a><br />2. put the "mediacenter" plugin on the page<br />3. try to attach some images to the FAL field.</p>
<p>Result:<br />Images will not show up under the "add file" button.</p> TYPO3 Core - Bug #40146 (Closed): [rsaauth] Call to undefined method CommandUtility::getCommand()http://forge.typo3.org/issues/401462012-08-24T22:24:16ZTymoteusz Motylewskit.motylewski@gmail.com
<p>While trying to log in into backend I'm getting:</p>
<p>Fatal error: Call to undefined method TYPO3\CMS\Core\Utility\CommandUtility::getCommand() in C:\xampp\htdocs\community46\typo3\sysext\rsaauth\Classes\Backend\CommandLineBackend.php on line 60</p>
<p>this line right now is:<br />$this->opensslPath = \TYPO3\CMS\Core\Utility\CommandUtility::getCommand('openssl');</p>
<p>before was:<br />$this->opensslPath = t3lib_exec::getCommand('openssl');</p>
<p>Class t3lib_exec is now mapped to \TYPO3\CMS\Core\Extension\ExtensionManager::extPath('core') . 'Classes/Utility/CommandUtility.php';</p>
<p>but the content of CommandUtility is completely different then the original t3lib_exec class</p> TYPO3 Core - Bug #36894 (Closed): [felogin] Wrong action url when nested array is passedhttp://forge.typo3.org/issues/368942012-05-06T20:36:05ZTymoteusz Motylewskit.motylewski@gmail.com
<p>If you have login form on page with url like this:<br />index.php?id=10&L=3&tx_someext[@widget_0][currentPage]=3</p>
<p>Action url of login form will point to:<br />index.php?id=10&L=3&tx_someext[@widget_0]=Array</p>
<p>The problem is in method tx_felogin_pi1->getPreserveGetVars() (called from getPageLink() ).<br />This method assumes that no nested arrays are passed as parameter.<br /><pre>
$params .= '&' . $key . '[' . $key1 . ']=' . $val1;
</pre></p> TYPO3 Core - Bug #21339 (Closed): "Generate random key" button doesn't workhttp://forge.typo3.org/issues/213392009-10-22T13:52:15ZTymoteusz Motylewskit.motylewski@gmail.com
<p>In Typo3 4.2.9 installation tool -> "Basic Configuration" there is a button "Generate random key" used to generate encryption key. There is no action after clicking this button. I tested it in both Firefox 3.5 and Google Chrome 3.0</p>
<p>(issue imported from #M12313)</p>