TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-07-31T11:23:09ZTYPO3 Forge
Redmine TYPO3 Core - Task #101503 (New): Cover Ckeditor with acceptance testshttp://forge.typo3.org/issues/1015032023-07-31T11:23:09ZTymoteusz Motylewskit.motylewski@gmail.com
<p>lets cover recent changes/fixes to ckeditor in v12 with acceptance tests, to make sure its working as expected.</p>
<p>Example flow:<br />- input content to RTE<br />- switch to HTML mode<br />- switch back<br />- save<br />- check if content is still ok (nothing is lost on save)</p>
<p>Content could include:<br />- styles (classes from selector, including multiple classes case),<br />- links marked as wrong by linkvalidator<br />- classes set by element/link browser<br />...</p>
<p>It would be good to go through recently merged issues related to RTE and extract test cases for them.<br />link v</p> TYPO3 Core - Task #101180 (Closed): Add more common tracking params to excludedParametershttp://forge.typo3.org/issues/1011802023-06-27T15:33:39ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Here are some tracking params we're not excluding in excludedParameters.</p>
<p>HubSpot Email Tracking Parameters<br />_hsenc<br />_hsmi</p>
<p>HubSpot CTA Tracking Parameters<br /><pre>
__hssc
__hstc
__hsfp
hsCtaTracking
</pre></p>
<p>HubSpot Form Tracking Parameters<br />submissionGuid</p>
<p>HubSpot Ad Tracking Parameters (Google / Facebook / LinkedIn)<br />hsa_acc<br />hsa_ad<br />hsa_cam<br />hsa_grp<br />hsa_kw<br />hsa_mt<br />hsa_net<br />hsa_src<br />hsa_tgt<br />hsa_ver<br />hsa_ol<br />hsa_la</p>
<p>Additional GA4 UTM Parameters<br />utm_id<br />utm_source_platform<br />utm_creative_format<br />utm_marketing_tactic</p>
<p>GTM<br />gtm_debug</p>
<p>Google Ads<br />dclid</p>
<p>Adobe Advertising IDs Used by Analytics<br />s_kwcid<br />ef_id</p>
<p>At last, we should include the google related ones.<br />It is cumbersome right now, that if marketing wants to use new tool (crm/newsletter...) they have to check with developers whether params are causing 404 or not. And deploy code changes to make it run.</p>
<p>some sources:<br /><a class="external" href="https://matomo.org/faq/tracking-campaigns-url-builder/">https://matomo.org/faq/tracking-campaigns-url-builder/</a><br /><a class="external" href="https://matomo.org/faq/how-to/faq_120/">https://matomo.org/faq/how-to/faq_120/</a><br /><a class="external" href="https://matomo.org/faq/reports/advanced-how-to-manually-build-campaign-tracking-urls/">https://matomo.org/faq/reports/advanced-how-to-manually-build-campaign-tracking-urls/</a></p>
<p><a class="external" href="https://support.google.com/analytics/answer/10917952">https://support.google.com/analytics/answer/10917952</a><br /><a class="external" href="https://support.google.com/analytics/answer/11242870">https://support.google.com/analytics/answer/11242870</a></p> TYPO3 Core - Task #100532 (Closed): Improve PathUtility::getCanonicalPath testshttp://forge.typo3.org/issues/1005322023-04-07T22:08:52ZTymoteusz Motylewskit.motylewski@gmail.com
<p>running mutation tests over PathUtility::getCanonicalPath shows that there are few paths not covered, lets cover them with tests</p> TYPO3 Core - Task #100266 (Closed): Improve error message in testMethodPrefixCheckerhttp://forge.typo3.org/issues/1002662023-03-23T08:51:14ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The current message "At least on method starts with "test" in" is confusing.<br />Lets make it more clear.</p> TYPO3 Core - Task #100263 (Closed): Cover filelist sorting functionality with testshttp://forge.typo3.org/issues/1002632023-03-22T21:41:33ZTymoteusz Motylewskit.motylewski@gmail.com
<p><a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187">https://review.typo3.org/c/Packages/TYPO3.CMS/+/78187</a> brings locale aware sorting for files and folders.<br />Lets add a test to show it.</p> TYPO3 Core - Bug #100121 (Resolved): Warning in TreeFormLineStreamBuilder when including TS from ...http://forge.typo3.org/issues/1001212023-03-08T12:03:39ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Go to pageproperties, insert TSconfig with wrong path (correct extension, but typo in the folder name).</p>
<pre>
@import 'EXT:sitepackage/Configuration/TSConfig/Mod/NonExistingFolder/*.tsconfig'
</pre>
<p>go to "PageTSConfig" module -> "Included PageTsConfig" <br />An error will be thrown:<br /><pre>
Core: Error handler (BE): PHP Warning: scandir(/var/www/html/typo3conf/ext/sitepackage/Configuration/TSConfig/Mod/NonExistingFolder/): Failed to open directory: No such file or directory in /var/www/html/typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php line 315
</pre></p>
<p>Expected behaviour:<br />Warning is not thrown.<br />Nice to have -> some notice is shown in PageTSConfig module, or logged into TYPO3 log.</p>
<p>Most probably the same problem affects TypoScript.</p> TYPO3 Core - Bug #100115 (Resolved): Copy operator < replaces previous reference operator result ...http://forge.typo3.org/issues/1001152023-03-07T17:22:35ZTymoteusz Motylewskit.motylewski@gmail.com
<p>This is a change of behavior in TypoScript v12.</p>
<p>Given TS:</p>
<pre>
lib.prototype {
fields {
content {
fields {
header = TEXT
header {
field = header
}
}
}
}
}
lib.additionalField {
fields {
content {
fields {
enlargeImageOnClick = true
}
}
}
}
testElement =< lib.prototype
testElement < lib.additionalField
testElement {
fields {
content {
fields {
subheader = TEXT
subheader {
field = subheader
}
}
}
}
}
tt_content.testElement =< lib.prototype
tt_content.testElement < lib.additionalField
tt_content.testElement {
fields {
content {
fields {
subheader = TEXT
subheader {
field = subheader
}
}
}
}
}
</pre>
<p>In v11 it looked like:<br /><img src="http://forge.typo3.org/attachments/download/37452/clipboard-202303071819-mhee9.png" alt="" loading="lazy" /></p>
<p>In v12 it is:<br /><img src="http://forge.typo3.org/attachments/download/37453/clipboard-202303071820-nkssh.png" alt="" loading="lazy" /></p>
<p>see missing "=< lib.prototype" in v12.<br />What is also interesting. Is that neither in v11 nor in v12 there is no "=< lib.prototype" if the testElement is on the root level of TS.</p> TYPO3 Core - Bug #97508 (Closed): Update to PHPStan 1.6.3http://forge.typo3.org/issues/975082022-04-28T14:46:44ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Task #94888 (Closed): Improve wording in indexed search deleteFromIndexAfterEditinghttp://forge.typo3.org/issues/948882021-08-14T10:44:08ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The rst file attached to the <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/69914">https://review.typo3.org/c/Packages/TYPO3.CMS/+/69914</a><br />mentioned "feature flag" when talking about extension configuration setting.</p>
<p>Lets improve the wording to avoid confusion.</p> TYPO3 Core - Task #94831 (Closed): DUMY test ticket for the codesrpirnthttp://forge.typo3.org/issues/948312021-08-12T09:27:58ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Task #94467 (Closed): Acceptance tests for indexed search backend modulehttp://forge.typo3.org/issues/944672021-07-02T08:01:30ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Indexed search should get some acceptance test coverage.<br />Lets start from backend module.</p>
<p>First scenario:</p>
<p>open Indexing Module module<br />go through the pages (dropdown)<br />see if expected text exists</p> TYPO3 Core - Bug #92856 (New): "Admin Panel" naming confusinghttp://forge.typo3.org/issues/928562020-11-16T16:05:40ZTymoteusz Motylewskit.motylewski@gmail.com
<p>New TYPO3 users are confusing "Admin Panel" with TYPO3 Backend, as in many other systems (WP, Drupal, Magento,...) the "Admin Panel" (or Administration Panel) means the place we call "Backend".<br />More appropriate name would be "developer toolbar" or "debug bar" or sth similar.</p>
<p>Btw, the term "Backend" is also confusing, especialy with IT/devops, where it's used in the meaning of "upstream server".</p> TYPO3 Core - Task #92724 (Closed): Add page ID prefix to page cache and lock identifiershttp://forge.typo3.org/issues/927242020-10-27T22:59:30ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Currently page cache and page locks identifiers are md5 values.<br />It would be nice to be able to quickly spot which page are these entries related to,<br />by prefixing md5 with page id.<br />Identifier before:<br />18aa076fd39fc4b1d03d23dc4dc7c2f5</p>
<p>Identifier after:<br />108_18aa076fd39fc4b1d03d23dc4dc7c2f5</p>
<p>where 108 is a page id.</p>
<p>Thanks to that its easier to debug monitor cache related issues.</p> TYPO3 Core - Feature #91691 (Rejected): Add code coverage report to bamboo buildhttp://forge.typo3.org/issues/916912020-06-22T17:30:32ZTymoteusz Motylewskit.motylewski@gmail.com
<p>It would be nice to get feedback about test code coverage when pushing a commit to gerrit.<br />I've played around with PCOV (<a class="external" href="https://github.com/krakjoe/pcov">https://github.com/krakjoe/pcov</a>), and running unit tests with coverage enabled on my local machine took 46.63 seconds (23.74 seconds without coverage enabled),<br />Generating code coverage report in Clover XML format ... done [15.69 seconds]<br />Generating code coverage report in HTML format ... done [7.77 seconds]</p>
<p>Here is the config I've used:<br /><pre>
#Build/pcov.ini
pcov.enabled = 1
pcov.directory = typo3
pcov.exclude="~(vendor|Tests|Resources|Configuration|node_modules)~"
pcov.initial.files = 10000
memory_limit = 2G
</pre><br /><pre>
php -c Build/pcov.ini vendor/phpunit/phpunit/phpunit -c vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml --coverage-html 'reports/clover_html' --coverage-clover 'reports/clover.xml'
</pre></p>
<p>We can either generate html coverage report ourselves or push the report to some external tool like <a class="external" href="https://coveralls.io/">https://coveralls.io/</a>.</p>
<p>As a first step the report could be generated in the nightly build , later it could be added to bamboo patchset tests.</p>
<p>To have the most meaningful report we should combine coverage reports from our parallel unit builds and functional tests. This could be achieved using phpunit/phpcov (<a class="external" href="https://github.com/sebastianbergmann/phpcov">https://github.com/sebastianbergmann/phpcov</a>):</p>
<pre>
phpunit --coverage-php build/cov/coverage-${component_name}.cov
php vendor/bin/phpcov.php merge --clover build/logs/clover.xml build/cov
</pre> TYPO3 Core - Bug #83721 (Closed): Page translated using localization overview is shown as normal ...http://forge.typo3.org/issues/837212018-01-29T18:00:29ZTymoteusz Motylewskit.motylewski@gmail.com
<p>In v9 when you translate a page using localization overview from the Info module<br />The page is create as a subpage of a given page instead of it's translation.</p>
<p>Translating a page uid =10, pid=5 results in page uid=11, pid=10, sys_language_uid= 0</p>