TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692020-02-20T10:38:39ZTYPO3 Forge
Redmine TYPO3 Core - Bug #90449 (Closed): Wrong key calculation in Admin panel QueryInformationhttp://forge.typo3.org/issues/904492020-02-20T10:38:39ZTymoteusz Motylewskit.motylewski@gmail.com
<p>the line <br /><pre>
$identifier = sha1($query['sql']) . sha1(implode(',', $query['backtrace']));
</pre><br />in TYPO3\CMS\Adminpanel\Modules\Debug\QueryInformation<br />throws a notice "array to string conversion" and does not do what it should, because $query['backtrace'] is an 2 level array, so after implode the string is "Array, Array, Array" - see screenshot.</p>
<p><img src="https://forge.typo3.org/attachments/download/34878/query_info.png" alt="" /></p> TYPO3 Core - Feature #89209 (Closed): Workspaces module should display info if no workspace recor...http://forge.typo3.org/issues/892092019-09-19T17:32:33ZTymoteusz Motylewskit.motylewski@gmail.com
<p>To lower the entry level, the workspace module should display a hint, when there is no worspace record yet created.</p> TYPO3 Core - Bug #85976 (Closed): Wrong relation in FAL fixture data for TS and extbase renderinghttp://forge.typo3.org/issues/859762018-08-25T00:45:13ZTymoteusz Motylewskit.motylewski@gmail.com
<p>In the <br />typo3/sysext/frontend/Tests/Functional/Rendering/DataSet/LiveDefaultElements.csv</p>
<p>The sys_file_reference record 127 (Kasper) is related to tt_content 298 "Regular Element #2",</p>
<p>however sys_file_reference 128 (which is a translation of 127) is connected to tt_content 300 ("[Translate to Dansk:] Regular Element #3").</p>
<p>It is wrong, because translated sys_file_reference should be connected to translated version of the tt_content.</p> TYPO3 Core - Bug #85733 (Closed): Wrong reference to TCA ctrl section in DefaultTcaSchema->getPri...http://forge.typo3.org/issues/857332018-08-02T17:45:36ZTymoteusz Motylewskit.motylewski@gmail.com
<p>there is<br /><pre>
$tableDefinition = $GLOBALS['TCA']['ctrl'];
</pre></p>
<p>but should be <br /><pre>
$tableDefinition = $GLOBALS['TCA'][$table]['ctrl'];
</pre></p> TYPO3 Core - Bug #85399 (Closed): Wrong doc comment in TableManualRepository -> getSectionshttp://forge.typo3.org/issues/853992018-06-26T22:39:02ZTymoteusz Motylewskit.motylewski@gmail.com
<p>the mode parameter should be int</p> TYPO3 Core - Bug #84868 (Closed): wrong check for key existance in getPageForRootline http://forge.typo3.org/issues/848682018-04-25T12:57:22ZTymoteusz Motylewskit.motylewski@gmail.com
<p>in review <a class="external" href="https://review.typo3.org/#/c/54558/">https://review.typo3.org/#/c/54558/</a><br />the coalescing operator was placed in the wrong position.<br />it should be inside is_array()</p> TYPO3 Core - Bug #83720 (Closed): Wrong page type when translating page through localization over...http://forge.typo3.org/issues/837202018-01-29T17:44:18ZTymoteusz Motylewskit.motylewski@gmail.com
<p>When mass-translating multiple pages in Info -> Localization Overview, all pages have the same page type (doktype) set to "standard".</p>
<p>Steps to reproduce:<br />Given you have untranslated shortcut page "A".<br />1. go to Info module<br />2. switch to localization overview<br />3. select checkbox by the "A" page<br />4. click on the icon with plus sign from the column header "create new translation headers" <br />5. fill the titles<br />6. save & close</p>
<p>You will see that newly created page translation will have wrong page type = standard instead of shortcut</p> TYPO3 Core - Bug #81622 (Closed): Wrong comment for sys_language_contentOLhttp://forge.typo3.org/issues/816222017-06-19T20:29:12ZTymoteusz Motylewskit.motylewski@gmail.com
<p>The comment in TSFE for sys_language_contentOL should be fixed<br />is:<br /><pre>
/**
* Site content overlay flag; If set - and sys_language_content is > 0 - ,
* records selected will try to look for a translation pointing to their uid. (If
* configured in [ctrl][languageField] / [ctrl][transOrigP...]
* @var int
*/
public $sys_language_contentOL = 0;
</pre></p>
<p>should be:<br /><pre>
/**
* Site content overlay flag; If set - and sys_language_content is > 0 - ,
* records selected will try to look for a translation pointing to their uid. (If
* configured in [ctrl][languageField] / [ctrl][transOrigP...]
* Possible values: [0,1,hideNonTranslated]
* This flag is set based on TypoScript config.sys_language_overlay setting
*
* @var int|string
*/
public $sys_language_contentOL = 0;
</pre></p> TYPO3 Core - Task #78382 (Closed): Workspaces functional tests should cover t3_origuid fieldhttp://forge.typo3.org/issues/783822016-10-22T22:06:02ZTymoteusz Motylewskit.motylewski@gmail.comTYPO3 Core - Bug #77809 (Closed): Wrong path in compatibility7 indexed searchhttp://forge.typo3.org/issues/778092016-09-02T22:33:08ZTymoteusz Motylewskit.motylewski@gmail.com
<p>typo3/sysext/compatibility7/ext_tables.php<br />contains<br /><pre>
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('compatibility7') . 'Resources/PHP/class.tx_indexed_search_pi_wizicon.php';
</pre><br />but should</p>
<p>\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath('compatibility7') . 'PHP/class.tx_indexed_search_pi_wizicon.php';</p> TYPO3 Core - Bug #77733 (Closed): Wrong icon for mounting a page as temporary root in context menuhttp://forge.typo3.org/issues/777332016-09-01T09:53:54ZTymoteusz Motylewskit.motylewski@gmail.com
<p>In the non-pagetree context menu the icon for mounting page as a temporary mounting point is apps-pagetree-page-mountpoint (page type icon, red one)<br />but should be actions-pagetree-mountroot (action icon, monochromatic)</p> TYPO3 Core - Bug #75909 (Closed): Wrong link to wiki in Extbase typoscripthttp://forge.typo3.org/issues/759092016-04-25T12:34:14ZTymoteusz Motylewskit.motylewski@gmail.com
<p>file typo3/sysext/extbase/ext_typoscript_setup.txt<br />contains link to old project on wiki:<br /><pre>
# if enabled, default controller and/or action is skipped when creating URIs through the URI Builder (see http://forge.typo3.org/projects/typo3v4-mvc/wiki/Skip_default_arguments_in_URIs)
96 skipDefaultArguments = 0
</pre></p>
<p>this page is not accessible any more.</p>
<p>Internet archvive helped me recover following text:</p>
<pre>
Skip default arguments in URIs
This feature is part of Extbase 1.4, that will be included in TYPO3 4.6
From version 1.4 on you can configure Extbase to skip the URI arguments for controller and action if they are equal to the respective default in the target plugin.
NOTE: This only works reliably, if you do not modify the default controller / actions of a plugin via FlexForms!
You can enable the feature with following TypoScript configuration:
plugin.tx_yourextension {
features {
skipDefaultArguments = 1
}
}
You can enable the feature globally, but make sure that all installed Extbase extensions are compatible with that setting:
config.tx_extbase {
features {
skipDefaultArguments = 1
}
}
</pre>
<p>We should move this documentation to a proper place and fix the link.</p> TYPO3 Core - Bug #68088 (Closed): Wrong calls for GeneralUtility::sysLoghttp://forge.typo3.org/issues/680882015-07-13T21:04:25ZTymoteusz Motylewskit.motylewski@gmail.com
<p>TODO:<br />make all calls to generalUtility::sysLog use extkey "core" instead of "Core".<br />Use constants for severity<br />fix wrong parameters</p>
<p>will push a patch once have an stable internet connection :)</p> TYPO3 Core - Bug #67843 (Closed): Wrong queries in indexSearchRepositoryhttp://forge.typo3.org/issues/678432015-06-30T11:14:08ZTymoteusz Motylewskit.motylewski@gmail.com
<p>Duplicate 'AND' in IndexSearchRepository.php</p>
<p>Line 562 and 627 both add a 'AND' string so the final query contains 'AND AND' and gets invalid.</p>
<p>The pi-based version of indexed search does not contain 'AND' in function execFinalQuery (SearchFormController.php line 1108)</p>
<p>There is something wrong with the implode function in statement<br />$wordSel = '(' . implode(' OR ', $this->wSelClauses) . ') AND ';<br />in line 614 in IndexSearchRepository.php<br />Implode returns double ORs ('OR OR'). Therefore the query gets invalid.</p>
<p>There are only search results for the first item in defaultFreeIndexUidList. <br />Other items return "no result" even if there are some.</p> TYPO3 Core - Bug #55721 (Closed): wrong filenames when UTF8filesystem is set and 'systemLocale' i...http://forge.typo3.org/issues/557212014-02-06T12:11:20ZTymoteusz Motylewskit.motylewski@gmail.com
<p>While checking out issue <a class="external" href="http://forge.typo3.org/issues/32683">http://forge.typo3.org/issues/32683</a> on 6.2 I stumbled upon the same issue.<br />I found out that if you have UTF8Filesystem set to 1, but $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'] is empty, then TYPO3 generate wrong file names, resulting e.g. in thumbnails not being generated in the backend. The problem disappear if I set '['SYS']['systemLocale']' to e.g. 'C.UTF-8' or 'en_US.UTF-8' or similar.</p>
<p>But the issue is not limited to thumbnails ony. It also occurs in many other places. There are plenty of related issues in Forge.</p>
<p>The common pattern all over TYPO3 is sth like this:<br /><pre>
if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem']) {
$currentLocale = setlocale(LC_CTYPE, 0);
setlocale(LC_CTYPE, $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale']);
}
//do sth here e.g. basename, escapeshellarg, dirname, pathinfo
$escapedInputName = escapeshellarg($inputName);
if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem']) {
setlocale(LC_CTYPE, $currentLocale);
}
</pre><br />Btw, there is already a ticket to refactor this and put the logic in the central place. <a class="external" href="http://forge.typo3.org/issues/39928">http://forge.typo3.org/issues/39928</a></p>
<p>I see several solutions here:<br />1. Use fallback when setting locale. <br />Instead of <br /> setlocale(LC_CTYPE, $currentLocale);<br /> setlocale(LC_CTYPE, $currentLocale, 'C.UTF-8', 'en_US.utf8');</p>
<p>2. Set default value 'C.UTF-8' to $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'], so it should be never empty.<br />3. Add install tool warning when systemLocale is not set<br />4. BTW, why can not we set setlocale() globally in bootstrap instead of setting it for each function separately?</p>