TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692024-03-27T17:18:45ZTYPO3 Forge
Redmine TYPO3 Core - Bug #103494 (Under Review): Linkvalidator uses tstamp field directly without checkin...http://forge.typo3.org/issues/1034942024-03-27T17:18:45ZSybille Peterssypets@gmx.de
<p><strong>This should be merged before <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612">https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612</a></strong></p>
<p>TCA should be used to determine which field is relevant for tstamp (and if there is such a field) before using it for a DB query</p>
<p>$GLOBALS['TCA'][$table]['ctrl']['tstamp']</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Change configuration to mod.linkvalidator.searchFields.sys_redirect.target</li>
<li>check links (with a broken redirect target)</li>
<li>in the list of broken links, click pencil to edit redirect target field</li>
<li>close edit field</li>
</ol>
<p>Now, exception is thrown.</p> TYPO3 Core - Bug #101119 (Closed): SoftReferenceParserFactory has 2 required constructor argument...http://forge.typo3.org/issues/1011192023-06-19T10:17:11ZSybille Peterssypets@gmx.de
<p><strong>Update</strong> : It should be possible to get an instance of an object with GeneralUtility::makeInstance which is instantiated with DI without the constructor arguments (at least from looking at makeInstance).</p>
<p>I am still investigating how to reproduce this, what is exactly the problem and if it is a core bug ....</p>
<hr />
<p>core SoftReferenceParserFactory.php constructor has 2 arguments, but is instantiated without arguments in ReferenceIndex.php if object not passed in constructor.</p>
<p>This occurred after installation of causal/extractor and only in combination with specific other extensions. I have not been able to narrow it down. The exception appears when opening "Extension Configuration".</p>
<p>Anyhow, the code in the core looks wrong:</p>
<p>in /typo3/sysext/core/Classes/Database/ReferenceIndex.php line 126</p>
<pre>
$this->softReferenceParserFactory = $softReferenceParserFactory ?? GeneralUtility::makeInstance(SoftReferenceParserFactory::class);
</pre>
<p>typo3/sysext/core/Classes/DataHandling/SoftReference/SoftReferenceParserFactory.php line 33</p>
<pre>
public function __construct(FrontendInterface $runtimeCache, LoggerInterface $logger)
</pre>
<p>instantiated in FileIndexRepository line 339</p>
<pre>
public function updateRefIndex($id)
{
$refIndexObj = GeneralUtility::makeInstance(ReferenceIndex::class);
</pre>
<a name="Versions"></a>
<h2 >Versions<a href="#Versions" class="wiki-anchor">¶</a></h2>
<ul>
<li>reproduced with 11.5.28, not checked with v12 / main</li>
</ul>
<a name="Exception-stack-trace"></a>
<h2 >Exception stack trace<a href="#Exception-stack-trace" class="wiki-anchor">¶</a></h2>
<p>see file exception_extconf.txt (linked below)</p> TYPO3 Core - Task #99772 (Closed): Deprecate TCA renderType="inputLink" at some pointhttp://forge.typo3.org/issues/997722023-01-31T14:09:48ZSybille Peterssypets@gmx.de
<p>The type="input", renderType="inputLink" was replaced in TYPO3 v12 with type="link", however the inputLink still works. At some point it can be deprecated and removed.</p>
<p>typo3/sysext/backend/Migrations/Code/ClassAliasMap.php:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">return</span> <span class="p">[</span>
<span class="s1">'TYPO3\\CMS\\Backend\\Form\\Element\\InputLinkElement'</span> <span class="o">=></span> <span class="nc">\TYPO3\CMS\Backend\Form\Element\LinkElement</span><span class="o">::</span><span class="n">class</span><span class="p">,</span>
</code></pre> TYPO3 Core - Bug #92972 (New): Softref parsers should take syntax format of field into accounthttp://forge.typo3.org/issues/929722020-12-02T11:08:42ZSybille Peterssypets@gmx.de
<a name="Suggestion"></a>
<h2 >Suggestion<a href="#Suggestion" class="wiki-anchor">¶</a></h2>
<ul>
<li>make it possible to always set "format" for TCA column type "text" and "input" </li>
<li>use the format in the softref parsers</li>
</ul>
<a name="Explanation"></a>
<h2 >Explanation<a href="#Explanation" class="wiki-anchor">¶</a></h2>
<p>Currently, AFAIK, the softref parser does not evaluate what format the field has. Possible formats can be HTML (e.g. tt_content.bodytext), plain text, TypoScript (e.g. sys_template.config, sys_template.constants), comma separated list.</p>
<p>The <a href="https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/textT3editor.html#format" class="external">format</a> can already (partly) be set in TCA, but only if type is 'text' and 'renderType' is 't3editor', for example as 'typoscript' for sys_template.config.</p>
<p>Since t3editor is used only for typoscript it does not really seem to make sense that the format can be set for this renderType but not for renderType default.</p>
<blockquote>
<p>renderType='t3editor': System extension “t3editor” provides an enhanced textarea for TypoScript input</p>
</blockquote>
<blockquote>
<p>format: The value specifies the language t3editor should handle. Allowed values: css, html, javascript, php, typoscript, xml</p>
</blockquote>
<p>For tt_content.bodytext neither renderType nor format are set.</p>
<p>If this is handled consistently, you would not have to pass 'linklist' to the softref parser, but read this from format as well (e.g. for findRef_typolink()).</p>
<p>By being able to handle the formatting consistently in all softref parsers, it might be possible to simplify things and also avoid inconsistencies.</p>
<a name="Examples"></a>
<h1 >Examples:<a href="#Examples" class="wiki-anchor">¶</a></h1>
<p>Currently, URLs <strong>in comments</strong> in sys_template config or constants are added to the reference index, e.g.</p>
<pre>
sys_template.config:
# https://example.org
</pre>
<p>When saved, this record is created:</p>
<pre>
+----------------------------------+--------------+--------+--------+-------------+-------------+------------+---------+---------+-----------+-----------+---------+---------------------+
| hash | tablename | recuid | field | flexpointer | softref_key | softref_id | sorting | deleted | workspace | ref_table | ref_uid | ref_string |
+----------------------------------+--------------+--------+--------+-------------+-------------+------------+---------+---------+-----------+-----------+---------+---------------------+
| a7ad94098b4c8ea1293af92fcd8be9b5 | sys_template | 2 | config | | url | 2 | -1 | 0 | 0 | _STRING | 0 | https://example.org |
+----------------------------------+--------------+--------+--------+-------------+-------------+------------+---------+---------+-----------+-----------+---------+---------------------+
</pre>
<p>If TypoScript were parsed correctly, this should not happen.</p>
<p>(Not sure why URLs in TypoScript are added to reference index in the first place and whether this has any benefit).</p> TYPO3 Core - Bug #92546 (Closed): Misleading errror message for pagetree if user has no access to...http://forge.typo3.org/issues/925462020-10-12T14:31:31ZSybille Peterssypets@gmx.de
<pre><code class="text syntaxhl" data-language="text">Page tree error
Got unexpected response from the server. Please check logs for details.
</code></pre>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Create user / group which has no access to the pages, e.g. the page belongs to different user / group and "Everybody" has no access:</li>
</ol>
<p><img src="http://forge.typo3.org/attachments/download/35523/permissions.png" alt="" loading="lazy" /></p>
<a name="Expected"></a>
<h2 >Expected<a href="#Expected" class="wiki-anchor">¶</a></h2>
<p>It is correct that the user has no access but the error message is misleading.</p> TYPO3 Core - Bug #92541 (New): Text of flash message is misleading for JavaScript errorshttp://forge.typo3.org/issues/925412020-10-12T11:53:07ZSybille Peterssypets@gmx.de
<p>Example: Page tree error message</p>
<pre><code class="text syntaxhl" data-language="text">Page tree error
Got unexpected response from the server. Please check logs for details.
</code></pre>
<p>When I get this type of error, the logs are usually empty. This is usually a JavaScript error displayed in browser console.</p>
<p>It would be great if error message which recommends to look in logs is only given if error has been logged.</p>
<p>Would be great if user got a different hint if there has been a JavaScript error.</p> TYPO3 Core - Feature #92193 (New): Make console commands (directly) visible in list of scheduler ...http://forge.typo3.org/issues/921932020-09-04T09:55:26ZSybille Peterssypets@gmx.de
<p>When you create a new task in the scheduler, you can see a list of available tasks in Class.</p>
<p><img src="http://forge.typo3.org/attachments/download/35430/scheduler1.png" alt="" loading="lazy" /></p>
<p>Here, you have to select "Execute console commands" to see a list of the console commands.</p>
<p>This makes the usability a bit clunky, because you do not have a full list of what is available. You have to choose "console command" and only then do you see the console commands (or not).</p>
<p>Extension authors may want to make their schedulable tasks available as console commands because this adds more flexibility (as they can be called on the console or via cron directly). However, having the commands then be a bit hidden is a downside of this.</p>
<a name="Possible-solution"></a>
<h2 >Possible solution<a href="#Possible-solution" class="wiki-anchor">¶</a></h2>
<ul>
<li>add the console commands to the list of scheduler tasks to be visible like any other scheduler task.</li>
</ul> TYPO3 Core - Task #91977 (Rejected): Code cleanup in ExtensionListCommandhttp://forge.typo3.org/issues/919772020-08-11T15:01:15ZSybille Peterssypets@gmx.deTYPO3 Core - Task #87394 (Closed): composer gerrit:setup should be available for all platformshttp://forge.typo3.org/issues/873942019-01-11T08:51:38ZSybille Peterssypets@gmx.de
<p>I am currently updating the Contribution Guide. I would like to simplify the setup.</p>
<p>composer gerrit:setup sets up both commit hooks: commit-msg and pre-commit. The pre-commit hook currently may not run on Windows.</p>
<p>For this reason, you can't just write: just run composer gerrit:setup to setup commit hooks. You have to write: for windows do ..., for Linux / Mac do ...</p>
<p>So, it might be useful to do one of the following:</p>
<ol>
<li>make the pre-commit hook portable</li>
<li>only copy the commit-msg hook with gerrit:setup</li>
<li>or check before copying if it will run on current system in <a href="https://github.com/TYPO3/TYPO3.CMS/blob/master/Build/Scripts/composer/InstallerScripts.php" class="external">InstallerScripts:enablePreCommitHook</a></li>
</ol> TYPO3 Core - Task #87176 (Closed): Add git setup script for core developmenthttp://forge.typo3.org/issues/871762018-12-16T23:33:05ZSybille Peterssypets@gmx.de
<p>Currently, several commands must be executed manually. Some of these, can't just be copy-pasted, because user-specific options must be added to commands (email address, username, etc.).</p>
<p>A script can be added, which makes the setup easier.</p>
<p>Currently, you must execute the following commands:</p>
<pre><code class="text syntaxhl" data-language="text">git config user.name "Your Name"
git config user.email "your-email@example.com"
git config branch.autosetuprebase remote
# usually, not required
mkdir -p .git/hooks
cp Build/git-hooks/commit-msg .git/hooks/commit-msg
# make executable (usually not required)
chmod +x .git/hooks/commit-msg
# optional
cp Build/git-hooks/unix+mac/pre-commit .git/hooks/
chmod +x .git/hooks/pre-commit
git config url."ssh://<YOUR_TYPO3_USERNAME>@review.typo3.org:29418".pushInsteadOf git://git.typo3.org
# optional
git config commit.template ~/.gitmessage.txt
</code></pre>
<p>See <a class="external" href="https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/Git/Index.html">https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/Git/Index.html</a></p> TYPO3 Core - Task #85725 (Closed): Add directories created by rendering of documentation to .giti...http://forge.typo3.org/issues/857252018-08-02T10:38:01ZSybille Peterssypets@gmx.deTYPO3 Core - Bug #85386 (Closed): Fix inconsistency of command line arguments, help output and d...http://forge.typo3.org/issues/853862018-06-25T17:57:40ZSybille Peterssypets@gmx.de
<p>Note: Closed for now, until researched further. Initially noticed that documentation partly does not fit behaviour or may be a little difficult to understand.</p>
<p>There seems to be also an issue with inconsistency of some options and the help output.</p>
<p><strong>1. Some commands have --dry-run in their help message and some do not</strong></p>
<ul>
<li>cleanup:deletedrecords : does not</li>
<li>cleanup:multiplereferencedfiles : does</li>
</ul>
<p>Weird that deletedrecords should suddenly not support dry-run</p>
<blockquote><blockquote>
<p>this needs to be researched further, not really a problem of the docs, though.</p>
</blockquote></blockquote>
<p><a class="external" href="https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/lowlevel/README.rst">https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/lowlevel/README.rst</a></p>
<p>In TYPO3 7 there where some common options so you could execute the commands without problems in a loop using a generic commmand line, e.g.</p>
<pre><code class="text syntaxhl" data-language="text">for tag in $tags;do
if [[ $cmd == fix ]];then
# fix
php ./typo3/cli_dispatch.phpsh lowlevel_cleaner $tag -r -s -v 2 --AUTOFIX --YES --refindex update
else
# dry-run
php ./typo3/cli_dispatch.phpsh lowlevel_cleaner $tag -r -s -v 2 --dryrun
fi
done
</code></pre>
<p>Having --dryrun <strong>and</strong> --AUTOFIX makes absolutely no sense, so it is better now, but it should be easier to use.</p>
<p><strong>2. Usage:</strong></p>
<pre><code class="text syntaxhl" data-language="text"> help [options] [--] [<command_name>]
Arguments:
command The command to execute
command_name The command name [default: "help"]
</code></pre>
<p>Not very inuitive</p>
<ul>
<li>where is 'command' in the usage at the top?</li>
</ul>
<p><strong>3. Two different help messages with help and --help.</strong></p>
<p>The output with --help is confusing (--help is documented), the output of help is better. Maybe better to document only help (and not --help and remove that)</p>
<p>e.g <br /><pre><code class="text syntaxhl" data-language="text">php ./typo3/sysext/core/bin/typo3 help cleanup:multiplereferencedfiles
</code></pre></p> TYPO3 Core - Task #85007 (Closed): Remove setting style for broken links in RteHtmlParser::markBr...http://forge.typo3.org/issues/850072018-05-15T09:05:14ZSybille Peterssypets@gmx.de
<p>Once patch <a class="external" href="https://review.typo3.org/c/56943/">https://review.typo3.org/c/56943/</a> is merged, setting the style for broken links in RteHtmlParser should be removed in master.</p> TYPO3 Core - Epic #84889 (Closed): Make frontend: PageRepository and PageRepositoryTest notice freehttp://forge.typo3.org/issues/848892018-04-28T10:54:03ZSybille Peterssypets@gmx.de
<p>Core: Error handler (BE): PHP Notice: Undefined index: disabled in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L1364" class="external">line 1364</a></p>
<p>Core: Error handler (BE): PHP Notice: Undefined index: starttime in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L1368" class="external">line 1368</a></p>
<p>Core: Error handler (BE): PHP Notice: Undefined index: endtime in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L1372" class="external">line 1372</a></p>
<p>Core: Error handler (BE): PHP Notice: Undefined index: TYPO3\CMS\Frontend\Page\PageRepository in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L209" class="external">line 209</a></p> TYPO3 Core - Bug #37467 (Closed): Change in class.t3lib_div.php may break things for HTTPS via re...http://forge.typo3.org/issues/374672012-05-24T14:51:11ZSybille Peterssypets@gmx.de
<p>The change introduced in TYPO3 4.5.16 as fix for bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Wrong HTTP protocol in combination with a proxy (Closed)" href="http://forge.typo3.org/issues/36004">#36004</a> makes working in backend impossible for some HTTPS reverse-proxy configurations.</p>
<p>It may be a misconfiguration on our end, but as far as I can see, since the change HTTPS will only work with reverse proxy, if <strong>X-Forwarded-For</strong> contains local and proxy IP and</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="err">$</span><span class="p">[</span><span class="s1">'TYPO3_CONF_VARS'</span><span class="p">][</span><span class="s1">'SYS'</span><span class="p">][</span><span class="s1">'reverseProxyHeaderMultiValue'</span> <span class="o">=</span> <span class="s2">"last"</span><span class="p">;</span>
</code></pre>
<p>Login to backend works, but then a network connections error is displayed (<em>"Verbindungsproblem Bei dem Versuch eine Verbindung zum Server herzustellen ist ein Fehler aufgetreten. Bitte überprüfen Sie Ihre Netzwerkverbindung."</em>)</p>
<p>Analyzing this shows that the changed line 4151 in class.t3lib_div.php has caused this problem:</p>
<p>older version:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">(</span><span class="k">self</span><span class="o">::</span><span class="nf">cmpIP</span><span class="p">(</span><span class="nv">$_SERVER</span><span class="p">[</span><span class="s1">'REMOTE_ADDR'</span><span class="p">],</span> <span class="nv">$proxySSL</span><span class="p">))</span> <span class="p">{</span>
</code></pre>
<p>newer version:<br /><pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">(</span><span class="k">self</span><span class="o">::</span><span class="nf">cmpIP</span><span class="p">(</span><span class="k">self</span><span class="o">::</span><span class="nf">getIndpEnv</span><span class="p">(</span><span class="s1">'REMOTE_ADDR'</span><span class="p">),</span> <span class="nv">$proxySSL</span><span class="p">))</span> <span class="p">{</span>
</code></pre></p>