TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692024-03-27T17:18:45ZTYPO3 Forge
Redmine TYPO3 Core - Bug #103494 (Under Review): Linkvalidator uses tstamp field directly without checkin...http://forge.typo3.org/issues/1034942024-03-27T17:18:45ZSybille Peterssypets@gmx.de
<p><strong>This should be merged before <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612">https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612</a></strong></p>
<p>TCA should be used to determine which field is relevant for tstamp (and if there is such a field) before using it for a DB query</p>
<p>$GLOBALS['TCA'][$table]['ctrl']['tstamp']</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Change configuration to mod.linkvalidator.searchFields.sys_redirect.target</li>
<li>check links (with a broken redirect target)</li>
<li>in the list of broken links, click pencil to edit redirect target field</li>
<li>close edit field</li>
</ol>
<p>Now, exception is thrown.</p> TYPO3 Core - Feature #103493 (Under Review): Show button to edit full record in linkvalidator (ad...http://forge.typo3.org/issues/1034932024-03-27T17:07:51ZSybille Peterssypets@gmx.de
<p>By default, a form showing only the field with the broken link is opened, if clicking the "pencil" button in the Link Validator report.</p>
<p>If checking sys_redirect.target as well, I noticed that opening the form this way is not helpful, because some context is missing: we see only the target, but not the source_path and the rest of the fields.</p>
<p>In this particular case, the default behaviour is unhelpful.</p>
<p>Originally, the behaviour was that the entire record was edited. This, however also proved as unhelpful, because sometime the broken link was a bit hidden, or it was in a different tab.</p>
<a name="Implementation-options"></a>
<h2 >Implementation options<a href="#Implementation-options" class="wiki-anchor">¶</a></h2>
<ol>
<li>(Idealistic) would be if the full record was opened, but the tab where the broken link is contained is opened by default, and if necessary there is scrolling so the field is in focus. Additionally, it might be helpful if this field (or all fields with broken links) would be marked visibly. (However, marking visibly should be different from what is currently used in case of evaluation).</li>
<li>(pragmatic) show both buttons but make it configurable, e.g.</li>
</ol> TYPO3 Core - Bug #103478 (New): Linkvalidator should check fields with type "file"http://forge.typo3.org/issues/1034782024-03-25T05:47:22ZSybille Peterssypets@gmx.de
<p>e.g. pages.media</p>
<p>see documentation: <a class="external" href="https://docs.typo3.org/c/typo3/cms-linkvalidator/main/en-us/Configuration/Index.html">https://docs.typo3.org/c/typo3/cms-linkvalidator/main/en-us/Configuration/Index.html</a></p>
<p>LinkAnalyzer.php:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">((</span><span class="nv">$conf</span><span class="p">[</span><span class="s1">'type'</span><span class="p">]</span> <span class="o">??</span> <span class="s1">''</span><span class="p">)</span> <span class="o">===</span> <span class="s1">'link'</span> <span class="o">&&</span> <span class="k">empty</span><span class="p">(</span><span class="nv">$conf</span><span class="p">[</span><span class="s1">'softref'</span><span class="p">]))</span> <span class="p">{</span>
<span class="nv">$conf</span><span class="p">[</span><span class="s1">'softref'</span><span class="p">]</span> <span class="o">=</span> <span class="s1">'typolink'</span><span class="p">;</span>
<span class="p">}</span>
</code></pre> TYPO3 Core - Feature #103403 (Under Review): Make it possible to check custom record links with l...http://forge.typo3.org/issues/1034032024-03-15T09:45:42ZSybille Peterssypets@gmx.de
<p><strong>Currently, there is a known problem that RECORD link checking is not possible via the typolink_tag softref parser, see <a class="issue tracker-1 status-1 priority-4 priority-default" title="Bug: Linkvalidator doesn't check record/custom links within RTEs at all (New)" href="http://forge.typo3.org/issues/102468">#102468</a>. Because of this, when fixing this issue, one must currently test the record link checking using urls which are not wrapped in an a tag. This can be done for example, by using tt_content.header_link.</strong></p>
<p>e.g. "t3://record?identifier=tx_news&uid=99999"</p>
<p>as described in <a class="external" href="https://docs.typo3.org/p/georgringer/news/main/en-us/Tutorials/BestPractice/Linkhandler/Index.html#linkhandler">https://docs.typo3.org/p/georgringer/news/main/en-us/Tutorials/BestPractice/Linkhandler/Index.html#linkhandler</a></p>
<p>Currently, InternalLinktype::checkLink is called for these types of links, but then it always evaluates to "true" if the target table is not "tt_content" or "pages":</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="nb">in_array</span><span class="p">(</span><span class="nv">$table</span><span class="p">,</span> <span class="p">[</span><span class="s1">'pages'</span><span class="p">,</span> <span class="s1">'tt_content'</span><span class="p">],</span> <span class="kc">true</span><span class="p">))</span> <span class="p">{</span>
<span class="k">return</span> <span class="kc">true</span><span class="p">;</span>
<span class="p">}</span>
</code></pre>
<p><a class="external" href="https://github.com/TYPO3/typo3/blob/5c95229af666e4ce39dd5a22baecd3390d649c49/typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php#L85">https://github.com/TYPO3/typo3/blob/5c95229af666e4ce39dd5a22baecd3390d649c49/typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php#L85</a></p>
<p>Ideally, the InternalLinktype could handle custom records for other tables as well, e.g. tx_news_domain_model_news.</p> TYPO3 Core - Bug #103100 (Resolved): "Refresh display" or "Check links" button is entirely disabl...http://forge.typo3.org/issues/1031002024-02-11T13:18:51ZSybille Peterssypets@gmx.de
<p>By default, the buttons in "Report" and "Check links" module are disabled. They are enabled via JavaScript if a check option is enabled.</p>
<p>However, in TYPO3 v13 (and possibly below), this does not work correctly: if all options are unchecked (which is the default for new users) and then one of them is toggled (to enabled), it is still not possible to click the button at all, it remains disabled even if options are being checked. It looks like the event listener is not being called.</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>1. switch to a new user where the options have not been enabled yet<br />2. Either in the "Report" or "Check links" view, enable one of the checkboxes for the link types<br />3. Try to click the button</p>
<p>Result: nothing happens, the button is disabled, so it is not possible to execute the new selection.</p>
<a name="Versions"></a>
<h2 >Versions<a href="#Versions" class="wiki-anchor">¶</a></h2>
<p>Could be reproduced in TYPO3 v13 (main).</p>
<p>Could NOT be reproduce din TYPO3 v12.</p>
<a name="Screenshot"></a>
<h2 >Screenshot<a href="#Screenshot" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/38255/linkvalidator_checkboxes.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #103059 (New): Not possible to see references if no access to content where file...http://forge.typo3.org/issues/1030592024-02-06T10:22:55ZSybille Peterssypets@gmx.de
<p>In the file list you can see the number of references for files which are referenced from content which you do not have access to, and you can also click on the link, but the references will not be displayed.</p>
<p>I would expect it to be possible to see the references (read-only) and also be able to see which pages the references are on (ideally by having a "view page" button).</p>
<p>Otherwise you cannot delete files and you can't find out (as normal editor) where they are still being referenced from.</p>
<p>This means, these cases can only be resolved by admin users or by users with access to both the files and the content.</p>
<a name="Example"></a>
<h2 >Example<a href="#Example" class="wiki-anchor">¶</a></h2>
<p>user A<br />- access to pages /a/<br />- access to files fileadmin/a</p>
<p>user B<br />- access to pages /b/<br />- access to files fileadmin/b</p>
<p>Content in /a/ links to file /b/test.png. Now, user b cannot see references for test.png and cannot delete test.png.</p> TYPO3 Core - Feature #102644 (New): Make it easier to restrict uploadable file types / extensions...http://forge.typo3.org/issues/1026442023-12-09T22:07:09ZSybille Peterssypets@gmx.de
<p>I want to prevent <strong>additional</strong> unwanted files from being uploaded, such as .exe, .zip, .iso etc. (this should be configurable). Right now, I can only do it AFAIK by changing the regex in fileDenyPattern.</p>
<a name="My-feature-reqeust"></a>
<h2 >My feature reqeust<a href="#My-feature-reqeust" class="wiki-anchor">¶</a></h2>
<ul>
<li>add a "safe" configuration, so you can add <strong>additional</strong> file extensions, without having to change fileDenyPattern. This does not even have to be a regex or be added to fileDenyPattern, it could be a comma separated list of file extensions, which is used in FileNameValidator</li>
<li>make it possible to use "explicit allow" instead of "explicit deny" here. This should probably not be the default yet, but could be in the future.</li>
</ul>
<a name="Background"></a>
<h2 >Background<a href="#Background" class="wiki-anchor">¶</a></h2>
<p>Currently, there is a setting which is a bit hidden: $GLOBALS['TYPO3_CONF_VARS']['BE']['fileDenyPattern'], is used in FileNameValidator.</p>
<p>It is hidden, because it is not in the Default configuration and not visible when editing "Global configuration" in the BE.</p>
<p>I assume, that is for security reasons, that you don't accidentally mess up the regular expression, making the system less secure. In particular, it should not be possible to upload .php files, .htaccess files etc.</p>
<p>But, this also makes it difficult, in case you want to be <em>more restrictive</em> (!). You have to first find the hidden option and then edit the regex, hoping you don't break anything.</p> TYPO3 Core - Bug #102595 (New): Not possible to override richtextConfiguration via TSconfig if in...http://forge.typo3.org/issues/1025952023-12-04T05:11:41ZSybille Peterssypets@gmx.de
<p>Normally, overriding settings in Flexform via TSconfig is possibly, for example like this:</p>
<pre>
# TCEFORM.[tableName].[fieldName].[dataStructureKey].[flexSheet].[flexFieldName with escaped dots].[propertyName]
<pre>
TCEFORM.tt_content.pi_flexform.sfregister_create.sDEF.settings\.fields\.selected.addItems.ZZZ = ZZZ
</pre>
</pre><br />see <a class="external" href="https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/TceForm.html">https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/TceForm.html</a>
<p>But this does not seem to work with the richtextConfiguration if in a Flexform which would then be overridden with RTE, for example like this:</p>
<pre>
RTE.config.tx_news_domain_model_news.bodytext.preset = otherpreset
</pre>
<p>For a Flexform field, it should look for example like this:</p>
<pre>
RTE.config.tt_content.pi_flexform.powermail_pi1.thx.settings\.flexform\.thx\.body.preset = otherpreset
</pre>
<p>but this does not work</p> TYPO3 Core - Feature #102447 (New): Prevent information disclosure from Only Office by copy-paste...http://forge.typo3.org/issues/1024472023-11-22T12:21:55ZSybille Peterssypets@gmx.de
<p>This seems to be already fixed in ckeditor: <a class="external" href="https://github.com/ckeditor/ckeditor5/issues/14947">https://github.com/ckeditor/ckeditor5/issues/14947</a></p>
<blockquote>
<p>We have found blobs in the class attributes of HTML elements on some pages. These blobs seem to contain metadata from the document from which the content was copied. If you take the blob and decode it with base64 and encode the result as 'utf-16' you can read some text fragments. These fragments can contain chat, comments or parts of the onlyoffice document, which would result in a leak of data.</p>
</blockquote>
<p>However I am not sure which version and which versions of ckeditor and TYPO3 will have this fix.</p>
<p>Perhaps it is also possible to remove these when the CE is saved by default (RTE post-processing) to also remove already existing ones.</p>
<p>This is a problem because:</p>
<ul>
<li>sensitive information might get accidentally disclosed (unfortunately often editors are not even aware what they are copy-pasting into the RTE).</li>
<li>it bloats up the DB tables which is unnecessary and might have a performance / storage usage impact (in extreme cases)</li>
<li>it clutters up the visible history (sys_history view in BE)</li>
</ul>
<p>I have seen this in our site which uses latest TYPO3 v11.</p> TYPO3 Core - Task #101711 (New): document classesAnchor for rte_ckeditorhttp://forge.typo3.org/issues/1017112023-08-18T14:58:45ZSybille Peterssypets@gmx.de
<p>This is the only documentation for classesAnchor I could find so far, but this is for rtehtmlarea:</p>
<p><a class="external" href="https://docs.typo3.org/p/friendsoftypo3/rtehtmlarea/main/en-us//Configuration/PageTsconfig/classesAnchor/Index.html">https://docs.typo3.org/p/friendsoftypo3/rtehtmlarea/main/en-us//Configuration/PageTsconfig/classesAnchor/Index.html</a></p>
<p>classesAnchor is not documented in the rte_ckeditor documentation: <a class="external" href="https://docs.typo3.org/c/typo3/cms-rte-ckeditor/main/en-us/Index.html">https://docs.typo3.org/c/typo3/cms-rte-ckeditor/main/en-us/Index.html</a></p>
<p>classesAnchor can be used in rte_ckeditor as well, see example in bootstrap_package:</p>
<pre>
classesAnchor:
page:
class: 'link-page'
type: 'page'
folder:
class: 'link-folder'
type: 'folder'
file:
class: 'link-file'
type: 'file'
external:
class: 'link-external'
type: 'url'
mail:
class: 'link-mail'
type: 'mail'
</pre>
<p><a class="external" href="https://github.com/benjaminkott/bootstrap_package/blob/master/Configuration/RTE/Default.yaml">https://github.com/benjaminkott/bootstrap_package/blob/master/Configuration/RTE/Default.yaml</a></p>
<a name="Search-for-classesAnchor"></a>
<h3 >Search for "classesAnchor"<a href="#Search-for-classesAnchor" class="wiki-anchor">¶</a></h3>
<ul>
<li>in "TYPO3 Explained": no result</li>
<li>in rte_ckeditor Documentation: no result</li>
</ul>
<a name="Related"></a>
<h3 >Related<a href="#Related" class="wiki-anchor">¶</a></h3>
<ul>
<li>changelog: <a href="https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-98275-RemovedPreDefinedLinkTitleAttributesInRTELinkBrowser.html" class="external">Breaking: #98275 - Removed pre-defined link title attributes in RTE link browser</a></li>
</ul> TYPO3 Core - Bug #92242 (Closed): Problem after updating to TYPO3 9.5.21 w adminpanel: Page is ca...http://forge.typo3.org/issues/922422020-09-09T13:15:24ZSybille Peterssypets@gmx.de
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>1. Use a page with hidden elements<br />2. Select "Show hidden records" in adminpanel. Unset "No caching" <br />3. Remove cache for page and load (e.g. with CTRL + SHIFT + r)<br />4. Now load the page without being logged in (e.g. in different browser, via proxy, logout from BE etc.)</p>
<a name="Actual-result"></a>
<h2 >Actual result<a href="#Actual-result" class="wiki-anchor">¶</a></h2>
<p>The hidden elements are displayed even if not logged in.</p>
<a name="Expected-Result"></a>
<h2 >Expected Result<a href="#Expected-Result" class="wiki-anchor">¶</a></h2>
<p>The hidden elements should not get displayed if not logged in</p> TYPO3 Core - Bug #89378 (Closed): Preprossing of URLs for conversion to punycode truncates some URLshttp://forge.typo3.org/issues/893782019-10-08T18:38:06ZSybille Peterssypets@gmx.de
<p>The function ExternalLinktype::preprocessUrl truncates some URLs into an empty string.</p>
<p>The function was originally introduced in order to enable URLs with Umlaut in domains, e.g. <a class="external" href="https://äh.de">https://äh.de</a></p>
<p>These are some of the URLs the function converts into empty strings:</p>
<pre>
https://www.nbank.de/Unternehmen/Ausbildung-Qualifikation/Weiterbildung-in-Niedersachsen/
https://www.oldenburg.de/startseite/wirtschaft/wirtschaftsfoerderung/beratung-foerderung/gruenderberatung/gruenderforen.html
http://www.nwzonline.de/tv?bcpid=1701167454001&amp;amp;amp;bckey=AQ~~,AAAAAGL7LqU~,aXlKNnCf9d9Tmck-kOc4PGFfCgHjM5JR&amp;amp;amp;bctid=1040702768001
http://www.uni-bremen.de/universitaet/die-uni-im-ueberblick/lageplan/gebaeude/building/120
</pre><br />These will then falsely be reported as broken links.
<p>The function preprocessUrl was originally introduced to handle domains with special characters, see <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: No conversion to punycode (Closed)" href="http://forge.typo3.org/issues/55155">#55155</a></p> TYPO3 Core - Bug #88079 (Closed): Multi-selection mode in List module does not work anymorehttp://forge.typo3.org/issues/880792019-04-04T11:10:41ZSybille Peterssypets@gmx.de
<p>Tested this in latest master:</p>
<p>When clicking on one of the Clipboard modes (e.g. "Clipboard #1 (multi-selection mode), you usually get checkboxes for the records above. Also, the action icons do not appear where they usually do.</p>
<p>This works for me in 9.5 branch, but not in master.</p>
<p><strong>TYPO3 9:</strong></p>
<p><img src="http://forge.typo3.org/attachments/download/34222/typo3_9.png" alt="" loading="lazy" /></p>
<p><strong>TYPO3 10:</strong></p>
<p><img src="http://forge.typo3.org/attachments/download/34221/typo3_10.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #88006 (Closed): Error in Changelog breaks renderinghttp://forge.typo3.org/issues/880062019-03-26T11:39:58ZSybille Peterssypets@gmx.de
<p>This file is in the wrong place:</p>
<p>typo3/sysext/core/Documentation/Changelog/Breaking-87937-TCAOption_selicon_field_path_removed.rst</p>
<p>In any case, the path to Includes.txt is wrong:</p>
<pre><code class="text syntaxhl" data-language="text">.. include:: ../../Includes.txt
</code></pre>
<p>It should be:<br /><pre><code class="text syntaxhl" data-language="text">.. include:: ../Includes.txt
</code></pre></p>
<p>Or rather the file should be moved.</p>
<p>This breaks the rendering:</p>
<pre><code class="text syntaxhl" data-language="text">==================================================
16-Convert-and-fix-and-check/run_04-Check-included-files.py
exitcode: 3
</code></pre>
<p>...</p>
<pre><code class="text syntaxhl" data-language="text">We saw these exitcodes (code, count):
{
"0": 53,
"3": 1,
"22": 7
}
</code></pre>
<p>See <a href="https://docs.typo3.org/typo3cms/HowToDocument/RenderingDocs/Troubleshooting.html" class="external">Troubleshooting</a></p> TYPO3 Core - Bug #84573 (Closed): Translated deactivated elements are not displayed in page modehttp://forge.typo3.org/issues/845732018-03-31T22:52:11ZSybille Peterssypets@gmx.de
<p>Translated, not activated (hidden) elements are not displayed in page mode. They are visible in list mode, though. Once the elements are activated (unhidden), they are displayed in page mode. Bug seems unrelated to type of element (tested with "Text & Media" and "Bootstrap Carousel").</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Create elements, e.g. "Text & Media" </li>
<li>In "page" module, select "Languages", use the "Translate" button (I used translate mode, not copy - don't know if this is relevant)</li>
</ol>
<a name="Screenshots"></a>
<h2 >Screenshots<a href="#Screenshots" class="wiki-anchor">¶</a></h2>
<p>page mode: 2 translated elements are missing.</p>
<p><img src="http://forge.typo3.org/attachments/download/33340/disappeared-elements-in-page-mode.png" loading="lazy" style="width:600px;" alt="" /></p>
<p>list mode: all elements are displayed.</p>
<p><img src="http://forge.typo3.org/attachments/download/33341/disappeared-elements-n-list-mode.png" loading="lazy" style="width:600px;" alt="" /></p>