TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-07-21T14:45:59ZTYPO3 Forge
Redmine TYPO3 Core - Bug #101408 (Accepted): Fluid debug output is displayed on page even if adminpanel n...http://forge.typo3.org/issues/1014082023-07-21T14:45:59ZSybille Peterssypets@gmx.de
<p>This probably was reported before, but was then fixed and has now reappeared: <a class="external" href="https://forge.typo3.org/issues/85087">https://forge.typo3.org/issues/85087</a></p>
<p>I usually don't use Fluid debug output in adminpanel and usually don't enable it on production but I did that recently by accident.</p>
<p>Several days later I loaded a page, the debug output was displayed, the admin panel was not even activated.</p>
<p>What made matters worse, the debug output was also displayed if not logged in the BE (using different browser).</p>
<a name="versions"></a>
<h2 >versions<a href="#versions" class="wiki-anchor">¶</a></h2>
<ul>
<li>reproduced in v11, did not check newer versions yet.</li>
</ul>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>1. Flush all cache (including system cache)<br />2. Enable admin panel <br />3. Activate checkbox "Fluid debug output" <br />4. Load page: debug output is displayed) (ok)<br />5. deactivate adminpanel (via the toggle)<br />6. load page again: debug output is displayed (unexpected)<br />7. load page in different browser (not logged in): debug output is displayed (bad)<br />8. Deactivate the checkbox "Fluid debug output" <br />9. refresh page CTRL-SHIFT-r (or flush cache in adminpanel): debug output still displayed</p>
<p>finally, flush cache</p>
<pre>
vendor/bin/typo3 cache:flush
</pre>
<p>Is now ok</p>
<a name="Suggestion"></a>
<h2 >Suggestion<a href="#Suggestion" class="wiki-anchor">¶</a></h2>
<p>I think this should be changed (at least in production context)</p>
<ul>
<li>the debug output should not be saved</li>
<li>or better: not possible to enable "Fluid debug" checkbox in production context</li>
</ul>
<a name="Screenshot"></a>
<h2 >Screenshot<a href="#Screenshot" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/37842/adminpanel_fluid.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #101119 (Closed): SoftReferenceParserFactory has 2 required constructor argument...http://forge.typo3.org/issues/1011192023-06-19T10:17:11ZSybille Peterssypets@gmx.de
<p><strong>Update</strong> : It should be possible to get an instance of an object with GeneralUtility::makeInstance which is instantiated with DI without the constructor arguments (at least from looking at makeInstance).</p>
<p>I am still investigating how to reproduce this, what is exactly the problem and if it is a core bug ....</p>
<hr />
<p>core SoftReferenceParserFactory.php constructor has 2 arguments, but is instantiated without arguments in ReferenceIndex.php if object not passed in constructor.</p>
<p>This occurred after installation of causal/extractor and only in combination with specific other extensions. I have not been able to narrow it down. The exception appears when opening "Extension Configuration".</p>
<p>Anyhow, the code in the core looks wrong:</p>
<p>in /typo3/sysext/core/Classes/Database/ReferenceIndex.php line 126</p>
<pre>
$this->softReferenceParserFactory = $softReferenceParserFactory ?? GeneralUtility::makeInstance(SoftReferenceParserFactory::class);
</pre>
<p>typo3/sysext/core/Classes/DataHandling/SoftReference/SoftReferenceParserFactory.php line 33</p>
<pre>
public function __construct(FrontendInterface $runtimeCache, LoggerInterface $logger)
</pre>
<p>instantiated in FileIndexRepository line 339</p>
<pre>
public function updateRefIndex($id)
{
$refIndexObj = GeneralUtility::makeInstance(ReferenceIndex::class);
</pre>
<a name="Versions"></a>
<h2 >Versions<a href="#Versions" class="wiki-anchor">¶</a></h2>
<ul>
<li>reproduced with 11.5.28, not checked with v12 / main</li>
</ul>
<a name="Exception-stack-trace"></a>
<h2 >Exception stack trace<a href="#Exception-stack-trace" class="wiki-anchor">¶</a></h2>
<p>see file exception_extconf.txt (linked below)</p> TYPO3 Core - Task #99772 (Closed): Deprecate TCA renderType="inputLink" at some pointhttp://forge.typo3.org/issues/997722023-01-31T14:09:48ZSybille Peterssypets@gmx.de
<p>The type="input", renderType="inputLink" was replaced in TYPO3 v12 with type="link", however the inputLink still works. At some point it can be deprecated and removed.</p>
<p>typo3/sysext/backend/Migrations/Code/ClassAliasMap.php:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">return</span> <span class="p">[</span>
<span class="s1">'TYPO3\\CMS\\Backend\\Form\\Element\\InputLinkElement'</span> <span class="o">=></span> <span class="nc">\TYPO3\CMS\Backend\Form\Element\LinkElement</span><span class="o">::</span><span class="n">class</span><span class="p">,</span>
</code></pre> TYPO3 Core - Bug #96449 (Closed): Exception with Adminpanel activatedhttp://forge.typo3.org/issues/964492022-01-02T14:56:12ZSybille Peterssypets@gmx.de
<p>Can be reproduced with latest "main" branch (12-dev).</p>
<pre>
1/1) TypeError
TYPO3\CMS\Core\TimeTracker\TimeTracker::fixContent(): Argument #1 ($arr) must be of type array, null given, called in /var/www/html/typo3/sysext/core/Classes/TimeTracker/TimeTracker.php on line 328
in /var/www/html/typo3/sysext/core/Classes/TimeTracker/TimeTracker.php line 437
* @param string $depthData Prefixed icons for new PM icons
* @param string $vKey Seems to be the previous tsStackLog key
* @return string Returns the $content string generated/modified. Also the $arr array is modified!
*/
protected function fixContent(array &$arr, string $content, string $depthData = '', string $vKey = ''): string
{
$entriesCount = 0;
$c = 0;
// First, find number of entries
</pre>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>1. Created new installation following instructions <a class="external" href="https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/SettingUpTypo3Ddev.html">https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/SettingUpTypo3Ddev.html</a> (with PHP 8.0)<br />2. Created empty root page page with default TypoScript (Hello World)</p>
<pre>
# Default PAGE object:
page = PAGE
page.10 = TEXT
page.10.value = HELLO WORLD!
</pre>
<p>3. Enable adminpanel</p>
<pre>
config.admPanel = 1
</pre>
<p>4. Load page in frontend</p>
<p>5. Activate adminpanel on bottom right</p>
<p>Exception occurs</p> TYPO3 Core - Feature #96024 (Closed): Show state of page - visible or not in FE if logged in (e.g...http://forge.typo3.org/issues/960242021-11-18T10:02:53ZSybille Peterssypets@gmx.de
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ul>
<li>load hidden page in FE. Though adminpanel is enabled, there is no indication if page is (normally) visible in FE (not logged in). Not as admin, not as regular editor.</li>
</ul>
<a name="Use-case"></a>
<h2 >Use case<a href="#Use-case" class="wiki-anchor">¶</a></h2>
<p>If you load a page not via a page tree, but for example by testing redirects and you are currently logged in it is confusing because you don't see immediately the state of the page. You have to load the page in other browser or check in database or page tree.</p>
<p>We show lots of information in admin-panel. We could probably show too some status on page, e.g. is visible.</p>
<p>Should take hidden, l18n_cfg ("Hide default language of page", "Hide page if no translation for current language exists"), fe_group etc. into account - same as loading page in FE if not logged in.</p>
<a name="Related"></a>
<h2 >Related<a href="#Related" class="wiki-anchor">¶</a></h2>
<p>I am also not sure why the page is displayed at all, "Show hidden pages" is not activated (in adminpanel). It seems the behaviour changed, confirmed with master 11-dev. But for me, this is preferable, it just makes the checkbox redundant. "Show hidden pages"</p> TYPO3 Core - Bug #94597 (Closed): Hard reload does not clear cache if adminpanel is activatedhttp://forge.typo3.org/issues/945972021-07-20T10:27:44ZSybille Peterssypets@gmx.de
<p>The behaviour of hard refresh (e.g. CTRL-F5 or CTRL-SHIFT-r etc.) is different, depending on if the admin panel is active or not.</p>
<p>Previously, hard refresh could always be used to flush page cache for a page and regenerate it.</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>With adminpanel</p>
<p>1. Create a page with some content which will change often (e.g. show current time in a plugin) or use this TypoScript:</p>
<pre>
page >
page = PAGE
page.10 = TEXT
page.10.data = date:U
page.10.strftime = %A %d, %B %Y %H:%M:%S
</pre>
<p>2. Open this in the browser with adminpanel activated<br />3. Load page in a different browser (not logged in backend) to make sure cache is filled<br />4. hard reload on page with logged in backend<br />5. Load page in different browser (not logged in backend) again to show page as loaded on cache</p>
<p>Repeat this with adminpanel deactivated (is enough to press toggle for switching adminpanel off in FE on bottom right).</p>
<a name="Results"></a>
<h2 >Results<a href="#Results" class="wiki-anchor">¶</a></h2>
<p>The result will be different if adminpanel is deactivated. If adminpanel is deactivated, the cache will not be flushed. In the not logged in browser, the old content will still be displayed.</p>
<a name="Settings"></a>
<h2 >Settings<a href="#Settings" class="wiki-anchor">¶</a></h2>
<p>Settings in adminpanel using defaults ("No caching" is off. In fact "No caching" seems to have no effect in this case. The page loaded with adminpanel on is always updated. It seems to always generate the page, not use the cache.)</p>
<a name="Versions"></a>
<h2 >Versions<a href="#Versions" class="wiki-anchor">¶</a></h2>
<ul>
<li>TYPO3 10.4.17</li>
<li>current master (11)</li>
</ul>
<a name="PRoblem"></a>
<h2 >PRoblem<a href="#PRoblem" class="wiki-anchor">¶</a></h2>
<p>This way, the editor can only use hard reload if adminpanel is disabled, with adminpanel he must click on "flush cache of current page".</p>
<p>The hard reload was a convenient method for the rare cases where manual cache flushing is necessary. It was also a convenient method to also flush data from the caching framework (e.g. if used by extensions). Simply using the lighning symbol would not work (because it only flushes and does not regenerate). But with hard-reload, the extension could check if page is reloaded with hard-reload and not get data from caching framework but fetch it fresh.</p>
<a name="Solution"></a>
<h2 >Solution<a href="#Solution" class="wiki-anchor">¶</a></h2>
<p>The solution might be to flush cache on hard-refresh if adminpanel is active. If this should not be done, it might help to add this information to the documentation.</p>
<a name="Documentation"></a>
<h2 >Documentation<a href="#Documentation" class="wiki-anchor">¶</a></h2>
<p>I can no longer find the information about hard reload in the documentation. I am pretty sure, it used to be there. It is still supported, it is in the core.</p>
<a name="Code"></a>
<h2 >Code<a href="#Code" class="wiki-anchor">¶</a></h2>
<p>typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php</p>
<pre><code class="php syntaxhl" data-language="php"><span class="cd">/**
* Detecting if shift-reload has been clicked
* Will not be called if re-generation of page happens by other reasons (for instance that the page is not in cache yet!)
* Also, a backend user MUST be logged in for the shift-reload to be detected due to DoS-attack-security reasons.
*
* @param ServerRequestInterface|null $request
* @return bool If shift-reload in client browser has been clicked, disable getting cached page (and regenerate it).
*/</span>
<span class="k">public</span> <span class="k">function</span> <span class="n">headerNoCache</span><span class="p">(</span><span class="kt">ServerRequestInterface</span> <span class="nv">$request</span> <span class="o">=</span> <span class="kc">null</span><span class="p">)</span>
<span class="p">{</span>
<span class="k">if</span> <span class="p">(</span><span class="nv">$request</span> <span class="k">instanceof</span> <span class="nc">ServerRequestInterface</span><span class="p">)</span> <span class="p">{</span>
<span class="nv">$serverParams</span> <span class="o">=</span> <span class="nv">$request</span><span class="o">-></span><span class="nf">getServerParams</span><span class="p">();</span>
<span class="p">}</span> <span class="k">else</span> <span class="p">{</span>
<span class="nv">$serverParams</span> <span class="o">=</span> <span class="nv">$_SERVER</span><span class="p">;</span>
<span class="p">}</span>
<span class="nv">$disableAcquireCacheData</span> <span class="o">=</span> <span class="kc">false</span><span class="p">;</span>
<span class="k">if</span> <span class="p">(</span><span class="nv">$this</span><span class="o">-></span><span class="nf">isBackendUserLoggedIn</span><span class="p">())</span> <span class="p">{</span>
<span class="k">if</span> <span class="p">(</span><span class="nb">strtolower</span><span class="p">(</span><span class="nv">$serverParams</span><span class="p">[</span><span class="s1">'HTTP_CACHE_CONTROL'</span><span class="p">]</span> <span class="o">??</span> <span class="s1">''</span><span class="p">)</span> <span class="o">===</span> <span class="s1">'no-cache'</span> <span class="o">||</span> <span class="nb">strtolower</span><span class="p">(</span><span class="nv">$serverParams</span><span class="p">[</span><span class="s1">'HTTP_PRAGMA'</span><span class="p">]</span> <span class="o">??</span> <span class="s1">''</span><span class="p">)</span> <span class="o">===</span> <span class="s1">'no-cache'</span><span class="p">)</span> <span class="p">{</span>
<span class="nv">$disableAcquireCacheData</span> <span class="o">=</span> <span class="kc">true</span><span class="p">;</span>
<span class="p">}</span>
<span class="p">}</span>
<span class="c1">// Call hook for possible by-pass of requiring of page cache (for recaching purpose)</span>
<span class="nv">$_params</span> <span class="o">=</span> <span class="p">[</span><span class="s1">'pObj'</span> <span class="o">=></span> <span class="o">&</span><span class="nv">$this</span><span class="p">,</span> <span class="s1">'disableAcquireCacheData'</span> <span class="o">=></span> <span class="o">&</span><span class="nv">$disableAcquireCacheData</span><span class="p">];</span>
<span class="k">foreach</span> <span class="p">(</span><span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TYPO3_CONF_VARS'</span><span class="p">][</span><span class="s1">'SC_OPTIONS'</span><span class="p">][</span><span class="s1">'tslib/class.tslib_fe.php'</span><span class="p">][</span><span class="s1">'headerNoCache'</span><span class="p">]</span> <span class="o">??</span> <span class="p">[]</span> <span class="k">as</span> <span class="nv">$_funcRef</span><span class="p">)</span> <span class="p">{</span>
<span class="nc">GeneralUtility</span><span class="o">::</span><span class="nf">callUserFunction</span><span class="p">(</span><span class="nv">$_funcRef</span><span class="p">,</span> <span class="nv">$_params</span><span class="p">,</span> <span class="nv">$this</span><span class="p">);</span>
<span class="p">}</span>
<span class="k">return</span> <span class="nv">$disableAcquireCacheData</span><span class="p">;</span>
<span class="p">}</span>
</code></pre> TYPO3 Core - Bug #94596 (Closed): How to deactivate "simulate time" in adminpanel? Status of simu...http://forge.typo3.org/issues/945962021-07-20T09:20:28ZSybille Peterssypets@gmx.de
<p>Currently, I have a problem because I am not sure if my simulate time settings are active and how to deactivate them.</p>
<p>With "Usergroup" I can explicitly select a blank option in the list and thus deactivate it. With "simulate time" there is no such option and I am unsure how to deactivate it.</p>
<p>In addition to this, no matter what I select for the date, the date looks greyed out.</p>
<p>Also, when I select a usergroup, there used to be GET-Parameters in the URL. This is no longer the case and I am unsure if this is actually working. I can test it, but I am currently trying to figure out something else and all this is making it really difficult.</p>
<p>This may be browser thing because the browser may display the form fields differently, but IMHO this should be well usable in any browser and there should be a clear indication if the simulation is on - <strong>maybe even with an additional warning on top if any simulation is activated</strong> .</p>
<p>I already had several problems with this with people reporting bugs and overlooking that they had activated the usergroup simulation or myself trying to find out how cache flushing works in combination with the adminpanel etc.</p>
<p>Apart from some things actually being buggy or being not sure if they are working correctly, see <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: TYPO3 v9.1.15 Admin-Panel, Simulate FE-Time not working (Closed)" href="http://forge.typo3.org/issues/91225">#91225</a>.</p>
<a name="Versions"></a>
<h2 >Versions<a href="#Versions" class="wiki-anchor">¶</a></h2>
<ul>
<li>TYPO3 10.4.17</li>
</ul>
<a name="Screenshots"></a>
<h2 >Screenshots<a href="#Screenshots" class="wiki-anchor">¶</a></h2>
<p>With chromium browser, after selecting a date:</p>
<p><img src="http://forge.typo3.org/attachments/download/36189/simulate_time.png" alt="" loading="lazy" /></p>
<p>(date looks greyed out to me, time does not)</p> TYPO3 Core - Bug #92972 (New): Softref parsers should take syntax format of field into accounthttp://forge.typo3.org/issues/929722020-12-02T11:08:42ZSybille Peterssypets@gmx.de
<a name="Suggestion"></a>
<h2 >Suggestion<a href="#Suggestion" class="wiki-anchor">¶</a></h2>
<ul>
<li>make it possible to always set "format" for TCA column type "text" and "input" </li>
<li>use the format in the softref parsers</li>
</ul>
<a name="Explanation"></a>
<h2 >Explanation<a href="#Explanation" class="wiki-anchor">¶</a></h2>
<p>Currently, AFAIK, the softref parser does not evaluate what format the field has. Possible formats can be HTML (e.g. tt_content.bodytext), plain text, TypoScript (e.g. sys_template.config, sys_template.constants), comma separated list.</p>
<p>The <a href="https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/textT3editor.html#format" class="external">format</a> can already (partly) be set in TCA, but only if type is 'text' and 'renderType' is 't3editor', for example as 'typoscript' for sys_template.config.</p>
<p>Since t3editor is used only for typoscript it does not really seem to make sense that the format can be set for this renderType but not for renderType default.</p>
<blockquote>
<p>renderType='t3editor': System extension “t3editor” provides an enhanced textarea for TypoScript input</p>
</blockquote>
<blockquote>
<p>format: The value specifies the language t3editor should handle. Allowed values: css, html, javascript, php, typoscript, xml</p>
</blockquote>
<p>For tt_content.bodytext neither renderType nor format are set.</p>
<p>If this is handled consistently, you would not have to pass 'linklist' to the softref parser, but read this from format as well (e.g. for findRef_typolink()).</p>
<p>By being able to handle the formatting consistently in all softref parsers, it might be possible to simplify things and also avoid inconsistencies.</p>
<a name="Examples"></a>
<h1 >Examples:<a href="#Examples" class="wiki-anchor">¶</a></h1>
<p>Currently, URLs <strong>in comments</strong> in sys_template config or constants are added to the reference index, e.g.</p>
<pre>
sys_template.config:
# https://example.org
</pre>
<p>When saved, this record is created:</p>
<pre>
+----------------------------------+--------------+--------+--------+-------------+-------------+------------+---------+---------+-----------+-----------+---------+---------------------+
| hash | tablename | recuid | field | flexpointer | softref_key | softref_id | sorting | deleted | workspace | ref_table | ref_uid | ref_string |
+----------------------------------+--------------+--------+--------+-------------+-------------+------------+---------+---------+-----------+-----------+---------+---------------------+
| a7ad94098b4c8ea1293af92fcd8be9b5 | sys_template | 2 | config | | url | 2 | -1 | 0 | 0 | _STRING | 0 | https://example.org |
+----------------------------------+--------------+--------+--------+-------------+-------------+------------+---------+---------+-----------+-----------+---------+---------------------+
</pre>
<p>If TypoScript were parsed correctly, this should not happen.</p>
<p>(Not sure why URLs in TypoScript are added to reference index in the first place and whether this has any benefit).</p> TYPO3 Core - Bug #92546 (Closed): Misleading errror message for pagetree if user has no access to...http://forge.typo3.org/issues/925462020-10-12T14:31:31ZSybille Peterssypets@gmx.de
<pre><code class="text syntaxhl" data-language="text">Page tree error
Got unexpected response from the server. Please check logs for details.
</code></pre>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Create user / group which has no access to the pages, e.g. the page belongs to different user / group and "Everybody" has no access:</li>
</ol>
<p><img src="http://forge.typo3.org/attachments/download/35523/permissions.png" alt="" loading="lazy" /></p>
<a name="Expected"></a>
<h2 >Expected<a href="#Expected" class="wiki-anchor">¶</a></h2>
<p>It is correct that the user has no access but the error message is misleading.</p> TYPO3 Core - Bug #92541 (New): Text of flash message is misleading for JavaScript errorshttp://forge.typo3.org/issues/925412020-10-12T11:53:07ZSybille Peterssypets@gmx.de
<p>Example: Page tree error message</p>
<pre><code class="text syntaxhl" data-language="text">Page tree error
Got unexpected response from the server. Please check logs for details.
</code></pre>
<p>When I get this type of error, the logs are usually empty. This is usually a JavaScript error displayed in browser console.</p>
<p>It would be great if error message which recommends to look in logs is only given if error has been logged.</p>
<p>Would be great if user got a different hint if there has been a JavaScript error.</p> TYPO3 Core - Feature #92193 (New): Make console commands (directly) visible in list of scheduler ...http://forge.typo3.org/issues/921932020-09-04T09:55:26ZSybille Peterssypets@gmx.de
<p>When you create a new task in the scheduler, you can see a list of available tasks in Class.</p>
<p><img src="http://forge.typo3.org/attachments/download/35430/scheduler1.png" alt="" loading="lazy" /></p>
<p>Here, you have to select "Execute console commands" to see a list of the console commands.</p>
<p>This makes the usability a bit clunky, because you do not have a full list of what is available. You have to choose "console command" and only then do you see the console commands (or not).</p>
<p>Extension authors may want to make their schedulable tasks available as console commands because this adds more flexibility (as they can be called on the console or via cron directly). However, having the commands then be a bit hidden is a downside of this.</p>
<a name="Possible-solution"></a>
<h2 >Possible solution<a href="#Possible-solution" class="wiki-anchor">¶</a></h2>
<ul>
<li>add the console commands to the list of scheduler tasks to be visible like any other scheduler task.</li>
</ul> TYPO3 Core - Task #91977 (Rejected): Code cleanup in ExtensionListCommandhttp://forge.typo3.org/issues/919772020-08-11T15:01:15ZSybille Peterssypets@gmx.deTYPO3 Core - Task #87176 (Closed): Add git setup script for core developmenthttp://forge.typo3.org/issues/871762018-12-16T23:33:05ZSybille Peterssypets@gmx.de
<p>Currently, several commands must be executed manually. Some of these, can't just be copy-pasted, because user-specific options must be added to commands (email address, username, etc.).</p>
<p>A script can be added, which makes the setup easier.</p>
<p>Currently, you must execute the following commands:</p>
<pre><code class="text syntaxhl" data-language="text">git config user.name "Your Name"
git config user.email "your-email@example.com"
git config branch.autosetuprebase remote
# usually, not required
mkdir -p .git/hooks
cp Build/git-hooks/commit-msg .git/hooks/commit-msg
# make executable (usually not required)
chmod +x .git/hooks/commit-msg
# optional
cp Build/git-hooks/unix+mac/pre-commit .git/hooks/
chmod +x .git/hooks/pre-commit
git config url."ssh://<YOUR_TYPO3_USERNAME>@review.typo3.org:29418".pushInsteadOf git://git.typo3.org
# optional
git config commit.template ~/.gitmessage.txt
</code></pre>
<p>See <a class="external" href="https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/Git/Index.html">https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/Git/Index.html</a></p> TYPO3 Core - Bug #85386 (Closed): Fix inconsistency of command line arguments, help output and d...http://forge.typo3.org/issues/853862018-06-25T17:57:40ZSybille Peterssypets@gmx.de
<p>Note: Closed for now, until researched further. Initially noticed that documentation partly does not fit behaviour or may be a little difficult to understand.</p>
<p>There seems to be also an issue with inconsistency of some options and the help output.</p>
<p><strong>1. Some commands have --dry-run in their help message and some do not</strong></p>
<ul>
<li>cleanup:deletedrecords : does not</li>
<li>cleanup:multiplereferencedfiles : does</li>
</ul>
<p>Weird that deletedrecords should suddenly not support dry-run</p>
<blockquote><blockquote>
<p>this needs to be researched further, not really a problem of the docs, though.</p>
</blockquote></blockquote>
<p><a class="external" href="https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/lowlevel/README.rst">https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/lowlevel/README.rst</a></p>
<p>In TYPO3 7 there where some common options so you could execute the commands without problems in a loop using a generic commmand line, e.g.</p>
<pre><code class="text syntaxhl" data-language="text">for tag in $tags;do
if [[ $cmd == fix ]];then
# fix
php ./typo3/cli_dispatch.phpsh lowlevel_cleaner $tag -r -s -v 2 --AUTOFIX --YES --refindex update
else
# dry-run
php ./typo3/cli_dispatch.phpsh lowlevel_cleaner $tag -r -s -v 2 --dryrun
fi
done
</code></pre>
<p>Having --dryrun <strong>and</strong> --AUTOFIX makes absolutely no sense, so it is better now, but it should be easier to use.</p>
<p><strong>2. Usage:</strong></p>
<pre><code class="text syntaxhl" data-language="text"> help [options] [--] [<command_name>]
Arguments:
command The command to execute
command_name The command name [default: "help"]
</code></pre>
<p>Not very inuitive</p>
<ul>
<li>where is 'command' in the usage at the top?</li>
</ul>
<p><strong>3. Two different help messages with help and --help.</strong></p>
<p>The output with --help is confusing (--help is documented), the output of help is better. Maybe better to document only help (and not --help and remove that)</p>
<p>e.g <br /><pre><code class="text syntaxhl" data-language="text">php ./typo3/sysext/core/bin/typo3 help cleanup:multiplereferencedfiles
</code></pre></p> TYPO3 Core - Bug #37467 (Closed): Change in class.t3lib_div.php may break things for HTTPS via re...http://forge.typo3.org/issues/374672012-05-24T14:51:11ZSybille Peterssypets@gmx.de
<p>The change introduced in TYPO3 4.5.16 as fix for bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Wrong HTTP protocol in combination with a proxy (Closed)" href="http://forge.typo3.org/issues/36004">#36004</a> makes working in backend impossible for some HTTPS reverse-proxy configurations.</p>
<p>It may be a misconfiguration on our end, but as far as I can see, since the change HTTPS will only work with reverse proxy, if <strong>X-Forwarded-For</strong> contains local and proxy IP and</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="err">$</span><span class="p">[</span><span class="s1">'TYPO3_CONF_VARS'</span><span class="p">][</span><span class="s1">'SYS'</span><span class="p">][</span><span class="s1">'reverseProxyHeaderMultiValue'</span> <span class="o">=</span> <span class="s2">"last"</span><span class="p">;</span>
</code></pre>
<p>Login to backend works, but then a network connections error is displayed (<em>"Verbindungsproblem Bei dem Versuch eine Verbindung zum Server herzustellen ist ein Fehler aufgetreten. Bitte überprüfen Sie Ihre Netzwerkverbindung."</em>)</p>
<p>Analyzing this shows that the changed line 4151 in class.t3lib_div.php has caused this problem:</p>
<p>older version:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">(</span><span class="k">self</span><span class="o">::</span><span class="nf">cmpIP</span><span class="p">(</span><span class="nv">$_SERVER</span><span class="p">[</span><span class="s1">'REMOTE_ADDR'</span><span class="p">],</span> <span class="nv">$proxySSL</span><span class="p">))</span> <span class="p">{</span>
</code></pre>
<p>newer version:<br /><pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">(</span><span class="k">self</span><span class="o">::</span><span class="nf">cmpIP</span><span class="p">(</span><span class="k">self</span><span class="o">::</span><span class="nf">getIndpEnv</span><span class="p">(</span><span class="s1">'REMOTE_ADDR'</span><span class="p">),</span> <span class="nv">$proxySSL</span><span class="p">))</span> <span class="p">{</span>
</code></pre></p>