TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692024-03-27T17:18:45ZTYPO3 Forge
Redmine TYPO3 Core - Bug #103494 (Under Review): Linkvalidator uses tstamp field directly without checkin...http://forge.typo3.org/issues/1034942024-03-27T17:18:45ZSybille Peterssypets@gmx.de
<p><strong>This should be merged before <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612">https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612</a></strong></p>
<p>TCA should be used to determine which field is relevant for tstamp (and if there is such a field) before using it for a DB query</p>
<p>$GLOBALS['TCA'][$table]['ctrl']['tstamp']</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Change configuration to mod.linkvalidator.searchFields.sys_redirect.target</li>
<li>check links (with a broken redirect target)</li>
<li>in the list of broken links, click pencil to edit redirect target field</li>
<li>close edit field</li>
</ol>
<p>Now, exception is thrown.</p> TYPO3 Core - Task #101934 (Closed): Cleanup code for ContentObjectRenderer::listNum and add testshttp://forge.typo3.org/issues/1019342023-09-17T12:18:16ZSybille Peterssypets@gmx.de
<p>- Add unit tests for function ContentObjectRenderer::listNum.<br />- Improve code by renaming function argument ($char => $delimeter)<br />- Make sure arguments are always passed as strings (and not null)<br /> (as declared in PHPDoc)<br />- Improve clarity of description in PHPDoc</p>
<p>In the future typehints can be added for function arguments and<br />return type.</p> TYPO3 Core - Task #101716 (Closed): Improve changelog Breaking-100229-ConvertJSConfirmationToBitS...http://forge.typo3.org/issues/1017162023-08-20T08:45:00ZSybille Peterssypets@gmx.de
<p><a class="external" href="https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100229-ConvertJSConfirmationToBitSet.html">https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100229-ConvertJSConfirmationToBitSet.html</a></p>
<p>The improvements are pretty minimal and not strictly necessary (except for the formatting). Normally, I would not start a patch for this, but there is already a patch <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/80599">https://review.typo3.org/c/Packages/TYPO3.CMS/+/80599</a> where I first intended to make more changes (in particular the formatting of the bullet lists), but was deemed as too much.</p>
<p>1. bullet lists should have a newline before and after, otherwise they will not be rendered correctly, see <a class="external" href="https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100229-ConvertJSConfirmationToBitSet.html#impact">https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-100229-ConvertJSConfirmationToBitSet.html#impact</a>: matches, setValue and isValid is a list</p>
<p>2. \TYPO3\CMS\Core\Type\Bitmask\JSConfirmation::method should be \TYPO3\CMS\Core\Type\Bitmask\JSConfirmation?</p>
<p>3. "calling public methods methods" should be "calling public methods"</p>
<p>4. The part for BackendUserAuthentication->jsConfirmation() in "Affected installations" could be rephrased for "affected installations"</p> TYPO3 Core - Task #101715 (Closed): Fix syntax for lists in .rst fileshttp://forge.typo3.org/issues/1017152023-08-20T08:18:19ZSybille Peterssypets@gmx.de
<p><a class="external" href="https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/WritingReST/CommonPitfalls/Lists.html">https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/WritingReST/CommonPitfalls/Lists.html</a></p> TYPO3 Core - Task #99986 (Closed): Cleanup TSFE::addCacheTagshttp://forge.typo3.org/issues/999862023-02-19T10:41:35ZSybille Peterssypets@gmx.de
<p>addCacheTags used array_merge but not array_unique. In another place in the core, array_merge and array_unique were used. Theoretically, a cache tag can be added multiple times which should not a huge problem, but is unnecessary</p> TYPO3 Core - Task #96015 (Closed): Remove unused language labelshttp://forge.typo3.org/issues/960152021-11-17T18:32:32ZSybille Peterssypets@gmx.de
LLL:EXT:redirects/Resources/Private/Language/locallang_module_redirect.xlf:
<ul>
<li>source_host</li>
<li>source_path</li>
<li>destination</li>
<li>hits</li>
<li>hit_last</li>
<li>filter.destination</li>
</ul> TYPO3 Core - Task #95832 (Closed): Discrepancies in text in BE UI for redirects modulehttp://forge.typo3.org/issues/958322021-10-31T08:21:29ZSybille Peterssypets@gmx.de
<p>The redirects module has a list and an edit form which reflect the exact same fields in sys_redirect, but the labels are slightly different.</p>
<p>the suggested preferred solution is marked with "Preferred"</p>
<pre>
list: "Source Host" (LL: source_host)
edit: "Source Domain" (LL: "sys_redirect.source_host)
filter: "Source Host"
list: "Destination" (LL: destination)
edit: "Target" (LL: sys_redirect.target)
filter: "Destination (Path or Page ID)" (LL: filter.destination)
list: "# Hits" (LL: hits)
edit: "Count" (LL: sys_redirect.hitcount)
list: "Last Hit on" (LL: hit_last)
edit: "Last Hit On" (LL: sys_redirect.lasthiton)
</pre>
<p><strong>Note: for hit count, a different text might be better, but we cannot introduce a new language label at this point so it is better to work with what we have.</strong></p>
<p>edit:<br /><img src="http://forge.typo3.org/attachments/download/36561/redirects_edit.png" alt="" loading="lazy" /></p>
<p>list:<br /><img src="http://forge.typo3.org/attachments/download/36560/redirects_list.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #95191 (Closed): Less visible difference between "disabled" buttons and not "dis...http://forge.typo3.org/issues/951912021-09-12T05:05:15ZSybille Peterssypets@gmx.de
<p>Some of the buttons in the pagination button group of the redirects (and other) module are disabled if they do not apply.</p>
<p>In TYPO3 v10 the difference in styling between the active and disabled buttons was more noticeable. Since v11 this has changed so it is more difficult to see the difference between the active and not active buttons.</p>
<p>This may be an issue for accessibility, but also a general issue.</p>
<a name="Examples"></a>
<h1 >Examples<a href="#Examples" class="wiki-anchor">¶</a></h1>
<p>The buttons on the left side (|< <<) are disabled. The ones on the right side (>> >|) are not.</p>
<a name="TYPO3-v10"></a>
<h2 >TYPO3 v10<a href="#TYPO3-v10" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/36347/redirects_pagination_v10.png" alt="" loading="lazy" /></p>
<p>color: rgb(215,215,215) = #d7d7d7</p>
<a name="TYPO3-v11"></a>
<h2 >TYPO3 v11<a href="#TYPO3-v11" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/36348/redirects_pagination_v11.png" alt="" loading="lazy" /></p>
<p>color: rgb(115,115,115) = #737373</p> TYPO3 Core - Task #94473 (Rejected): Optimize texts for the "copy" and "translate" descriptionhttp://forge.typo3.org/issues/944732021-07-02T13:22:01ZSybille Peterssypets@gmx.de
<a name="Possible-problems-and-room-for-improvement"></a>
<h2 >Possible problems and room for improvement<a href="#Possible-problems-and-room-for-improvement" class="wiki-anchor">¶</a></h2>
<ul>
<li>the "connected mode" sound overlay negative: it lists mostly the negative effect and not the positive.</li>
</ul>
<a name="Screenshot"></a>
<h2 >Screenshot<a href="#Screenshot" class="wiki-anchor">¶</a></h2>
<p>11-dev:</p>
<p><img src="http://forge.typo3.org/attachments/download/36173/localize.png" alt="" loading="lazy" /></p> TYPO3 Core - Task #94324 (Closed): Remove "Module Web>Modules" from select list in Info > Page TS...http://forge.typo3.org/issues/943242021-06-12T09:23:38ZSybille Peterssypets@gmx.de
<p>This corresponds to mod.web_modules which no longer exists.</p> TYPO3 Core - Feature #93192 (Closed): Add event to add additional callouts in page modulehttp://forge.typo3.org/issues/931922020-12-31T09:08:02ZSybille Peterssypets@gmx.deTYPO3 Core - Task #87647 (Closed): "TSconfig" is not spelled consistentlyhttp://forge.typo3.org/issues/876472019-02-04T19:01:53ZSybille Peterssypets@gmx.de
<ul>
<li>WEB > Info > "Page <strong>TSconfig</strong>" </li>
<li>Page properties > Resources > "Page <strong>TSConfig</strong>" </li>
<li>various changelogs mostly (but not all) use "Page <strong>TSconfig</strong>" </li>
<li><a href="https://docs.typo3.org/typo3cms/TSconfigReference/" class="external">TSconfig reference</a> uses <strong>TSconfig</strong></li>
</ul>
<p>So spelling is either TSconfig or TSConfig. Most of the time TSconfig is used.</p>
<p>What should it be?</p> TYPO3 Core - Task #85725 (Closed): Add directories created by rendering of documentation to .giti...http://forge.typo3.org/issues/857252018-08-02T10:38:01ZSybille Peterssypets@gmx.deTYPO3 Core - Task #85007 (Closed): Remove setting style for broken links in RteHtmlParser::markBr...http://forge.typo3.org/issues/850072018-05-15T09:05:14ZSybille Peterssypets@gmx.de
<p>Once patch <a class="external" href="https://review.typo3.org/c/56943/">https://review.typo3.org/c/56943/</a> is merged, setting the style for broken links in RteHtmlParser should be removed in master.</p> TYPO3 Core - Epic #84889 (Closed): Make frontend: PageRepository and PageRepositoryTest notice freehttp://forge.typo3.org/issues/848892018-04-28T10:54:03ZSybille Peterssypets@gmx.de
<p>Core: Error handler (BE): PHP Notice: Undefined index: disabled in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L1364" class="external">line 1364</a></p>
<p>Core: Error handler (BE): PHP Notice: Undefined index: starttime in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L1368" class="external">line 1368</a></p>
<p>Core: Error handler (BE): PHP Notice: Undefined index: endtime in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L1372" class="external">line 1372</a></p>
<p>Core: Error handler (BE): PHP Notice: Undefined index: TYPO3\CMS\Frontend\Page\PageRepository in /var/www/linkvalidator/typo3/sysext/frontend/Classes/Page/PageRepository.php <a href="https://github.com/TYPO3/TYPO3.CMS/blob/48adc7ac337bc45eb4263ebc675080f2042c685a/typo3/sysext/frontend/Classes/Page/PageRepository.php#L209" class="external">line 209</a></p>