TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692024-03-27T17:18:45ZTYPO3 Forge
Redmine TYPO3 Core - Bug #103494 (Under Review): Linkvalidator uses tstamp field directly without checkin...http://forge.typo3.org/issues/1034942024-03-27T17:18:45ZSybille Peterssypets@gmx.de
<p><strong>This should be merged before <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612">https://review.typo3.org/c/Packages/TYPO3.CMS/+/83612</a></strong></p>
<p>TCA should be used to determine which field is relevant for tstamp (and if there is such a field) before using it for a DB query</p>
<p>$GLOBALS['TCA'][$table]['ctrl']['tstamp']</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Change configuration to mod.linkvalidator.searchFields.sys_redirect.target</li>
<li>check links (with a broken redirect target)</li>
<li>in the list of broken links, click pencil to edit redirect target field</li>
<li>close edit field</li>
</ol>
<p>Now, exception is thrown.</p> TYPO3 Core - Bug #103478 (New): Linkvalidator should check fields with type "file"http://forge.typo3.org/issues/1034782024-03-25T05:47:22ZSybille Peterssypets@gmx.de
<p>e.g. pages.media</p>
<p>see documentation: <a class="external" href="https://docs.typo3.org/c/typo3/cms-linkvalidator/main/en-us/Configuration/Index.html">https://docs.typo3.org/c/typo3/cms-linkvalidator/main/en-us/Configuration/Index.html</a></p>
<p>LinkAnalyzer.php:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">((</span><span class="nv">$conf</span><span class="p">[</span><span class="s1">'type'</span><span class="p">]</span> <span class="o">??</span> <span class="s1">''</span><span class="p">)</span> <span class="o">===</span> <span class="s1">'link'</span> <span class="o">&&</span> <span class="k">empty</span><span class="p">(</span><span class="nv">$conf</span><span class="p">[</span><span class="s1">'softref'</span><span class="p">]))</span> <span class="p">{</span>
<span class="nv">$conf</span><span class="p">[</span><span class="s1">'softref'</span><span class="p">]</span> <span class="o">=</span> <span class="s1">'typolink'</span><span class="p">;</span>
<span class="p">}</span>
</code></pre> TYPO3 Core - Bug #103476 (Under Review): Disrepancy of returned link type in LinktypeInternal::fe...http://forge.typo3.org/issues/1034762024-03-23T16:22:43ZSybille Peterssypets@gmx.de
<p>Currently, when calling fetchType for various link types differs if you change the order of the link types.</p>
<p>Also, InternalLinktype always returns "db" link type if the "db" link type is set by the softref parser even if it has no business doing so.</p>
<p>These link types are mutually exclusive:</p>
<p>- "db" => InternalLinktype<br />- "file" => FileLinktype<br />- "record" => RecordLinktype (introduced in patch via issue <a class="issue tracker-2 status-8 priority-3 priority-lowest" title="Feature: Make it possible to check custom record links with linkvalidator (Under Review)" href="http://forge.typo3.org/issues/103403">#103403</a>)</p>
<p>However, the softref parsers returns "db" for all of these.</p>
<p>Fixing this may avoid problems further down the line.</p>
<a name="Test-protocol-by-debugging-the-link-types"></a>
<h2 >Test protocol (by debugging the link types)<a href="#Test-protocol-by-debugging-the-link-types" class="wiki-anchor">¶</a></h2>
<p>file link: t3://file?uid=<uid><br />-------------------------------------</p>
<p>$softRefEntry<br />- value['type'] = 'db'<br />- value['recordRef'] = 'sys_file:94'<br />- value['tokenValue'] = 'file:94'</p>
<p>- result of fetchType: (order: db, file)<br /> - if class=InternatlLinktype => AbstactLinktype::fetchType: 'db'<br /> - if class=FileLinktype => FileLinkType::fetchType: 'file'</p>
<p>- after changing order: file,db<br /> - if class=FileLinktype => FileLinkType::fetchType: 'file'<br /> sets $value['type'] to 'file'<br /> - if class=InternatlLinktype => AbstactLinktype::fetchType: 'file'</p>
<p>!!!! discrepancy !!! effective type depends on order of evaluation!</p>
<blockquote><blockquote>
<p>if "file" type is not in "linktypes", file links will be checked with InteralLinktype</p>
</blockquote></blockquote>
BUT if "file" type is in "linktypes, file links will be checked with FileLinktype
<p>The result is in most cases still ok, because InternalLinktype refuses to check file links, but it is messy, makes troubleshooting difficult and may cause problems in some scenarios.</p> TYPO3 Core - Bug #103100 (Resolved): "Refresh display" or "Check links" button is entirely disabl...http://forge.typo3.org/issues/1031002024-02-11T13:18:51ZSybille Peterssypets@gmx.de
<p>By default, the buttons in "Report" and "Check links" module are disabled. They are enabled via JavaScript if a check option is enabled.</p>
<p>However, in TYPO3 v13 (and possibly below), this does not work correctly: if all options are unchecked (which is the default for new users) and then one of them is toggled (to enabled), it is still not possible to click the button at all, it remains disabled even if options are being checked. It looks like the event listener is not being called.</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>1. switch to a new user where the options have not been enabled yet<br />2. Either in the "Report" or "Check links" view, enable one of the checkboxes for the link types<br />3. Try to click the button</p>
<p>Result: nothing happens, the button is disabled, so it is not possible to execute the new selection.</p>
<a name="Versions"></a>
<h2 >Versions<a href="#Versions" class="wiki-anchor">¶</a></h2>
<p>Could be reproduced in TYPO3 v13 (main).</p>
<p>Could NOT be reproduce din TYPO3 v12.</p>
<a name="Screenshot"></a>
<h2 >Screenshot<a href="#Screenshot" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/38255/linkvalidator_checkboxes.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #103059 (New): Not possible to see references if no access to content where file...http://forge.typo3.org/issues/1030592024-02-06T10:22:55ZSybille Peterssypets@gmx.de
<p>In the file list you can see the number of references for files which are referenced from content which you do not have access to, and you can also click on the link, but the references will not be displayed.</p>
<p>I would expect it to be possible to see the references (read-only) and also be able to see which pages the references are on (ideally by having a "view page" button).</p>
<p>Otherwise you cannot delete files and you can't find out (as normal editor) where they are still being referenced from.</p>
<p>This means, these cases can only be resolved by admin users or by users with access to both the files and the content.</p>
<a name="Example"></a>
<h2 >Example<a href="#Example" class="wiki-anchor">¶</a></h2>
<p>user A<br />- access to pages /a/<br />- access to files fileadmin/a</p>
<p>user B<br />- access to pages /b/<br />- access to files fileadmin/b</p>
<p>Content in /a/ links to file /b/test.png. Now, user b cannot see references for test.png and cannot delete test.png.</p> TYPO3 Core - Bug #102595 (New): Not possible to override richtextConfiguration via TSconfig if in...http://forge.typo3.org/issues/1025952023-12-04T05:11:41ZSybille Peterssypets@gmx.de
<p>Normally, overriding settings in Flexform via TSconfig is possibly, for example like this:</p>
<pre>
# TCEFORM.[tableName].[fieldName].[dataStructureKey].[flexSheet].[flexFieldName with escaped dots].[propertyName]
<pre>
TCEFORM.tt_content.pi_flexform.sfregister_create.sDEF.settings\.fields\.selected.addItems.ZZZ = ZZZ
</pre>
</pre><br />see <a class="external" href="https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/TceForm.html">https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/TceForm.html</a>
<p>But this does not seem to work with the richtextConfiguration if in a Flexform which would then be overridden with RTE, for example like this:</p>
<pre>
RTE.config.tx_news_domain_model_news.bodytext.preset = otherpreset
</pre>
<p>For a Flexform field, it should look for example like this:</p>
<pre>
RTE.config.tt_content.pi_flexform.powermail_pi1.thx.settings\.flexform\.thx\.body.preset = otherpreset
</pre>
<p>but this does not work</p> TYPO3 Core - Bug #101674 (Resolved): Improve user interface for selecting linktypes via checkboxe...http://forge.typo3.org/issues/1016742023-08-13T16:38:40ZSybille Peterssypets@gmx.de
<p>The linkvalidator linktypes checkbox selector can be a bit tedious to use.</p>
<p>On initially using linkvalidator, all linktypes are usually deactivated by default. So you would have to activate them all, clicking 3 or more times (there may be more custom linktypes configured).</p>
<p>Also, if not just the Reports but the Check view is enabled, you have to repeat this again.</p>
<a name="Possible-improvement"></a>
<h2 >Possible improvement<a href="#Possible-improvement" class="wiki-anchor">¶</a></h2>
<p>Add a "Toggle all" checkbox as is already used in the SelectCheckBoxElement FormEngine renderType. (the FormEngine version can be looked at using the styleguide extension: list view, page "elements select"):</p>
<p><img src="http://forge.typo3.org/attachments/download/37927/formengine_select_checkboxes.png" alt="" loading="lazy" /></p>
<a name="Screenshots"></a>
<h2 >Screenshots<a href="#Screenshots" class="wiki-anchor">¶</a></h2>
<p>before:</p>
<p><img src="http://forge.typo3.org/attachments/download/37915/linkvalidator_linktypes_checkboxes_current.png" alt="" loading="lazy" /></p>
<p>after:</p>
<p><img src="http://forge.typo3.org/attachments/download/37914/linkvalidator_linktypes_checkboxes_with_toggle_all.png" alt="" loading="lazy" /></p>
<a name="Implementation-details"></a>
<h2 >Implementation details<a href="#Implementation-details" class="wiki-anchor">¶</a></h2>
<p>Since Linkvalidator uses Fluid for the view, we would probably have to write that from scratch.</p>
<p>Implement like FormEngine type="select", renderType="selectCheckBox".</p>
<p>Behaviour:</p>
<ul>
<li>"Toggle all" gets checked as soon as all checkboxes are checked</li>
<li>"Toggle all" gets unchecked when not all checkboxes are checked</li>
<li>"Toggle all: if clicked will change state, e.g. if unchecked will change to checked and all checkboxes will be checked</li>
</ul> TYPO3 Core - Bug #101670 (New): Linkvalidator reports some external URLs as "false positives"http://forge.typo3.org/issues/1016702023-08-13T06:39:37ZSybille Peterssypets@gmx.de
<p>Links are reported as broken which are not broken.</p>
<p>Known cases:</p>
<p>1. sites without complete certificate chain ( <strong>intermediate</strong> (not root) certs missing), Qualys SSLLabs reports this when checking, but browsers resolve this by fetching (and storing) the intermediate certificates, so the URL seems to work fine in the browser<br />2. sites protected by Cloadflare (returns status code 503)</p>
<p>Some other sites also cause problems for unknown reasons:</p>
<ul>
<li>twitter</li>
<li>linkedin</li>
<li>etc.</li>
</ul> TYPO3 Core - Bug #101417 (Closed): It is not possible to remove the target via the link browserhttp://forge.typo3.org/issues/1014172023-07-23T05:43:05ZSybille Peterssypets@gmx.de
<p>Reproducible with latest v13, possibly also v12. May have to use patch <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034">https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034</a> to reproduce, otherwise target is not always saved to DB.</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Add a target to a link</li>
<li>In the link brower, remove the target, klick update</li>
<li>Save the CE (or switch to source mode)</li>
</ol>
<p>The target is still there, e.g.</p>
<pre>
<p><a href="t3://page?uid=1" title="hallo" target="_blank">link1</a></p>
</pre> TYPO3 Core - Feature #101077 (New): Improve administrative handling of "Anonymize IP Adresses"http://forge.typo3.org/issues/1010772023-06-15T05:24:09ZSybille Peterssypets@gmx.de
<ul>
<li>currently it is only possible to select 1 table in the task (but more can be configured in ext_localconf.php)</li>
<li>the task is a scheduler task which means you have to create a scheduler task first, you can't just run it from the console (which means extra work and you can't (easily) store the configuration in a Git repo)</li>
</ul>
<a name="Sugestions"></a>
<h2 >Sugestions<a href="#Sugestions" class="wiki-anchor">¶</a></h2>
<ul>
<li>make a Symfony command out of it</li>
<li>make it possible to run it with "all configured tables" which would use all tables in $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks'][self::class]['options']</li>
</ul>
<p>In the "Table garbage collection" task there is a checkbox "Clean all available tables"</p>
<a name="Side-note"></a>
<h2 >Side note<a href="#Side-note" class="wiki-anchor">¶</a></h2>
<p>It is unclear to me whether all current scheduler tasks will be migrated to Symfony commands in the future.</p> TYPO3 Core - Task #96015 (Closed): Remove unused language labelshttp://forge.typo3.org/issues/960152021-11-17T18:32:32ZSybille Peterssypets@gmx.de
LLL:EXT:redirects/Resources/Private/Language/locallang_module_redirect.xlf:
<ul>
<li>source_host</li>
<li>source_path</li>
<li>destination</li>
<li>hits</li>
<li>hit_last</li>
<li>filter.destination</li>
</ul> TYPO3 Core - Feature #92231 (Closed): Add some more error messages to linkvalidatorhttp://forge.typo3.org/issues/922312020-09-08T18:55:47ZSybille Peterssypets@gmx.de
<p>For some error types, the error messages are too long, verbose and not suited for non technical audience.</p>
<p>The reason is, that not all error types have language strings and in some cases a generic error message and the exception (from Guzzle) is used.</p>
<p>I would propose to add some more error messages.</p>
<p>Also, the "Network error / invalid domain" error message is misleading, because all error reasons listed in <a class="external" href="https://curl.haxx.se/libcurl/c/libcurl-errors.html">https://curl.haxx.se/libcurl/c/libcurl-errors.html</a> return that. In fact, the error code is also returned which could be used to give a more specific error message.</p>
<a name="Examples-that-already-have-short-custom-error-messages"></a>
<h2 >Examples that already have short custom error messages:<a href="#Examples-that-already-have-short-custom-error-messages" class="wiki-anchor">¶</a></h2>
<p>404:</p>
<pre><code class="text syntaxhl" data-language="text">The requested url was not found (404).
</code></pre>
<p>403:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="nc">Accessing</span> <span class="n">this</span> <span class="n">address</span> <span class="n">is</span> <span class="n">not</span> <span class="nf">allowed</span> <span class="p">(</span><span class="mi">403</span><span class="p">)</span><span class="mf">.</span>
</code></pre>
<a name="Examples-for-errors-with-long-and-cluttered-error-message"></a>
<h2 >Examples for errors with long and cluttered error message<a href="#Examples-for-errors-with-long-and-cluttered-error-message" class="wiki-anchor">¶</a></h2>
<p>401:</p>
<pre><code class="text syntaxhl" data-language="text">An error occurred (401): "Client error: `GET https://url-which-requires-login/login` resulted in a `401 Unauthorized` response:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xh (truncated...)
".
</code></pre>
<p>wrong domain:</p>
<pre><code class="text syntaxhl" data-language="text">Network error / invalid domain:cURL error 6: Could not resolve host: invalid-domain.de; Unknown error (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)
</code></pre>
<p>ssl problem:</p>
<pre><code class="text syntaxhl" data-language="text">Network error / invalid domain:cURL error 51: Unable to communicate securely with peer: requested domain name does not match the server's certificate. (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)
</code></pre>
<p>timeout:</p>
<pre><code class="text syntaxhl" data-language="text">Network error / invalid domain:cURL error 28: Connection timed out after 10001 milliseconds (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)
</code></pre>
<p>HTTP Status code 500:</p>
<pre><code class="text syntaxhl" data-language="text">Network error / invalid domain:Server error: `GET http://some-domain/` resulted in a `500 Internal Server Error` response:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
< (truncated...)
</code></pre>
<p>wrong protocol:</p>
<pre><code class="text syntaxhl" data-language="text">Network error / invalid domain:cURL error 1: Protocol hhttps not supported or disabled in libcurl (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)
</code></pre>
<p>502:</p>
<pre><code class="text syntaxhl" data-language="text">Network error / invalid domain:Server error: `GET http://hochschule-ohne-grenzen.org/` resulted in a `502 Proxy Error` response:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy E (truncated...)
07.09.20 16:15
</code></pre> TYPO3 Core - Task #84836 (Closed): Create a template with best practices for php files in Build/S...http://forge.typo3.org/issues/848362018-04-22T15:00:55ZSybille Peterssypets@gmx.de
<p>Some of the existing scripts in Build/Scripts have been converted to PHP. New scripts will be created. It might be good to have a template which includes some best practices, e.g.</p>
<ul>
<li>security: abort script if not called from command line</li>
<li>handle command line arguments</li>
<li>Apply <a href="https://www.php-fig.org/psr/psr-1/#23-side-effects" class="external">PSR-1 2.3 Side Effects</a> ? Which could mean do not define class and execute it in one file. </li>
<li>... more?</li>
</ul>
<p>This script could continuously be refined and the other scripts updated at least for critical and security-related things.</p> TYPO3 Core - Bug #69665 (Closed): Rendering of TypoScript shortcutIcon does not consider HTTPS (i...http://forge.typo3.org/issues/696652015-09-11T12:40:28ZSybille Peterssypets@gmx.de
<p>IMHO it should be possible to enter the URL for shortcutIcon as arbitrary URL, specifically in any the following formats:</p>
<ul>
<li>absolute path, starting with /</li>
<li>absolute URL e.g. <a class="external" href="https://www.example.org">https://www.example.org</a></li>
<li>scheme relative : //www.example.org</li>
</ul>
<p>The current rendering is not flexible enough for HTTP/ HTTPS because the rendered and cached page will be dependant on the URL scheme first used. This may result in a URL with HTTP scheme used for favicon (if the page is first fetched via http), which will then be cached and used for HTTPS as well resulting in security warnings (mixed content).</p>
<a name="TYPO3-source-code-45-and-62-more-or-less-the-same"></a>
<h1 >TYPO3 source code (4.5 and 6.2 more or less the same):<a href="#TYPO3-source-code-45-and-62-more-or-less-the-same" class="wiki-anchor">¶</a></h1>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">(</span><span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TSFE'</span><span class="p">]</span><span class="o">-></span><span class="n">pSetup</span><span class="p">[</span><span class="s1">'shortcutIcon'</span><span class="p">])</span> <span class="p">{</span>
<span class="nv">$favIcon</span> <span class="o">=</span> <span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TSFE'</span><span class="p">]</span><span class="o">-></span><span class="n">tmpl</span><span class="o">-></span><span class="nf">getFileName</span><span class="p">(</span><span class="nv">$GLOBALS</span><span class="p">[</span><span class="s1">'TSFE'</span><span class="p">]</span><span class="o">-></span><span class="n">pSetup</span><span class="p">[</span><span class="s1">'shortcutIcon'</span><span class="p">]);</span>
<span class="k">if</span> <span class="p">(</span><span class="nb">is_file</span><span class="p">(</span><span class="n">PATH_site</span> <span class="mf">.</span> <span class="nv">$favIcon</span><span class="p">))</span> <span class="p">{</span>
<span class="k">if</span> <span class="p">(</span><span class="nb">function_exists</span><span class="p">(</span><span class="s1">'finfo_open'</span><span class="p">))</span> <span class="p">{</span>
<span class="k">if</span> <span class="p">(</span><span class="nv">$finfo</span> <span class="o">=</span> <span class="o">@</span><span class="nb">finfo_open</span><span class="p">(</span><span class="no">FILEINFO_MIME</span><span class="p">))</span> <span class="p">{</span>
<span class="nv">$iconMimeType</span> <span class="o">=</span> <span class="s1">' type="'</span> <span class="mf">.</span> <span class="nb">finfo_file</span><span class="p">(</span><span class="nv">$finfo</span><span class="p">,</span> <span class="p">(</span><span class="n">PATH_site</span> <span class="mf">.</span> <span class="nv">$favIcon</span><span class="p">))</span> <span class="mf">.</span> <span class="s1">'"'</span><span class="p">;</span>
<span class="nb">finfo_close</span><span class="p">(</span><span class="nv">$finfo</span><span class="p">);</span>
<span class="nv">$pageRenderer</span><span class="o">-></span><span class="nf">setIconMimeType</span><span class="p">(</span><span class="nv">$iconMimeType</span><span class="p">);</span>
<span class="p">}</span>
<span class="p">}</span>
<span class="nv">$pageRenderer</span><span class="o">-></span><span class="nf">setFavIcon</span><span class="p">(</span><span class="nc">GeneralUtility</span><span class="o">::</span><span class="nf">getIndpEnv</span><span class="p">(</span><span class="s1">'TYPO3_SITE_URL'</span><span class="p">)</span> <span class="mf">.</span> <span class="nv">$favIcon</span><span class="p">);</span>
<span class="p">}</span>
</code></pre>
<p>As you can see, it is not possible to use relative or absolute paths because TYPO3_SITE_URL is prepended in any case. It is not possible to use absolute URLs because this will result in is_file failing.</p>
<p>This issue has actually already been reported, but for typo3.org, see <a class="external" href="https://forge.typo3.org/issues/58265">https://forge.typo3.org/issues/58265</a></p>
<p>Any help is appreciated.</p> TYPO3 Core - Feature #36542 (Closed): Changed domain handling on "View webpage" from backend caus...http://forge.typo3.org/issues/365422012-04-25T12:32:51ZSybille Peterssypets@gmx.de
<p>Due to fix for Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: t3lib_befunc::getViewDomain returns wrong or no domain (Closed)" href="http://forge.typo3.org/issues/30892">#30892</a>:</p>
<p>This new behaviour causes problems for us.</p>
<p>For a long time (due to bug or not) the domain currently used in the backend was used for loading a page with "View webpage". Due to the change in getViewDomain, the first domain from the domain records is now used.</p>
<p>On multi-site installations we use a generic domain for working in the backend and this should be consistent with the domain used for viewing the page from the backend.</p>
<p>We now have to patch the core or completely change handling.</p>
<p>Ideal would be to make this configurable !!!</p>