TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692024-03-25T05:47:22ZTYPO3 Forge
Redmine TYPO3 Core - Bug #103478 (New): Linkvalidator should check fields with type "file"http://forge.typo3.org/issues/1034782024-03-25T05:47:22ZSybille Peterssypets@gmx.de
<p>e.g. pages.media</p>
<p>see documentation: <a class="external" href="https://docs.typo3.org/c/typo3/cms-linkvalidator/main/en-us/Configuration/Index.html">https://docs.typo3.org/c/typo3/cms-linkvalidator/main/en-us/Configuration/Index.html</a></p>
<p>LinkAnalyzer.php:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">((</span><span class="nv">$conf</span><span class="p">[</span><span class="s1">'type'</span><span class="p">]</span> <span class="o">??</span> <span class="s1">''</span><span class="p">)</span> <span class="o">===</span> <span class="s1">'link'</span> <span class="o">&&</span> <span class="k">empty</span><span class="p">(</span><span class="nv">$conf</span><span class="p">[</span><span class="s1">'softref'</span><span class="p">]))</span> <span class="p">{</span>
<span class="nv">$conf</span><span class="p">[</span><span class="s1">'softref'</span><span class="p">]</span> <span class="o">=</span> <span class="s1">'typolink'</span><span class="p">;</span>
<span class="p">}</span>
</code></pre> TYPO3 Core - Bug #103476 (Under Review): Disrepancy of returned link type in LinktypeInternal::fe...http://forge.typo3.org/issues/1034762024-03-23T16:22:43ZSybille Peterssypets@gmx.de
<p>Currently, when calling fetchType for various link types differs if you change the order of the link types.</p>
<p>Also, InternalLinktype always returns "db" link type if the "db" link type is set by the softref parser even if it has no business doing so.</p>
<p>These link types are mutually exclusive:</p>
<p>- "db" => InternalLinktype<br />- "file" => FileLinktype<br />- "record" => RecordLinktype (introduced in patch via issue <a class="issue tracker-2 status-8 priority-3 priority-lowest" title="Feature: Make it possible to check custom record links with linkvalidator (Under Review)" href="http://forge.typo3.org/issues/103403">#103403</a>)</p>
<p>However, the softref parsers returns "db" for all of these.</p>
<p>Fixing this may avoid problems further down the line.</p>
<a name="Test-protocol-by-debugging-the-link-types"></a>
<h2 >Test protocol (by debugging the link types)<a href="#Test-protocol-by-debugging-the-link-types" class="wiki-anchor">¶</a></h2>
<p>file link: t3://file?uid=<uid><br />-------------------------------------</p>
<p>$softRefEntry<br />- value['type'] = 'db'<br />- value['recordRef'] = 'sys_file:94'<br />- value['tokenValue'] = 'file:94'</p>
<p>- result of fetchType: (order: db, file)<br /> - if class=InternatlLinktype => AbstactLinktype::fetchType: 'db'<br /> - if class=FileLinktype => FileLinkType::fetchType: 'file'</p>
<p>- after changing order: file,db<br /> - if class=FileLinktype => FileLinkType::fetchType: 'file'<br /> sets $value['type'] to 'file'<br /> - if class=InternatlLinktype => AbstactLinktype::fetchType: 'file'</p>
<p>!!!! discrepancy !!! effective type depends on order of evaluation!</p>
<blockquote><blockquote>
<p>if "file" type is not in "linktypes", file links will be checked with InteralLinktype</p>
</blockquote></blockquote>
BUT if "file" type is in "linktypes, file links will be checked with FileLinktype
<p>The result is in most cases still ok, because InternalLinktype refuses to check file links, but it is messy, makes troubleshooting difficult and may cause problems in some scenarios.</p> TYPO3 Core - Bug #103059 (New): Not possible to see references if no access to content where file...http://forge.typo3.org/issues/1030592024-02-06T10:22:55ZSybille Peterssypets@gmx.de
<p>In the file list you can see the number of references for files which are referenced from content which you do not have access to, and you can also click on the link, but the references will not be displayed.</p>
<p>I would expect it to be possible to see the references (read-only) and also be able to see which pages the references are on (ideally by having a "view page" button).</p>
<p>Otherwise you cannot delete files and you can't find out (as normal editor) where they are still being referenced from.</p>
<p>This means, these cases can only be resolved by admin users or by users with access to both the files and the content.</p>
<a name="Example"></a>
<h2 >Example<a href="#Example" class="wiki-anchor">¶</a></h2>
<p>user A<br />- access to pages /a/<br />- access to files fileadmin/a</p>
<p>user B<br />- access to pages /b/<br />- access to files fileadmin/b</p>
<p>Content in /a/ links to file /b/test.png. Now, user b cannot see references for test.png and cannot delete test.png.</p> TYPO3 Core - Bug #102595 (New): Not possible to override richtextConfiguration via TSconfig if in...http://forge.typo3.org/issues/1025952023-12-04T05:11:41ZSybille Peterssypets@gmx.de
<p>Normally, overriding settings in Flexform via TSconfig is possibly, for example like this:</p>
<pre>
# TCEFORM.[tableName].[fieldName].[dataStructureKey].[flexSheet].[flexFieldName with escaped dots].[propertyName]
<pre>
TCEFORM.tt_content.pi_flexform.sfregister_create.sDEF.settings\.fields\.selected.addItems.ZZZ = ZZZ
</pre>
</pre><br />see <a class="external" href="https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/TceForm.html">https://docs.typo3.org/m/typo3/reference-tsconfig/main/en-us/PageTsconfig/TceForm.html</a>
<p>But this does not seem to work with the richtextConfiguration if in a Flexform which would then be overridden with RTE, for example like this:</p>
<pre>
RTE.config.tx_news_domain_model_news.bodytext.preset = otherpreset
</pre>
<p>For a Flexform field, it should look for example like this:</p>
<pre>
RTE.config.tt_content.pi_flexform.powermail_pi1.thx.settings\.flexform\.thx\.body.preset = otherpreset
</pre>
<p>but this does not work</p> TYPO3 Core - Bug #101674 (Resolved): Improve user interface for selecting linktypes via checkboxe...http://forge.typo3.org/issues/1016742023-08-13T16:38:40ZSybille Peterssypets@gmx.de
<p>The linkvalidator linktypes checkbox selector can be a bit tedious to use.</p>
<p>On initially using linkvalidator, all linktypes are usually deactivated by default. So you would have to activate them all, clicking 3 or more times (there may be more custom linktypes configured).</p>
<p>Also, if not just the Reports but the Check view is enabled, you have to repeat this again.</p>
<a name="Possible-improvement"></a>
<h2 >Possible improvement<a href="#Possible-improvement" class="wiki-anchor">¶</a></h2>
<p>Add a "Toggle all" checkbox as is already used in the SelectCheckBoxElement FormEngine renderType. (the FormEngine version can be looked at using the styleguide extension: list view, page "elements select"):</p>
<p><img src="http://forge.typo3.org/attachments/download/37927/formengine_select_checkboxes.png" alt="" loading="lazy" /></p>
<a name="Screenshots"></a>
<h2 >Screenshots<a href="#Screenshots" class="wiki-anchor">¶</a></h2>
<p>before:</p>
<p><img src="http://forge.typo3.org/attachments/download/37915/linkvalidator_linktypes_checkboxes_current.png" alt="" loading="lazy" /></p>
<p>after:</p>
<p><img src="http://forge.typo3.org/attachments/download/37914/linkvalidator_linktypes_checkboxes_with_toggle_all.png" alt="" loading="lazy" /></p>
<a name="Implementation-details"></a>
<h2 >Implementation details<a href="#Implementation-details" class="wiki-anchor">¶</a></h2>
<p>Since Linkvalidator uses Fluid for the view, we would probably have to write that from scratch.</p>
<p>Implement like FormEngine type="select", renderType="selectCheckBox".</p>
<p>Behaviour:</p>
<ul>
<li>"Toggle all" gets checked as soon as all checkboxes are checked</li>
<li>"Toggle all" gets unchecked when not all checkboxes are checked</li>
<li>"Toggle all: if clicked will change state, e.g. if unchecked will change to checked and all checkboxes will be checked</li>
</ul> TYPO3 Core - Bug #101670 (New): Linkvalidator reports some external URLs as "false positives"http://forge.typo3.org/issues/1016702023-08-13T06:39:37ZSybille Peterssypets@gmx.de
<p>Links are reported as broken which are not broken.</p>
<p>Known cases:</p>
<p>1. sites without complete certificate chain ( <strong>intermediate</strong> (not root) certs missing), Qualys SSLLabs reports this when checking, but browsers resolve this by fetching (and storing) the intermediate certificates, so the URL seems to work fine in the browser<br />2. sites protected by Cloadflare (returns status code 503)</p>
<p>Some other sites also cause problems for unknown reasons:</p>
<ul>
<li>twitter</li>
<li>linkedin</li>
<li>etc.</li>
</ul> TYPO3 Core - Bug #101417 (Closed): It is not possible to remove the target via the link browserhttp://forge.typo3.org/issues/1014172023-07-23T05:43:05ZSybille Peterssypets@gmx.de
<p>Reproducible with latest v13, possibly also v12. May have to use patch <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034">https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034</a> to reproduce, otherwise target is not always saved to DB.</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>Add a target to a link</li>
<li>In the link brower, remove the target, klick update</li>
<li>Save the CE (or switch to source mode)</li>
</ol>
<p>The target is still there, e.g.</p>
<pre>
<p><a href="t3://page?uid=1" title="hallo" target="_blank">link1</a></p>
</pre> TYPO3 Core - Bug #101414 (Resolved): Alert dialog does not show information about references inli...http://forge.typo3.org/issues/1014142023-07-22T13:09:23ZSybille Peterssypets@gmx.de
<p>This issue handles only one specific case which was already patched in v12 and v13.</p>
<p>More information is in <a class="issue tracker-1 status-1 priority-4 priority-default" title="Bug: Message that there are references which point to this record is not always displayed when trying ... (New)" href="http://forge.typo3.org/issues/101411">#101411</a></p>
<p>Hopefully part of the improvements in <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001">https://review.typo3.org/c/Packages/TYPO3.CMS/+/72001</a> can be backported to v11.</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>1. Create a record [1] (e.g. texmedia), create a shortcut ce [2] which references this<br />2. In page module try to delete the record [1] (using the inline delete button).</p>
<p>We see a generic delete msg. We expect delete msg which warns about references.</p>
<a name="Screenshot"></a>
<h2 >Screenshot<a href="#Screenshot" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/37847/delete_record_with_references_generic_message.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #101411 (New): Message that there are references which point to this record is n...http://forge.typo3.org/issues/1014112023-07-22T12:42:30ZSybille Peterssypets@gmx.de
<p>Usually, we get an alert, sometime like this:</p>
<blockquote>
<p>Are you sure you want to delete the record 'textmedia1 [tt_content:54]'? There are 1 reference(s) to this record!</p>
</blockquote>
<p>or</p>
<blockquote>
<p>Are you sure you want to delete 'textmedia with shortcuts to this ce'? (There are 1 reference(s) to this record!)</p>
</blockquote>
<p>when trying to delete a record (e.g. [textmedia]) which has references pointing to it (e.g. "Insert Records" [shortcut]").</p>
<p>But sometimes we get a generic message which does not point out there are references, such as:</p>
<blockquote>
<p>Are you sure you want to delete this record?</p>
</blockquote>
<p>It looks like the behaviour improved between v11 => v13 but is not fully resolved.</p>
<p>(language label: labels.referencesToRecord)</p>
<a name="Problems-Inconsistencies"></a>
<h2 >Problems / Inconsistencies<a href="#Problems-Inconsistencies" class="wiki-anchor">¶</a></h2>
<p>in <strong>v13</strong></p>
<ul>
<li>list module: if using checkboxes to select several records then deleting, we get:</li>
</ul>
<blockquote>
<p>Delete marked<br />Are you sure you want to delete all marked records from the table 'Page Content'?<br />Close Delete</p>
</blockquote>
<p>(no hint that there are references)</p>
<ul>
<li>(minor): in FormEngine the "Delete record" button does not have an "(!)", in the other cases it does</li>
</ul>
<p>in <strong>v11</strong> , sames as v13, but also</p>
<ul>
<li>in page layout: using inline delete button, we get generic message (not warning about references):</li>
</ul>
<blockquote>
<p>Delete this record?<br />Delete this record?<br />Cancel | OK</p>
</blockquote>
<ul>
<li>some more minor inconsistencies in how the delete button is named etc.</li>
</ul>
<a name="Screenshots"></a>
<h2 >Screenshots<a href="#Screenshots" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/37844/delete_record_with_references_generic_message.png" title="generic delete message" alt="generic delete message" loading="lazy" /></p>
<p><img src="http://forge.typo3.org/attachments/download/37845/delete_record_with_references_message_points_out_references.png" title="delete message which mentions references" alt="delete message which mentions references" loading="lazy" /></p>
<p>v13</p>
<p><img src="http://forge.typo3.org/attachments/download/37846/v13_delete_record_with_references_in_list_module_bulk_removal_no_mention_of_references.png" title="v13 bulk removal in list module (references not mentioned)" alt="v13 bulk removal in list module (references not mentioned)" loading="lazy" /></p>
<a name="Full-report"></a>
<h2 >Full report<a href="#Full-report" class="wiki-anchor">¶</a></h2>
<p>see delete_record_with_references.txt</p> TYPO3 Core - Bug #101408 (Accepted): Fluid debug output is displayed on page even if adminpanel n...http://forge.typo3.org/issues/1014082023-07-21T14:45:59ZSybille Peterssypets@gmx.de
<p>This probably was reported before, but was then fixed and has now reappeared: <a class="external" href="https://forge.typo3.org/issues/85087">https://forge.typo3.org/issues/85087</a></p>
<p>I usually don't use Fluid debug output in adminpanel and usually don't enable it on production but I did that recently by accident.</p>
<p>Several days later I loaded a page, the debug output was displayed, the admin panel was not even activated.</p>
<p>What made matters worse, the debug output was also displayed if not logged in the BE (using different browser).</p>
<a name="versions"></a>
<h2 >versions<a href="#versions" class="wiki-anchor">¶</a></h2>
<ul>
<li>reproduced in v11, did not check newer versions yet.</li>
</ul>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>1. Flush all cache (including system cache)<br />2. Enable admin panel <br />3. Activate checkbox "Fluid debug output" <br />4. Load page: debug output is displayed) (ok)<br />5. deactivate adminpanel (via the toggle)<br />6. load page again: debug output is displayed (unexpected)<br />7. load page in different browser (not logged in): debug output is displayed (bad)<br />8. Deactivate the checkbox "Fluid debug output" <br />9. refresh page CTRL-SHIFT-r (or flush cache in adminpanel): debug output still displayed</p>
<p>finally, flush cache</p>
<pre>
vendor/bin/typo3 cache:flush
</pre>
<p>Is now ok</p>
<a name="Suggestion"></a>
<h2 >Suggestion<a href="#Suggestion" class="wiki-anchor">¶</a></h2>
<p>I think this should be changed (at least in production context)</p>
<ul>
<li>the debug output should not be saved</li>
<li>or better: not possible to enable "Fluid debug" checkbox in production context</li>
</ul>
<a name="Screenshot"></a>
<h2 >Screenshot<a href="#Screenshot" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/37842/adminpanel_fluid.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #101367 (New): page link to not hidden child of hidden page with extendToSubpage...http://forge.typo3.org/issues/1013672023-07-17T15:58:03ZSybille Peterssypets@gmx.de
<p>In linkvalidator, page links to hidden pages are considered broken.</p>
<p>But extendToSubpages is not considered, the rootline is not traversed.</p>
<pre>
page [3] (hidden, extendToSubpages)
└── page [4] (not hidden)
</pre>
<ul>
<li>link to => 3 (hidden) : marked as broken</li>
<li>link to => 4 (child of hidden/extendToSubapges: not marked as broken, wrong.</li>
</ul> TYPO3 Core - Bug #101360 (Resolved): Some attributes for <a> element are not persisted (class, re...http://forge.typo3.org/issues/1013602023-07-15T07:19:47ZSybille Peterssypets@gmx.de
<p>Since TYPO3 v12 (ckeditor 5) some attributes for element a are not persisted.</p>
<p>Specifically:</p>
<p>- class<br />- rel<br />- target</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<p>Enter something like this in Source mode of RTE and switch to non-Source mode:</p>
<pre>
<p>
<a class="hallo" href="https://sdfsfsd.de" title="hallo" target="_top" rel="nofollow">link</a>
</p>
</pre>
<p>The additional attributes class,target and rel are then removed, which should not happen.</p>
<p>I used the following TSConfig:</p>
<pre>
RTE.default.preset = full
</pre> TYPO3 Core - Bug #101357 (Resolved): Broken links are not marked in RTE anymore (affects linkvali...http://forge.typo3.org/issues/1013572023-07-14T18:29:54ZSybille Peterssypets@gmx.de
<p>Seems to be the case since v12</p>
<ul>
<li>the event BrokenLinkAnalysisEvent is correctly dispatched in RteHtmlParser</li>
<li>$attributes['data-rte-error'] is set in RteHtmlParser</li>
<li>BUT, the ckeditor removes the data-rte-error attribute</li>
<li>also, the style is missing (css / sass)</li>
</ul>
<a name="Reproduce-simple-only-using-RTE"></a>
<h2 >Reproduce (simple, only using RTE)<a href="#Reproduce-simple-only-using-RTE" class="wiki-anchor">¶</a></h2>
<p>1. Insert this in the RTE in Source mode:</p>
<pre>
<p><a data-rte-error="Broken link" href="https:/iambroken.org/yesreally">link</a></p>
</pre><br />2. switch to wysiwyg mode
<p>The attribute data-rte-error is removed. This should not happen.</p>
<a name="Reproduce-with-linkvalidator"></a>
<h2 >Reproduce (with linkvalidator)<a href="#Reproduce-with-linkvalidator" class="wiki-anchor">¶</a></h2>
<ol>
<li>install linkvalidator</li>
<li>create one or more broken links</li>
<li>check links with linkvalidator (linkvalidator module)</li>
<li>in list of broken links, click pencil icon</li>
</ol>
<p>The broken links should now be marked in RTE with yellow background and red border. Also, if in source mode of RTE, you should see the attribute 'data-rte-error' in the "a" HTML elements for the broken links.</p> TYPO3 Core - Bug #101336 (New): Pages are shown in page tree even if (non-admin) BE user has no D...http://forge.typo3.org/issues/1013362023-07-12T10:56:48ZSybille Peterssypets@gmx.de
<p>This could also be a privacy problem because user sees pages in page tree which he has no business seeing (which might be access protected).</p>
<p>He can also sees<br />- which user is currently editing the page (see first screenshot)</p>
<p>I could reproduce it in a way where the user sees all pages in entire installation (even though they are not even in the DB mount in the group).</p>
<p>Is only reproducable</p>
<p>- if the user does not have any DB mounts at all<br />- OR has a DB mount but no permission for the pages.</p>
<p>This could happen by wrong page permissions or misconfiguration of BE user.</p>
<a name="Reproduce"></a>
<h2 >Reproduce<a href="#Reproduce" class="wiki-anchor">¶</a></h2>
<ol>
<li>create user with no DB mount and set "Mount from groups" | "DB mounts" to off, assign this user to a group</li>
<li>add a DB mount in the group</li>
<li>switch to user</li>
<li>switch to page module (or list module)</li>
</ol>
<a name="Result"></a>
<h2 >Result<a href="#Result" class="wiki-anchor">¶</a></h2>
<p>The pages which are available for the group will now be displayed in the pagetree but the user has no access to them. If he clicks on a page, exception is thrown: "You don't have access to this page".</p>
<p>Also: context menu | "Info" is displayed, but this results in error message: "Sorry, you didn't have proper permissions to perform this change."</p>
<a name="Expected-behaviour"></a>
<h2 >Expected behaviour<a href="#Expected-behaviour" class="wiki-anchor">¶</a></h2>
<p>- If the user does not have access to the pages, they should <strong>not</strong> be displayed in the page tree and if he has access to no pages, no pages should be displayed in page tree<br />- in one case, an exception is thrown, in the other (Context "Info") a modal dialog is displayed with error. I would always expect the error message, not the exception</p>
<a name="Setup"></a>
<h2 >Setup<a href="#Setup" class="wiki-anchor">¶</a></h2>
user1:
<ul>
<li>has mostly default permissions, no DB mounts or any modifications of permissions, except:</li>
<li>has group group1</li>
<li>"Mounts and Workspaces" | ""Mount from groups" | "DB Mounts" is off</li>
</ul>
group1
<ul>
<li>has DB mount (page id 1)</li>
<li>has access to all modules: "Access Lists" | "Modules" : all selected</li>
<li>has (read) access to all tables: "Access Lists" | "Tables (listing)" : all selected</li>
</ul>
page tree (page id 1):
<ul>
<li>"everybody" has all permisions (set in "Access" module)</li>
</ul>
<a name="Versions"></a>
<h2 >Versions<a href="#Versions" class="wiki-anchor">¶</a></h2>
<p>Reproduced with</p>
<ul>
<li>v11 ... latest main</li>
</ul>
<a name="Screenshot"></a>
<h2 >Screenshot<a href="#Screenshot" class="wiki-anchor">¶</a></h2>
<p><img src="http://forge.typo3.org/attachments/download/37818/be_user_mount_from_groups_off_editing.png" alt="" loading="lazy" /></p>
<p><img src="http://forge.typo3.org/attachments/download/37817/mount_from_groups.png" alt="" loading="lazy" /></p>
<p><img src="http://forge.typo3.org/attachments/download/37815/be_user_mount_from_groups_off.png" alt="" loading="lazy" /></p> TYPO3 Core - Bug #51360 (Closed): Linkvalidator: specifying TSconfig in scheduler has no effecthttp://forge.typo3.org/issues/513602013-08-26T17:22:37ZSybille Peterssypets@gmx.de
<p>It is possible to set for example subject and content type via page TSconfig. This works fine. However, setting TSconfig in linkvalidator task in scheduler has no effect.</p>
<p>Using version TYPO3 4.5.29</p>