TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692021-12-07T09:29:03ZTYPO3 Forge
Redmine TYPO3 Core - Task #96267 (New): Add dedicated error for class construction without dependencieshttp://forge.typo3.org/issues/962672021-12-07T09:29:03ZMathias Brodalambrodala@pagemachine.de
<p>Right now if <code>GeneralUtility::makeInstance()</code> is used to construct a class which uses constructor dependency injection and has not being marked as <code>public</code>, a low-level <code>\ArgumentCountError</code> is thrown by PHP.</p>
<p>This should be improved by catching this case and replacing the error with a custom one (e.g. <code>MissingDependenciesError</code>). Either that custom error already hints at possible solutions or its dedicated error code is used to link to the docs with more details. The docs could then suggest to mark the class as <code>public</code> or manually pass the dependencies as arguments.</p> TYPO3 Core - Bug #87149 (Closed): Cannot debug Generator outputhttp://forge.typo3.org/issues/871492018-12-13T15:08:23ZMathias Brodalambrodala@pagemachine.de
<p>If <code>DebuggerUtility::var_dump()</code> is used on a <code>\Generator</code>, an error occurs:</p>
<blockquote>
<p>Cannot rewind a generator that was already run</p>
</blockquote>
<p>This is due to the implicit <code>rewind()</code> call within <code>DebuggerUtility::renderCollection()</code> which should be avoided for generators.</p> TYPO3 Core - Bug #87035 (Closed): AdditionalFactoryConfiguration.php not used anymorehttp://forge.typo3.org/issues/870352018-11-29T10:32:53ZMathias Brodalambrodala@pagemachine.de
<p>The <code>typo3conf/AdditionalFactoryConfiguration.php</code> file can be used to provide additional default values to be put into <code>typo3conf/LocalConfiguration.php</code> upon TYPO3 setup.</p>
<p>However, this file is not used anymore since TYPO3v9 and currently must be placed one level above instead, so basically next to <code>index.php</code>.</p>
<p>This is a regression introduced with <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Replace further path usages with Environment API (Closed)" href="http://forge.typo3.org/issues/85560">#85560</a>.</p> TYPO3 Core - Bug #85988 (Closed): @cli annotation deprecated without replacementhttp://forge.typo3.org/issues/859882018-08-27T11:10:51ZMathias Brodalambrodala@pagemachine.de
<p>With <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Deprecate @cli annotation (Closed)" href="http://forge.typo3.org/issues/85977">#85977</a> the <code>@cli</code> annotation has been deprecated without replacement but hinting at a successor in TYPO3v10. No matter if and when this will really happen we cannot do a deprecation without a replacement so this change needs to be reverted.</p> TYPO3 Core - Bug #84973 (Closed): Cannot delete invalid Scheduler taskhttp://forge.typo3.org/issues/849732018-05-11T17:39:24ZMathias Brodalambrodala@pagemachine.de
<p>When trying to delete an invalid Scheduler task (e.g. due to the related code being removed) an error occurs:</p>
<pre>
Fatal error: TYPO3\CMS\Scheduler\Scheduler::isValidTaskObject(): The script tried to execute a method or access a property of an incomplete object. Please ensure that the class definition &quot;<Task>&quot; of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide a __autoload() function to load the class definition in /.../typo3/sysext/scheduler/Classes/Scheduler.php on line 449
</pre> TYPO3 Core - Bug #84178 (Closed): Cannot create but upload file with "@" in namehttp://forge.typo3.org/issues/841782018-03-08T14:45:32ZMathias Brodalambrodala@pagemachine.de
<p>In FAL there are at least two different ways to create files which apparently do not apply the same sanitation/validation rules to file names.</p>
<p>This can be verified easily in the <strong>Filelist</strong> module: if you try to upload a file called <strong><a class="email" href="mailto:foo@bar.txt">foo@bar.txt</a></strong> everything simply works.</p>
<p>But if you create a file called <strong><a class="email" href="mailto:foo@bar.txt">foo@bar.txt</a></strong> a <code>ResourceDoesNotExistException</code> is thrown:</p>
<pre>
#1329647780: Object with identifier "1:/foo@bar.txt" does not exist in storage
</pre>
<p>When opening the file list once more after this, an error flash message is shown which says <em>File name "<a class="email" href="mailto:foo@bar.txt">foo@bar.txt</a>" was not allowed!</em>.</p>
<p>This behavior can be traced back to these two code paths:</p>
<ul>
<li><code>LocalDriver::addFile()</code> calls <code>LocalDriver::sanitizeFileName()</code> which accepts <strong><a class="email" href="mailto:foo@bar.txt">foo@bar.txt</a></strong> (this is used e.g. for file uploads)</li>
<li><code>LocalDriver::createFile()</code> calls <code>AbstractDriver::isValidFilename()</code> which denies <strong><a class="email" href="mailto:foo@bar.txt">foo@bar.txt</a></strong> (this is used for everything else)</li>
</ul> TYPO3 Core - Bug #83260 (Closed): Cannot set "class" for file upload elementhttp://forge.typo3.org/issues/832602017-12-08T14:26:31ZMathias Brodalambrodala@pagemachine.de
<p>HTML classes set via <code>elementClassAttribute</code> for the <code>FileUpload</code> element are not respected.</p> TYPO3 Core - Bug #82853 (Closed): Cannot translate field options by typehttp://forge.typo3.org/issues/828532017-10-25T11:41:28ZMathias Brodalambrodala@pagemachine.de
<p>The translation chain for field options (e.g. for <code>SingleSelect</code>) can only be translated a) by form identifier + field identifier or b) by field identifier. Other properties also include c) by field type.</p>
<p>This should be added.</p> TYPO3 Core - Bug #82518 (Closed): Broken composite form element check in RenderAllFormValuesViewH...http://forge.typo3.org/issues/825182017-09-20T13:51:32ZMathias Brodalambrodala@pagemachine.de
<p>The check for composite form elements in the <code>RenderAllFormValuesViewHelper</code> is broken:</p>
<pre>
if (
!$element instanceof FormElementInterface
|| $element->getType() === 'Honeypot'
|| (
isset($renderingOptions['_isCompositeFormElement'])
&& $renderingOptions['_isCompositeFormElement'] = true
)
) {
continue;
}
</pre>
<p>This was implicitly fixed for master in <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: EXT:form - do not show hidden field on confirmation page (Closed)" href="http://forge.typo3.org/issues/81770">#81770</a>.</p> TYPO3 Core - Task #77891 (Closed): Add Forger RST utility link to changelog HowTohttp://forge.typo3.org/issues/778912016-09-09T09:34:01ZMathias Brodalambrodala@pagemachine.de
<p>The <a href="https://docs.typo3.org/typo3cms/extensions/core/Changelog/Howto.html" class="external">changelog HowTo</a> should contain a link to the Forger RST utility.</p> TYPO3 Core - Bug #76928 (Closed): Cannot use speaking paths containing "typo3"http://forge.typo3.org/issues/769282016-07-04T16:16:12ZMathias Brodalambrodala@pagemachine.de
<p>If I use an extension for speaking paths (RealURL/CoolURI/...) and create a page named "TYPO3", the path segment will be ".../typo3/". Opening that page yields a 404 from the webserver.</p>
<p>This is caused by a too generous <code>RewriteRule</code> in the default <code>.htaccess</code> which is meant for passing through static resources.</p> TYPO3 Core - Bug #72548 (Closed): Cannot install: phpwhois/idna-convert cannot be downloadedhttp://forge.typo3.org/issues/725482016-01-06T10:01:16ZMathias Brodalambrodala@pagemachine.de
<p>The Github repository of the package <a href="https://packagist.org/packages/phpwhois/idna-convert" class="external">phpwhois/idna-convert</a> is somehow gone which makes every Composer installation of TYPO3 fail:</p>
<pre>
- Installing phpwhois/idna-convert (v0.8.2)
Downloading
Failed to download phpwhois/idna-convert from dist: The "https://api.github.com/repos/phpWhois/idna-convert/zipball/ea337954b43ae47f5ebba97c19d309081bebc46e" file could not be downloaded (HTTP/1.1 404 Not Found)
Now trying to download from source
- Installing phpwhois/idna-convert (v0.8.2)
Cloning ea337954b43ae47f5ebba97c19d309081bebc46e
[RuntimeException]
Failed to clone git@github.com:phpWhois/idna-convert.git via git, https, ssh protocols, aborting.
- git://github.com/phpWhois/idna-convert.git
Cloning into '/.../vendor/phpwhois/idna-convert'...
fatal: remote error:
Repository not found.
- https://github.com/phpWhois/idna-convert.git
Cloning into '/.../vendor/phpwhois/idna-convert'...
remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/phpWhois/idna-convert.git/'
- git@github.com:phpWhois/idna-convert.git
Cloning into '/.../vendor/phpwhois/idna-convert'...
Warning: Permanently added 'github.com,192.30.252.129' (RSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
</pre>
<p>I am currently investigating the options since the whole issue is a mess.</p> TYPO3 Core - Bug #61529 (Closed): Cannot ensure checkbox for multiple valueshttp://forge.typo3.org/issues/615292014-09-11T12:10:41ZMathias Brodalambrodala@pagemachine.de
<p>In TYPO3.Fluid the <code><f:form.checkbox/></code> viewhelper has a <code>multiple</code> attribute to enforce field value processing as array. This is not possible with the CMS Fluid and only marked as <code>@todo</code>.</p>
<p>This should be fixed by adding the attribute and respecting it the same way as TYPO3.Fluid.</p> TYPO3 Core - Bug #60913 (Closed): Cannot edit lazy loaded objectshttp://forge.typo3.org/issues/609132014-08-12T14:01:52ZMathias Brodalambrodala@pagemachine.de
<p>Lazy loaded objects cannot be edited through Fluid forms.</p>
<p>Given the following form:</p>
<pre>
<f:form name="bar" object="{foo.bar}">
<f:form.textfield property="propertyOfBar"/>
<f:form.submit value="Update"/>
</f:form>
</pre>
<p>If "bar" of "foo" is an instance of <code>TYPO3\CMS\Extbase\Persistence\Generic\LazyLoadingProxy</code> the initial check in <code>TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormViewHelper::renderHiddenIdentityField</code> fails because the <code>LazyLoadingProxy</code> instance cannot be an instance of <code>TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject</code>. This prevents the hidden identity field from being rendered which makes editing impossible.</p> TYPO3 Core - Bug #60338 (Closed): Changing view format does not affect partial formathttp://forge.typo3.org/issues/603382014-07-15T15:35:24ZMathias Brodalambrodala@pagemachine.de
<p>When using one view object to render a template in different formats (e.g. email in text and HTML), the template respects the requested format. However, partials are always rendered in the first rendered format. Example:</p>
<p><strong>Content of templates/partials</strong>:</p>
<p>Content of <code>Foo.txt</code>:<br /><pre>
Hello
<f:render partial="Bar"/>
</pre></p>
<p>Content of <code>Partials/Bar.txt</code>:<br /><pre>
World
</pre></p>
<p>Content of <code>Foo.html</code>:<br /><pre>
<p>Text</p>
<f:render partial="Bar"/>
</pre></p>
<p>Content of <code>Partials/Bar.html</code>:<br /><pre>
<p>World</p>
</pre></p>
<p><strong>1st invocation</strong>:</p>
<pre>
// Let $view be an instance of \TYPO3\CMS\Fluid\View\TemplateView
$view->setFormat('txt');
$view->render('Foo');
</pre>
<p>Result:<br /><pre>
Hello
World
</pre></p>
<p><strong>2nd invocation</strong>:</p>
<pre>
// $view is the same instance as above
$view->setFormat('html');
$view->render('Foo');
</pre>
<p>Result:<br /><pre>
<p>Hello</p>
World
</pre></p>
<p>As you can see, the 2nd output was rendered using the txt-Partial.</p>
<p>This is due to the local partial identifier cache in <code>AbstractTemplateView</code> which only considers the partial name, not the current request format. If that one is incorporated, separate cache entries for each partial formats are created.</p>