TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692024-03-26T08:54:11ZTYPO3 Forge
Redmine TYPO3 Core - Task #103485 (Under Review): Provide lib.parseFunc via ext:frontendhttp://forge.typo3.org/issues/1034852024-03-26T08:54:11ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #101483 (Closed): Revert "[!!!][TASK] Introduce type declarations in AbstractFile"http://forge.typo3.org/issues/1014832023-07-29T07:52:20ZBenjamin Franzkeben@bnf.dev
<p>There were errors in CI that have not been catched properly.</p> TYPO3 Core - Task #101481 (Closed): Revert "[!!!][TASK] Add native type declarations to GU array...http://forge.typo3.org/issues/1014812023-07-29T07:42:45ZBenjamin Franzkeben@bnf.dev
<p>CI test failures were not catched properly.</p> TYPO3 Core - Task #101265 (Closed): Update docs to refer to ES6 modules instead of RequireJShttp://forge.typo3.org/issues/1012652023-07-06T14:30:36ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #97319 (Closed): Revert "[TASK] Refresh the look of pagemodule"http://forge.typo3.org/issues/973192022-04-06T13:40:00ZBenjamin Franzkeben@bnf.dev
<p>Reason for revert:</p>
<ul>
<li>Invasive change that was merged too quickly</li>
<li>Missing commit message description
* No description of the global scope/direction.<br /> Will the new style be applied to <strong>all</strong> backend<br /> interfaces? And who will feel responsible?
* Deserves an epic on forge</li>
<li>Missing credits to structured content initiative</li>
<li>Quality issues:
* Delete button removal does not have broad acceptance
* Inconsistent border radii for content elements and grid cells
* Inconsistent elevation (box-shadow) for elements and grid cells</li>
</ul> TYPO3 Core - Task #96725 (Closed): Use generics for ObjectProphecy class propertieshttp://forge.typo3.org/issues/967252022-02-01T15:52:33ZBenjamin Franzkeben@bnf.dev
<p>With <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Fix incorrect Prophecy usages (Closed)" href="http://forge.typo3.org/issues/96713">#96713</a> all type annotations on class properties<br />in tests have been reduced to ObjectProphecy only,<br />removing the information which class or interface<br />is mocked.</p>
<p>The jangregor/phpstan-prophecy plugin defines ObjectProphecy<br />as a generic tag, allowing generics to be used and<br />resolved by PHPStan. Therefore the type annotations<br />on class properties or function results are now re-added.</p> TYPO3 Core - Task #96709 (Closed): Serialize PageRenderer state instead of the entire classhttp://forge.typo3.org/issues/967092022-01-31T13:54:15ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #96707 (Closed): Fix PHPStan errors in JavaScript module classeshttp://forge.typo3.org/issues/967072022-01-31T10:35:53ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #96706 (Closed): Remove broken test from ServiceProviderCompilationPassTesthttp://forge.typo3.org/issues/967062022-01-31T09:57:41ZBenjamin Franzkeben@bnf.dev
<p>PHPStan static analysis revealed that the method<br />exceptionForInvalidFactories() did not containa a proper test<br />setup, which went undetected as the expected TypeError<br />was thrown for the invalid test setup.</p>
<p>This could have been fixed but the test actually only<br />tried to assert whether a callable type declaration is set,<br />in order to test whether a PHP error is thrown when an<br />invalid factory is provided. This is useless as an<br />invalid factory will result in an error in any case,<br />once tried to be called.</p> TYPO3 Core - Task #96704 (Closed): Harden event listener automagic parameter type resolutionhttp://forge.typo3.org/issues/967042022-01-31T07:50:21ZBenjamin Franzkeben@bnf.dev
<p>Do only auto-resolve the event name if the reflection type<br />of the first parameter is a ReflectionNamedType [1] as<br />only this subclass of ReflectionType defines the getName() method.</p>
<p>[1] <a class="external" href="https://www.php.net/manual/en/class.reflectionnamedtype.php">https://www.php.net/manual/en/class.reflectionnamedtype.php</a></p> TYPO3 Core - Task #92298 (Closed): phpstan related changes to DependencyInjection caused wrong ty...http://forge.typo3.org/issues/922982020-09-13T06:55:53ZBenjamin Franzkeben@bnf.dev
<p><a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/65685">https://review.typo3.org/c/Packages/TYPO3.CMS/+/65685</a></p>
<p>In ServiceProviderRegistry::create Package argument was changed to PackageInterface,<br />but the method getServiveProvider() is not available on the Interface.<br />Package was declared as type (instead of PackageInterface) by intent.</p> TYPO3 Core - Task #91500 (Closed): Remove runtimeActivatedPackages left overs after deprecation r...http://forge.typo3.org/issues/915002020-05-27T09:07:03ZBenjamin Franzkeben@bnf.dev
<p><a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/64584">https://review.typo3.org/c/Packages/TYPO3.CMS/+/64584</a></p>
<p>From what I see right now there are some remaining places where runtimeActivatesPackages are still taken into account:</p>
<p>typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php calculates $GLOBALS['TYPO3_CONF_VARS']['EXT']['runtimeActivatedPackages'] into cache hashes.</p>
<p>typo3/sysext/core/Configuration/DefaultConfiguration.php contains the default value.</p>
<p>typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php contains logic regarding runtimeActivatedPackages.</p>
<p>See:<br />git grep runtimeActivatedPackages | grep -v "/Documentation/\|/ExtensionScanner/"</p>
<p>Also the Bootstrapping could be adapted to remove hacks that where needed for runtime activated packages.</p> TYPO3 Core - Task #88721 (Closed): Hook up ContainerInterface in backend route dispatcherhttp://forge.typo3.org/issues/887212019-07-11T11:55:58ZBenjamin Franzkeben@bnf.dev
<p>Backend RouterDispatcher use the symfony provided PSR-11 container to retrieve services from the container, if available.</p> TYPO3 Core - Task #87742 (Closed): Use real ObjectManager stubs in unit testshttp://forge.typo3.org/issues/877422019-02-19T12:19:14ZBenjamin Franzkeben@bnf.dev
<p>Prevent invocation of the constructor (which instantiates<br />an internal instance of the extbase container) and do not<br />mix usage of mocked and stubbed methods.</p>
<p>The mixture happened due to using setMethods(['get']) – where<br />all other methods (besides 'get()') are actually proxied to the<br />real ObjectManager.</p> TYPO3 Core - Task #87741 (Closed): Mock SignalSlot\Dispatcher FileRepository Singletons in unit t...http://forge.typo3.org/issues/877412019-02-19T12:17:22ZBenjamin Franzkeben@bnf.dev
<p>Prevent indirect ObjectManager invocation by mocking FileRepository.</p>