TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692018-03-20T06:46:09ZTYPO3 Forge
Redmine TYPO3 Core - Task #84490 (Closed): Add missing HTTP status code presets for PSR-7 responseshttp://forge.typo3.org/issues/844902018-03-20T06:46:09ZBenjamin Franzkeben@bnf.dev
<p>The list of status codes/reason phrases should be synchronized with<br /><a class="external" href="http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml">http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml</a></p> TYPO3 Core - Task #84126 (Closed): Remove comments that contain v4 or FLOW informationhttp://forge.typo3.org/issues/841262018-03-03T12:42:52ZBenjamin Franzkeben@bnf.dev
<p>Whether a class or functionality is not available or available<br />differently in v4 or FLOW is not relevant for TYPO3 CMS.<br />They should be removed.</p> TYPO3 Core - Task #84117 (Closed): Do not reinitialize CacheManager and PackageManager in clearAl...http://forge.typo3.org/issues/841172018-03-02T14:09:54ZBenjamin Franzkeben@bnf.dev
<p>Those (re)initializations originate from <a class="external" href="https://review.typo3.org/19605">https://review.typo3.org/19605</a><br />were reinitializeClassLoaderAndCachesAndPackageManagement()<br />was used to "Reinitialize the class loader during clear cache actions" <br />(according to phpdoc).</p>
<p>Then with the changes in <a class="external" href="https://review.typo3.org/29811">https://review.typo3.org/29811</a><br />reinitializeClassLoaderAndCachesAndPackageManagement()<br />was dropped and splitted into unregisterClassLoader(),<br />flagCachingFrameworkForReinitialization().<br />initializeCachingFramework() and initializePackageManagement().<br />(just historical info, still all good)</p>
<p>Then <a class="external" href="http://review.typo3.org/39827">http://review.typo3.org/39827</a> came and dropped unregisterClassLoader<br />but left the CacheManager and PackageManager reinitialization in place<br />superfluously. It's superfluous as the original usecase was to<br />reinitialize the class loader which is no longer required.</p> TYPO3 Core - Task #84109 (Closed): Merge the package DependencyResolver into the PackageManagerhttp://forge.typo3.org/issues/841092018-03-01T19:38:55ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #84107 (Closed): Stop monkey patching CacheManager configuration in InstallToolhttp://forge.typo3.org/issues/841072018-03-01T16:55:38ZBenjamin Franzkeben@bnf.dev
<p>Instead of creating the cacheManager and then disabling all cache confiurations afterwards, the desired state should simply be enforced inside the CacheManager.</p> TYPO3 Core - Task #84102 (Closed): Set COMPOSER_ROOT_VERSION to 9.2.0@dev for bamboohttp://forge.typo3.org/issues/841022018-03-01T11:55:15ZBenjamin Franzkeben@bnf.dev
<p>If typo3/testing-framework needs to be synced with changes<br />in core it needs to require the dev branch of the upcoming<br />release as the compatibility to previous releases needs to<br />be dropped.<br />Therefore it has to define a dependency in composer.json like:<br /> "typo3/cms-core": "^9.2@dev"</p>
<p>If composer install is executed with COMPOSER_ROOT_VERSION<br />set to 9.1.0 that produces a conflict, therefore the version<br />should be raised to 9.2.0@dev.</p> TYPO3 Core - Task #84099 (Closed): Decouple SystemEnvironmentBuilder from Bootstraphttp://forge.typo3.org/issues/840992018-03-01T11:10:58ZBenjamin Franzkeben@bnf.dev
<p>Do not rely on defined constants or methods from Bootstrap<br />to be usable on it own (at some point).</p> TYPO3 Core - Task #84083 (Closed): ApplicationContext should consistently be retrieved from Gener...http://forge.typo3.org/issues/840832018-02-28T15:28:39ZBenjamin Franzkeben@bnf.dev
<p>ClassLoadingInformation reads from Bootstrap, that should be adapted to use GeneralUtility.</p>
<p>Bootstrap code states:</p>
<pre>
* Use \TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext() instead
</pre>
<p>Therefore the method should just be removed.</p> TYPO3 Core - Task #84082 (Closed): A LogRecord should not rely on global state (requestId from Bo...http://forge.typo3.org/issues/840822018-02-28T15:17:33ZBenjamin Franzkeben@bnf.devTYPO3 Core - Bug #83946 (Closed): Content-Type for some backend ajax routes and eID scripts broke...http://forge.typo3.org/issues/839462018-02-16T21:06:04ZBenjamin Franzkeben@bnf.dev
<p><a class="external" href="https://review.typo3.org/c/55754">https://review.typo3.org/c/55754</a> refactored all PSR-7<br />related controllers to remove an own response.</p>
<p>Missing is the fact that ajax routes used a<br />pre-generated response with application/json<br />Content-Type header.<br />eID scripts did not use a pre-generated header<br />at all.</p> TYPO3 Core - Bug #83867 (Closed): ProductionExceptionHandler: assumes TSFE is always availablehttp://forge.typo3.org/issues/838672018-02-12T21:56:06ZBenjamin Franzkeben@bnf.dev
<p>Uncaught Error: Call to a member function isBackendUserLoggedIn() on null<br />in […]/typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php:103</p> TYPO3 Core - Bug #83854 (Closed): EidHandler triggers an exception when an eID script returns nullhttp://forge.typo3.org/issues/838542018-02-12T09:56:05ZBenjamin Franzkeben@bnf.dev
<p>A null return value returned by a eID script needs to be converted to NullResponse.</p>
<pre>
Core: Exception handler (WEB): Uncaught TYPO3 Exception: Return value of TYPO3\CMS\Frontend\Middleware\EidHandler::process() must implement interface Psr\Http\Message\ResponseInterface, null returned | TypeError thrown in file […]/typo3/sysext/frontend/Classes/Middleware/EidHandler.php in line 66. Requested URL: http://127.0.0.1:3002/index.php?eID=dumpFile&t=f&f=1&token=38b5b8024d5652bc59ce83ed943fec71def7d417
</pre> TYPO3 Core - Bug #83802 (Closed): Timetracker and pre-process middleware ordering is incorrecthttp://forge.typo3.org/issues/838022018-02-07T21:59:57ZBenjamin Franzkeben@bnf.dev
<p>The middlware's introduced in <a class="external" href="https://review.typo3.org/c/55537/">https://review.typo3.org/c/55537/</a> did not preserve the sequence as used before.</p>
<p>timetracker has been marked to be executed after the preprocessing:</p>
<pre>
'typo3/cms-frontend/timetracker' => [
'target' => \TYPO3\CMS\Frontend\Middleware\TimeTrackerInitialization::class,
'after' => [
'typo3/cms-frontend/preprocessing'
]
]
</pre>
<p>'timetracker' needs to be executed first, then the request 'preprocessing', as done before the mentioned change:</p>
<pre>
// Starting time tracking
$configuredCookieName = trim($GLOBALS['TYPO3_CONF_VARS']['BE']['cookieName']) ?: 'be_typo_user';
/** @var TimeTracker $timeTracker */
$timeTracker = GeneralUtility::makeInstance(TimeTracker::class, ($request->getCookieParams()[$configuredCookieName] ? true : false));
$timeTracker->start();
// Hook to preprocess the current request
foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preprocessRequest'] ?? [] as $hookFunction) {
$hookParameters = [];
GeneralUtility::callUserFunction($hookFunction, $hookParameters, $hookParameters);
}
</pre> TYPO3 Core - Feature #83725 (Closed): Introduce PSR-15 HTTP Middleware supporthttp://forge.typo3.org/issues/837252018-01-29T21:10:04ZBenjamin Franzkeben@bnf.dev
<p>The PSR-15 middleware specification was released on 22nd of january 2018.<br />TYPO3 should support PSR-15 middlewares out-of-the box.</p>
<p>Supporting PSR-15 middlewares improves interoperability with independent libraries and would superseed ugly hooks like <code>$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preprocessRequest']</code> (ugly as they have not been adapted when PSR-7 Requests/Responses were introduced).</p> TYPO3 Core - Bug #79107 (Closed): Extensionmanager shows incorrect warning in composer modehttp://forge.typo3.org/issues/791072016-12-29T13:24:05ZBenjamin Franzkeben@bnf.dev
<p>The warning should be an info instead, as the warning can't be resolved besides not using composer:</p>
<blockquote><blockquote>
<p>The system is set to composer mode. Please notice that it is not possible to add an extension with the Extension Manager. You have to use composer to add further extensions to your system.</p>
</blockquote></blockquote>