TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-08-24T11:06:22ZTYPO3 Forge
Redmine TYPO3 Core - Bug #101747 (Rejected): Web Components with CSS in shadowRoot are not usable in cros...http://forge.typo3.org/issues/1017472023-08-24T11:06:22ZBenjamin Franzkeben@bnf.dev
<p>As already reported in <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Streamline icon elements (Closed)" href="http://forge.typo3.org/issues/100270">#100270</a> and reverted in <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Reactivate usage of constructable stylesheets for icon element (Closed)" href="http://forge.typo3.org/issues/101464">#101464</a>, web Components with CSS in shadowRoot are not usable in cross frame boundaries.<br />This happens when a custom element is created within <code>window.list_frame</code> via <code>document.createElement()</code> and is then attached to another frame via <code>appendChild()</code>.<br />This mostly happens when code is written that renders web components into a Modal (which is placed in the outer frame)</p>
<p>Following exception is logged in that case.<br /><pre>
css-tag.js?bust=1692874613:6 Uncaught DOMException: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed
at S (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/css-tag.js?bust=1692874613:6:1012)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:2898)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:163)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:3010)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:478)
at R.k (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:4627)
at R.$ (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:4701)
at R.g (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:5085)
at R._$AI (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:4534)
at D (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:7898)
</pre></p>
<p>This can easily reproduced via:<br /><pre><code class="javascript syntaxhl" data-language="javascript"><span class="nb">document</span><span class="p">.</span><span class="nx">body</span><span class="p">.</span><span class="nf">appendChild</span><span class="p">(</span><span class="nb">window</span><span class="p">.</span><span class="nx">list_frame</span><span class="p">.</span><span class="nb">document</span><span class="p">.</span><span class="nf">createElement</span><span class="p">(</span><span class="dl">'</span><span class="s1">typo3-backend-icon</span><span class="dl">'</span><span class="p">))</span>
</code></pre></p>
<p>Which also logs to the console:<br /><pre>
css-tag.js?bust=1692874613:6 Uncaught DOMException: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed
at S (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/css-tag.js?bust=1692874613:6:1012)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:2898)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:163)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:3010)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:478)
at <anonymous>:1:15
</pre></p>
<p>Note that this is known in lit, but not easily fixable, as the <code>css``</code> template literaly implicitly use <code>(window).CSSStyleSheet</code></p>
<p><a class="external" href="https://github.com/lit/lit-element/issues/1139">https://github.com/lit/lit-element/issues/1139</a><br /><a class="external" href="https://github.com/lit/lit/issues/2068">https://github.com/lit/lit/issues/2068</a></p> TYPO3 Core - Task #98496 (Rejected): Remove outdated ckeditor requirejs configurationhttp://forge.typo3.org/issues/984962022-10-01T18:55:17ZBenjamin Franzkeben@bnf.dev
<p>With the migration to use plain script-loading for CKEditor v4<br />it was forgotten to remove the RequireJS configuration that was <br />intended to be removed as preparation for ES6-only mode <br />in TYPO3 core.</p> TYPO3 Core - Bug #97144 (Closed): Slow module scrolling in Google Chrome on Linuxhttp://forge.typo3.org/issues/971442022-03-08T15:09:57ZBenjamin Franzkeben@bnf.dev
<p>Scrolling the list module with 100 entries causes FPS to drop to <15fps on Google Chrome (v99) with Linux during scrolling.<br />This is for sure a Chrome Bug, but reveals that <code>overflow: hidden</code> and <code>scrolling="no"</code> on the module iframe is not a good idea.</p>
<p>It would be great to remove the <code>scrolling="no"</code> parameter from the module iframe and enable scrolling on <html> instead of .module-body</p>
<p>There are some past issues to take into account when changing the module-scrolling semantics: <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: Correct horizontal scrolling in iOS browsers (Closed)" href="http://forge.typo3.org/issues/83841">#83841</a> <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: rte_ckeditor displaces dropdown overlays and jumps to top of page on crome/safari (Closed)" href="http://forge.typo3.org/issues/80116">#80116</a> <a class="issue tracker-1 status-5 priority-6 priority-high2 closed" title="Bug: RTE CKeditor top-positioning for maximize and combopanels is broken in browsers with webkit (Closed)" href="http://forge.typo3.org/issues/82780">#82780</a></p>
<p>Using overflow: auto on <code><html></code> as suggested in <a class="external" href="https://forge.typo3.org/issues/80116#note-7">https://forge.typo3.org/issues/80116#note-7</a> was mainly avoided because of mobile iOS overscroll behaviour, otherwise this could have already been changed with: <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/55647">https://review.typo3.org/c/Packages/TYPO3.CMS/+/55647</a></p>
<p>Consider using the standardized <code>overscroll-behaviour</code> property to fix issues on that part.</p> TYPO3 Core - Bug #93233 (Closed): Backend Group Comparison is brokenhttp://forge.typo3.org/issues/932332021-01-06T15:46:40ZBenjamin Franzkeben@bnf.dev
<pre>
(1/1) Error
Typed property TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::$userSession must not be accessed before initialization
in /home/ben/src/TYPO3.CMS/typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php line 1012
* @return mixed
*/
public function getSessionData($key)
{
return $this->userSession->get($key);
}
</pre> TYPO3 Core - Bug #93132 (Closed): Localization carousel doesn't move slideshttp://forge.typo3.org/issues/931322020-12-21T10:33:31ZBenjamin Franzkeben@bnf.dev
<p>Bootstrap carousel item has been renamed to carousel-item.</p>
<p><img src="http://forge.typo3.org/attachments/download/35704/localization-carousel-doesnt-move.png" alt="" loading="lazy" /></p>
<p>See <a class="external" href="https://getbootstrap.com/docs/5.0/components/carousel/">https://getbootstrap.com/docs/5.0/components/carousel/</a></p> TYPO3 Core - Bug #92239 (Closed): SymfonyEventDispatcher is not symfony/event-dispatcher-contract...http://forge.typo3.org/issues/922392020-09-09T12:09:37ZBenjamin Franzkeben@bnf.dev
<p><b>Fatal error</b>: Declaration of TYPO3\CMS\Core\Adapter\SymfonyEventDispatcher::dispatch(object $event, ?string $eventName = NULL): object must be compatible with Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch($event) in <b>[…]typo3/sysext/core/Classes/Adapter/SymfonyEventDispatcher.php</b> on line <b>26</b><br /></p>
<p><a class="external" href="https://bamboo.typo3.com/browse/CORE-GTN-229">https://bamboo.typo3.com/browse/CORE-GTN-229</a></p> TYPO3 Core - Bug #91398 (Closed): Serialization of ObjectManager is brokenhttp://forge.typo3.org/issues/913982020-05-14T13:11:34ZBenjamin Franzkeben@bnf.dev
<p>This is broken in v10 since the introduction of dependency injection in:<br /><a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/58255">https://review.typo3.org/c/Packages/TYPO3.CMS/+/58255</a></p>
<p>Using:<br /><pre>
serialize($this->objectManager)
</pre></p>
<p>Results in the following exception:</p>
<pre>
(1/1) Exception
Serialization of 'Closure' is not allowed
</pre> TYPO3 Core - Bug #91316 (Closed): MetaTagManagerRegistry instance not unique in uncached pluginshttp://forge.typo3.org/issues/913162020-05-06T09:04:27ZBenjamin Franzkeben@bnf.dev
<p>Reported by Aristeidis Karavas (Apr 28th at 11:51) via Slack:<br /><a class="external" href="https://typo3.slack.com/archives/C025BQLFA/p1588067478426300">https://typo3.slack.com/archives/C025BQLFA/p1588067478426300</a></p>
<blockquote>
<p>Why in TYPO3 v10 this won't set the meta tags in frontend?<br />$metaTag = $this->metaTagManagerRegistry->getManagerForProperty($key);<br />$metaTag->addProperty($key, $metaTagValue);<br />If i debug it, it sets everything right but it won't be displayed in the frontend</p>
</blockquote>
<p>The reason is that the PageRenderer stores a new Singleton via <code>GeneralUtility::setSingletonInstance</code> in <code>__wakeup</code>.</p>
<p>That updates <code>MetaTagManagerRegistry</code> instances retrieved via <code>GeneralUtility::makeInstance</code>, but not those injected via symfony DI,<br />where the object will already have been generated, as it is loaded during EXT:seo/ext_localconf.php loading and GeneralUtility::makeInstance<br />will call the DI container.</p>
<p>This issues happens when the PageRenderer was serialized and is unserialized for <code>USER_INT</code> plugins (e.g. uncached extbase plugins).</p>
<p>Same applies to AssetCollector, which is serialized and unserialized as well.</p> TYPO3 Core - Bug #91074 (Rejected): typo3conf/ folder is not created when using a custom app-dir ...http://forge.typo3.org/issues/910742020-04-17T01:15:10ZBenjamin Franzkeben@bnf.dev
<p>In composer mode in composer.json:</p>
<pre><code>"extra": {<br /> "typo3/cms": {<br /> "app-dir": "custom",<br /> "web-dir": "public" <br /> }<br /> },</code></pre>
<p>In this case Environment::$projectPath would be /path/to/root/custom and Environment::$publicPath would be /path/to/root/public.</p>
<p>The typo3conf folder is then generated in /path/to/root/custom/typo3conf instead of /path/to/root/public/typo3conf.</p>
<p>This is actually by accident, because "custom" and "public" have the same length.<br />Reason is the code in <a class="external" href="https://git.typo3.org/Packages/TYPO3.CMS.git/blob/9fb677f6f3b3a1cd584b9ef183b35da771d3e25d:/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php#l134">https://git.typo3.org/Packages/TYPO3.CMS.git/blob/9fb677f6f3b3a1cd584b9ef183b35da771d3e25d:/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php#l134</a><br /><pre>
$publicPath = substr(Environment::getPublicPath(), strlen(Environment::getProjectPath())+1);
</pre><br />which tries to substract the project path from the public path, while assuming that project path is an ancestor, which results in a public path <code>""</code> to be calculate.<br />The result should rather be <code>"../public"</code>.</p>
<p>We should rather generate a relative path and adapt the FolderStructur Factory to handle relative paths, include partent dots ("..").</p> TYPO3 Core - Bug #89891 (Closed): Temporary assets can not be removed in install tool, exception ...http://forge.typo3.org/issues/898912019-12-06T22:37:42ZBenjamin Franzkeben@bnf.dev
<p>Exception is:</p>
<p>Too few arguments to function TYPO3\CMS\Core\Resource\ResourceFactory::__construct(), 0 passed in […]/typo3/sysext/core/Classes/Utility/GeneralUtility.php on line 3461 and exactly 1 expected</p>
<p>Solution:<br />The ResourceFactory needs to be defined by a service provider to be available in install tool mode.</p> TYPO3 Core - Bug #88808 (Closed): Warning in AbstractConfigurationManagerTesthttp://forge.typo3.org/issues/888082019-07-19T20:45:19ZBenjamin Franzkeben@bnf.dev
<pre>
TYPO3\CMS\Extbase\Tests\Unit\Configuration\AbstractConfigurationManager
⚠ Controller of switchable controller actions can be a fully qualified class name
┐
├ Trying to configure method "getSwitchableControllerActions" which cannot be configured because it does not exist, has not been specified, is final, or is static
│
</pre> TYPO3 Core - Bug #88576 (Closed): SiteProcessorTest produces a warning because of wrong method mo...http://forge.typo3.org/issues/885762019-06-17T16:35:22ZBenjamin Franzkeben@bnf.dev
<pre>
1) TYPO3\CMS\Frontend\Tests\Unit\DataProcessing\SiteProcessorTest::nullIsProvidedIfSiteCouldNotBeRetrieved
Trying to configure method "getSiteFinder" which cannot be configured because it does not exist, has not been specified, is final, or is static
</pre> TYPO3 Core - Bug #87997 (Rejected): Links to workspace overlays should not be generated without b...http://forge.typo3.org/issues/879972019-03-25T11:49:57ZBenjamin Franzkeben@bnf.dev
<p>If an editor links to a versioned page id (let's say 1011) directly (e.g. by specifying that id in header_link),<br />that link is currently generated as /index.php?id=1011 when the frontend is visited as a regular visitor (e.g. without backend/workspace context).</p>
<p>Visiting that page will fail with "page not found" (which is fine).</p>
<p>It would be expected that links wouldn't be generated at all (that means: link is empty), as for hidden/deleted pages.</p> TYPO3 Core - Bug #87622 (Closed): Minimum required prophecy version is incompatible with object (...http://forge.typo3.org/issues/876222019-02-02T06:08:41ZBenjamin Franzkeben@bnf.dev
<p>Recent changes like <a class="external" href="https://review.typo3.org/c/59600/">https://review.typo3.org/c/59600/</a> introduced <code>object</code> return type decarations which are only supported as of prophecy version 1.7.5.<br />This caused nightly, composer minimum builds, to fail: <a class="external" href="https://bamboo.typo3.com/browse/CORE-GTN-UT2PHP72-646">https://bamboo.typo3.com/browse/CORE-GTN-UT2PHP72-646</a></p>
<p>Therefore the default minimum – as required by phpunit (^1.7) – needs to be raised to 1.7.5.</p> TYPO3 Core - Bug #87229 (Closed): checkDataSubmission is missing in extension scannerhttp://forge.typo3.org/issues/872292018-12-19T20:05:14ZBenjamin Franzkeben@bnf.dev
<p>In <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Deprecate hooks superseded by PSR-15 middlewares (Closed)" href="http://forge.typo3.org/issues/86279">#86279</a> checkDataSubmission slipped through and was forgotten to be mentioned in a .rst file and the extension scanner configuration.</p>