TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692024-03-23T06:28:58ZTYPO3 Forge
Redmine TYPO3 Core - Task #103473 (Resolved): Account for double click pagetree timeout in acceptance testshttp://forge.typo3.org/issues/1034732024-03-23T06:28:58ZBenjamin Franzkeben@bnf.devTYPO3 Core - Feature #103439 (Under Review): Site TypoScripthttp://forge.typo3.org/issues/1034392024-03-20T14:35:14ZBenjamin Franzkeben@bnf.dev
<p>Allow TypoScript without requiring sys_template records.</p>
<p>Idea: A site can define TypoScript and include other dependencies via profiles (<a class="issue tracker-2 status-8 priority-4 priority-default child" title="Feature: Site Profiles that ship Settings, TypoScript, TSConfig, Templates and enabled Content Elements (Under Review)" href="http://forge.typo3.org/issues/103437">#103437</a>)</p> TYPO3 Core - Task #103081 (Resolved): Failing nightlies due to incorrect window sizehttp://forge.typo3.org/issues/1030812024-02-08T10:54:12ZBenjamin Franzkeben@bnf.dev
<p><a class="external" href="https://git.typo3.org/typo3/CI/cms/-/pipelines/52871">https://git.typo3.org/typo3/CI/cms/-/pipelines/52871</a></p>
<pre>
1) PageTreeFilterCest: Clear filter reloads page tree without filter applied
Test Acceptance/Application/PageTree/PageTreeFilterCest.php:clearFilterReloadsPageTreeWithoutFilterApplied
Step Can see "inline mngroup","#typo3-pagetree-tree .nodes-list"
Fail Failed asserting that any element by '#typo3-pagetree-tree .nodes-list' on page /typo3/module/web/list?id=51
Elements:
+ <div> New TYPO3 site
Root
styleguide TCA demo
staticdata
ctrl common
ctrl minimal
displaycond
elements basic
elements folder
elements group
elements imagemanipulation
elements rte
elements select
elements slugs
elements t3editor
file
flex
inline 11
inline 1n
inline 1n1n
inline 1nnol10n
inline 1nreusabletable
inline expand
inline expandsingle
inline foreignrecorddefaults
contains text 'inline mngroup'
Scenario Steps:
19. $I->canSee("inline mngroup","#typo3-pagetree-tree ...") at Acceptance/Application/PageTree/PageTreeFilterCest.php:83
18. $I->canSee("elements group","#typo3-pagetree-tree ...") at Acceptance/Application/PageTree/PageTreeFilterCest.php:82
17. $I->waitForElementVisible("//*[text()='inline expa...") at Acceptance/Application/PageTree/PageTreeFilterCest.php:81
16. $I->waitForElementNotVisible("#typo3-pagetree ....",10) at Acceptance/Application/PageTree/PageTreeFilterCest.php:116
15. $I->waitForElement("#typo3-pagetree-tree .nodes...",10) at Acceptance/Application/PageTree/PageTreeFilterCest.php:115
14. $I->pressKey("#typo3-pagetree #typo3-pagetree-...","") at Acceptance/Application/PageTree/PageTreeFilterCest.php:78
Artifacts:
</pre>
<p><img src="http://forge.typo3.org/attachments/download/38243/TYPO3.CMS.Core.Tests.Acceptance.Application.PageTree.PageTreeFilterCest.clearFilterReloadsPageTreeWithoutFilterApplied.headless.fail.png" alt="" loading="lazy" /></p> TYPO3 Core - Task #102132 (Closed): CI Composer max failure: phpstan: Ignored error pattern in T...http://forge.typo3.org/issues/1021322023-10-10T04:43:13ZBenjamin Franzkeben@bnf.dev
<p><a class="external" href="https://git.typo3.org/typo3/CI/cms/-/jobs/2632464">https://git.typo3.org/typo3/CI/cms/-/jobs/2632464</a></p>
<pre>
- Upgrading phpstan/phpdoc-parser (1.20.0 => 1.24.2)
- Upgrading phpstan/phpstan-phpunit (1.3.14 => 1.3.15)
</pre>
<pre>
$ Build/Scripts/runTests.sh -s phpstan -p 8.1
06:14
------ -----------------------------------------------------------------------------------------------
Line core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php
------ -----------------------------------------------------------------------------------------------
Ignored error pattern #^Call to static method
PHPUnit\\Framework\\Assert\:\:assertSame\(\) with 0 and string\|null
will always evaluate to false\.$# in path
/builds/typo3/CI/cms/typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php
was not matched in reported errors.
</pre> TYPO3 Core - Bug #101885 (Resolved): runTests.sh -u does not update imageshttp://forge.typo3.org/issues/1018852023-09-09T05:03:10ZBenjamin Franzkeben@bnf.dev
<p>Update does nothing:<br /><pre>
Build/Scripts/runTests.sh -u
> prune unused, dangling local volumes
> pull ghcr.io/core-testing-*:latest versions of those ones that exist locally
> remove "dangling" ghcr.io/core-testing-* images (those tagged as <none>)
###########################################################################
Result of update
Environment: local
PHP: 8.1
SUCCESS
###########################################################################
</pre></p>
<p>Although the images are outdated<br /><pre>
[typo3-clean] (main) $ docker images | grep core-testing-php
ghcr.io/typo3/core-testing-php83 latest 184e88ecc62c 2 weeks ago 206MB
ghcr.io/typo3/core-testing-php82 latest 10292ff1a2dd 7 weeks ago 224MB
ghcr.io/typo3/core-testing-php81 latest d5e5c603d5b4 3 months ago 230MB
ghcr.io/typo3/core-testing-php74 latest 46fc907a5d1c 3 months ago 217MB
ghcr.io/typo3/core-testing-php72 latest 9fb67a3524b5 3 months ago 184MB
</pre></p> TYPO3 Core - Task #101615 (Under Review): Remove implicit wait timeout from acceptance testshttp://forge.typo3.org/issues/1016152023-08-08T08:09:17ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #98270 (Closed): Drop unneeded .cache/.npmrchttp://forge.typo3.org/issues/982702022-09-06T20:15:27ZBenjamin Franzkeben@bnf.dev
<p><code>unsafe-perm = true</code> is not available in npm v8 documentation, and TYPO3 core requires npm v8, so the setting should not be needed.</p> TYPO3 Core - Bug #97123 (Closed): ResourceCompressorTest.php fails in random ordered unit testshttp://forge.typo3.org/issues/971232022-03-06T06:44:52ZBenjamin Franzkeben@bnf.dev
<p><a class="external" href="https://git.typo3.org/typo3/CI/cms/-/jobs/1109375">https://git.typo3.org/typo3/CI/cms/-/jobs/1109375</a></p>
<pre>
1) TYPO3\CMS\Core\Tests\Unit\Resource\ResourceCompressorTest::getFilenamesFromMainDirInBackendContext with data set #3 ('typo3temp/assets/compressed/.htaccess', '../typo3temp/assets/compresse...access')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'../typo3temp/assets/compressed/.htaccess'
+'typo3temp/assets/compressed/.htaccess'
/builds/typo3/CI/cms/typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php:604
</pre>
<p>Steps to reproduce:</p>
<pre>
rm -rf typo3temp/Build/Scripts/runTests.sh -s unitRandom -o 1646183048
</pre>
<p>Also reproducible with:</p>
<pre>
rm -f typo3temp/assets/compressed/.htaccess && Build/Scripts/runTests.sh -s unit -e "--filter getFilenamesFromMainDirInBackendContext" typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php
</pre> TYPO3 Core - Task #96951 (Closed): Streamline tab-handling in ElementsBasic cestshttp://forge.typo3.org/issues/969512022-02-17T15:03:36ZBenjamin Franzkeben@bnf.dev
<ul>
<li>Avoid scrollIntoView which is no longer<br /> needed since <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: preselected TCA useOrOverridePlaceholder checkbox/input fields cause autofocus on initial page load (Closed)" href="http://forge.typo3.org/issues/96947">#96947</a></li>
<li>Do not catch exception on tab-click in<br /> ElementsBasicInputRangeCest which only have been<br /> introduced in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: Acceptance Test Failure for InputRangeCest (Closed)" href="http://forge.typo3.org/issues/93629">#93629</a> but actually due not catch<br /> the case where the tab is already scrolled, but<br /> where the content is scrolled away.<br /> Again no longer needed due to <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: preselected TCA useOrOverridePlaceholder checkbox/input fields cause autofocus on initial page load (Closed)" href="http://forge.typo3.org/issues/96947">#96947</a>.</li>
</ul> TYPO3 Core - Task #96409 (Closed): Port remaining JavaScript unit tests to TypeScripthttp://forge.typo3.org/issues/964092021-12-21T07:03:33ZBenjamin Franzkeben@bnf.dev
<p>typo3/sysext/backend/Tests/JavaScript/FormEngineValidationTest.js<br />typo3/sysext/backend/Tests/JavaScript/IconsTest.js<br />typo3/sysext/backend/Tests/JavaScript/PopoverTest.js</p>
<p>Will ease igration to ES6 modules.</p> TYPO3 Core - Bug #94135 (Closed): Typo3DbQueryParserTest fail with wrong timestamp when php timez...http://forge.typo3.org/issues/941352021-05-13T08:25:12ZBenjamin Franzkeben@bnf.dev
<p>My php timezone is Europe/Berlin and unit tests error in this case:</p>
<pre>
./bin/phpunit -d memory_limit=1G -c vendor/typo3/testing-framework/Resources/Core/Build/UnitTests.xml typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php
1) TYPO3\CMS\Extbase\Tests\Unit\Persistence\Generic\Storage\Typo3DbQueryParserTest::visibilityConstraintStatementIsGeneratedAccordingToTheQuerySettings with data set "in fe: respect enable fields and do not include deleted" ('FE', false, array(), false, '(tx_foo_table.deleted_column ...79200)')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'(tx_foo_table.deleted_column = 0) AND (tx_foo_table.disabled_column = 0) AND (tx_foo_table.starttime_column <= 1451779200)'
+'(tx_foo_table.deleted_column = 0) AND (tx_foo_table.disabled_column = 0) AND (tx_foo_table.starttime_column <= 1451775600)'
/home/ben/src/TYPO310.CMS/typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php:607
/home/ben/src/TYPO310.CMS/vendor/phpunit/phpunit/phpunit:61
2) TYPO3\CMS\Extbase\Tests\Unit\Persistence\Generic\Storage\Typo3DbQueryParserTest::respectEnableFieldsSettingGeneratesCorrectStatement with data set "in FE: respectEnableFields=true" ('FE', true, '(tx_foo_table.deleted_column ...79200)')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'(tx_foo_table.deleted_column = 0) AND (tx_foo_table.disabled_column = 0) AND (tx_foo_table.starttime_column <= 1451779200)'
+'(tx_foo_table.deleted_column = 0) AND (tx_foo_table.disabled_column = 0) AND (tx_foo_table.starttime_column <= 1451775600)'
/home/ben/src/TYPO310.CMS/typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php:672
/home/ben/src/TYPO310.CMS/vendor/phpunit/phpunit/phpunit:61
</pre> TYPO3 Core - Task #89890 (Closed): Reset PSR-11 container in GeneralUtility in unit testshttp://forge.typo3.org/issues/898902019-12-06T21:43:26ZBenjamin Franzkeben@bnf.dev
<p>If a container instance is provided for a unit test via GeneralUtility::setContainer(), it needs to set to null again, in order to not affect other unit tests.</p> TYPO3 Core - Task #89280 (Closed): TypoScript Template Constant Editor flushes to many caches, re...http://forge.typo3.org/issues/892802019-09-25T21:26:07ZBenjamin Franzkeben@bnf.dev
<p>Reported by Simon Schaufelberger via Slack channel #psr11-initiative:</p>
<pre>
Sunday, August 4th 3:21 pm
The problem also is that the DI cache gets flushed way too often.
I just saved a typoscript constant in the template module and the whole cache was empty again afterwards.
Wondering why the DI cache needs to get flushed in such a case
</pre>
<p>The reason is the usage of clear_cacheCmd('all') which flushes all core caches like ext_localconf and DI cache.<br />Also opcache is flushed. These caches are unaffected by TypoScript Template change.s</p> TYPO3 Core - Bug #87997 (Rejected): Links to workspace overlays should not be generated without b...http://forge.typo3.org/issues/879972019-03-25T11:49:57ZBenjamin Franzkeben@bnf.dev
<p>If an editor links to a versioned page id (let's say 1011) directly (e.g. by specifying that id in header_link),<br />that link is currently generated as /index.php?id=1011 when the frontend is visited as a regular visitor (e.g. without backend/workspace context).</p>
<p>Visiting that page will fail with "page not found" (which is fine).</p>
<p>It would be expected that links wouldn't be generated at all (that means: link is empty), as for hidden/deleted pages.</p> TYPO3 Core - Task #87973 (Closed): LinkGeneratorTests should use a proper backend user context fo...http://forge.typo3.org/issues/879732019-03-21T09:20:38ZBenjamin Franzkeben@bnf.dev
<p>Currently typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php linkIsGeneratedForPageVersionDataProvider() does only specify a workspaceId, but misses a backend user id.</p>
<p>In that case the workspace id was ignored ignored by the test framework, see TYPO3\JsonResponse\Middleware\BackendUserMiddleware: <a class="external" href="https://github.com/TYPO3/testing-framework/blob/3d03574ce47d247f1c893cd8bd49292982418d0b/Resources/Core/Functional/Extensions/json_response/Classes/Middleware/BackendUserHandler.php#L53-L54">https://github.com/TYPO3/testing-framework/blob/3d03574ce47d247f1c893cd8bd49292982418d0b/Resources/Core/Functional/Extensions/json_response/Classes/Middleware/BackendUserHandler.php#L53-L54</a></p>
<p>Some of the current todos fail because the test context is wrong.</p>