TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-08-24T11:06:22ZTYPO3 Forge
Redmine TYPO3 Core - Bug #101747 (Rejected): Web Components with CSS in shadowRoot are not usable in cros...http://forge.typo3.org/issues/1017472023-08-24T11:06:22ZBenjamin Franzkeben@bnf.dev
<p>As already reported in <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Streamline icon elements (Closed)" href="http://forge.typo3.org/issues/100270">#100270</a> and reverted in <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Reactivate usage of constructable stylesheets for icon element (Closed)" href="http://forge.typo3.org/issues/101464">#101464</a>, web Components with CSS in shadowRoot are not usable in cross frame boundaries.<br />This happens when a custom element is created within <code>window.list_frame</code> via <code>document.createElement()</code> and is then attached to another frame via <code>appendChild()</code>.<br />This mostly happens when code is written that renders web components into a Modal (which is placed in the outer frame)</p>
<p>Following exception is logged in that case.<br /><pre>
css-tag.js?bust=1692874613:6 Uncaught DOMException: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed
at S (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/css-tag.js?bust=1692874613:6:1012)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:2898)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:163)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:3010)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:478)
at R.k (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:4627)
at R.$ (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:4701)
at R.g (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:5085)
at R._$AI (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:4534)
at D (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-html/lit-html.js?bust=1692874613:6:7898)
</pre></p>
<p>This can easily reproduced via:<br /><pre><code class="javascript syntaxhl" data-language="javascript"><span class="nb">document</span><span class="p">.</span><span class="nx">body</span><span class="p">.</span><span class="nf">appendChild</span><span class="p">(</span><span class="nb">window</span><span class="p">.</span><span class="nx">list_frame</span><span class="p">.</span><span class="nb">document</span><span class="p">.</span><span class="nf">createElement</span><span class="p">(</span><span class="dl">'</span><span class="s1">typo3-backend-icon</span><span class="dl">'</span><span class="p">))</span>
</code></pre></p>
<p>Which also logs to the console:<br /><pre>
css-tag.js?bust=1692874613:6 Uncaught DOMException: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed
at S (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/css-tag.js?bust=1692874613:6:1012)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:2898)
at IconElement.createRenderRoot (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:163)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/@lit/reactive-element/reactive-element.js?bust=1692874613:6:3010)
at IconElement.connectedCallback (http://t3core.localhost/typo3/sysext/core/Resources/Public/JavaScript/Contrib/lit-element/lit-element.js?bust=1692874613:6:478)
at <anonymous>:1:15
</pre></p>
<p>Note that this is known in lit, but not easily fixable, as the <code>css``</code> template literaly implicitly use <code>(window).CSSStyleSheet</code></p>
<p><a class="external" href="https://github.com/lit/lit-element/issues/1139">https://github.com/lit/lit-element/issues/1139</a><br /><a class="external" href="https://github.com/lit/lit/issues/2068">https://github.com/lit/lit/issues/2068</a></p> TYPO3 Core - Task #98496 (Rejected): Remove outdated ckeditor requirejs configurationhttp://forge.typo3.org/issues/984962022-10-01T18:55:17ZBenjamin Franzkeben@bnf.dev
<p>With the migration to use plain script-loading for CKEditor v4<br />it was forgotten to remove the RequireJS configuration that was <br />intended to be removed as preparation for ES6-only mode <br />in TYPO3 core.</p> TYPO3 Core - Bug #91074 (Rejected): typo3conf/ folder is not created when using a custom app-dir ...http://forge.typo3.org/issues/910742020-04-17T01:15:10ZBenjamin Franzkeben@bnf.dev
<p>In composer mode in composer.json:</p>
<pre><code>"extra": {<br /> "typo3/cms": {<br /> "app-dir": "custom",<br /> "web-dir": "public" <br /> }<br /> },</code></pre>
<p>In this case Environment::$projectPath would be /path/to/root/custom and Environment::$publicPath would be /path/to/root/public.</p>
<p>The typo3conf folder is then generated in /path/to/root/custom/typo3conf instead of /path/to/root/public/typo3conf.</p>
<p>This is actually by accident, because "custom" and "public" have the same length.<br />Reason is the code in <a class="external" href="https://git.typo3.org/Packages/TYPO3.CMS.git/blob/9fb677f6f3b3a1cd584b9ef183b35da771d3e25d:/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php#l134">https://git.typo3.org/Packages/TYPO3.CMS.git/blob/9fb677f6f3b3a1cd584b9ef183b35da771d3e25d:/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php#l134</a><br /><pre>
$publicPath = substr(Environment::getPublicPath(), strlen(Environment::getProjectPath())+1);
</pre><br />which tries to substract the project path from the public path, while assuming that project path is an ancestor, which results in a public path <code>""</code> to be calculate.<br />The result should rather be <code>"../public"</code>.</p>
<p>We should rather generate a relative path and adapt the FolderStructur Factory to handle relative paths, include partent dots ("..").</p> TYPO3 Core - Bug #87997 (Rejected): Links to workspace overlays should not be generated without b...http://forge.typo3.org/issues/879972019-03-25T11:49:57ZBenjamin Franzkeben@bnf.dev
<p>If an editor links to a versioned page id (let's say 1011) directly (e.g. by specifying that id in header_link),<br />that link is currently generated as /index.php?id=1011 when the frontend is visited as a regular visitor (e.g. without backend/workspace context).</p>
<p>Visiting that page will fail with "page not found" (which is fine).</p>
<p>It would be expected that links wouldn't be generated at all (that means: link is empty), as for hidden/deleted pages.</p> TYPO3 Core - Task #84490 (Closed): Add missing HTTP status code presets for PSR-7 responseshttp://forge.typo3.org/issues/844902018-03-20T06:46:09ZBenjamin Franzkeben@bnf.dev
<p>The list of status codes/reason phrases should be synchronized with<br /><a class="external" href="http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml">http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml</a></p> TYPO3 Core - Task #84126 (Closed): Remove comments that contain v4 or FLOW informationhttp://forge.typo3.org/issues/841262018-03-03T12:42:52ZBenjamin Franzkeben@bnf.dev
<p>Whether a class or functionality is not available or available<br />differently in v4 or FLOW is not relevant for TYPO3 CMS.<br />They should be removed.</p> TYPO3 Core - Task #84117 (Closed): Do not reinitialize CacheManager and PackageManager in clearAl...http://forge.typo3.org/issues/841172018-03-02T14:09:54ZBenjamin Franzkeben@bnf.dev
<p>Those (re)initializations originate from <a class="external" href="https://review.typo3.org/19605">https://review.typo3.org/19605</a><br />were reinitializeClassLoaderAndCachesAndPackageManagement()<br />was used to "Reinitialize the class loader during clear cache actions" <br />(according to phpdoc).</p>
<p>Then with the changes in <a class="external" href="https://review.typo3.org/29811">https://review.typo3.org/29811</a><br />reinitializeClassLoaderAndCachesAndPackageManagement()<br />was dropped and splitted into unregisterClassLoader(),<br />flagCachingFrameworkForReinitialization().<br />initializeCachingFramework() and initializePackageManagement().<br />(just historical info, still all good)</p>
<p>Then <a class="external" href="http://review.typo3.org/39827">http://review.typo3.org/39827</a> came and dropped unregisterClassLoader<br />but left the CacheManager and PackageManager reinitialization in place<br />superfluously. It's superfluous as the original usecase was to<br />reinitialize the class loader which is no longer required.</p> TYPO3 Core - Task #84109 (Closed): Merge the package DependencyResolver into the PackageManagerhttp://forge.typo3.org/issues/841092018-03-01T19:38:55ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #84107 (Closed): Stop monkey patching CacheManager configuration in InstallToolhttp://forge.typo3.org/issues/841072018-03-01T16:55:38ZBenjamin Franzkeben@bnf.dev
<p>Instead of creating the cacheManager and then disabling all cache confiurations afterwards, the desired state should simply be enforced inside the CacheManager.</p> TYPO3 Core - Task #84102 (Closed): Set COMPOSER_ROOT_VERSION to 9.2.0@dev for bamboohttp://forge.typo3.org/issues/841022018-03-01T11:55:15ZBenjamin Franzkeben@bnf.dev
<p>If typo3/testing-framework needs to be synced with changes<br />in core it needs to require the dev branch of the upcoming<br />release as the compatibility to previous releases needs to<br />be dropped.<br />Therefore it has to define a dependency in composer.json like:<br /> "typo3/cms-core": "^9.2@dev"</p>
<p>If composer install is executed with COMPOSER_ROOT_VERSION<br />set to 9.1.0 that produces a conflict, therefore the version<br />should be raised to 9.2.0@dev.</p> TYPO3 Core - Task #84099 (Closed): Decouple SystemEnvironmentBuilder from Bootstraphttp://forge.typo3.org/issues/840992018-03-01T11:10:58ZBenjamin Franzkeben@bnf.dev
<p>Do not rely on defined constants or methods from Bootstrap<br />to be usable on it own (at some point).</p> TYPO3 Core - Task #84083 (Closed): ApplicationContext should consistently be retrieved from Gener...http://forge.typo3.org/issues/840832018-02-28T15:28:39ZBenjamin Franzkeben@bnf.dev
<p>ClassLoadingInformation reads from Bootstrap, that should be adapted to use GeneralUtility.</p>
<p>Bootstrap code states:</p>
<pre>
* Use \TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext() instead
</pre>
<p>Therefore the method should just be removed.</p> TYPO3 Core - Task #84082 (Closed): A LogRecord should not rely on global state (requestId from Bo...http://forge.typo3.org/issues/840822018-02-28T15:17:33ZBenjamin Franzkeben@bnf.devTYPO3 Core - Task #84015 (Closed): Use PSR-7 request params in viewpage modulehttp://forge.typo3.org/issues/840152018-02-22T21:25:11ZBenjamin Franzkeben@bnf.dev
<p>Since changeset I3020aa7a9cffd92d4b96afd4d4044979a771db5b<br />the viewpage module is a native PSR-7 controller, therefore<br />GeneralUtility _GP() and getIndpEnv() should no longer be used.</p> TYPO3 Core - Bug #79107 (Closed): Extensionmanager shows incorrect warning in composer modehttp://forge.typo3.org/issues/791072016-12-29T13:24:05ZBenjamin Franzkeben@bnf.dev
<p>The warning should be an info instead, as the warning can't be resolved besides not using composer:</p>
<blockquote><blockquote>
<p>The system is set to composer mode. Please notice that it is not possible to add an extension with the Extension Manager. You have to use composer to add further extensions to your system.</p>
</blockquote></blockquote>