TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692017-06-01T13:55:58ZTYPO3 Forge
Redmine TYPO3 Core - Bug #81405 (Closed): New pages are places at same level instead of under, when using...http://forge.typo3.org/issues/814052017-06-01T13:55:58ZChrister Vcvi@systime.dk
<p>When one creates a new page using the ContextMenu they are placed at the same level as the page you clicked on, instead of under. This means that none admins can't create new pages when clicking on the root page.</p>
Current behaviour, when add a new page on Page 1 as Admin
<ul>
<li>Root
<ul>
<li>Page2</li>
<li>Page 3</li>
</ul></li>
</ul>
<p>=></p>
<ul>
<li>Root
<ul>
<li>Page 1</li>
<li>Page 2</li>
</ul>
</li>
<li>Page new</li>
</ul>
<p>As none admin you get "Sorry, you didn't have proper permissions to perform this change."</p>
Expected behaviour:
<ul>
<li>Root
<ul>
<li>Page 1</li>
<li>Page 2</li>
</ul></li>
</ul>
<p>=></p>
<ul>
<li>Root
<ul>
<li>Page 1</li>
<li>Page 2</li>
<li>Page new</li>
</ul></li>
</ul> TYPO3 Core - Bug #81357 (Closed): Icon and title links in file References links are broken.http://forge.typo3.org/issues/813572017-05-29T10:43:15ZChrister Vcvi@systime.dk
<p>The icon and title links in the file "References to this item" list are broken.</p>
To recreate:
<ol>
<li>Goto file list.</li>
<li>Click on a reference.</li>
<li>Click on a reference icon or title.</li>
</ol>
<p>You now get an exception "Module is not configured."</p> TYPO3 Core - Bug #81039 (Closed): buildRepresentationForNode function doesn't scale.http://forge.typo3.org/issues/810392017-04-27T11:00:33ZChrister Vcvi@systime.dk
<p>The code in <code>buildRepresentationForNode</code> doesn't scale since it sorts the entire list after each append.</p> TYPO3 Core - Bug #80872 (Closed): QueryGenerator::getSelectQuery can use Doctrine bind values but...http://forge.typo3.org/issues/808722017-04-18T10:59:28ZChrister Vcvi@systime.dk
<p>If an none admin call <code>QueryGenerator::getSelectQuery</code>, bind values will be assign to the <code>$queryBuilder</code> and then thrown away, since the method just returns the string <code>$queryBuilder->getSQL()</code>. This will cause an sql error:<br /><pre>
Error: An exception occurred while executing 'SELECT `header`, `uid`, `pid`, `pid`, `deleted` FROM `tt_content` WHERE (`pid` IN (:dcValue1)) AND (tt_content.CType = 'test') AND (`tt_content`.`deleted` = 0) LIMIT 100': You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':dcValue1)) AND (tt_content.CType = 'test') AND (`tt_content`.`deleted` = 0) L' at line 1
</pre></p>
<p>Also the return type is notes as <code>bool|\mysqli_result|object</code> but is actually a <code>string</code>.</p> TYPO3 Core - Bug #80675 (Closed): Recycler Scheduler job fails - due to missing doctrine bind va...http://forge.typo3.org/issues/806752017-04-04T11:05:12ZChrister Vcvi@systime.dk
<p>Recycler Scheduler job fails due to missing doctrine bind variables.</p>
To reproduce:
<ul>
<li>Setup Recycler Scheduler job</li>
<li>Select the "Backend Layout" table</li>
<li>Run</li>
</ul>
<p>Error:</p>
<p><code>Execution of task "Remove deleted records (recycler)" failed with the following message: An exception occurred while executing 'SELECT `icon` FROM `backend_layout` WHERE (`deleted` = :dcValue1) AND (`tstamp` < :dcValue2)': You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':dcValue1) AND (`tstamp` < :dcValue2)' at line 1</code></p>
<p>This seems to be caused by <code>CleanerTask->deleteFilesForTable</code> which reuses the $constraints from <code>CleanerTask->cleanTable</code>, but without the doctrine createNamedParameter bind variables.</p> TYPO3 Core - Bug #80209 (Closed): Wrong variable checked in getTitleFieldhttp://forge.typo3.org/issues/802092017-03-09T13:52:21ZChrister Vcvi@systime.dk
<p>In BrowseLinksController::getTitleField the wrong variable is checked, which can cause an PHP warning since $title can become null instead of the empty string '';</p>
<p><code><br />$title = !$this->classesAnchorDefault[$this->displayedLinkHandlerId] ? '' : $this->classesAnchorDefaultTitle[$this->displayedLinkHandlerId];<br /></code></p>
<p>to</p>
<p><code><br />$title = !$this->classesAnchorDefaultTitle[$this->displayedLinkHandlerId] ? '' : $this->classesAnchorDefaultTitle[$this->displayedLinkHandlerId];<br /></code></p> TYPO3 Core - Bug #80183 (Closed): Backend requireJS paths are calculated wrongly for CLI.http://forge.typo3.org/issues/801832017-03-08T10:50:39ZChrister Vcvi@systime.dk
<p>If after clearing all the cache the first hit to a typo3 installation is a cli command the backend requireJS paths are calculated and saved wrongly causing the backend to fail.</p>
<p>In <code>computeRequireJsConfig</code> the <code>$fullJsPath</code> is calculated to be '/typo3/sysext/core/Resources/Public/JavaScript/' instead of 'sysext/core/Resources/Public/JavaScript/'.</p>
<p>How to replicate:<br />Removed 'var/cache' run 'typo3/cli_dispatch.phpsh' visit backend.</p> TYPO3 Core - Bug #80075 (Closed): PHP 7.1: QueryGenerator declares $this->queryConfig as an array...http://forge.typo3.org/issues/800752017-03-01T11:59:38ZChrister Vcvi@systime.dk
<p>When using PHP 7.1 the DB Check module throws an exception when using the advanced search functionality, because of <code>$this->queryConfig</code> being declared as a array but used as string and array.</p>
<p>In QueryGenerator::procesData <code>$this->queryConfig</code> can be set to and string instead of an array. This causes <code>cleanUpQueryConfig</code> to fail since indexing into and string will not created an array for the foreach to process.</p> TYPO3 Core - Bug #79970 (Closed): Indexed search causes 404 because of missing cHashhttp://forge.typo3.org/issues/799702017-02-23T14:59:42ZChrister Vcvi@systime.dk
<p>With <code>[FE][pageNotFoundOnCHashError] = true </code> Make a simple FE search will cause a 404 since the POST action is missing an cHash.</p> TYPO3 Core - Bug #79918 (Closed): Opening links in pop-up windows no longer workshttp://forge.typo3.org/issues/799182017-02-20T12:48:39ZChrister Vcvi@systime.dk
<p>After the rewrite of Css Styled Content, it's no longer possible to open links in pop up windows.</p>
How to replicate.
<ul>
<li>Create a link</li>
<li>Set a external link</li>
<li>Set 500x500 as target</li>
</ul>
<p>Expected behaviour is that the link opens in a new pop-up window with size 500x500. But currently the link just opens in a new tab.</p>
<p>The reason is that the typoscript was rewritten so that <code>parameter.data = parameters:allParams</code> was changed to <code>parameter.data = parameters:href</code>. This means that the link target doesn't get parsed by to <code>resolveMixedLinkParameter</code>, which means that <code>TypoLinkCodecService->decode</code> won't return the correct target.</p> TYPO3 Core - Bug #79687 (Closed): Missing else statement in Css Styles Content causes images not ...http://forge.typo3.org/issues/796872017-02-08T13:41:35ZChrister Vcvi@systime.dk
<p>In the new Css Styles Content there seems to be missing an else.</p>
<p>In <code>TYPO3\CMS\CssStyledContent\Controller\CssStyledContentController::render_textpic</code></p>
<p>if <code>$accessibilityMode</code> is set to <code>false</code> and <code>$separateRows</code> is also <code>false</code>.</p>
<p><code>$allRows</code> is never added to <code>$thisImages</code>.</p>
<p>Changing the code to:</p>
<pre>
if ($separateRows) {
$thisImages .= $allRows;
}
else {
$thisImages .= $this->cObj->stdWrap($allRows, $conf['noRowsStdWrap.']);
}
</pre><br />like it was before, seems to fix it. TYPO3 Core - Bug #79347 (Closed): DB Check causes Php warning in QueryBuilderhttp://forge.typo3.org/issues/793472017-01-17T10:03:29ZChrister Vcvi@systime.dk
<p>Selecting "Database Relations" under "DB check" causes a php warning:<br /><pre>
PHP Warning: Missing argument 1 for Doctrine\DBAL\Query\QueryBuilder::orWhere(), called in typo3_src/typo3/sysext/core/Classes/Database/Query/QueryBuilder.php on line 651 and defined in vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryBuilder.php line 836
</pre></p> TYPO3 Core - Bug #79166 (Closed): Wrong parameter type in LinkAnalyzer causes exceptionhttp://forge.typo3.org/issues/791662017-01-05T12:29:01ZChrister Vcvi@systime.dk
<p>How to replicated: Run Linkvalidator somewhere that already has broken link. When trying to delete the previous broken links you get a exception.</p>
<p>To fix:</p>
<p>In TYPO3\CMS\Linkvalidator\LinkAnalyzer::getLinkStatistics</p>
<pre>
$queryBuilder->expr()->in(
'link_type',
$queryBuilder->createNamedParameter($checkKeys, Connection::PARAM_INT_ARRAY)
)
</pre><br />Should be changed to <br /><pre>
$queryBuilder->expr()->in(
'link_type',
$queryBuilder->createNamedParameter($checkKeys, Connection::PARAM_STR_ARRAY)
)
</pre>
<p>Tested in T3 8.5.1. PHP 7. MySQL 5.7</p>