TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692021-07-13T11:47:17ZTYPO3 Forge
Redmine TYPO3 Core - Task #94553 (Closed): Enforce trailing commas in multi line arrays with PHP CS Fixerhttp://forge.typo3.org/issues/945532021-07-13T11:47:17ZSebastian Michaelsenmichaelsen@t3seo.de
<p>The PHP CS Fixer rule <code> trailing_comma_in_multiline => ['arrays']</code> ensures that multi line arrays always have a trailing comma.</p>
<pre><code class="php syntaxhl" data-language="php"><span class="nv">$array</span> <span class="o">=</span> <span class="p">[</span>
<span class="s1">'one'</span><span class="p">,</span>
<span class="s1">'two'</span>
<span class="p">];</span>
</code></pre>
<p>becomes</p>
<pre><code class="php syntaxhl" data-language="php"><span class="nv">$array</span> <span class="o">=</span> <span class="p">[</span>
<span class="s1">'one'</span><span class="p">,</span>
<span class="s1">'two'</span><span class="p">,</span>
<span class="p">];</span>
</code></pre>
<p>Having trailing commas makes it easier to rearrange entries and when an entry is added to the list the line before doesn't need to be changed. This results in smaller git changes for a better overview and less likely merge conflicts.</p> TYPO3 Core - Task #92971 (Closed): Don't try to create language switch for non-persisted recordshttp://forge.typo3.org/issues/929712020-12-01T14:57:31ZSebastian Michaelsenmichaelsen@t3seo.de
<p><code>EditDocumentController->languageSwitch()</code> generates the language dropdown menu in the backend record edit form.</p>
<p>When creating a new record, the result is always that no dropdown form is displayed.</p>
<p>However also for new records the function performs DB queries and runs a lot of code. Instead it should not be called in this case.</p> TYPO3 Core - Task #90237 (Closed): Show property path on hover in Template Tree Viewhttp://forge.typo3.org/issues/902372020-01-29T07:58:21ZSebastian Michaelsenmichaelsen@t3seo.de
<p>This is about the tree view that is used for TypoScript constants/setup in the Template module and also the Page TSconfig view in the info module.</p>
<p>Especially in Page TSconfig (where all nodes are always expanded) for deeply nested properties it's often not so easy to find out the whole path of a property. It can involve a lot of scrolling and sticking fingers to your screen to keep track of the indention.</p>
<p>So I suggest to put the whole property path in the title-Attribute of the property name, so it can easily be seen by hovering over it.</p> TYPO3 Core - Task #69381 (Rejected): Move the images field of the images CE to the first form tabhttp://forge.typo3.org/issues/693812015-08-28T08:50:19ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Historically the images of the images content element were always configured in the second tab.<br />Back in the times before FAL this might have been a good idea, because there were many fields that would have cluttered the first view on the record.</p>
<p>Now with FAL and the image config details hidden the collapsed inline records it's time to move the images to the first tab. In fact they are the most important property of the record and should be directly visible.</p> TYPO3 Core - Task #68329 (Closed): Use ::class where possible in fluid unit testshttp://forge.typo3.org/issues/683292015-07-18T10:36:04ZSebastian Michaelsenmichaelsen@t3seo.deTYPO3 Core - Task #68326 (Closed): Use "an" instead of "a" in labels and comments where appropriatehttp://forge.typo3.org/issues/683262015-07-18T02:18:17ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In english you have to use "an" before any spoken vowel.</p> TYPO3 Core - Task #63327 (Closed): Use class imports in Cache Frontend classeshttp://forge.typo3.org/issues/633272014-11-25T21:37:39ZSebastian Michaelsenmichaelsen@t3seo.deTYPO3 Core - Task #63326 (Closed): Avoid using $GLOBALS['TYPO3_DB'] in DataHandlerhttp://forge.typo3.org/issues/633262014-11-25T16:38:46ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Instead of $GLOBALS['TYPO3_DB'] a type hinted property $this->databaseConnection should be used to gain autocompletion and better IDE inspection in this class.</p>
<p>Concerns: This might be a breaking change. $this->databaseConnection is set on DataHandler->start(). If some code relies on setting/modifying $GLOBALS['TYPO3_DB'] <strong>after</strong> DataHandler->start() and <strong>before</strong> other methods of DataHandler are invoked it might break. Please decide if this is too much of a risk.</p> TYPO3 Core - Task #63324 (Closed): Cleanups in DataHandlerhttp://forge.typo3.org/issues/633242014-11-25T15:17:27ZSebastian Michaelsenmichaelsen@t3seo.de
<ul>
<li>remove unused local variables</li>
<li>fix phpDoc inconsistencies</li>
</ul>
<p>Notice for reviewers: I would suggest not make dozens of new versions of this change because you found another spot in DataHandler that could be ironed out. That would lead to no end.</p> TYPO3 Core - Task #59006 (Closed): Code Cleanups in LanguageServicehttp://forge.typo3.org/issues/590062014-05-21T16:59:30ZSebastian Michaelsenmichaelsen@t3seo.de
<p>\TYPO3\CMS\Lang\LanguageService could use a few cleanups:</p>
<ul>
<li>Avoid unnecessary fully qualified class names</li>
<li>Add return NULL for consistency if a method only returns a value in some cases</li>
</ul> TYPO3 Core - Task #59004 (Closed): Code Cleanups in TranslationConfigurationProviderhttp://forge.typo3.org/issues/590042014-05-21T16:47:22ZSebastian Michaelsenmichaelsen@t3seo.de
<p>\TYPO3\CMS\Backend\Configuration\TranslationConfigurationProvider could use a few cleanups:</p>
<ul>
<li>Introduce type hinted $this->databaseConnection instead of using $GLOBALS['TYPO3_DB']</li>
<li>Use type hinted local variable instead of $GLOBALS['LANG']</li>
<li>Deprecate $backPath parameter of ->getSystemLanguages and adapt the method calls</li>
<li>Break very long lines of code into smaller chunks</li>
<li>Fix phpDoc issue</li>
</ul> TYPO3 Core - Task #59001 (Closed): Use self:: where possible in GeneralUtilityhttp://forge.typo3.org/issues/590012014-05-21T16:08:50ZSebastian Michaelsenmichaelsen@t3seo.de
<p>It's common sense to use self:: where possible because it's quicker and makes code better understandable.</p>
<p>I found 2 violations in \TYPO3\CMS\Core\Utility\GeneralUtility</p> TYPO3 Core - Task #58995 (Closed): Code Cleanups in FormEnginehttp://forge.typo3.org/issues/589952014-05-21T15:00:14ZSebastian Michaelsenmichaelsen@t3seo.de
<p>\TYPO3\CMS\Backend\Form\FormEngine could use a few cleanups:</p>
<ul>
<li>Import some classes to avoid unnecessary fully qualified class names</li>
<li>Fix some PHPDoc issues</li>
<li>Slightly adjust some method signatures (when 0, 1, or '' were used for boolean information)</li>
<li>Remove some unused local variables</li>
</ul> TYPO3 Core - Task #46461 (Closed): Extract displayCond functionality from FormEngine to new classhttp://forge.typo3.org/issues/464612013-03-20T13:23:21ZSebastian Michaelsenmichaelsen@t3seo.de
<p>I'd like to extend the 'displayCond' mechanism by a new type, but \TYPO3\CMS\Backend\Form\FormEngine (formerly t3lib_TCEforms) is way to bloated anyway. So I thought this might be a good point to streamline FormEngine a bit and extract the displayCond functionality to a new class: \TYPO3\CMS\Backend\Form\ElementConditionMatcher</p>
<p>I (hope I) didn't change any functionality, I just tried to split thing a up into clean pieces.</p> TYPO3 Core - Task #44972 (Closed): Update documentation: Mark borderCol and rowSpace options from...http://forge.typo3.org/issues/449722013-01-30T15:34:54ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Passing borderCol and rowSpace to IMGTEXT doesn't have any effect anymore.</p>
<p>However the correspoding constants {$styles.content.imgtext.borderColor}<br />and {$styles.content.imgtext.rowSpace} are used in CSC's default CSS.</p>