TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-08-30T11:27:43ZTYPO3 Forge
Redmine TYPO3 Core - Bug #101798 (New): Prevent saving unchanged inline records to save performancehttp://forge.typo3.org/issues/1017982023-08-30T11:27:43ZSebastian Michaelsenmichaelsen@t3seo.de
<p><strong>Problem</strong></p>
<p>When you have a record, which has 10 inline items and the record is translated (along with the inline items) into 10 languages, then saving the record even with no changes to the inline items causes the DataHandler to save 110 database records which can take some 30 seconds.</p>
<p><strong>Why is that?</strong></p>
<p>The inline records have toggles to hide/unhide them (unless the table does no support that), which means when saving the record there will be a `someid => ['hidden' => '0']` entry for each inline item, which causes DataHandler to save that inline item, which then also triggers saving of its translations.</p>
<p><strong>Solution(?)</strong></p>
<p>It could be solved in backend JavaScript, so that the inline `hidden` form fields are only included in the request when their value was changed.</p>
<p><strong>Workaround</strong></p>
<p>For our project I created a backend middleware, that intercepts the `data` when a record is saved and removes any entries, that have just the hidden field and it is unchanged. (Yes, I create a database request for each of those entries but it's still <em>way</em> faster than before)</p> TYPO3 Core - Bug #97776 (New): Disabled scheduler tasks are not dimmed outhttp://forge.typo3.org/issues/977762022-06-15T09:50:04ZSebastian Michaelsenmichaelsen@t3seo.de
<p>The <code>SchedulerModueController</code> says <code>// Row is shown dimmed if task is disabled, unless it is still running</code> and a corresponding CSS class <code>disabled</code> is set on disabled tasks, but visually there is no difference.</p>
<p>Tested in TYPO3 v10, but I suppose this is also the case in higher versions.</p> TYPO3 Core - Bug #95368 (Closed): Passing an eID array URL parameter logs into the TYPO3 error loghttp://forge.typo3.org/issues/953682021-09-27T10:31:17ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Calling <a class="external" href="https://www.example.com/index.php?eID[]=">https://www.example.com/index.php?eID[]=</a> produces an entry like this in the <code>sys_log</code>:</p>
<pre>
Core: Error handler (FE): PHP Warning: Illegal offset type in /path/to/project/typo3/sysext/frontend/Classes/Middleware/EidHandler.php line 70
</pre>
<p>This is the case for TYPO3 v10.4 and from looking at the code also at master.</p> TYPO3 Core - Bug #95042 (Closed): email validation makes link generation unnecessary costlyhttp://forge.typo3.org/issues/950422021-08-31T06:11:44ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Whenever links are generated with "legacy" parameter, the <code>\TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter</code> checks if the provided parameter is a valid email address. For validation we use the 3rd party library <code>egulias/email-validator</code>. With blackfire I determined that this library is quite costly in terms of memory and wall time.</p>
<p>I added this simple early return to <code>GeneralUtility::validEmail()</code>:</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="k">if</span> <span class="p">(</span><span class="nb">strpos</span><span class="p">(</span><span class="nv">$email</span><span class="p">,</span> <span class="s1">'@'</span><span class="p">)</span> <span class="o">===</span> <span class="kc">false</span><span class="p">)</span> <span class="p">{</span>
<span class="k">return</span> <span class="kc">false</span><span class="p">;</span>
<span class="p">}</span>
</code></pre>
<p>And it significantly improved the speed of links generation. I don't know if that is a suitable solution for the core, or if such a fix should get into the library itself.</p> TYPO3 Core - Bug #93480 (New): PDF Cropping configuration is not possible for editorshttp://forge.typo3.org/issues/934802021-02-10T09:42:03ZSebastian Michaelsenmichaelsen@t3seo.de
<p>TYPO3 can create images from PDFs and can also crop them. But for editors it's not possible to set that cropping, because the cropping wizard doesn't work for PDFs.</p> TYPO3 Core - Bug #93433 (New): TCA placeholder __row|field doesn't translate related recordshttp://forge.typo3.org/issues/934332021-02-04T11:40:41ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When using the __row|field syntax in placeholders, the related row is not overlaid with its translation.</p>
<p>example TCA for a tt_content field:<br /><pre>
'tx_myext_teaser_title' => [
'label' => $lll . '.tx_myext_teaser_title',
'config' => [
'type' => 'input',
'placeholder' => '__row|tx_myext_teaser_page|title',
],
],
</pre></p>
<p>For a translated content element, the placeholder should be filled with the value from the translated page record.</p> TYPO3 Core - Bug #93336 (Closed): Enabling translated content in workspace is not previewablehttp://forge.typo3.org/issues/933362021-01-21T09:35:08ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When you enable content element translation in a WS (which is hidden in LIVE), you cannot see the effect in the workspace preview.</p>
<p>Setup:</p>
<table>
<tr>
<th>Workspace </th>
<th>Default Lang Content </th>
<th>Translated Content </th>
</tr>
<tr>
<td> LIVE </td>
<td> enabled </td>
<td> hidden </td>
</tr>
<tr>
<td> WS </td>
<td> enabled </td>
<td> enabled </td>
</tr>
</table>
<p><code>PageRepository->getRecordOverlay()</code> first does the language overlay and the version overlay afterwards. But the language overlay applies enable field restrictions, so the translation is not loaded (even it would be enabled in the WS version).</p> TYPO3 Core - Bug #93109 (Closed): Records can not be discarded from workspacehttp://forge.typo3.org/issues/931092020-12-18T14:59:21ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When I try to discard news records in the workspaces module I get an SQL error: Unknown column 'tablenames' in 'where clause'.</p>
<p>I tracked down the issue to here: <a class="external" href="https://github.com/TYPO3/TYPO3.CMS/blob/956c01e07885d5c1dffffb2a7ab8aae0db4df9d6/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L5656">https://github.com/TYPO3/TYPO3.CMS/blob/956c01e07885d5c1dffffb2a7ab8aae0db4df9d6/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L5656</a></p>
<p>There it is hardcoded that the mm relation table always has a "tablenames" field. However this is not always the case, e.g. tx_news_domain_model_news.related (<a class="external" href="https://github.com/georgringer/news/blob/master/Configuration/TCA/tx_news_domain_model_news.php#L310">https://github.com/georgringer/news/blob/master/Configuration/TCA/tx_news_domain_model_news.php#L310</a>)</p> TYPO3 Core - Bug #93098 (Closed): Missing 'depends' section in ext_emconf.php leads to errorhttp://forge.typo3.org/issues/930982020-12-17T13:04:57ZSebastian Michaelsenmichaelsen@t3seo.de
<p>If an extension has no <code>'depends'</code> section in <code>ext_emconf.php</code>, but requires packages via <code>composer.json</code>, then during <code>install:generatepackagestates</code> an error is raised:</p>
<p>The package "myext" depends on "my/composer-package" which is not present in the system.</p>
<p>When putting <code>'constraints' => ['depends' => []],</code> into <code>ext_emconf.php</code> it works fine.</p>
<p>Especially for project specific local extensions you may not have any dependencies specified. When it works with the empty depends array, it should also be possible to leave it out entirely.</p> TYPO3 Core - Feature #46460 (Closed): Introduce TCA displayCond type "USER"http://forge.typo3.org/issues/464602013-03-20T13:18:21ZSebastian Michaelsenmichaelsen@t3seo.de
<p>With displayCond you can evaluate each form field whether it should be displayed or not. There is a number of options, but you can't define a UserFunction if the options provided by the core don't fit your needs.</p>
<p>Usage example:<br />'displayCond' => 'USER:\\MyVendor\\MyExt\\UserFunction\\MyClass->displayCondition'</p> TYPO3 Core - Feature #45022 (Closed): Utility function to deprecate public method calls.http://forge.typo3.org/issues/450222013-01-31T13:50:38ZSebastian Michaelsenmichaelsen@t3seo.de
<p>At the moment we have a lot of public methods which are not intended for being public. We need a way to deprecate calling them publicly, therefore a Utility Function is introduced.</p>
<p>Usage:</p>
<pre>
/**
* @publicCallDeprecated Since 6.1. Will be protected 2 versions later
*/
public function privateFoo() {
GeneralUtility::logDeprecatedPublicMethodCall();
// do stuff
}
</pre>
<p>If the method is called publicy an entry like this is being made to the deprecation log:<br /><pre>
Deprecated public method call: MyClass->privateFoo() was called publicly which is deprecated (Since 6.1. Will be protected 2 versions later). [DEBUG TRAIL]
</pre></p>
<p>I'm not sure if it is ok to just invent a new phpDoc annotation. But it's the best solution I found to store information about the deprecation strategy.</p> TYPO3 Core - Task #44744 (Closed): Cleanups for sysext beloghttp://forge.typo3.org/issues/447442013-01-23T12:09:15ZSebastian Michaelsenmichaelsen@t3seo.de
<ul>
<li>Fix references to old classes</li>
<li>Use property injection where possible</li>
</ul> TYPO3 Core - Task #40870 (Closed): Add Utility Functions to retreive Information from Class Nameshttp://forge.typo3.org/issues/408702012-09-12T16:23:02ZSebastian Michaelsenmichaelsen@t3seo.de
<p>My intention is to introduce these 2 Utility Functions:</p>
<p>\TYPO3\CMS\Core\Extension\ExtensionManager::getClassNameWithoutVendorAndProduct($className)<br />\TYPO3\CMS\Core\Extension\ExtensionManager::getExtensionKeyFromClassName($className)</p>
<p>These can be used in the the Autoloader for example (will be a separate patch, when this one is done).<br />Also Extbase can make use of these functions to resolve #40742.</p> TYPO3 Core - Bug #40673 (Closed): sysexts cli and integrity have no ext_emconf.phphttp://forge.typo3.org/issues/406732012-09-06T14:05:27ZSebastian Michaelsenmichaelsen@t3seo.de
<p>There are two new sysext folders which have no ext_emconf.php and therefore do not appear in the EM: cli and integrity</p>
<p>Is this by intention?</p> TYPO3 Core - Bug #30406 (Closed): TCA: Fields with eval md5 can not be clearedhttp://forge.typo3.org/issues/304062011-09-29T08:41:29ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Try this: Open a Backend User record and try to use the little 'x' to clear the password field. The field is not cleared.</p>
<p>I pinned it down to the 'eval' => 'md5' configuration. Any fields with this md5-option (most likely password fields) will produce this error.</p>