TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692023-08-30T11:27:43ZTYPO3 Forge
Redmine TYPO3 Core - Bug #101798 (New): Prevent saving unchanged inline records to save performancehttp://forge.typo3.org/issues/1017982023-08-30T11:27:43ZSebastian Michaelsenmichaelsen@t3seo.de
<p><strong>Problem</strong></p>
<p>When you have a record, which has 10 inline items and the record is translated (along with the inline items) into 10 languages, then saving the record even with no changes to the inline items causes the DataHandler to save 110 database records which can take some 30 seconds.</p>
<p><strong>Why is that?</strong></p>
<p>The inline records have toggles to hide/unhide them (unless the table does no support that), which means when saving the record there will be a `someid => ['hidden' => '0']` entry for each inline item, which causes DataHandler to save that inline item, which then also triggers saving of its translations.</p>
<p><strong>Solution(?)</strong></p>
<p>It could be solved in backend JavaScript, so that the inline `hidden` form fields are only included in the request when their value was changed.</p>
<p><strong>Workaround</strong></p>
<p>For our project I created a backend middleware, that intercepts the `data` when a record is saved and removes any entries, that have just the hidden field and it is unchanged. (Yes, I create a database request for each of those entries but it's still <em>way</em> faster than before)</p> TYPO3 Core - Bug #98625 (Closed): Fluid syntax error in login templatehttp://forge.typo3.org/issues/986252022-10-16T06:04:26ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In the default Login.html template of the <code>felogin</code> extension there's a space at the end of the <code>additionalAttributes</code> attribute, so that it is detected as string, when it should be an array, resulting in:</p>
<pre>
InvalidArgumentException: The argument "additionalAttributes" was registered with type "array", but is of type "string" in view helper "TYPO3\CMS\Fluid\ViewHelpers\Form\PasswordViewHelper"., in file /var/www/html/vendor/typo3fluid/fluid/src/Core/ViewHelper/AbstractViewHelper.php:352
</pre>
<p>This is where it happened</p> TYPO3 Core - Bug #97776 (New): Disabled scheduler tasks are not dimmed outhttp://forge.typo3.org/issues/977762022-06-15T09:50:04ZSebastian Michaelsenmichaelsen@t3seo.de
<p>The <code>SchedulerModueController</code> says <code>// Row is shown dimmed if task is disabled, unless it is still running</code> and a corresponding CSS class <code>disabled</code> is set on disabled tasks, but visually there is no difference.</p>
<p>Tested in TYPO3 v10, but I suppose this is also the case in higher versions.</p> TYPO3 Core - Bug #95368 (Closed): Passing an eID array URL parameter logs into the TYPO3 error loghttp://forge.typo3.org/issues/953682021-09-27T10:31:17ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Calling <a class="external" href="https://www.example.com/index.php?eID[]=">https://www.example.com/index.php?eID[]=</a> produces an entry like this in the <code>sys_log</code>:</p>
<pre>
Core: Error handler (FE): PHP Warning: Illegal offset type in /path/to/project/typo3/sysext/frontend/Classes/Middleware/EidHandler.php line 70
</pre>
<p>This is the case for TYPO3 v10.4 and from looking at the code also at master.</p> TYPO3 Core - Bug #95042 (Closed): email validation makes link generation unnecessary costlyhttp://forge.typo3.org/issues/950422021-08-31T06:11:44ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Whenever links are generated with "legacy" parameter, the <code>\TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter</code> checks if the provided parameter is a valid email address. For validation we use the 3rd party library <code>egulias/email-validator</code>. With blackfire I determined that this library is quite costly in terms of memory and wall time.</p>
<p>I added this simple early return to <code>GeneralUtility::validEmail()</code>:</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="k">if</span> <span class="p">(</span><span class="nb">strpos</span><span class="p">(</span><span class="nv">$email</span><span class="p">,</span> <span class="s1">'@'</span><span class="p">)</span> <span class="o">===</span> <span class="kc">false</span><span class="p">)</span> <span class="p">{</span>
<span class="k">return</span> <span class="kc">false</span><span class="p">;</span>
<span class="p">}</span>
</code></pre>
<p>And it significantly improved the speed of links generation. I don't know if that is a suitable solution for the core, or if such a fix should get into the library itself.</p> TYPO3 Core - Bug #93480 (New): PDF Cropping configuration is not possible for editorshttp://forge.typo3.org/issues/934802021-02-10T09:42:03ZSebastian Michaelsenmichaelsen@t3seo.de
<p>TYPO3 can create images from PDFs and can also crop them. But for editors it's not possible to set that cropping, because the cropping wizard doesn't work for PDFs.</p> TYPO3 Core - Bug #93469 (Closed): Editing file metadata in a workspace takes immediate effect on ...http://forge.typo3.org/issues/934692021-02-09T08:09:54ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Steps to reproduce:</p>
<ul>
<li>Switch into a Workspace</li>
<li>Open the File module and edit a file</li>
<li>Fill out or change the title and save</li>
<li>Switch into the LIVE environment again</li>
<li>Edit the same file again<br />=> There are your Workspace changes, immediately applied to the LIVE record.</li>
</ul>
<p>As an editor I must be sure that my workspace changes can not alter the current LIVE website. Otherwise I will lose trust into the whole workspace feature.</p> TYPO3 Core - Bug #93433 (New): TCA placeholder __row|field doesn't translate related recordshttp://forge.typo3.org/issues/934332021-02-04T11:40:41ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When using the __row|field syntax in placeholders, the related row is not overlaid with its translation.</p>
<p>example TCA for a tt_content field:<br /><pre>
'tx_myext_teaser_title' => [
'label' => $lll . '.tx_myext_teaser_title',
'config' => [
'type' => 'input',
'placeholder' => '__row|tx_myext_teaser_page|title',
],
],
</pre></p>
<p>For a translated content element, the placeholder should be filled with the value from the translated page record.</p> TYPO3 Core - Bug #93336 (Closed): Enabling translated content in workspace is not previewablehttp://forge.typo3.org/issues/933362021-01-21T09:35:08ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When you enable content element translation in a WS (which is hidden in LIVE), you cannot see the effect in the workspace preview.</p>
<p>Setup:</p>
<table>
<tr>
<th>Workspace </th>
<th>Default Lang Content </th>
<th>Translated Content </th>
</tr>
<tr>
<td> LIVE </td>
<td> enabled </td>
<td> hidden </td>
</tr>
<tr>
<td> WS </td>
<td> enabled </td>
<td> enabled </td>
</tr>
</table>
<p><code>PageRepository->getRecordOverlay()</code> first does the language overlay and the version overlay afterwards. But the language overlay applies enable field restrictions, so the translation is not loaded (even it would be enabled in the WS version).</p> TYPO3 Core - Bug #93109 (Closed): Records can not be discarded from workspacehttp://forge.typo3.org/issues/931092020-12-18T14:59:21ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When I try to discard news records in the workspaces module I get an SQL error: Unknown column 'tablenames' in 'where clause'.</p>
<p>I tracked down the issue to here: <a class="external" href="https://github.com/TYPO3/TYPO3.CMS/blob/956c01e07885d5c1dffffb2a7ab8aae0db4df9d6/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L5656">https://github.com/TYPO3/TYPO3.CMS/blob/956c01e07885d5c1dffffb2a7ab8aae0db4df9d6/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L5656</a></p>
<p>There it is hardcoded that the mm relation table always has a "tablenames" field. However this is not always the case, e.g. tx_news_domain_model_news.related (<a class="external" href="https://github.com/georgringer/news/blob/master/Configuration/TCA/tx_news_domain_model_news.php#L310">https://github.com/georgringer/news/blob/master/Configuration/TCA/tx_news_domain_model_news.php#L310</a>)</p> TYPO3 Core - Bug #92909 (New): Page Translation list is not orderable, but is rendered always in ...http://forge.typo3.org/issues/929092020-11-23T15:24:12ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In the list view for translated pages the "Page Translation" list is always on top.</p>
<p>In the daily work of content editors this list will hardly ever be the most important one, but there is no possbility to reorder it, because <code>mod.web_list.tableDisplayOrder</code> doesn't have any effect on it.</p>
<p>The fact that you also can't really collapse it (<a class="issue tracker-1 status-1 priority-4 priority-default" title="Bug: Page and Page Translation lists can not be collapsed/expanded independently (New)" href="http://forge.typo3.org/issues/92907">#92907</a>) makes the situation worse.</p> TYPO3 Core - Bug #92907 (New): Page and Page Translation lists can not be collapsed/expanded inde...http://forge.typo3.org/issues/929072020-11-23T15:06:14ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In the list module when you collapse/expand the "Page Translation" list, it will not be persisted. Instead it seems that it will always take over the state of the "Page" list.</p>
<p>Reproduce in a multi-language installation:</p>
<ol>
<li>Open a page in the list module that has translations and subpages. It will have “Page Translations” and “Page” record lists.</li>
<li>Collapse the “Page Translation” list by clicking the little “up”-chevron in the top right.</li>
<li>Refresh the module. “Page Translations” is not collapsed.</li>
<li>Collapse the “Page” list.</li>
<li>Refresh the module. Both lists are now collapsed.</li>
</ol> TYPO3 Core - Bug #92906 (New): File Metadata are not editable when translation doesn't exist yethttp://forge.typo3.org/issues/929062020-11-23T13:52:03ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In the backend form of sys_file_reference inline records, typically there's a link where you can edit the metadata of the selected file.</p>
<p>Since the fix for <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: \TYPO3\CMS\Backend\Form\Container\InlineRecordContainer::renderForeignRecordHeaderControl wrong e... (Closed)" href="http://forge.typo3.org/issues/82178">#82178</a> this link is removed if there is not sys_file_metadata record in the same language as sys_file_reference record.</p>
<p>However obviously editors want to edit metdata for files which have not been explicitly localized before. So I suggest that sys_file_metadata translations are created on demand in this situation.</p> TYPO3 Core - Bug #89192 (Accepted): TypoScript multi-line value syntax in is broken in Backend La...http://forge.typo3.org/issues/891922019-09-17T18:06:42ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Consider the following Backend Layout:</p>
<pre><code class="text syntaxhl" data-language="text">mod.web_layout.BackendLayouts.infoPage {
title = Info Page
config.backend_layout {
colCount = 1
rowCount = 1
rows {
1.columns.1 {
name = Content Area
colPos = 0
allowed.CType (
gridelements_pi1,
list,
shortcut,
text,
)
}
}
}
}
</code></pre>
<p>The multi-line value for allowed.CType is perfectly valid and correctly parsed by TYPO3. However <code>\TYPO3\CMS\Backend\Provider\PageTsBackendLayoutDataProvider->generateBackendLayoutFromTsConfig</code> tries to reconstruct the original TSconfig from the parsed array and assumes all values are one-line values with <code>=</code> syntax.</p>
<p>The reconstructed TSconfig then looks like this (in Xdebug)</p>
<pre><code class="text syntaxhl" data-language="text">backend_layout.colCount = 1
backend_layout.rowCount = 1
backend_layout.rows.1.columns.1.name = Content Area
backend_layout.rows.1.columns.1.colPos = 0
backend_layout.rows.1.columns.1.allowed.CType = gridelements_pi1,
list,
shortcut,
text
</code></pre>
<p>Resulting in only <code>gridelements_pi1</code> to be allowed.</p>
<p>A possible solution could be to strip all line breaks while reconstructing the TSconfig.</p>
<p>Workaround: Do not use the multi-line value syntax in Backend Layouts.</p>
<p>This affects at least TYPO3 8 to 10.</p> TYPO3 Core - Bug #82784 (Accepted): DataHandler: copyRecords doesn't set sorting correctly for ne...http://forge.typo3.org/issues/827842017-10-17T15:52:35ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In <code>DataHandler->copyRecord()</code> accepts a <code>$destPid</code> which (according to the phpDoc) can either contain a page id or (indicated by a negative number) a content uid after which the source record is copied to. This "convention" is also used in <code>DataHandler->moveRecord()</code>.</p>
<p>However <code>DataHandler->copyRecord()</code> does not implement the functionality. Only <code>DataHandler->moveRecord()</code> does.</p>
<p>How to reproduce:</p>
<pre>
$dataHandler = GeneralUtility::makeInstance(DataHandler::class);
$data = [
'tt_content' => [
$sourceContentUid=> [
'copy' => ($targetContentUid * -1),
],
],
];
$dataHandler->start([], $data);
$dataHandler->process_cmdmap();
</pre>
<p>The copied element will just receive the sorting value of the source element instead of being sorted after the target content element.</p>