TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692021-02-04T11:40:41ZTYPO3 Forge
Redmine TYPO3 Core - Bug #93433 (New): TCA placeholder __row|field doesn't translate related recordshttp://forge.typo3.org/issues/934332021-02-04T11:40:41ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When using the __row|field syntax in placeholders, the related row is not overlaid with its translation.</p>
<p>example TCA for a tt_content field:<br /><pre>
'tx_myext_teaser_title' => [
'label' => $lll . '.tx_myext_teaser_title',
'config' => [
'type' => 'input',
'placeholder' => '__row|tx_myext_teaser_page|title',
],
],
</pre></p>
<p>For a translated content element, the placeholder should be filled with the value from the translated page record.</p> TYPO3 Core - Bug #93027 (Closed): Workspace preview of hidden extbase records not possiblehttp://forge.typo3.org/issues/930272020-12-08T11:16:58ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Previewing hidden Extbase records works.<br />Previewing versioned Extbase records works.<br />Previewing hidden AND versioned Extbase records does not work for us.</p>
<p>The reason is in <code>\TYPO3\CMS\Extbase\Persistence\Generic\Storage\Typo3DbBackend</code> the record is overlaid with <code>$pageRepository->versionOL()</code>.<br /><code>Typo3DbBackend</code> does not set the optional <code>$bypassEnableFieldsCheck</code> parameter of <code>versionOL()</code> (default is <code>false</code>).</p>
<p>Instead it should respect whatever is set in <code>$querySettings->getIgnoreEnableFields()</code></p>
<p>How to reproduce:</p>
<ul>
<li>Have a TYPO3 installation with EXT:news which has a basic setup (like detail page with a plugin)</li>
<li>Set <code>previewHiddenRecords</code> to true (either via TypoScript <code>plugin.tx_news.settings.previewHiddenRecords = 1</code> or via Plugin Flexform)</li>
<li>Have a hidden news record.</li>
<li>"View" it from its backend form. => Preview will work because we enabled <code>previewHiddenRecords</code> </li>
<li>Switch to a workspace</li>
<li>"View" it from its backend form.</li>
</ul>
<p>Expected result: News preview should open<br />Actual result: "The news record is not available anymore"</p> TYPO3 Core - Bug #89192 (Accepted): TypoScript multi-line value syntax in is broken in Backend La...http://forge.typo3.org/issues/891922019-09-17T18:06:42ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Consider the following Backend Layout:</p>
<pre><code class="text syntaxhl" data-language="text">mod.web_layout.BackendLayouts.infoPage {
title = Info Page
config.backend_layout {
colCount = 1
rowCount = 1
rows {
1.columns.1 {
name = Content Area
colPos = 0
allowed.CType (
gridelements_pi1,
list,
shortcut,
text,
)
}
}
}
}
</code></pre>
<p>The multi-line value for allowed.CType is perfectly valid and correctly parsed by TYPO3. However <code>\TYPO3\CMS\Backend\Provider\PageTsBackendLayoutDataProvider->generateBackendLayoutFromTsConfig</code> tries to reconstruct the original TSconfig from the parsed array and assumes all values are one-line values with <code>=</code> syntax.</p>
<p>The reconstructed TSconfig then looks like this (in Xdebug)</p>
<pre><code class="text syntaxhl" data-language="text">backend_layout.colCount = 1
backend_layout.rowCount = 1
backend_layout.rows.1.columns.1.name = Content Area
backend_layout.rows.1.columns.1.colPos = 0
backend_layout.rows.1.columns.1.allowed.CType = gridelements_pi1,
list,
shortcut,
text
</code></pre>
<p>Resulting in only <code>gridelements_pi1</code> to be allowed.</p>
<p>A possible solution could be to strip all line breaks while reconstructing the TSconfig.</p>
<p>Workaround: Do not use the multi-line value syntax in Backend Layouts.</p>
<p>This affects at least TYPO3 8 to 10.</p> TYPO3 Core - Bug #74124 (Closed): sys_file_reference field downloadname has no TCA definitionhttp://forge.typo3.org/issues/741242016-03-04T08:23:26ZSebastian Michaelsenmichaelsen@t3seo.de
<p>sys_file_reference comes with the database field downloadname but it is not used or displayed anywhere and it even has no TCA definition.</p>
<p>It noticed that when I tried to use it with extbase but it was not persisted, because of the missing TCA definition.</p>
<p>We should either drop it or provide a TCA definition for it.</p> TYPO3 Core - Bug #71850 (Closed): typolink.forceAbsoluteUrl doesn't force absolute urlhttp://forge.typo3.org/issues/718502015-11-26T10:35:23ZSebastian Michaelsenmichaelsen@t3seo.de
<p>This is were it broke: <a class="external" href="https://github.com/TYPO3/TYPO3.CMS/commit/dacd79bc67c814a4f622dc6bd299ceb521aa325f#diff-fb30f860811e026eb162ad4095fa44e4R6692">https://github.com/TYPO3/TYPO3.CMS/commit/dacd79bc67c814a4f622dc6bd299ceb521aa325f#diff-fb30f860811e026eb162ad4095fa44e4R6692</a></p>
<p>parse_url() doesn't always return a host. With the weak comparison it matched the empty string.</p>
<p>Should be something like:</p>
<p><code>if (!isset($urlParts['host']) || $urlParts['host'] === '') {</code></p> TYPO3 Core - Bug #71477 (Closed): TypoScript condition hostname checks for IP address instead of ...http://forge.typo3.org/issues/714772015-11-11T11:19:01ZSebastian Michaelsenmichaelsen@t3seo.de
<p><a class="external" href="https://github.com/TYPO3/TYPO3.CMS/blob/874a64c54712131350d195e77d775324682cc33a/typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php#L323">https://github.com/TYPO3/TYPO3.CMS/blob/874a64c54712131350d195e77d775324682cc33a/typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php#L323</a></p>
<pre>
case 'hostname':
return (bool)GeneralUtility::cmpFQDN(GeneralUtility::getIndpEnv('REMOTE_ADDR'), $value);
break;
</pre>
<p>Instead of checking against <code>REMOTE_HOST</code> (as it says in the documentation) it checks for <code>REMOTE_ADDR</code>.</p> TYPO3 Core - Bug #70498 (Closed): The CategoryRepository should obey the sorting fieldhttp://forge.typo3.org/issues/704982015-10-08T15:06:06ZSebastian Michaelsenmichaelsen@t3seo.de
<p>sys_category records have a sorting field but CategoryRepository ignores it by default.</p>
<p>This is missing in the CategoryRepository:</p>
<pre>
/**
* @var array
*/
protected $defaultOrderings = array(
'sorting' => QueryInterface::ORDER_ASCENDING
);
</pre> TYPO3 Core - Bug #67892 (Closed): Symlink to autoload.php should be relativehttp://forge.typo3.org/issues/678922015-07-02T16:24:52ZSebastian Michaelsenmichaelsen@t3seo.de
<p>The symlink from typo3/contrib/vendor/autoload.php to the autoload file in Packages is created absolute, which can causes trouble in certain situations. Use relative link instead.</p> TYPO3 Core - Bug #40673 (Closed): sysexts cli and integrity have no ext_emconf.phphttp://forge.typo3.org/issues/406732012-09-06T14:05:27ZSebastian Michaelsenmichaelsen@t3seo.de
<p>There are two new sysext folders which have no ext_emconf.php and therefore do not appear in the EM: cli and integrity</p>
<p>Is this by intention?</p> TYPO3 Core - Bug #30406 (Closed): TCA: Fields with eval md5 can not be clearedhttp://forge.typo3.org/issues/304062011-09-29T08:41:29ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Try this: Open a Backend User record and try to use the little 'x' to clear the password field. The field is not cleared.</p>
<p>I pinned it down to the 'eval' => 'md5' configuration. Any fields with this md5-option (most likely password fields) will produce this error.</p> TYPO3 Core - Bug #28085 (Closed): t3lib_div::debugRows can't return data anymorehttp://forge.typo3.org/issues/280852011-07-11T10:39:39ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In TYPO3 4.5 t3lib_div::debugRows() was deprecated and moved to t3lib_utility_Debug::debugRows()</p>
<pre>
/**
* Displays an array as rows in a table. Useful to debug output like an array of database records.
*
* @param mixed Array of arrays with similar keys
* @param string Table header
* @param boolean If TRUE, will return content instead of echo'ing out.
* @return void Outputs to browser.
* @deprecated since TYPO3 4.5 - Use t3lib_utility_Debug::debugRows instead
*/
public static function debugRows($rows, $header = '', $returnHTML = FALSE) {
self::logDeprecatedFunction();
t3lib_utility_Debug::debugRows($rows, $header, $returnHTML);
}
</pre>
<p>The problem is, that t3lib_utility_Debug::debugRows() is just called but not returned, despite the fact that debugRows() offers an option $returnHTML to return an HTML table.<br />So in the (a bit unlikely) case someone relies on values returned by t3lib_div::debugRows(), 4.5 broke his code.</p>
<p>Adding a simple "return" will solve this problem.</p> TYPO3 Core - Bug #28050 (Closed): t3lib_div::devLog - PHPDoc Comment does not match method signaturehttp://forge.typo3.org/issues/280502011-07-09T20:12:04ZSebastian Michaelsenmichaelsen@t3seo.de
<p>This is the signature of t3lib_div::devLog<br /><pre>
/**
* Logs message to the development log.
* This should be implemented around the source code, both frontend and backend, logging everything from the flow through an application, messages, results from comparisons to fatal errors.
* The result is meant to make sense to developers during development or debugging of a site.
* The idea is that this function is only a wrapper for external extensions which can set a hook which will be allowed to handle the logging of the information to any format they might wish and with any kind of filter they would like.
* If you want to implement the devLog in your applications, simply add lines like:
* if (TYPO3_DLOG) t3lib_div::devLog('[write message in english here]', 'extension key');
*
* @param string Message (in english).
* @param string Extension key (from which extension you are calling the log)
* @param integer Severity: 0 is info, 1 is notice, 2 is warning, 3 is fatal error, -1 is "OK" message
* @param array Additional data you want to pass to the logger.
* @return void
*/
public static function devLog($msg, $extKey, $severity = 0, $dataVar = FALSE) {
}
</pre></p>
<p>Notice that the last Parameter is declared as array, but defaults to FALSE. This leads to warning notices in IDEs like PHPStorm when you use devLog.</p> TYPO3 Core - Bug #23451 (Closed): Typo in CSC Constants: "Audeo"http://forge.typo3.org/issues/234512010-08-26T07:01:06ZSebastian Michaelsenmichaelsen@t3seo.de
<p>The Constant Options styles.content.media.defaultAudioWidth has the title "Media Audeo Width" in the constant editor</p>
<p>(issue imported from #M15559)</p> TYPO3 Core - Bug #22981 (Closed): Template Analyzer: Line numbers barely readablehttp://forge.typo3.org/issues/229812010-06-24T11:27:57ZSebastian Michaelsenmichaelsen@t3seo.de
<p>The line numbers in the Template Analyzer have a very low contrast (white on light-grey) and are barely readable.</p>
<p>I suggest setting the font color to dark-grey (#585858).</p>
<p>See screenshots attached</p>
<p>I don't know in which stylesheet to correct this, because they are merged - sorry.<br />(issue imported from #M14847)</p> TYPO3 Core - Bug #22227 (Closed): t3lib_div CGL Cleanup: Missing spaces around string concatenatorhttp://forge.typo3.org/issues/222272010-03-03T14:21:16ZSebastian Michaelsenmichaelsen@t3seo.de
<p>t3lib_div does absolutely not match the current CGL. This issue is intended be focused on one particular rule of CGL: "String concatenation operator must be surrounded by spaces".</p>
<p>This issue/RFC/patch intentionally ignores other violations of the CGL, because this would be too much for one RFC. So the modified lines still contain violations like missing spaces after comma and so on.<br />(issue imported from #M13729)</p>