TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692022-06-15T09:50:04ZTYPO3 Forge
Redmine TYPO3 Core - Bug #97776 (New): Disabled scheduler tasks are not dimmed outhttp://forge.typo3.org/issues/977762022-06-15T09:50:04ZSebastian Michaelsenmichaelsen@t3seo.de
<p>The <code>SchedulerModueController</code> says <code>// Row is shown dimmed if task is disabled, unless it is still running</code> and a corresponding CSS class <code>disabled</code> is set on disabled tasks, but visually there is no difference.</p>
<p>Tested in TYPO3 v10, but I suppose this is also the case in higher versions.</p> TYPO3 Core - Bug #95042 (Closed): email validation makes link generation unnecessary costlyhttp://forge.typo3.org/issues/950422021-08-31T06:11:44ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Whenever links are generated with "legacy" parameter, the <code>\TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter</code> checks if the provided parameter is a valid email address. For validation we use the 3rd party library <code>egulias/email-validator</code>. With blackfire I determined that this library is quite costly in terms of memory and wall time.</p>
<p>I added this simple early return to <code>GeneralUtility::validEmail()</code>:</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="k">if</span> <span class="p">(</span><span class="nb">strpos</span><span class="p">(</span><span class="nv">$email</span><span class="p">,</span> <span class="s1">'@'</span><span class="p">)</span> <span class="o">===</span> <span class="kc">false</span><span class="p">)</span> <span class="p">{</span>
<span class="k">return</span> <span class="kc">false</span><span class="p">;</span>
<span class="p">}</span>
</code></pre>
<p>And it significantly improved the speed of links generation. I don't know if that is a suitable solution for the core, or if such a fix should get into the library itself.</p> TYPO3 Core - Bug #93469 (Closed): Editing file metadata in a workspace takes immediate effect on ...http://forge.typo3.org/issues/934692021-02-09T08:09:54ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Steps to reproduce:</p>
<ul>
<li>Switch into a Workspace</li>
<li>Open the File module and edit a file</li>
<li>Fill out or change the title and save</li>
<li>Switch into the LIVE environment again</li>
<li>Edit the same file again<br />=> There are your Workspace changes, immediately applied to the LIVE record.</li>
</ul>
<p>As an editor I must be sure that my workspace changes can not alter the current LIVE website. Otherwise I will lose trust into the whole workspace feature.</p> TYPO3 Core - Bug #93336 (Closed): Enabling translated content in workspace is not previewablehttp://forge.typo3.org/issues/933362021-01-21T09:35:08ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When you enable content element translation in a WS (which is hidden in LIVE), you cannot see the effect in the workspace preview.</p>
<p>Setup:</p>
<table>
<tr>
<th>Workspace </th>
<th>Default Lang Content </th>
<th>Translated Content </th>
</tr>
<tr>
<td> LIVE </td>
<td> enabled </td>
<td> hidden </td>
</tr>
<tr>
<td> WS </td>
<td> enabled </td>
<td> enabled </td>
</tr>
</table>
<p><code>PageRepository->getRecordOverlay()</code> first does the language overlay and the version overlay afterwards. But the language overlay applies enable field restrictions, so the translation is not loaded (even it would be enabled in the WS version).</p> TYPO3 Core - Bug #82784 (Accepted): DataHandler: copyRecords doesn't set sorting correctly for ne...http://forge.typo3.org/issues/827842017-10-17T15:52:35ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In <code>DataHandler->copyRecord()</code> accepts a <code>$destPid</code> which (according to the phpDoc) can either contain a page id or (indicated by a negative number) a content uid after which the source record is copied to. This "convention" is also used in <code>DataHandler->moveRecord()</code>.</p>
<p>However <code>DataHandler->copyRecord()</code> does not implement the functionality. Only <code>DataHandler->moveRecord()</code> does.</p>
<p>How to reproduce:</p>
<pre>
$dataHandler = GeneralUtility::makeInstance(DataHandler::class);
$data = [
'tt_content' => [
$sourceContentUid=> [
'copy' => ($targetContentUid * -1),
],
],
];
$dataHandler->start([], $data);
$dataHandler->process_cmdmap();
</pre>
<p>The copied element will just receive the sorting value of the source element instead of being sorted after the target content element.</p> TYPO3 Core - Bug #75904 (Closed): Category Model has icon property but no database fieldhttp://forge.typo3.org/issues/759042016-04-25T11:36:39ZSebastian Michaelsenmichaelsen@t3seo.de
<p><code>\TYPO3\CMS\Extbase\Domain\Model\Category</code> has a property <code>$icon</code> without a corresponding database field. Therefore it's not usable at the moment.</p>
<p>So either the property should be removed or the database field should be added.</p>
<p>My personal experience is that this property would definitely be useful and the database field should be added.</p>
<p>Is that possible as a backport for 7 or only for master?</p> TYPO3 Core - Bug #68332 (Closed): Duplicate mime type declaration FlowPlayerContentObjecthttp://forge.typo3.org/issues/683322015-07-18T11:26:13ZSebastian Michaelsenmichaelsen@t3seo.de
<ul>
<li>Fix duplicate array key in $mimeTypes for 'swa'</li>
<li>Order the keys alphabetically, which can help to avoid duplicate keys</li>
</ul> TYPO3 Core - Bug #59000 (Closed): Code Cleanups in ExtraPageContextMenuOptionshttp://forge.typo3.org/issues/590002014-05-21T15:53:09ZSebastian Michaelsenmichaelsen@t3seo.de
<p>\TYPO3\CMS\ExtraPageCmOptions\ExtraPageContextMenuOptions could use a few cleanups:</p>
<ul>
<li>Use local variables with type hinting instead of $GLOBALS['BE_USER'] and $GLOBALS['LANG']</li>
<li>Don't use & on object function parameters (objects are always automatically passed by reference)</li>
<li>Rename and type-hint the "$backRef" parameter</li>
</ul> TYPO3 Core - Bug #44781 (Closed): ConfigurationUtility->getCurrentConfiguration only delivers def...http://forge.typo3.org/issues/447812013-01-24T11:56:56ZSebastian Michaelsenmichaelsen@t3seo.de
<p>TYPO3\CMS\Extensionmanager\Utility\ConfigurationUtility has a nice handy function getCurrentConfiguration($extensionKey), which tries to load the default configuration and overlay it with the current configuration. But due to an error it will always output the default configuration.</p>
<p>Using GeneralUtility::array_merge_recursive_overrule $defaultConfig should be overlayed with $currentExtensionConfig. The problem is that the two arrays have different formats.</p>
<p>$defaultConfig contains the array with information parsed from the typoscript (style) comments, the default values are nested in these informations.<br />$currentExtensionConfig contains a pure key value store for the configuration.<br />Also see the attached screenshot to see how the two array don't fit together.</p>
<p>I don't really know how to solve this properly. I would love to have a Utility Function that just returns a key value array, but at the moment the function returns the more verbose array. We can't really change this anymore, since this is public API isn't it?</p>
<p>There are two spots in the core at the moment that use this method, that could be adjusted, but there might already be 3rd party implementations using it.</p> TYPO3 Core - Bug #44537 (Closed): BackendUtility::displayWarningMessages uses wrong returnUrlhttp://forge.typo3.org/issues/445372013-01-15T14:26:18ZSebastian Michaelsenmichaelsen@t3seo.de
Steps to reproduce:
<ul>
<li>create a user with the following credentials: admin/password (you're encouraged not to do so on a live system ;) )</li>
<li>open the "About Modules" module, which shows a warning about the admin user.</li>
<li>click the link to edit the admin user</li>
<li>close or save/close the form</li>
<li>404</li>
</ul> TYPO3 Core - Bug #43949 (Closed): Cleanups for the Authentication Classeshttp://forge.typo3.org/issues/439492012-12-13T12:38:32ZSebastian Michaelsenmichaelsen@t3seo.de
<p>For the classes:<br />\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication<br />\TYPO3\CMS\Core\Authentication\AbstractUserAuthenticationFrontendUserAuthtenication (did you see the typo in the class name? :/ )<br />\TYPO3\CMS\Core\Authentication\BackendUserAuthentication<br />\TYPO3\CMS\Backend\FrontendBackendUserAuthentication</p>
<p>do the following cleanups:<br />- provide proper phpDoc comments for all properties and methods<br />- remove a lot of "@todo Define visibility" annotations for properties and methods that already have a visibility definition<br />- some minor cleanups</p> TYPO3 Core - Bug #43874 (Closed): array_merge_recursive_overrule: __UNSET can't unset array valueshttp://forge.typo3.org/issues/438742012-12-11T11:17:09ZSebastian Michaelsenmichaelsen@t3seo.de
<p>If the $enableUnsetFeature parameter is true, array_merge_recursive_overrule you can unset values from the first array.<br />The phpDoc says:<br /><pre>
* @param boolean $enableUnsetFeature If set, special values "__UNSET" can be used in the second array in order to unset array keys in the resulting array.
</pre><br />But in fact keys are only unset if they don't hold an array value. I see no reason why this should be like this. There should be the possibility to unset array values.</p> TYPO3 Core - Bug #35762 (Closed): Edit Link in Backend Live Search doesn't workhttp://forge.typo3.org/issues/357622012-04-07T09:32:07ZSebastian Michaelsenmichaelsen@t3seo.de
<p>Reproduce:</p>
<p>- Start a search in the backend with the live search in the upper right corner.<br />- Click on one of the search results<br />- The edit view will open but will close immediately and jump back to where you came from</p>
<p>Can anyone confirm this? I can reproduce this on 2 independent TYPO3 (4.6.7) installations.</p>
<p>I could not find the error on the code or a possible solution yet.</p> TYPO3 Core - Bug #34882 (Closed): Clean up phpDoc comments in t3lib_TStemplatehttp://forge.typo3.org/issues/348822012-03-15T15:07:34ZSebastian Michaelsenmichaelsen@t3seo.de
<p>In analogy to <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Clean up phpDoc comments in t3lib_div (Closed)" href="http://forge.typo3.org/issues/28087">#28087</a> and <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: Clean up phpDoc comments in class template (Closed)" href="http://forge.typo3.org/issues/34629">#34629</a> I want to clean up the template class (typo3/template.php) this time. Clean phpDoc comments are important to make the API understandable to Users and IDEs.</p>
<p>So I made a patch doing mostly:</p>
<ul>
<li>Provide correct parameter names in phpDoc</li>
<li>Provide correct data types in phpDoc</li>
<li>CGLify phpDoc (remove tabs)</li>
<li>CGLify method signatures (the first line of the method)</li>
</ul> TYPO3 Core - Bug #22340 (Closed): Automatically hiding Option Checkboxes and search fields on "em...http://forge.typo3.org/issues/223402010-03-29T13:54:44ZSebastian Michaelsenmichaelsen@t3seo.de
<p>When you open a page in list view which has no records to display, it still shows up Checkboxes for "Extended View" and "Localization view" and a search form.<br />The functionality to hide these automatically is implemented but does not work anymore.</p>
<p>After computing the list of tables the list module checks if it has any output. If it's empty Checkboxes and searchform are hidden.</p>
<p>The problem ist that the "list of tables" output is never empty because t3lib_recordlist::writeBottom adds some Hardcoded HTML to the bottom of the table list.</p>
<p>Additionally note that rendering of the clipboard is inside the mentioned condition, so when no records are there the clipboard would also be hidden (you don't want that because you may want to paste records into an empty page). So the Clipboard rendering needs to be moved outside the if-statement<br />(issue imported from #M13942)</p>