TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692018-11-21T09:48:08ZTYPO3 Forge
Redmine TYPO3 Core - Feature #86962 (Closed): Asset pipeline: Only include assets for rendered content el...http://forge.typo3.org/issues/869622018-11-21T09:48:08ZSoren Mallingsoren@meteko.dk
<p>Inspired by my teachings after working a bit with Ruby on Rails and the keynote as T3CON18 about speed I would like to present a feature on Asset pipeline for rendered content element.</p>
<p>The idea/concept is as so:</p>
<p>Given the tt_content elements that are being rendered, the TYPO3 rendering engine can include only assets (css/js) that are related to the content element or plugin.</p>
<p>For example. Here is a number of content element in colPos = 0. The idea is not limited to a single colPos, but let's keep it simple :)</p>
<pre>
[CType: text]
[CType: image]
[CType: Plugin -> Extbase plugin]
[CType: menu_sitemap]
</pre>
<p>Giving a path configuration similar to how content elements are given a path to it's HTML files</p>
<pre>
lib.assetPipeline {
css.10 = EXT:awesomesite/Resources/Public/Assets/Css/Component/
}
</pre>
<p>The rendering will look at the rendered CType and look for EXT:awesomesite/Resources/Public/Assets/Css/Component/[CType].css to include into the pageGenerators includeCSS part. If you enable concate and compress css you will have a CSS file build for the content of that site and no bloated CSS/JS stuff.</p>
<p>I created a POC for extbase related rendering. Add this code block to the ActionController -> renderAssetsForRequest() method</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="nv">$assetFile</span> <span class="o">=</span> <span class="nc">GeneralUtility</span><span class="o">::</span><span class="nf">getFileAbsFileName</span><span class="p">(</span><span class="s1">'EXT:'</span> <span class="mf">.</span> <span class="nv">$this</span><span class="o">-></span><span class="nf">getControllerContext</span><span class="p">()</span><span class="o">-></span><span class="nf">getRequest</span><span class="p">()</span><span class="o">-></span><span class="nf">getControllerExtensionKey</span><span class="p">()</span> <span class="mf">.</span> <span class="s1">'/Resources/Public/Assets/Css/'</span> <span class="mf">.</span> <span class="nv">$this</span><span class="o">-></span><span class="nf">getControllerContext</span><span class="p">()</span><span class="o">-></span><span class="nf">getRequest</span><span class="p">()</span><span class="o">-></span><span class="nf">getControllerName</span><span class="p">()</span> <span class="mf">.</span> <span class="s1">'.css'</span><span class="p">);</span>
<span class="k">if</span> <span class="p">(</span><span class="nv">$assetFile</span> <span class="o">!==</span> <span class="s1">''</span><span class="p">)</span> <span class="p">{</span>
<span class="nv">$file</span> <span class="o">=</span> <span class="nc">PathUtility</span><span class="o">::</span><span class="nf">stripPathSitePrefix</span><span class="p">(</span><span class="nv">$assetFile</span><span class="p">);</span>
<span class="nv">$pageRenderer</span><span class="o">-></span><span class="nf">addCssFile</span><span class="p">(</span>
<span class="nv">$file</span>
<span class="p">);</span>
<span class="p">}</span>
</code></pre>
<p>The goal of this feature is to bring down the actual bytes being sent and served on each page load.</p>
<a name="Cons"></a>
<h2 >Cons<a href="#Cons" class="wiki-anchor">¶</a></h2>
<p>Given the dynamic combinations of content this will create a larger number of files than usual</p> TYPO3 Core - Bug #83468 (Closed): Custom icon for "Folder" is not shownhttp://forge.typo3.org/issues/834682018-01-04T14:01:34ZSoren Mallingsoren@meteko.dk
<p>I've registered a custom icon for the "Contains" selector in "Page Properties". the code is here</p>
<pre><code class="php syntaxhl" data-language="php"><span class="k">if</span> <span class="p">(</span><span class="no">TYPO3_MODE</span> <span class="o">===</span> <span class="s1">'BE'</span><span class="p">)</span> <span class="p">{</span>
<span class="cd">/** @var \TYPO3\CMS\Core\Imaging\IconRegistry $iconRegistry */</span>
<span class="nv">$iconRegistry</span> <span class="o">=</span> <span class="nc">\TYPO3\CMS\Core\Utility\GeneralUtility</span><span class="o">::</span><span class="nf">makeInstance</span><span class="p">(</span><span class="nc">\TYPO3\CMS\Core\Imaging\IconRegistry</span><span class="o">::</span><span class="n">class</span><span class="p">);</span>
<span class="nv">$iconRegistry</span><span class="o">-></span><span class="nf">registerIcon</span><span class="p">(</span>
<span class="s1">'apps-pagetree-folder-contains-partnerads'</span><span class="p">,</span>
<span class="nc">\TYPO3\CMS\Core\Imaging\IconProvider\FontawesomeIconProvider</span><span class="o">::</span><span class="n">class</span><span class="p">,</span>
<span class="p">[</span>
<span class="s1">'name'</span> <span class="o">=></span> <span class="s1">'rss'</span>
<span class="p">]</span>
<span class="p">);</span>
<span class="p">}</span>
</code></pre>
<p><b>Notice</b> it's a FontAwesome provided icon - dunno if that could cause the missing rendering of the icon</p>
<p>The custom icon is not being displayed in the page tree (see screenshot) but is working as identifier for ex. TCA tables.</p>
<p>!Screen Shot 2018-01-04 at 13.51.18.png!</p>
<p>Choosing the "frontend user" as "Module" gives the expected rendering of the icon, so the support for SVGIcons is working</p>
<p>The icons doesn't seem to be registered in the <defs> part of the pagetree, could that be a reason?</p>
<p>!Screen Shot 2018-01-04 at 14.00.07.png!</p> TYPO3 Core - Bug #79128 (Closed): "Record history" is shown, even if hidden with TSConfighttp://forge.typo3.org/issues/791282017-01-01T22:50:26ZSoren Mallingsoren@meteko.dk
<p>The tsconfig</p>
<pre>options.showHistory = 0</pre>
<p>is not respected in TYPO3\CMS\Backend\Controller\EditDocumentController in the getButtons() method in the making of the buttonbar.</p>
<p>Actually, a "Record History" buttons is being rendered twice but the TSconfig condition is only checked once.</p>
<p>In the first case, a condition only checks if there is any history</p>
<p><a class="external" href="https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369">https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369</a></p>
<p>and then renders the button.</p>
<p>On line 1400</p>
<p><a class="external" href="https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369">https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369</a></p>
<p>the condition is checked with the "getNewIconMode" method and respect if it's hidden</p> TYPO3 Core - Task #63524 (Closed): Use panels for "Template" configurationhttp://forge.typo3.org/issues/635242014-12-02T19:16:05ZSoren Mallingsoren@meteko.dk
<p>Use panel-* classes from Twitter Bootstrap<br />to give a better look and feel when browsing<br />the typoscript tree</p> TYPO3 Core - Feature #49922 (Closed): Allow "additionalWhereClause" for selection of items to pag...http://forge.typo3.org/issues/499222013-07-11T18:23:52ZSoren Mallingsoren@meteko.dk
<p>In user/usergroup specific TSconfig you can set a "additionalWhereClause" for selecting items to the pagetree. This is added to the where clause with a "AND"</p> TYPO3 Core - Bug #45699 (Closed): Implement pre- and post-hook around SELECT querieshttp://forge.typo3.org/issues/456992013-02-21T11:22:22ZSoren Mallingsoren@meteko.dk
<p>To use in example content/record security, a hook is implemented before and after the SELECT call.</p>
<p>The SELECT call is the only database call without such hook</p> TYPO3 Core - Bug #37906 (Closed): sys_action toolbar items doesn't go to right submodulehttp://forge.typo3.org/issues/379062012-06-11T16:22:47ZSoren Mallingsoren@meteko.dk
<p>The toolbar items in the sys_actions toolbar doesn't go to the right submodule in the "Task center" module - unless the last chosen submodule was "Tasks".</p>
<p>This patch add the "mode" setting, so the right submodule is chosen</p>
<p>How to test:</p>
<p>1. Open "Task Center" <br />2. Choose "Overview" as submodule<br />3. Click a created sys_action from the toolbar<br />4. You are still seeing the overview page</p>
<p>Apply patch and do the same again, you are now redirected to the actual task</p> TYPO3 Core - Bug #35070 (Closed): [Install tool] Image processing doesn't run script of file existshttp://forge.typo3.org/issues/350702012-03-21T10:47:45ZSoren Mallingsoren@meteko.dk
<p>Try this:</p>
<p>Make sure that you have been through the Image processing module once, so the test images have been created.</p>
<p>Enter a wrong path in im_path (or imagine that you move a installation, and the path to IM changes) and go to image processing again.</p>
<p>Install tool will report that everything went perfectly and you will see the create test images.</p>
<p><a class="external" href="https://skitch.com/sorenmalling/8m7e8/new-typo3-site-typo3-4.7-dev">https://skitch.com/sorenmalling/8m7e8/new-typo3-site-typo3-4.7-dev</a></p>
<p>The case is, that no new images are trying to be created (with the wrong im_path!) and you will just see the images from typo3temp</p>
<p>Try and find the image in the typo3temp folder, delete it and rerun the Image Processing, you will now get a error beacause the typo3temp doesn't exists and Image processing will try and create it, with a wrong im_path</p> TYPO3 Core - Task #30296 (Closed): Linkvalidator should have a hook for report markershttp://forge.typo3.org/issues/302962011-09-26T16:36:03ZSoren Mallingsoren@meteko.dk
<p>The Linkvalidator scheduler task should provide hooks within the markers, in order for administrators to create more detailed reports.</p>
<p>This hook gives the possibility to get the information about a page, and use it for any data purpose (user in charge, last update etc.)</p> TYPO3 Core - Bug #25276 (Closed): Backend toolbar (additionalBackendItems) doesn't use a common C...http://forge.typo3.org/issues/252762011-03-07T19:21:48ZSoren Mallingsoren@meteko.dk
<p>The backend toolbar with clear cache, bookmarks etc. doesn't use a common css class for styling the drop down. This makes it harder than necessary to create your own additionalBackendItems, as you will have to introduce new css markers yourself</p>
<p>(issue imported from #M17888)</p> TYPO3 Core - Bug #12177 (Closed): Closing dialog forces reloadhttp://forge.typo3.org/issues/121772011-01-13T13:46:20ZSoren Mallingsoren@meteko.dk
<p>if you click on the "Close" icon in the upperright corner of a modal window, the list of extensions is force-reloaded. Is this necessary, as you are "aborting" a action so nothing should/would be saved?</p> TYPO3 Core - Feature #23589 (Rejected): Popup wizard doesn't close when clicking "save & close"http://forge.typo3.org/issues/235892010-09-24T09:13:24ZSoren Mallingsoren@meteko.dk
<p>Using below configuration in TCA.</p>
<p>The popup window doesn't close, but shows the "parent element" that "popped up" the window, since it's set in the returnUrl and you can't overwrite it.</p>
<p>A solution might be to overwrite the returnUrl, would this be accepted as a solution? </p>
<pre><code>'categories' => array(<br /> 'exclude' => 0,<br /> 'label' => 'LLL:EXT:mediadatabase/Resources/Private/Language/locallang_db.xml:tx_mediadatabase_domain_model_media.categories',<br /> 'config' => array(<br /> 'type' => 'select',<br /> 'foreign_table' => 'tx_mediadatabase_domain_model_category',<br /> 'size' => 10,<br /> 'maxitems' => 20,<br /> 'wizards' => array(<br /> '_PADDING' => 2,<br /> '_VERTICAL' => 1,<br /> 'add' => Array(<br /> 'type' => 'popup',<br /> 'title' => 'LLL:EXT:tt_news/locallang_tca.xml:tt_news_cat.createNewParentCategory',<br /> 'icon' => 'add.gif',<br /> 'params' => Array(<br /> 'table'=>'tx_mediadatabase_domain_model_category',<br /> 'pid' => '###CURRENT_PID###',<br /> 'setValue' => 'append',<br /> ),<br /> 'script' => 'wizard_add.php',<br /> 'JSopenParams' => 'height=280,width=465,status=0,menubar=0,scrollbars=1',<br /> ),<br /> ),<br /> ),<br /> ),</code></pre>
<p>(issue imported from #M15782)</p> TYPO3 Core - Bug #23582 (Closed): Docheader (save, save+view, save+close etc) missinghttp://forge.typo3.org/issues/235822010-09-23T09:43:08ZSoren Mallingsoren@meteko.dk
<p>Editing/creating new elements in any tables, no buttons are shown in the top.</p>
<p>Check out screenshot</p>
<p>(issue imported from #M15771)</p> TYPO3 Core - Bug #22767 (Closed): "Create new element" got a lot of space between possible elementhttp://forge.typo3.org/issues/227672010-05-30T23:03:21ZSoren Mallingsoren@meteko.dk
<p>The list of new element to create got a lot of space, after the new sprite icons has been introduced</p>
<p>(issue imported from #M14542)</p> TYPO3 Core - Feature #22372 (Closed): [Feature request] Add return_url to link even though page d...http://forge.typo3.org/issues/223722010-04-03T15:02:49ZSoren Mallingsoren@meteko.dk
<p>This is a feature request:</p>
<p>Issue:<br />When creating a link in RTE it would be great to have the possibility of adding the current page to the link as a return_url GET parameter.</p>
<p>Ex. if linking to a login page, from one page. Because the login page isn't restrictd, you don't get the return_url GET parameter, and the user will then have to take action in order to get back to the correct page</p>
<p>Solution:<br />Add a checkbox to the link generator, where you can tick of "Add current page as return_url" (or something similar) which then add the current page to the created link</p>
<p>I would like to try and write the patch, as we are in need of this function in a project I'm working on, but i would like to hear whether or not this function could be interesting for the rtehtmlarea extension?</p>
<p>(issue imported from #M13994)</p>