TYPO3 Forge: Issueshttp://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692018-11-21T09:48:08ZTYPO3 Forge
Redmine TYPO3 Core - Feature #86962 (Closed): Asset pipeline: Only include assets for rendered content el...http://forge.typo3.org/issues/869622018-11-21T09:48:08ZSoren Mallingsoren@meteko.dk
<p>Inspired by my teachings after working a bit with Ruby on Rails and the keynote as T3CON18 about speed I would like to present a feature on Asset pipeline for rendered content element.</p>
<p>The idea/concept is as so:</p>
<p>Given the tt_content elements that are being rendered, the TYPO3 rendering engine can include only assets (css/js) that are related to the content element or plugin.</p>
<p>For example. Here is a number of content element in colPos = 0. The idea is not limited to a single colPos, but let's keep it simple :)</p>
<pre>
[CType: text]
[CType: image]
[CType: Plugin -> Extbase plugin]
[CType: menu_sitemap]
</pre>
<p>Giving a path configuration similar to how content elements are given a path to it's HTML files</p>
<pre>
lib.assetPipeline {
css.10 = EXT:awesomesite/Resources/Public/Assets/Css/Component/
}
</pre>
<p>The rendering will look at the rendered CType and look for EXT:awesomesite/Resources/Public/Assets/Css/Component/[CType].css to include into the pageGenerators includeCSS part. If you enable concate and compress css you will have a CSS file build for the content of that site and no bloated CSS/JS stuff.</p>
<p>I created a POC for extbase related rendering. Add this code block to the ActionController -> renderAssetsForRequest() method</p>
<pre><code class="php syntaxhl" data-language="php"> <span class="nv">$assetFile</span> <span class="o">=</span> <span class="nc">GeneralUtility</span><span class="o">::</span><span class="nf">getFileAbsFileName</span><span class="p">(</span><span class="s1">'EXT:'</span> <span class="mf">.</span> <span class="nv">$this</span><span class="o">-></span><span class="nf">getControllerContext</span><span class="p">()</span><span class="o">-></span><span class="nf">getRequest</span><span class="p">()</span><span class="o">-></span><span class="nf">getControllerExtensionKey</span><span class="p">()</span> <span class="mf">.</span> <span class="s1">'/Resources/Public/Assets/Css/'</span> <span class="mf">.</span> <span class="nv">$this</span><span class="o">-></span><span class="nf">getControllerContext</span><span class="p">()</span><span class="o">-></span><span class="nf">getRequest</span><span class="p">()</span><span class="o">-></span><span class="nf">getControllerName</span><span class="p">()</span> <span class="mf">.</span> <span class="s1">'.css'</span><span class="p">);</span>
<span class="k">if</span> <span class="p">(</span><span class="nv">$assetFile</span> <span class="o">!==</span> <span class="s1">''</span><span class="p">)</span> <span class="p">{</span>
<span class="nv">$file</span> <span class="o">=</span> <span class="nc">PathUtility</span><span class="o">::</span><span class="nf">stripPathSitePrefix</span><span class="p">(</span><span class="nv">$assetFile</span><span class="p">);</span>
<span class="nv">$pageRenderer</span><span class="o">-></span><span class="nf">addCssFile</span><span class="p">(</span>
<span class="nv">$file</span>
<span class="p">);</span>
<span class="p">}</span>
</code></pre>
<p>The goal of this feature is to bring down the actual bytes being sent and served on each page load.</p>
<a name="Cons"></a>
<h2 >Cons<a href="#Cons" class="wiki-anchor">¶</a></h2>
<p>Given the dynamic combinations of content this will create a larger number of files than usual</p> TYPO3 Core - Bug #79128 (Closed): "Record history" is shown, even if hidden with TSConfighttp://forge.typo3.org/issues/791282017-01-01T22:50:26ZSoren Mallingsoren@meteko.dk
<p>The tsconfig</p>
<pre>options.showHistory = 0</pre>
<p>is not respected in TYPO3\CMS\Backend\Controller\EditDocumentController in the getButtons() method in the making of the buttonbar.</p>
<p>Actually, a "Record History" buttons is being rendered twice but the TSconfig condition is only checked once.</p>
<p>In the first case, a condition only checks if there is any history</p>
<p><a class="external" href="https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369">https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369</a></p>
<p>and then renders the button.</p>
<p>On line 1400</p>
<p><a class="external" href="https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369">https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/backend/Classes/Controller/EditDocumentController.php#l1369</a></p>
<p>the condition is checked with the "getNewIconMode" method and respect if it's hidden</p> TYPO3 Core - Bug #79127 (Needs Feedback): Responsive LiveSearch toolbar item is rendered no matte...http://forge.typo3.org/issues/791272017-01-01T20:11:56ZSoren Mallingsoren@meteko.dk
<p><em>This is a result of a rather large work on trying to make the TYPO3 backend custom for a project.</em></p>
<p>The backend layout file Main.html (EXT:backend/Resources/Private/Templates/Backend/Main.html) contains a rendering of a LiveSearchToolbarItem even though a person might not have access</p>
<pre>
<button class="topbar-button topbar-button-search t3js-topbar-button-search">
<core:icon identifier="actions-search" alternativeMarkupIdentifier="inline" />
</button>
</pre>
<p>This causes the search to be printed in responsive view. Since you don't have access to the toolbar item (checkAccess() method from ToolbarItemInterface) you don't get a printed LiveSearch to use.</p>
<p><strong>Solution suggestion</strong></p>
<p>This part of ToolbarItem rendering (including the User Settings wrench icon) could be grouped into a viewhelper to render avaialble toolbar items. Perhaps introduce a rendering API for such things (a section in Fluid, or whatever ways the rendering of the backend is going)</p> TYPO3 Core - Task #63524 (Closed): Use panels for "Template" configurationhttp://forge.typo3.org/issues/635242014-12-02T19:16:05ZSoren Mallingsoren@meteko.dk
<p>Use panel-* classes from Twitter Bootstrap<br />to give a better look and feel when browsing<br />the typoscript tree</p> TYPO3 Core - Feature #50360 (Accepted): Having only one record type in "New record" should forwar...http://forge.typo3.org/issues/503602013-07-24T10:49:55ZSoren Mallingsoren@meteko.dk
<p>By using mod.web_list.allowedTables you can adjust the allowed tables. This is useful in storage folders, where you might only want one single record type.</p>
<p>The usability issue comes, when the editor has to click on that single record type. Instead we should forward the editor to the form for that specific record type allowed.</p>
<p>I suggest this being a core feature. In case of objection I suggest a hook, giving the possibility to introduce the functionality via a extension.</p> TYPO3 Core - Feature #49922 (Closed): Allow "additionalWhereClause" for selection of items to pag...http://forge.typo3.org/issues/499222013-07-11T18:23:52ZSoren Mallingsoren@meteko.dk
<p>In user/usergroup specific TSconfig you can set a "additionalWhereClause" for selecting items to the pagetree. This is added to the where clause with a "AND"</p> TYPO3 Core - Bug #35070 (Closed): [Install tool] Image processing doesn't run script of file existshttp://forge.typo3.org/issues/350702012-03-21T10:47:45ZSoren Mallingsoren@meteko.dk
<p>Try this:</p>
<p>Make sure that you have been through the Image processing module once, so the test images have been created.</p>
<p>Enter a wrong path in im_path (or imagine that you move a installation, and the path to IM changes) and go to image processing again.</p>
<p>Install tool will report that everything went perfectly and you will see the create test images.</p>
<p><a class="external" href="https://skitch.com/sorenmalling/8m7e8/new-typo3-site-typo3-4.7-dev">https://skitch.com/sorenmalling/8m7e8/new-typo3-site-typo3-4.7-dev</a></p>
<p>The case is, that no new images are trying to be created (with the wrong im_path!) and you will just see the images from typo3temp</p>
<p>Try and find the image in the typo3temp folder, delete it and rerun the Image Processing, you will now get a error beacause the typo3temp doesn't exists and Image processing will try and create it, with a wrong im_path</p> TYPO3 Core - Bug #25276 (Closed): Backend toolbar (additionalBackendItems) doesn't use a common C...http://forge.typo3.org/issues/252762011-03-07T19:21:48ZSoren Mallingsoren@meteko.dk
<p>The backend toolbar with clear cache, bookmarks etc. doesn't use a common css class for styling the drop down. This makes it harder than necessary to create your own additionalBackendItems, as you will have to introduce new css markers yourself</p>
<p>(issue imported from #M17888)</p> TYPO3 Core - Bug #24275 (Closed): "Marked as container for" not shown as select boxhttp://forge.typo3.org/issues/242752010-12-02T13:54:40ZSoren Mallingsoren@meteko.dk
<p>"Mared as container for" which gives the possibility to add a icon to the created page, isn't corectly rendered as selector box (see attachment)</p>
<p>(issue imported from #M16648)</p> TYPO3 Core - Bug #22770 (Closed): [No Title] shown when editing a record on root levelhttp://forge.typo3.org/issues/227702010-05-31T07:07:42ZSoren Mallingsoren@meteko.dk
<p>For records on root level the title of the record is not shown, when I edit the record.</p>
<p>E.g. the page title isn't shown, when editing page properties of the root page. (Have a look at attached screenshot.)</p>
<p>The field for pagetitle is filled and is shown in the pagetree.<br />The title is also displayed correctly, when the record I edit is not on root level.</p>
<p>(issue imported from #M14545)</p> TYPO3 Core - Bug #22767 (Closed): "Create new element" got a lot of space between possible elementhttp://forge.typo3.org/issues/227672010-05-30T23:03:21ZSoren Mallingsoren@meteko.dk
<p>The list of new element to create got a lot of space, after the new sprite icons has been introduced</p>
<p>(issue imported from #M14542)</p> TYPO3 Core - Bug #22684 (Closed): "User Settings" doesn't have CSS stylehttp://forge.typo3.org/issues/226842010-05-19T19:45:24ZSoren Mallingsoren@meteko.dk
<p>Sorry if double posting, couldn't seem to find this issue.</p>
<p>Using revision 7641 (and before) the "User Settings" module is lacking of CSS due to wrong path for the compressor made CSS styles.</p>
<p>From</p>
<p>typo3/ext/setup/mod/index.php</p>
<p>the css is tried to be reached by the address</p>
<p><link rel="stylesheet" type="text/css" href="../typo3temp/compressor/element_csh-3d889fbcb8e616b940bdf33f8e49fbe2.css.gzip" media="all" /></p>
<p>Solution:<br />-------------</p>
<p>There should be a <base.. > or the links should be generated with a absolute url?</p>
<p>(issue imported from #M14437)</p> TYPO3 Core - Bug #22396 (Closed): Add "tiff" to imagefile_ext arrayhttp://forge.typo3.org/issues/223962010-04-07T14:32:55ZSoren Mallingsoren@meteko.dk
<p>Problem:<br />Different application offers to possibility to save images as ".tiff" including the screenshot tool in Mac OSX. It's not possible to use this image extension in TYPO3 without adding it to the imagefile_ext in the install tool</p>
<p>Solution:<br />This format should also be able to use in TYPO3, without having to add it in the install tool, therefore it's added to the array in t3lib/config_default.php</p>
<p>(issue imported from #M14027)</p> TYPO3 Core - Feature #22372 (Closed): [Feature request] Add return_url to link even though page d...http://forge.typo3.org/issues/223722010-04-03T15:02:49ZSoren Mallingsoren@meteko.dk
<p>This is a feature request:</p>
<p>Issue:<br />When creating a link in RTE it would be great to have the possibility of adding the current page to the link as a return_url GET parameter.</p>
<p>Ex. if linking to a login page, from one page. Because the login page isn't restrictd, you don't get the return_url GET parameter, and the user will then have to take action in order to get back to the correct page</p>
<p>Solution:<br />Add a checkbox to the link generator, where you can tick of "Add current page as return_url" (or something similar) which then add the current page to the created link</p>
<p>I would like to try and write the patch, as we are in need of this function in a project I'm working on, but i would like to hear whether or not this function could be interesting for the rtehtmlarea extension?</p>
<p>(issue imported from #M13994)</p> TYPO3 Core - Bug #20368 (Closed): Automaticly append "www" to domain recordshttp://forge.typo3.org/issues/203682009-04-27T21:20:18ZSoren Mallingsoren@meteko.dk
<p>I would like to reqeust a feature, which automaticly checks for both "www.domain.com" and "domain.com" if you add "domain.com" to the sys_domain table for a page tree</p>
<p>(issue imported from #M10996)</p>