Project

General

Profile

Actions

Bug #103989

closed

runTests.sh tries to remove Documentation-GENERATED-temp files outside the project directory scope

Added by Garvin Hicking 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2024-06-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Given a TYPO3 git in:

/Users/garvin/TYPO3/GIT

when executing:

/Users/garvin/contrib/TYPO3/GIT/Build/Scripts/runTests.sh -s clean

this will try to remove all files from:

/Users/garvin/typo3/sysext/*/Documentation-GENERATED-temp

due to cleanRenderedDocumentationFiles referencing files from "../../../typo3/...".

The current script context however is the project root directory, so this will break out three levels outside that.

Luckily the final directory D@ocumentation-GENERATED-temp@ should never match critical system files from a user.

But the current reference didn't actually remove the documentation temporary files. This needs to be adapted to to not break out of the main script directory.

Actions #1

Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84513

Actions #2

Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84513

Actions #3

Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84464

Actions #4

Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84465

Actions #5

Updated by Garvin Hicking 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF