Project

General

Profile

Actions

Bug #105575

closed

TaskSerializer::deserialize(): Argument #1 ($serializedTask) must be of type string, null given

Added by Lina Wolf 4 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
scheduler
Target version:
-
Start date:
2024-11-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

(1/1) TypeError
TYPO3\CMS\Scheduler\Task\TaskSerializer::deserialize(): Argument #1 ($serializedTask) must be of type string, null given, called in /var/www/html/vendor/typo3/cms-scheduler/Classes/Controller/SchedulerModuleController.php on line 424

in /var/www/html/vendor/typo3/cms-scheduler/Classes/Task/TaskSerializer.php line 36

Happens in the scheduler in an older, updated instance where there might be data that is not expected.

$taskRecord = $this->taskRepository->findRecordByUid($taskUid); in line 408 is null as the record is not found but the try catch block expects an \OutOfBoundsException.

a) throw an out of bounds exception when a scheduler task is not found
b) If the task is found but does not have the key serialized_task_object fall back to an empty string as the methods expect a string. Maybe some kind of exception would be even better here.


Files

Bug105575.patch (1.76 KB) Bug105575.patch Lina Wolf, 2024-11-12 06:42
Actions #1

Updated by Lina Wolf 4 months ago

This patch solves it for me:

Actions #2

Updated by Lina Wolf about 1 month ago

  • Assignee set to Lina Wolf
Actions #3

Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88103

Actions #4

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88103

Actions #5

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88103

Actions #6

Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88103

Actions #7

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88124

Actions #8

Updated by Lina Wolf about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF