Project

General

Profile

Actions

Bug #105755

closed

TCA Type Inline -> Upload sometimes does not work

Added by Tiran Grigoryan about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2024-12-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
8.3
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

With TCA Type Inline, the Upload field sometimes does not work if you enter several data records without clicking on Save. However, as soon as you save, the field works again. Please fix this urgently. The editors are already annoyed about this.


Files

Typo3 Core Bug By TCA Inline.mp4 (22.1 KB) Typo3 Core Bug By TCA Inline.mp4 Video Tiran Grigoryan, 2024-12-03 16:59

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #102415: Remove jQuery from @typo3/backend/drag-uploaderClosedAndreas Nedbal2023-11-20

Actions
Has duplicate TYPO3 Core - Bug #105918: Image Fields not working correctly with restrictions in IRRE fieldsClosed2025-01-13

Actions
Actions #1

Updated by Garvin Hicking about 1 month ago

  • Status changed from New to Needs Feedback

Can you give more details to reproduce this? "Sometimes" is hard to get into inspecting this.

If you can provide reproducible steps, maybe errors in the browser console, failed network requests, or the DOM state once it fails to work, or screenshots/videos, that will increase the likelihood that someone will work for free on this.

Actions #2

Updated by Tiran Grigoryan about 1 month ago

Garvin Hicking wrote in #note-1:

Can you give more details to reproduce this? "Sometimes" is hard to get into inspecting this.

If you can provide reproducible steps, maybe errors in the browser console, failed network requests, or the DOM state once it fails to work, or screenshots/videos, that will increase the likelihood that someone will work for free on this.

Sorry, here I have made the steps in video and hope that you can get it reproduced

Actions #3

Updated by Garvin Hicking about 1 month ago

Hm, that video is only 22kb and doesn't load for me? If it's too large maybe you can upload it to vimeo or youtube or so?

Actions #4

Updated by Tiran Grigoryan about 1 month ago

Garvin Hicking wrote in #note-3:

Hm, that video is only 22kb and doesn't load for me? If it's too large maybe you can upload it to vimeo or youtube or so?

https://www.loom.com/share/b213fad0a9384a8b9418a0ca75378533?sid=05754950-1068-4e5c-8b57-325d788efd62

Actions #5

Updated by Tiran Grigoryan about 1 month ago

Tiran Grigoryan wrote in #note-4:

Garvin Hicking wrote in #note-3:

Hm, that video is only 22kb and doesn't load for me? If it's too large maybe you can upload it to vimeo or youtube or so?

https://www.loom.com/share/b213fad0a9384a8b9418a0ca75378533?sid=05754950-1068-4e5c-8b57-325d788efd62

Garvin Hicking wrote in #note-3:

Hm, that video is only 22kb and doesn't load for me? If it's too large maybe you can upload it to vimeo or youtube or so?

Could you reproduce it?

Actions #6

Updated by Garvin Hicking about 1 month ago

I could view the video but didn't find time today. Should be able to have a look tomorrow.

Actions #7

Updated by Garvin Hicking about 1 month ago

  • Status changed from Needs Feedback to Accepted
  • Priority changed from Should have to Must have

Yes, I can reproduce it now. Thank you!

For TYPO3 v14 main (and v13 below) this can be reproduced via EXT:styleguide:

  • Create an element of Type "Form engine - inline expand"
  • In "inline_1" click on "Create new"
  • New section gets added to the bottom
  • Clicking on "Select & upload files" there: works
  • Click on "Create new" once more
  • Clicking on "Select & upload files" on the second element: DOES NOT WORK
  • Clicking on "Select & upload files" on the first element: still works

Feels like wrong DOM element triggering/targetting, needs further inspection. I raised the priority on this.

Actions #8

Updated by Tiran Grigoryan about 1 month ago

Garvin Hicking wrote in #note-7:

Yes, I can reproduce it now. Thank you!

For TYPO3 v14 main (and v13 below) this can be reproduced via EXT:styleguide:

  • Create an element of Type "Form engine - inline expand"
  • In "inline_1" click on "Create new"
  • New section gets added to the bottom
  • Clicking on "Select & upload files" there: works
  • Click on "Create new" once more
  • Clicking on "Select & upload files" on the second element: DOES NOT WORK
  • Clicking on "Select & upload files" on the first element: still works

Feels like wrong DOM element triggering/targetting, needs further inspection. I raised the priority on this.

When will this bug be fixed? It's very stupid that customers can't maintain their things, they remain dissatisfied with us. Can I help you to fix it as soon as possible?

Actions #9

Updated by Garvin Hicking about 1 month ago

I cannot tell you this with certainty, when the bug can be fixed. Please also try to refrain from using words like "stupid", because it easily triggers people to feel offended.

Progress is made by volunteers or people who are interested in the product, and by very very few companies that pay their developers to work on TYPO3. They have a lot of tasks (see how many open issues this tracker has). We do our best, and everyone has a special area to work in. Sadly, the javascript of this is a bit more complex.

Me and two other core developers already spent a few hours on this, but there was no simple solution.

Do you or your company have people with JavaScript skills? We could talk and I can give pointers where they can help, indeed! The base problem is that no javascript event is delegated/fored to re-trigger the dragzone init constructor.

(Luckily for your reported bug, there's the mentioned workaround in place for saving a new entry first. Many other open bugs don't have workarounds in place)

Best regards.
Garvin

Actions #10

Updated by Tiran Grigoryan about 1 month ago

Garvin Hicking wrote in #note-9:

I cannot tell you this with certainty, when the bug can be fixed. Please also try to refrain from using words like "stupid", because it easily triggers people to feel offended.

Progress is made by volunteers or people who are interested in the product, and by very very few companies that pay their developers to work on TYPO3. They have a lot of tasks (see how many open issues this tracker has). We do our best, and everyone has a special area to work in. Sadly, the javascript of this is a bit more complex.

Me and two other core developers already spent a few hours on this, but there was no simple solution.

Do you or your company have people with JavaScript skills? We could talk and I can give pointers where they can help, indeed! The base problem is that no javascript event is delegated/fored to re-trigger the dragzone init constructor.

(Luckily for your reported bug, there's the mentioned workaround in place for saving a new entry first. Many other open bugs don't have workarounds in place)

Best regards.
Garvin

Hi Garvin,

Sorry about ‘stupid’ word. My English is not so good. And the translator app translated it that way, I speak German. I didn't mean to offend anyone.
Some customers react very aggressively to a mistake or little thing that doesn't work.
I am a backend developer and also have knowledge of JavaScript. I would also like to support you in the backend + JavaScript tasks, if it should be

Actions #11

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87409

Actions #12

Updated by Andreas Kienast about 1 month ago

  • Related to Task #102415: Remove jQuery from @typo3/backend/drag-uploader added
Actions #13

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87409

Actions #14

Updated by Garvin Hicking about 1 month ago

@Tiran Grigoryan Thanks for taking the time to explain this. I understand you get pressure from clients, and we must try to still act without too much pressure.

Andreas Kienast created a patch today which I verified working: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87409

Please have a try and vote on the patch if you can verify it works for you, too.

Actions #15

Updated by Tiran Grigoryan about 1 month ago · Edited

Garvin Hicking wrote in #note-14:

@Tiran Grigoryan Thanks for taking the time to explain this. I understand you get pressure from clients, and we must try to still act without too much pressure.

Andreas Kienast created a patch today which I verified working: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87409

Please have a try and vote on the patch if you can verify it works for you, too.

Works for me, thank you very much.

Actions #16

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87440

Actions #17

Updated by Anonymous about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #18

Updated by Garvin Hicking 3 days ago

  • Has duplicate Bug #105918: Image Fields not working correctly with restrictions in IRRE fields added
Actions

Also available in: Atom PDF